From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-159165-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 130255 invoked by alias); 30 Sep 2019 21:45:33 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 130136 invoked by uid 89); 30 Sep 2019 21:45:20 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-18.0 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Spam-Relays-External:209.85.167.195, H*RU:209.85.167.195, HX-Languages-Length:929
X-HELO: mail-oi1-f195.google.com
Received: from mail-oi1-f195.google.com (HELO mail-oi1-f195.google.com) (209.85.167.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Sep 2019 21:45:09 +0000
Received: by mail-oi1-f195.google.com with SMTP id i185so12503082oif.9        for <gdb-patches@sourceware.org>; Mon, 30 Sep 2019 14:45:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=google.com; s=20161025;        h=mime-version:references:in-reply-to:from:date:message-id:subject:to         :cc;        bh=icnMvlDrqUA0C1sWuasAgAzJQWVNllvgXfYoEyotB88=;        b=jiD1adsDuECariMvX+g3wMUX+rwOvgHNvAaCNtie9Iis5JK6duju6PE4vUzkTqJlRq         XnxmsGaAnNjRWkZuPAKnpWJ/n351rlG5vruePk7WEoWETwEJolNQb6APsfDXG/1xoqV9         Tpdtco74KpZGFoadubir6xtmXFyAGPLkxY30cpj38t3CZ6B4yVIu+WgTJ7aWaJssS6If         v6kkeciJOJtlojTENma2mrINdX6O7R9NoEvU/Pl6OxP/kKG/88gjg8+WLairl8m4Dxi/         w1BYWQEo76eVms0ZHqf6l/vTvDxSIp/mcvP3C9wMoeMtTf53EbAGInGK3hZMGTlNhF4E         8qKA==
MIME-Version: 1.0
References: <1559322805.1454.45.camel@skynet.be> <20190929003539.58325-1-cbiesinger@google.com> <874l0tc1gl.fsf@tromey.com>
In-Reply-To: <874l0tc1gl.fsf@tromey.com>
From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
Reply-To: Christian Biesinger <cbiesinger@google.com>
Date: Mon, 30 Sep 2019 21:45:00 -0000
Message-ID: <CAPTJ0XH-Mu-nedz5tm3hW4=+GzqRJydNyR76B=Kih3+bOp3-Bg@mail.gmail.com>
Subject: Re: [PATCH] Don't use the mutex for each symbol_set_names call
To: Tom Tromey <tom@tromey.com>
Cc: Christian Biesinger via gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes
X-SW-Source: 2019-09/txt/msg00632.txt.bz2

Hi Tom,

On Mon, Sep 30, 2019 at 9:18 AM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
>
> Christian> Also available, rebased to trunk, on
> Christian> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=shortlog;h=refs/heads/users/cbiesinger/parallel-minsyms-mutex
> Christian> ]
>
> I didn't read the patch yet, but this weekend I did rebase my branch and
> fixed most of the review issues.  So, you may want to consider rebasing
> on that.

Looking at your current patch version, I noticed this line in parallel-for.h:
+  if (n_threads > 1 && 2 * n_threads >= n_elements)

I am fairly sure this should be <= in the threads comparison,
otherwise you only use threads if there are few elements, which is the
opposite of what is desired (perhaps a merge error?)

Christian