From: Christian Biesinger <cbiesinger@google.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tom Tromey <tom@tromey.com>,
simark@simark.ca, gdb-patches@sourceware.org,
luis.machado@arm.com
Subject: Re: Two observations using GDB 13 snapshot
Date: Thu, 5 Jan 2023 09:49:14 -0500 [thread overview]
Message-ID: <CAPTJ0XHQJBr5XKFiVdEq7SDSnwG99=BSHraJvK1vhcBy59ZtXA@mail.gmail.com> (raw)
In-Reply-To: <83fscpxxom.fsf@gnu.org>
On Thu, Jan 5, 2023 at 2:11 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > From: Tom Tromey <tom@tromey.com>
> > Cc: Simon Marchi <simark@simark.ca>, cbiesinger@google.com,
> > tom@tromey.com, gdb-patches@sourceware.org, luis.machado@arm.com
> > Date: Wed, 04 Jan 2023 15:33:48 -0700
> >
> > >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
> >
> > Eli> Looks like indeed strcasecmp is the culprit. With the patch below,
> > Eli> which replaces strcasecmp with a simple case-insensitive comparison
> > Eli> that only works with ASCII, the phase of reading symbols from gdb.exe
> > Eli> goes down to just 6 seconds, which is basically the same time as with
> > Eli> GDB 12.
> >
> > Thank you. Hopefully the other patch I have pending, which does
> > something similar, should have the same effect.
>
> Thanks, I applied that patch (modulo the testsuite parts), and I can
> confirm that it is almost as fast as the simple one I posted before:
> 7.5 sec vs 6.2 sec to read the symbols from gdb.exe.
>
> However, what does this change mean in terms of GDB's support for
> symbols with non-ASCII names? AFAIU, libiberty's TOLOWER only handles
> ASCII characters.
>
> If it's okay for GDB to compare case-insensitively only ASCII
> characters, then is the above patch mature enough to go to the gdb-13
> branch?
If https://itanium-cxx-abi.github.io/cxx-abi/abi.html#mangle.name is
up-to-date (?), then
"This ABI does not yet specify a mangling for identifiers containing
characters outside of _A-Za-z0-9."
On the other hand, if
https://rust-lang.github.io/rfcs/2603-rust-symbol-name-mangling-v0.html#punycode-vs-utf-8
is to be believed, GCC/Clang/MSVC do use UTF-8 for symbol names. But I
don't think strcasecmp on Windows uses UTF-8?
Christian
next prev parent reply other threads:[~2023-01-05 14:49 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 17:42 Eli Zaretskii
2022-12-19 10:07 ` Luis Machado
2022-12-19 12:48 ` Eli Zaretskii
2022-12-19 14:08 ` Luis Machado
2022-12-19 14:45 ` Eli Zaretskii
2022-12-19 21:18 ` Tom Tromey
2022-12-20 3:26 ` Eli Zaretskii
2022-12-23 3:34 ` Simon Marchi
2022-12-23 8:05 ` Eli Zaretskii
2022-12-24 17:57 ` Tom Tromey
2022-12-24 18:13 ` Eli Zaretskii
2022-12-27 17:19 ` Tom Tromey
2022-12-27 18:00 ` Eli Zaretskii
2022-12-28 12:35 ` Luis Machado
2022-12-28 16:35 ` Tom Tromey
2022-12-28 17:35 ` Eli Zaretskii
2022-12-28 22:47 ` Tom Tromey
2022-12-29 15:18 ` Eli Zaretskii
2022-12-29 18:17 ` Tom Tromey
2022-12-29 18:36 ` John Baldwin
2022-12-29 19:13 ` Eli Zaretskii
2022-12-29 20:22 ` Simon Marchi
2022-12-30 14:31 ` Eli Zaretskii
2023-01-03 19:44 ` Christian Biesinger
2023-01-03 20:18 ` Eli Zaretskii
2023-01-03 20:34 ` Christian Biesinger
2023-01-03 21:34 ` Simon Marchi
2023-01-03 21:43 ` Christian Biesinger
2023-01-04 1:03 ` Tom Tromey
2023-01-04 18:10 ` Eli Zaretskii
2023-01-04 22:33 ` Tom Tromey
2023-01-05 7:11 ` Eli Zaretskii
2023-01-05 14:49 ` Christian Biesinger [this message]
2023-01-05 15:12 ` Eli Zaretskii
2023-01-06 20:55 ` Tom Tromey
2023-01-05 18:06 ` Torbjorn SVENSSON
2023-01-07 6:30 ` Eli Zaretskii
2023-01-07 9:14 ` Andreas Schwab
2023-01-07 9:32 ` Eli Zaretskii
2023-01-07 10:00 ` Andreas Schwab
2023-01-07 10:51 ` Eli Zaretskii
2023-01-07 13:04 ` Andreas Schwab
2023-01-07 13:54 ` Eli Zaretskii
2023-01-07 13:59 ` Andreas Schwab
2023-01-07 14:12 ` Eli Zaretskii
2023-01-07 14:23 ` Andreas Schwab
2023-01-07 14:29 ` Eli Zaretskii
2023-01-07 14:40 ` Andreas Schwab
2023-01-07 15:07 ` Eli Zaretskii
2023-01-07 15:40 ` Andreas Schwab
2023-01-07 16:10 ` Eli Zaretskii
2023-01-07 16:15 ` Eli Zaretskii
2023-01-07 16:16 ` Hannes Domani
2023-01-07 16:22 ` Eli Zaretskii
2023-01-07 17:39 ` Andreas Schwab
2023-01-07 18:08 ` Eli Zaretskii
2023-01-07 18:26 ` Andreas Schwab
2023-01-07 18:38 ` Eli Zaretskii
2023-01-07 19:26 ` Andreas Schwab
2023-01-07 19:35 ` Eli Zaretskii
2023-01-07 18:28 ` Hannes Domani
2023-01-07 19:25 ` Andreas Schwab
2023-01-07 15:07 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPTJ0XHQJBr5XKFiVdEq7SDSnwG99=BSHraJvK1vhcBy59ZtXA@mail.gmail.com' \
--to=cbiesinger@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).