From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118572 invoked by alias); 26 Dec 2019 07:51:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118561 invoked by uid 89); 26 Dec 2019 07:51:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.1 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=quoted, realized, HX-Received:1e11, HX-Spam-Relays-External:209.85.210.68 X-HELO: mail-ot1-f68.google.com Received: from mail-ot1-f68.google.com (HELO mail-ot1-f68.google.com) (209.85.210.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Dec 2019 07:51:26 +0000 Received: by mail-ot1-f68.google.com with SMTP id d7so27266425otf.5 for ; Wed, 25 Dec 2019 23:51:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fjkfEGaGqS3EGSjr6XZCm4D3Y4wR3DPK83qFPMJlojw=; b=VsDTAAgVu3pKeBPuGJK94Fl8z8liMyrwIG9V0luqXqe2BKe0uYpWUwXjVAdJvjlGFN Z7sdkIuNuMBG24bWYdd3Rjlfrj7IxeUkuNi1NU9a5rAjdXSMaLQoUjQzhiPaMB/ydyTm uLmi23vL/+qWYcwDJzz7u7jA80MEiuWepI2mQFMlzm6MqnoDz/H7emOiR3PF+0NAVUuE j+wqkdrS+Yq/jDGcCT7FrUQJ/94CQrYuHY26aamNITGUbnN3O49Z5ooVfcD1WPdaELYh +nupNFhFFHn9azYpZe9GZl5YRUWU4nOqPydU2Gp1Z7d89ilB1pVXT1m1GfsWGc7FrARG R6yw== MIME-Version: 1.0 References: <20191218210608.211751-1-cbiesinger@google.com> <87y2v886g2.fsf@tromey.com> In-Reply-To: From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Thu, 26 Dec 2019 07:51:00 -0000 Message-ID: Subject: Re: [PATCH] Consistently quote variables used with "test" To: Tom Tromey Cc: Christian Biesinger via gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg01016.txt.bz2 On Thu, Dec 19, 2019 at 8:31 PM Christian Biesinger wrote: > > On Thu, Dec 19, 2019 at 1:24 PM Tom Tromey wrote: > > > > >>>>> "Christian" == Christian Biesinger via gdb-patches writes: > > > > Christian> This ensures that empty variables and variables with spaces are handled > > Christian> correctly. > > > > Christian> Code was inconsistent on whether the constant string (e.g. yes/no) > > Christian> should also be quoted; I tried to be consistent with surrounding code. > > > > Christian> This fixes the error Eli reported during configure with mingw (though that > > Christian> was not fatal). > > > > Thanks. This is ok. > > Thanks, pushed. > To ssh://sourceware.org/git/binutils-gdb.git > 1ee7b812e7..0ad6b8ee70 HEAD -> master I just realized I only pushed this to trunk, whereas Eli reported this issue on the gdb 9 branch. OK to push this to the branch as well? Christian