From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by sourceware.org (Postfix) with ESMTPS id 59D783851C34 for ; Thu, 25 Jun 2020 22:36:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 59D783851C34 Received: by mail-qk1-x742.google.com with SMTP id 145so4595890qke.9 for ; Thu, 25 Jun 2020 15:36:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nF8TcjB26Bn3UAGFU7kDzRRyjVsBRksO13wIk0O/r/Y=; b=IJFF2ic1XbnvTUMQO4GiWXQpl15bDEDkB59752wFsZWl718KjrqjHvz7FLzP9nPpAR rB21kT8mXlUqPo1TXWjuv9CFVOPq1lt5GbsFvVl8hsU+xFVbqMjAjOjR9CUArxEvpN5P O6bWWB67ppMrZmMLlZFb7wMWEitPpg5xRwI6cazUWBR+Dj/zK3baoCbzMQBUfx2PoyjY JszT4IAzaoipzhWRbl1kRTGF0gTrIA6bJB26p58vfmU/Z2ACgfAY90GipxxU8GXYiJuk s7mRVN/JXc1+um/izAsgk58RCgZfDL/QStpy6f0pxwukDd+O/iMCvIT4vaJ7/DoKyCIG 8tYQ== X-Gm-Message-State: AOAM532XUFztc/OMLKEWJAFGhQ3C+Uxuwk/cXV7RU5tVYwfTOzNGKC1T m54qN7Z95ZMUm/aYiWsJW95BU9gwMV5yp6ioGqNMy1iI X-Google-Smtp-Source: ABdhPJzeLpV85puqSreYBuXY6HT1LgfUDDCs8/TwIdYO7iWSET0BhnBHLDCjmonlOxW68hhvnsg0MbvngfiPYY3EMM4= X-Received: by 2002:a37:4852:: with SMTP id v79mr31619571qka.132.1593124600615; Thu, 25 Jun 2020 15:36:40 -0700 (PDT) MIME-Version: 1.0 References: <6bc2b01e-3807-77b9-7d1e-d7f6a7875e49@codesourcery.com> In-Reply-To: From: Christian Biesinger Date: Thu, 25 Jun 2020 17:36:03 -0500 Message-ID: Subject: Re: [patch] gdb/testsuite: Fix POSIX-isms in gdb.base/shell.exp To: Sandra Loosemore Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jun 2020 22:36:42 -0000 On Thu, Jun 25, 2020 at 12:57 PM Sandra Loosemore wrote: > > On 6/25/20 11:32 AM, Christian Biesinger wrote: > > On Wed, Jun 24, 2020 at 8:35 PM Sandra Loosemore > > wrote: > >> > >> This patch fixes a group of failures in gdb.base/shell.exp on Windows > >> host due to assumptions that GDB is launching a POSIX-like shell. On > >> Windows, we get CMD.EXE instead. > > > > Hmm, if I call runtest/make check from an msys2 shell, do I really get > > cmd.exe here? I ask because i wonder how many people run this from > > cmd.exe as opposed to msys's shell, so it may be better to check for > > cmd more specifically somehow (maybe $SHELL?) > > I'm not familiar with the msys2 shell, but.... > > On Windows host GDB uses the system() function provided by the host C > library to launch a shell and does not consult $SHELL at all. This is > in shell_escape in gdb/cli/cli-cmds.c. Ah sorry, I didn't realize that this shell use came from GDB, I had assumed this was from dejagnu. This (unofficially) looks good then. Christian