public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Christian Biesinger <cbiesinger@google.com>
To: Tom Tromey <tom@tromey.com>
Cc: Bernd Edlinger <bernd.edlinger@hotmail.de>,
	 "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix gdb crash due to SIGPIPE when the compile command fails
Date: Wed, 2 Jun 2021 17:19:23 -0500	[thread overview]
Message-ID: <CAPTJ0XHgMKfGrnu-0EFeZeJxTiyKtaREC6S7jxVAqFYPXqQ5iw@mail.gmail.com> (raw)
In-Reply-To: <87tumgp1ob.fsf@tromey.com>

On Wed, Jun 2, 2021 at 1:22 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Bernd" == Bernd Edlinger <bernd.edlinger@hotmail.de> writes:
>
> Bernd> Due to the SIGPIPE the gdb process is killed here, which is
> Bernd> not helpful.
>
> Bernd> 2021-06-02  Bernd Edlinger  <bernd.edlinger@hotmail.de>
>
> Bernd>  * compile/compile.c (compile_to_object): Ignore SIGPIPE before calling
> Bernd>  the plugin.
>
> I don't understand why gdb gets a SIGPIPE here.
> Could you explain it a bit more?

Also, if we determine that this is necessary, this does not seem like
right way to do this. If gdb wants to globally ignore SIGPIPE, it
should probably do that in general startup code, maybe in
async_init_signals. If it should only be done for this specific call,
it should reset it afterwards.

Christian

  reply	other threads:[~2021-06-02 22:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02 17:31 Bernd Edlinger
2021-06-02 18:21 ` Tom Tromey
2021-06-02 22:19   ` Christian Biesinger [this message]
2021-06-03  5:45     ` Bernd Edlinger
2021-06-04 13:39       ` Tom Tromey
2021-06-05 11:44         ` Bernd Edlinger
2021-06-05 12:04           ` Andrew Burgess
2021-06-05 12:27             ` Bernd Edlinger
2021-06-05 14:04               ` Tom Tromey
2021-06-14 11:41           ` Rainer Orth
2021-06-14 12:57             ` Bernd Edlinger
2021-06-14 12:59               ` Rainer Orth
2021-06-14 14:36                 ` Bernd Edlinger
2021-06-14 14:39                   ` Rainer Orth
2021-06-14 15:07                 ` Tom Tromey
2021-06-15 11:10                   ` Rainer Orth
2021-06-14 15:04               ` Tom Tromey
2021-06-14 23:35         ` Pedro Alves
2021-06-15  5:14           ` Bernd Edlinger
2021-06-15 11:16             ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPTJ0XHgMKfGrnu-0EFeZeJxTiyKtaREC6S7jxVAqFYPXqQ5iw@mail.gmail.com \
    --to=cbiesinger@google.com \
    --cc=bernd.edlinger@hotmail.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).