From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88982 invoked by alias); 9 Nov 2019 20:18:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88973 invoked by uid 89); 9 Nov 2019 20:18:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.6 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Received:sk:t23mr15 X-HELO: mail-ot1-f42.google.com Received: from mail-ot1-f42.google.com (HELO mail-ot1-f42.google.com) (209.85.210.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 09 Nov 2019 20:18:39 +0000 Received: by mail-ot1-f42.google.com with SMTP id c19so8115062otr.11 for ; Sat, 09 Nov 2019 12:18:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Vp7GDnYaAVkvOon/4A/WQck8vgW8KzFn2Ao/PuWHt/A=; b=CtEAGnNzJcnQl2Bpab4IbtT5Z3crNhFIsNsrH6JZbfY8p1/qCn4IHdb0ooaqz0O6KK f0VJs0DiuTPAifh/VQmryS4YhHDCkvny8jkVwTM20KXZzx2sd5JmjK3tE4EZ1gwRW4Yw hDLwovS9aEFG/dXBWx7mayQvteshodYap8kiNAwdV5+uTIDFwULuS7JOYwpuMrNn1DMA KAp4nXnz3TXm6+ryTPvLtlKh4qfYhJYGNOxN6v7wpjrdYd/dLhwnn8qg1u0PqZeQ0gpa PGo/0J8e+8hlugXw5rJvDp9IZK2BgP6lnLKTDF8WMFADs8TQyXUfeL+gCfWHcOqVn6XN tJGw== MIME-Version: 1.0 References: <20191106203040.5207B25B28@gnutoolchain-gerrit.osci.io> <00713bff-8560-e51f-f193-8845af83251e@redhat.com> In-Reply-To: From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Sat, 09 Nov 2019 20:18:00 -0000 Message-ID: Subject: Re: [review v3] Use ctime_r and localtime_r if available To: Pedro Alves Cc: gnutoolchain-gerrit@osci.io, gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg00261.txt.bz2 On Fri, Nov 8, 2019 at 11:10 AM Christian Biesinger wrote: > > On Fri, Nov 8, 2019 at 8:08 AM Pedro Alves wrote: > > And, note that localtime, like other C functions that use global > > state, are thread safe on Windows, because the C run time stores > > the global buffers in thread local storage. So the gnulib > > implementation ends up being thread safe there, even though > > it doesn't look like it is. > > OK, I'll change this to use the time_r module. > > I'll make it depend on > https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/514 since that > one also imports a new module. So I tried gnulib's time_r module but it failed to compile on the mingw buildbot: https://gdb-buildbot.osci.io/#builders/23/builds/934 Any ideas? Christian