From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by sourceware.org (Postfix) with ESMTPS id 0FE02396EC24 for ; Wed, 20 May 2020 19:31:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0FE02396EC24 Received: by mail-qt1-x842.google.com with SMTP id v4so3568030qte.3 for ; Wed, 20 May 2020 12:31:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JyCW+psZTfQ4UVL/Kb1ESHwLXE6t3jcM/sdsfrVs6B8=; b=gJnoAlI1HmRoYGQvvSZ32VYCXXOD8rBcsAz1UzxAtJ3HwSsOPpMGbvkkX/yyddQD/Q zCa0xmBFzKKEVEB8xNoJYkx1OvdIlNFwVJ5EYEeQZYFzwK0Ofct1LSvlJ+xRVUPLrHCM KjdLz3Nc3u1DlGY8eLfxwhe1U05FTKOAbV8b+hDCVxygJTV9cpj0CJuPGXSiJKfNT6jF 4Dd6RBq9AsC5cPFPCsR+NylVMt0BcBMIio37MEYcEAKY+SKvKwJemGxjazBFJKCyOz3w 43aX++jIzJeRbcarNP0YDQnIkOSwIUUi/CqgJQpDXBu5WRW3i6u5WPwEOVsJDFLvVULb ZP2w== X-Gm-Message-State: AOAM530EPXzEHbmDJTeDEmmmHrwY7lKsgoONk/ND+5hMxpp6s+7a6fQE SMiMCR0M1nq8vcux6nvc7ybJStSOp8IhGHydwEmYBDol X-Google-Smtp-Source: ABdhPJw+dTqdtD6kFVfdRHym7vAvy+OkWvjg04e6lmGjUmgCCpmZgOqF46G+XbhBksAwFzI1bpcnGeQx9BUtW4QvaQ8= X-Received: by 2002:ac8:76d2:: with SMTP id q18mr2091387qtr.322.1590003091377; Wed, 20 May 2020 12:31:31 -0700 (PDT) MIME-Version: 1.0 References: <20200520174032.9525-1-tromey@adacore.com> In-Reply-To: <20200520174032.9525-1-tromey@adacore.com> From: Christian Biesinger Date: Wed, 20 May 2020 14:30:52 -0500 Message-ID: Subject: Re: [PATCH 0/4] Micro-optimize DWARF partial symbol reading To: Tom Tromey Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-20.5 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 May 2020 19:31:33 -0000 On Wed, May 20, 2020 at 12:40 PM Tom Tromey wrote: > > A personal goal of mine is to improve the startup time of gdb. In the > long run, I think the answer lies partly with threading, and perhaps > with a more radical rewrite of the DWARF psymbol reader. However, > those are difficult goals; and in the short term, I found that just > profiling the reader and making small improvements can make a > difference. > > This series improves the performance of the DWARF partial symbol > reader about 10% (more in one case) on some real-world executables. > See the first patch for details (I chose to put the details there so > they would end up in the eventual git log). > > Regression tested on x86-64 Fedora 30. > > Let me know what you think. These look good to me, for what it's worth. Christian