From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cbiesinger@google.com>
Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com
 [IPv6:2607:f8b0:4864:20::742])
 by sourceware.org (Postfix) with ESMTPS id 42AC83939C10
 for <gdb-patches@sourceware.org>; Tue, 12 May 2020 23:21:51 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 42AC83939C10
Received: by mail-qk1-x742.google.com with SMTP id a136so6590332qkg.6
 for <gdb-patches@sourceware.org>; Tue, 12 May 2020 16:21:51 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=BRXWUPKILoNJVUf1rRLKwEw+YivGGQ3T9wEk8M3Mpkw=;
 b=YBzjV5Jp+XWsirXLJNP7om2FJpwdLiXBW+1io481ZBtyoopV9vMhH+59yBfzOa3vvu
 /JDGm09Es2n9ve+1UWA0ByiWUNbX/xxbUnHbY0721Ba6HoPmL/xXlh0kgvGkixQAo/jt
 rl+5Ntys2FJJgJFFo6IPS12psEc+ijSUiLJHsgL/AIQjMQXE5N9dncAiArEw/TGv8/CU
 1+osbI8BpFl5HlsloB0Sv/Yq1/TVG5D5w6AScqHIKiLywcIFn/CKkXV0cKB/A52JHjcM
 m7qpGUIETj541MKB7wzmz2AbjN9yMoTxJ0TsNJR5sfDVy5dFmMZEYKNFmiAko8UhpX4E
 vnUQ==
X-Gm-Message-State: AGi0PuYRUAh5kNIfTCBfl2kuCs/iJ9kOaiTNPp7rvFrv4U0KnFJpoyu5
 vDIfdgCr+YKFLyZ0LfbmCB+GzXulDHylSR01iF7W4A==
X-Google-Smtp-Source: APiQypKhUBuRD/yBnMA+2MQn0lcsIfE3PmD3kVyEc6wnbGnV/tAM6PWUP6YUICDuLwfAwVhN1B91R5T5/Td9iOC6nVY=
X-Received: by 2002:a37:8582:: with SMTP id
 h124mr12653932qkd.375.1589325710522; 
 Tue, 12 May 2020 16:21:50 -0700 (PDT)
MIME-Version: 1.0
References: <cover.1589235908.git.andrew.burgess@embecosm.com>
 <7d30ea582a1a1fa41d7567058f8e441af14d0016.1589235908.git.andrew.burgess@embecosm.com>
In-Reply-To: <7d30ea582a1a1fa41d7567058f8e441af14d0016.1589235908.git.andrew.burgess@embecosm.com>
From: Christian Biesinger <cbiesinger@google.com>
Date: Tue, 12 May 2020 18:21:13 -0500
Message-ID: <CAPTJ0XHy=8jmisymh1WXHuFAm7wds5gdAhUxSkPsFgD4ts1rkw@mail.gmail.com>
Subject: Re: [PATCH 7/9] gdb: Convert language la_iterate_over_symbols field
 to a method
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-20.8 required=5.0 tests=BAYES_00, DKIMWL_WL_MED,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL,
 USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 12 May 2020 23:21:52 -0000

On Mon, May 11, 2020 at 5:36 PM Andrew Burgess
<andrew.burgess@embecosm.com> wrote:
> @@ -14122,6 +14099,27 @@ class ada_language : public language_defn
>      lai->bool_type_symbol = NULL;
>      lai->bool_type_default = builtin->builtin_bool;
>    }
> +
> +  /* See language.h.  */
> +
> +  bool iterate_over_symbols
> +       (const struct block *block, const lookup_name_info &name,
> +        domain_enum domain,
> +        gdb::function_view<symbol_found_callback_ftype> callback) const override
> +  {
> +    int ndefs, i;
> +    std::vector<struct block_symbol> results;
> +
> +    ndefs = ada_lookup_symbol_list_worker (name, block, domain, &results, 0);
> +
> +    for (i = 0; i < ndefs; ++i)

While touching this function, I would move the declaration of ndefs
and i to the line where they are first used.

Perhaps also change this to a range-based loop.

Christian