From: RAJESH DASARI <raajeshdasari@gmail.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Reg : gdb crash is seen while attaching a process to gdb.
Date: Thu, 27 Apr 2017 10:12:00 -0000 [thread overview]
Message-ID: <CAPXMrf_jyxS1muQ9gUUyiHyEkNUL9-aTw_CjUh7jOCbCKby9TQ@mail.gmail.com> (raw)
In-Reply-To: <86vapqp6j6.fsf@gmail.com>
Hi ,
Yes it worked for me.
Thanks,
Rajesh Dasari.
On Thu, Apr 27, 2017 at 2:32 PM, Yao Qi <qiyaoltc@gmail.com> wrote:
> RAJESH DASARI <raajeshdasari@gmail.com> writes:
>
> [Move it to gdb-patches@sourceware.org]
>
>> Could someone please provide comments.
>>
>> diff --git a/gdb/mips-linux-nat.c b/gdb/mips-linux-nat.c
>> index 9d22773..68641f8 100644
>> --- a/gdb/mips-linux-nat.c
>> +++ b/gdb/mips-linux-nat.c
>> @@ -634,9 +634,20 @@ mips_linux_new_thread (struct lwp_info *lp)
>> &watch_readback_valid, 0))
>> return;
>>
>> + long r;
>> + r= ptrace (PTRACE_SET_WATCH_REGS, tid, &watch_mirror, NULL);
>> tid = ptid_get_lwp (lp->ptid);
>> - if (ptrace (PTRACE_SET_WATCH_REGS, tid, &watch_mirror, NULL) == -1)
>> - perror_with_name (_("Couldn't write debug register"));
>> + if ( r == -1L && errno == ESRCH )
>> + {
>> + /* sleep for a while to eliminate race condition on update to kernel
>> + * task structure with the process state (STOP state of thread).
>> + */
>> + usleep(10000);
>> + if ( ptrace (PTRACE_SET_WATCH_REGS, tid, &watch_mirror, NULL) == -1 )
>> + {
>> + perror_with_name (_("Couldn't write debug register"));
>> + }
>> + }
>> }
>
> I am wondering why mips_linux_read_watch_registers
> (ptrace (PTRACE_GET_WATCH_REGS) is successful but
> ptrace (PTRACE_SET_WATCH_REGS) fails here. Looks they may use different
> lwpids. Does the patch work for you?
>
> --
> Yao (齐尧)
>
> From dc9b626b826b26431772271c9d9a3ee343d8a1e8 Mon Sep 17 00:00:00 2001
> From: Yao Qi <yao.qi@linaro.org>
> Date: Thu, 27 Apr 2017 09:59:40 +0100
> Subject: [PATCH] Use lwpid from lwp_info instead of inferior_ptid
>
> gdb:
>
> 2017-04-27 Yao Qi <yao.qi@linaro.org>
>
> * mips-linux-nat.c (mips_linux_new_thread): Get lwpid from
> lwp_info instead of getting from inferior_ptid.
>
> diff --git a/gdb/mips-linux-nat.c b/gdb/mips-linux-nat.c
> index 9596b49..c5c18fd 100644
> --- a/gdb/mips-linux-nat.c
> +++ b/gdb/mips-linux-nat.c
> @@ -624,14 +624,13 @@ write_watchpoint_regs (void)
> static void
> mips_linux_new_thread (struct lwp_info *lp)
> {
> - int tid;
> + long tid = ptid_get_lwp (lp->ptid);
>
> - if (!mips_linux_read_watch_registers (ptid_get_lwp (inferior_ptid),
> + if (!mips_linux_read_watch_registers (tid,
> &watch_readback,
> &watch_readback_valid, 0))
> return;
>
> - tid = ptid_get_lwp (lp->ptid);
> if (ptrace (PTRACE_SET_WATCH_REGS, tid, &watch_mirror, NULL) == -1)
> perror_with_name (_("Couldn't write debug register"));
> }
next prev parent reply other threads:[~2017-04-27 10:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAPXMrf8TH66vZtp+9riDpDR4fBizip5-LQtZ9+1nSfVaywTLxg@mail.gmail.com>
[not found] ` <CAH=s-PPcmOkY-yPuGsDbE0L=Q=SC9qjw9afTZnHfRE_oMPTzVA@mail.gmail.com>
[not found] ` <728178DD-B9FD-4695-A7FF-F13B829DFD2E@gmail.com>
[not found] ` <864lyfp0b7.fsf@gmail.com>
[not found] ` <CAPXMrf9sjaQ4DUF+2guOYNE2FGRsM7RCcnRxZZ6VT28xLu40ZA@mail.gmail.com>
[not found] ` <CAPXMrf_+cHn9sjFY-yXy==cNoGS98cSmcV+R9TVLbeExru+NWQ@mail.gmail.com>
2017-04-27 9:02 ` Yao Qi
2017-04-27 10:12 ` RAJESH DASARI [this message]
2017-04-27 14:23 ` [PATCH] [MIPS] Use lwpid from lwp_info instead of inferior_ptid Yao Qi
2017-04-27 14:26 ` Simon Marchi
2017-04-28 8:55 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPXMrf_jyxS1muQ9gUUyiHyEkNUL9-aTw_CjUh7jOCbCKby9TQ@mail.gmail.com \
--to=raajeshdasari@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).