From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4171 invoked by alias); 1 Sep 2011 11:09:16 -0000 Received: (qmail 4161 invoked by uid 22791); 1 Sep 2011 11:09:14 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Sep 2011 11:08:56 +0000 Received: by vxj3 with SMTP id 3so1433139vxj.0 for ; Thu, 01 Sep 2011 04:08:55 -0700 (PDT) Received: by 10.52.26.20 with SMTP id h20mr92840vdg.110.1314875335128; Thu, 01 Sep 2011 04:08:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.189.70 with HTTP; Thu, 1 Sep 2011 04:08:34 -0700 (PDT) In-Reply-To: References: <83vctdej0n.fsf@gnu.org> <83ty8xebob.fsf@gnu.org> <83obz5ea7z.fsf@gnu.org> From: Kevin Pouget Date: Thu, 01 Sep 2011 11:29:00 -0000 Message-ID: Subject: Re: [PATCH] PR/12691 Add the inferior to Python exited event To: Eli Zaretskii Cc: tromey@redhat.com, gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=20cf307760a346361704abdf459c X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00012.txt.bz2 --20cf307760a346361704abdf459c Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 2279 On Thu, Sep 1, 2011 at 12:07 PM, Eli Zaretskii wrote: >> From: Kevin Pouget >> Date: Thu, 1 Sep 2011 10:44:39 +0200 >> Cc: Tom Tromey , gdb-patches@sourceware.org >> >> On Wed, Aug 31, 2011 at 7:56 PM, Eli Zaretskii wrote: >> >> From: Tom Tromey >> >> Cc: Kevin Pouget , gdb-patches@sourceware.org >> >> Date: Wed, 31 Aug 2011 11:53:21 -0600 >> >> >> >> >>>>> "Eli" =3D=3D Eli Zaretskii writes: >> >> >> >> Eli> I'd still like to hear from someone "in the know" how is it poss= ible >> >> Eli> that the exit code won't be available, but let's not block the c= ommit >> >> Eli> on that behalf. >> >> >> >> It can happen at least on detach. >> > >> > Right, thanks. =A0Perhaps we should mention that in parentheses. >> > >> >> do you want it to appear in my patch, something like >> >> > Optional, will exist only in the case that the inferior exited with so= me status---i.e., not detached) >> >> along with >> >> >> +An integer representing the exit code which the inferior has returne= d. >> > I think we would be better off without that "has" word. >> >> ? > > No, I meant something like > > =A0An integer representing the exit code, if available, which the > =A0inferior has returned. =A0(The exit code could be unavailable if, for > =A0example, @value{GDBN} detaches from the inferior.) > right, I've updated the patch, is it fine for you ? thanks, Kevin 2011-09-20 Kevin Pouget PR python/12691: Add the inferior to Python exited event * python/py-exitedevent.c (create_exited_event_object): Add inferior to exited_event. * python/py-event.h (emit_exited_event): Likewise * python/-inferior.c (python_inferior_exit): Likewise 2011-09-01 Kevin Pouget PR python/12691: Add the inferior to Python exited event * gdb.python/py-events.exp: Test the inferior attribute of exited event with a fork. * gdb.python/py-events.py: Print inferior number on exit. * gdb.python/py-events.c: Fork the inferior. 2011-09-01 Kevin Pouget PR python/12691: Add the inferior to Python exited event * gdb.texinfo (Events In Python): Describe exited inferior attribute. --20cf307760a346361704abdf459c Content-Type: text/x-patch; charset=US-ASCII; name="0001-PR-12691-Add-the-inferior-to-Python-exited-event.patch" Content-Disposition: attachment; filename="0001-PR-12691-Add-the-inferior-to-Python-exited-event.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gs1mrep80 Content-length: 4998 RnJvbSA0ZDZiYmVmNjUyMzFlMzcxNDRiNmIxN2VjZDRjNzZiZjYyOWNmMTEx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLZXZpbiBQb3VnZXQg PGtldmluLnBvdWdldEBzdC5jb20+CkRhdGU6IFdlZCwgMzEgQXVnIDIwMTEg MTY6MzI6NDUgKzAyMDAKU3ViamVjdDogW1BBVENIXSBQUi8xMjY5MSBBZGQg dGhlIGluZmVyaW9yIHRvIFB5dGhvbiBleGl0ZWQgZXZlbnQKCi0tLQogZ2Ri L2RvYy9nZGIudGV4aW5mbyAgICAgICAgICAgICAgICAgICAgfCAgIDExICsr KysrKystLS0tCiBnZGIvcHl0aG9uL3B5LWV4aXRlZGV2ZW50LmMgICAgICAg ICAgICB8ICAgIDYgKysrKysrCiBnZGIvdGVzdHN1aXRlL2dkYi5weXRob24v cHktZXZlbnRzLmMgICB8ICAgIDEgKwogZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0 aG9uL3B5LWV2ZW50cy5leHAgfCAgIDExICsrKysrKysrKystCiBnZGIvdGVz dHN1aXRlL2dkYi5weXRob24vcHktZXZlbnRzLnB5ICB8ICAgIDEgKwogNSBm aWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2dkYi9kb2MvZ2RiLnRleGluZm8gYi9nZGIvZG9j L2dkYi50ZXhpbmZvCmluZGV4IDIzYjJhOTguLjc5NTMzNGQgMTAwNjQ0Ci0t LSBhL2dkYi9kb2MvZ2RiLnRleGluZm8KKysrIGIvZ2RiL2RvYy9nZGIudGV4 aW5mbwpAQCAtMjIyODUsMTIgKzIyMjg1LDE1IEBAIGluaGVyaXRlZCBhdHRy aWJ1dGUgcmVmZXIgdG8gQGNvZGV7Z2RiLlRocmVhZEV2ZW50fSBhYm92ZS4K IAogQGl0ZW0gZXZlbnRzLmV4aXRlZAogRW1pdHMgQGNvZGV7ZXZlbnRzLkV4 aXRlZEV2ZW50fSB3aGljaCBpbmRpY2F0ZXMgdGhhdCB0aGUgaW5mZXJpb3Ig aGFzIGV4aXRlZC4KLUBjb2Rle2V2ZW50cy5FeGl0ZWRFdmVudH0gaGFzIG9u ZSBvcHRpb25hbCBhdHRyaWJ1dGUuICBUaGlzIGF0dHJpYnV0ZQotd2lsbCBl eGlzdCBvbmx5IGluIHRoZSBjYXNlIHRoYXQgdGhlIGluZmVyaW9yIGV4aXRl ZCB3aXRoIHNvbWUKLXN0YXR1cy4KK0Bjb2Rle2V2ZW50cy5FeGl0ZWRFdmVu dH0gaGFzIHR3byBhdHRyaWJ1dGVzOgogQHRhYmxlIEBjb2RlCiBAZGVmaXZh ciBFeGl0ZWRFdmVudCBleGl0X2NvZGUKLUFuIGludGVnZXIgcmVwcmVzZW50 aW5nIHRoZSBleGl0IGNvZGUgd2hpY2ggdGhlIGluZmVyaW9yIGhhcyByZXR1 cm5lZC4KK0FuIGludGVnZXIgcmVwcmVzZW50aW5nIHRoZSBleGl0IGNvZGUs IGlmIGF2YWlsYWJsZSwgd2hpY2ggdGhlIGluZmVyaW9yIAoraGFzIHJldHVy bmVkLiAgKFRoZSBleGl0IGNvZGUgY291bGQgYmUgdW5hdmFpbGFibGUgaWYs IGZvciBleGFtcGxlLAorQHZhbHVle0dEQk59IGRldGFjaGVzIGZyb20gdGhl IGluZmVyaW9yLikKK0BlbmQgZGVmaXZhcgorQGRlZml2YXIgRXhpdGVkRXZl bnQgaW5mZXJpb3IKK0EgcmVmZXJlbmNlIHRvIHRoZSBpbmZlcmlvciB3aGlj aCB0cmlnZ2VyZWQgdGhlIEB7ZXhpdGVkfSBldmVudC4KIEBlbmQgZGVmaXZh cgogQGVuZCB0YWJsZQogCmRpZmYgLS1naXQgYS9nZGIvcHl0aG9uL3B5LWV4 aXRlZGV2ZW50LmMgYi9nZGIvcHl0aG9uL3B5LWV4aXRlZGV2ZW50LmMKaW5k ZXggMDgxNTBlNS4uNWVlNmViOCAxMDA2NDQKLS0tIGEvZ2RiL3B5dGhvbi9w eS1leGl0ZWRldmVudC5jCisrKyBiL2dkYi9weXRob24vcHktZXhpdGVkZXZl bnQuYwpAQCAtMzcsNiArMzcsMTIgQEAgY3JlYXRlX2V4aXRlZF9ldmVudF9v YmplY3QgKGNvbnN0IExPTkdFU1QgKmV4aXRfY29kZSkKIAkJCSAgICAgUHlM b25nX0Zyb21Mb25nTG9uZyAoKmV4aXRfY29kZSkpIDwgMCkKICAgICBnb3Rv IGZhaWw7CiAKKyAgaW5mX29iaiA9IGluZmVyaW9yX3RvX2luZmVyaW9yX29i amVjdCAoaW5mKTsKKyAgaWYgKCFpbmZfb2JqIHx8IGV2cHlfYWRkX2F0dHJp YnV0ZSAoZXhpdGVkX2V2ZW50LAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAiaW5mZXJpb3IiLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBpbmZfb2JqKSA8IDApCisgICAgZ290byBm YWlsOworCiAgIHJldHVybiBleGl0ZWRfZXZlbnQ7CiAKICAgZmFpbDoKZGlm ZiAtLWdpdCBhL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1ldmVudHMu YyBiL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1ldmVudHMuYwppbmRl eCBjZWI2OTdlLi42NjVjYTUxIDEwMDY0NAotLS0gYS9nZGIvdGVzdHN1aXRl L2dkYi5weXRob24vcHktZXZlbnRzLmMKKysrIGIvZ2RiL3Rlc3RzdWl0ZS9n ZGIucHl0aG9uL3B5LWV2ZW50cy5jCkBAIC0xNyw2ICsxNyw3IEBACiAqLwog CiBpbnQgc2Vjb25kKCl7CisgIGZvcmsoKSA7CiAgIHJldHVybiAxMjsKIH0K IApkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0aG9uL3B5LWV2 ZW50cy5leHAgYi9nZGIvdGVzdHN1aXRlL2dkYi5weXRob24vcHktZXZlbnRz LmV4cAppbmRleCBlNWQ2ZGFmLi5jZGY0YWU2IDEwMDY0NAotLS0gYS9nZGIv dGVzdHN1aXRlL2dkYi5weXRob24vcHktZXZlbnRzLmV4cAorKysgYi9nZGIv dGVzdHN1aXRlL2dkYi5weXRob24vcHktZXZlbnRzLmV4cApAQCAtNDIsNiAr NDIsOCBAQCBpZiAhW3J1bnRvX21haW4gXSB0aGVuIHsKICAgICByZXR1cm4g LTEKIH0KIAorZ2RiX3Rlc3Rfbm9fb3V0cHV0ICJzZXQgZGV0YWNoLW9uLWZv cmsgb2ZmIiAiRG9uJ3QgZGV0YWNoIG9uIGZvcmsiCisKIGdkYl90ZXN0ICJU ZXN0X0V2ZW50cyIgIkV2ZW50IHRlc3RlcnMgcmVnaXN0ZXJlZC4iCiAKIGdk Yl9icmVha3BvaW50ICJmaXJzdCIKQEAgLTU2LDQgKzU4LDExIEBAIGFsbCB0 aHJlYWRzIHN0b3BwZWQiCiAjdGVzdCBleGl0ZWQgZXZlbnQuCiBnZGJfdGVz dCAiY29udGludWUiICIuKmV2ZW50IHR5cGU6IGNvbnRpbnVlLioKIC4qZXZl bnQgdHlwZTogZXhpdC4qCi0uKmV4aXQgY29kZTogMTIuKiIKKy4qZXhpdCBj b2RlOiAxMi4qCisuKmV4aXQgaW5mOiAxLioiICJJbmZlcmlvciAxIHRlcm1p bmF0ZWQuIgorCitnZGJfdGVzdCAiaW5mZXJpb3IgMiIgIi4qU3dpdGNoaW5n IHRvIGluZmVyaW9yIDIuKiIKK2dkYl90ZXN0ICJjb250aW51ZSIgIi4qZXZl bnQgdHlwZTogY29udGludWUuKgorLipldmVudCB0eXBlOiBleGl0LioKKy4q ZXhpdCBjb2RlOiAxMi4qCisuKmV4aXQgaW5mOiAyLioiICJJbmZlcmlvciAx IHRlcm1pbmF0ZWQuIgpkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0ZS9nZGIu cHl0aG9uL3B5LWV2ZW50cy5weSBiL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhv bi9weS1ldmVudHMucHkKaW5kZXggOWYwNWI5Zi4uYjQwZjA3NCAxMDA2NDQK LS0tIGEvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0aG9uL3B5LWV2ZW50cy5weQor KysgYi9nZGIvdGVzdHN1aXRlL2dkYi5weXRob24vcHktZXZlbnRzLnB5CkBA IC00MSw2ICs0MSw3IEBAIGRlZiBleGl0X2hhbmRsZXIgKGV2ZW50KToKICAg ICBpZiAoaXNpbnN0YW5jZSAoZXZlbnQsIGdkYi5FeGl0ZWRFdmVudCkpOgog ICAgICAgICBwcmludCAiZXZlbnQgdHlwZTogZXhpdCIKICAgICBwcmludCAi ZXhpdCBjb2RlOiAlZCIgJSAoZXZlbnQuZXhpdF9jb2RlKQorICAgIHByaW50 ICJleGl0IGluZjogJWQiICUgKGV2ZW50LmluZmVyaW9yLm51bSkKIAogZGVm IGNvbnRpbnVlX2hhbmRsZXIgKGV2ZW50KToKICAgICBpZiAoaXNpbnN0YW5j ZSAoZXZlbnQsIGdkYi5Db250aW51ZUV2ZW50KSk6Ci0tIAoxLjcuNgoK --20cf307760a346361704abdf459c--