From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4094 invoked by alias); 24 Oct 2011 14:27:08 -0000 Received: (qmail 4082 invoked by uid 22791); 24 Oct 2011 14:27:07 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Oct 2011 14:26:48 +0000 Received: by vcbfk1 with SMTP id fk1so6358344vcb.0 for ; Mon, 24 Oct 2011 07:26:48 -0700 (PDT) Received: by 10.52.30.69 with SMTP id q5mr22615565vdh.110.1319466408132; Mon, 24 Oct 2011 07:26:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.180.75 with HTTP; Mon, 24 Oct 2011 07:26:28 -0700 (PDT) In-Reply-To: References: From: Kevin Pouget Date: Mon, 24 Oct 2011 14:30:00 -0000 Message-ID: Subject: Re: [RFC] Python Finish Breakpoints To: Eli Zaretskii Cc: tromey@redhat.com, gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00635.txt.bz2 On Mon, Oct 24, 2011 at 3:00 PM, Eli Zaretskii wrote: >> From: Kevin Pouget >> Date: Mon, 24 Oct 2011 11:14:42 +0200 >> Cc: gdb-patches@sourceware.org >> >> I've updated the doc and testsuite accordingly, and as far as I've >> seen, there is no regression on X86_64/Fedora >> (I need still need to improve my test environment) > > Thanks. thanks for your review, and sorry for the typos ... >> +@subsubsection Finish Breakpoints >> + >> +@cindex python finish breakpoints >> +@tindex gdb.FinishBreakpoint > > No @node? =A0Why not? my original idea was to insert "Finish Breakpoints" inside the Breakpoint page, because they address (almost) the same idea, but that's obviously not the right way to do! I can add something like @menu ... * Finish Breakpoints in Python:: Setting Breakpoints on function return using Python ... @node Finish Breakpoints in Python but can you/Tom confirm that you're happy with a new page/entry menu for Finish Breakpoints? It doesn't compile without the menu entry. > ... >> +breakpoint to become invisible to the user. =A0@xref{Breakpoints In Pyt= hon} >> +for further details about this argument. > > You need a comma after the braces (didn't "make info" bitch at you?). no, now I make sure it compiles and looks fine on the pdf before submitting! the comma is outside of the braces, so I guess it's not taken into consideration by the compiler. I've fixed it >> +In some circonstances (e.g.@: @code{longjmp}, C++ exceptions, @value{GD= BN} > =A0 =A0 =A0 =A0 =A0 ^^^^^^^^^^^^^ > A typo. =A0Also, we use "C@{++}" throughout the document, it looks > prettier in print. just for the record, it's "C@t{++}" which works > Okay with these changes. Thanks I've also prepared a NEWS entry (I'll merge it with the next code update). I assume the order is not important and put it next to the other breakpoint-related entry; let me know if it's not the right place: diff --git a/gdb/NEWS b/gdb/NEWS index 80c59f6..655e013 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -50,6 +50,10 @@ ** The "gdb.breakpoint" function has been deprecated in favor of "gdb.breakpoints". + ** A new class "gdb.FinishBreakpoint" is provided to catch the return + of a function. This class is based on the "finish" command + available in the CLI. + ** Type objects for struct and union types now allow access to the fields using standard Python dictionary (mapping) methods. For example, "some_type['myfield']" now works, as does