From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16212 invoked by alias); 20 Dec 2011 20:55:23 -0000 Received: (qmail 16174 invoked by uid 22791); 20 Dec 2011 20:55:22 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Dec 2011 20:55:09 +0000 Received: by vcge1 with SMTP id e1so5156774vcg.0 for ; Tue, 20 Dec 2011 12:55:08 -0800 (PST) Received: by 10.220.213.200 with SMTP id gx8mr2756910vcb.13.1324414508195; Tue, 20 Dec 2011 12:55:08 -0800 (PST) MIME-Version: 1.0 Received: by 10.220.224.136 with HTTP; Tue, 20 Dec 2011 12:54:47 -0800 (PST) In-Reply-To: References: From: Kevin Pouget Date: Tue, 20 Dec 2011 20:58:00 -0000 Message-ID: Subject: Re: [RFC] Python Finish Breakpoints To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00700.txt.bz2 On Tue, Dec 20, 2011 at 9:38 PM, Tom Tromey wrote: > > >>>>> "Kevin" =3D=3D Kevin Pouget writes: > > Kevin> 2011-12-09 =A0Kevin Pouget =A0 > Kevin> =A0Introduce gdb.FinishBreakpoint in Python > [...] > > One last little thing, in the test suite. > > Kevin> diff --git a/gdb/testsuite/gdb.python/py-finish-breakpoint.exp b/g= db/testsuite/gdb.python/py-finish-breakpoint.exp > Kevin> +if $tracelevel then { > Kevin> + =A0 =A0strace $tracelevel > Kevin> +} > > Here, this needs to check whether shlibs are ok, like: > > if {[skip_shlib_tests]} { > =A0 =A0untested $name.exp > =A0 =A0return -1 > } > > Kevin> +# Start with a fresh gdb. > Kevin> +clean_restart ${testfile} > > After clean_restart you need > > gdb_load_shlibs $lib_sl > > I think there are a few of these in this .exp file. > > I don't think you really needed shared libraries for this test, but now > that you did it, it is fine. > > Patch ok with this fixed up. =A0Thanks! > > Tom Great! I'll fix this last bits and commit it in the next few days Is it okay for 7.4 branch as well ? Cordially, Kevin