From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) by sourceware.org (Postfix) with ESMTPS id B01AF3876076 for ; Sun, 11 Jul 2021 18:52:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B01AF3876076 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kichwacoders.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=kichwacoders.com Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 1FF5D12FC05 for ; Sun, 11 Jul 2021 14:52:41 -0400 (EDT) (envelope-from jonah@kichwacoders.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h= mime-version:references:in-reply-to:from:date:message-id:subject :to:cc:content-type; s=sasl; bh=pn2LFs/m+j+q9117gbdXBcroLAW2BQi+ SxLLl94xnTU=; b=VhXbMhl3cIQeBOmuokmT0ut0FWdmef+EyiUa8rM3ERLlsEap C2267YR62Thg2uhRVFZADCOKDkgBueo8hBxC8rajyj0zfN9oMFZMGmydYT35rxw9 xZLbUv0JHsrU6ye6DNBiSGiTmTBj7GdegMgpkCQV/e4/FCK8CWVWVq/Eu/c= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 193F812FC04 for ; Sun, 11 Jul 2021 14:52:41 -0400 (EDT) (envelope-from jonah@kichwacoders.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kichwacoders.com; h=mime-version:references:in-reply-to:from:date:message-id:subject:to:cc:content-type; s=mesmtp; bh=pn2LFs/m+j+q9117gbdXBcroLAW2BQi+SxLLl94xnTU=; b=phGIVvI65fChg9RLJ57X/ngCz7W6FLk5g+OkCZ20ZEcBUt+7YuC8rvG0aNga1CwMqw5xMOkJwYZfEeFwp5cK4w0/zuzmKTFGAlmMm2J3uaUVaNhmwZdIWc3zmalkOmiqVXvReLlHfDoppTLbSjA2kjb4RaaYdc7Z0Xval2j8UUw= Received: from mail-wr1-f47.google.com (unknown [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 89E8B12FBFE for ; Sun, 11 Jul 2021 14:52:37 -0400 (EDT) (envelope-from jonah@kichwacoders.com) Received: by mail-wr1-f47.google.com with SMTP id a13so21592649wrf.10 for ; Sun, 11 Jul 2021 11:52:37 -0700 (PDT) X-Gm-Message-State: AOAM531YaBJMkW7ItLEmRX7C7OMzg1QMeM4cb9G0odqMWbi1BCoIK+Zt gmCahCHlGpfSHrsJulPiM4tm6vbEc3wXYVIVAus= X-Google-Smtp-Source: ABdhPJwz4EF89FrgSm8Kyzo+0ccRzYjjYBw/QW4De13O2SJD6BY2eTTkNRmzoCujZzI11JOH5NnUX8h0qsPaiKDA2r8= X-Received: by 2002:adf:9466:: with SMTP id 93mr55320640wrq.340.1626029555796; Sun, 11 Jul 2021 11:52:35 -0700 (PDT) MIME-Version: 1.0 References: <0da0d85b-e5c8-7c4a-b428-0f6f7ff6e404@polymtl.ca> In-Reply-To: <0da0d85b-e5c8-7c4a-b428-0f6f7ff6e404@polymtl.ca> From: Jonah Graham Date: Sun, 11 Jul 2021 14:51:59 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/2] gdb/mi: add a '--force' flag to the '-break-condition' command To: Simon Marchi Cc: Tankut Baris Aktemur , gdb-patches@sourceware.org X-Pobox-Relay-ID: 293DE484-E279-11EB-A4AC-FA9E2DDBB1FC-18936988!pb-smtp21.pobox.com X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Jul 2021 18:52:45 -0000 On Wed, 5 May 2021 at 22:46, Simon Marchi wrote: > > + /* There must be at least two more args: a bpnum and a condition > > + expression. */ > > + if (oind + 1 >= argc) > > + error (_("-break-condition: Missing arguments")); > > I don't know what the standard is for MI commands, but it would be handy > for somebody trying this by hand to say what are the expected arguments > in the error message. > Hi Baris and Simon, Sorry I didn't catch this earlier, but this change breaks removing conditions from MI. "-break-condition 2" should remove the condition for breakpoint 2, same as "condition 2" at CLI does. Instead an error message is returned: ^error,msg="-break-condition: Missing the and/or argument" which corresponds to the updated error message that was actually committed. I raised https://sourceware.org/bugzilla/show_bug.cgi?id=28076 to track this. Jonah > > Otherwise, LGTM, thanks! > > Simon >