From: Jonah Graham <jonah@kichwacoders.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v4 2/2] gdb/mi: add a '--force' flag to the '-break-condition' command
Date: Sun, 11 Jul 2021 20:25:07 -0400 [thread overview]
Message-ID: <CAPmGMvh0Rv_epKNpKK+KRYJvZF027v_o4E88Jy__dwtbvz_d7A@mail.gmail.com> (raw)
In-Reply-To: <CAPmGMvgGVoNvk+NX4UZLLeXOKpHDO8g0AcQu7U8rcp1aQRM+fA@mail.gmail.com>
~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com
On Sun, 11 Jul 2021 at 14:51, Jonah Graham <jonah@kichwacoders.com> wrote:
> On Wed, 5 May 2021 at 22:46, Simon Marchi <simon.marchi@polymtl.ca> wrote:
>
>> > + /* There must be at least two more args: a bpnum and a condition
>> > + expression. */
>> > + if (oind + 1 >= argc)
>> > + error (_("-break-condition: Missing arguments"));
>>
>> I don't know what the standard is for MI commands, but it would be handy
>> for somebody trying this by hand to say what are the expected arguments
>> in the error message.
>>
>
> Hi Baris and Simon,
>
> Sorry I didn't catch this earlier, but this change breaks removing
> conditions from MI. "-break-condition 2" should remove the condition for
> breakpoint 2, same as "condition 2" at CLI does. Instead an error message
> is returned:
>
> ^error,msg="-break-condition: Missing the <number> and/or <expr> argument"
>
> which corresponds to the updated error message that was actually committed.
>
> I raised https://sourceware.org/bugzilla/show_bug.cgi?id=28076 to track
> this.
>
> Jonah
>
PS. If you have a patch that you want me to run the Eclipse CDT testsuite
on, please cc me on the patch.
Jonah
>
>
>
>
>
>>
>> Otherwise, LGTM, thanks!
>>
>> Simon
>>
>
next prev parent reply other threads:[~2021-07-12 0:25 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 15:42 [PATCH 0/2] Breakpoint conditions at locations with differing contexts Tankut Baris Aktemur
[not found] ` <cover.1596209606.git.tankut.baris.aktemur@intel.com>
2020-07-31 15:42 ` [PATCH 1/2] gdb/breakpoint: disable a bp location if condition is invalid at that location Tankut Baris Aktemur
2020-07-31 15:42 ` [RFC][PATCH 2/2] gdb/breakpoint: add a '-force' flag to the 'condition' command Tankut Baris Aktemur
2020-08-03 10:28 ` Andrew Burgess
2020-08-20 21:24 ` [PATCH v2 0/2] Breakpoint conditions at locations with differing contexts Tankut Baris Aktemur
2020-08-20 21:24 ` [PATCH v2 1/2] gdb/breakpoint: disable a bp location if condition is invalid at that location Tankut Baris Aktemur
2020-09-19 3:05 ` Simon Marchi
2020-09-25 15:49 ` Aktemur, Tankut Baris
2020-09-25 16:10 ` Simon Marchi
2020-09-25 18:15 ` Aktemur, Tankut Baris
2020-10-13 12:24 ` Aktemur, Tankut Baris
2020-08-20 21:24 ` [PATCH v2 2/2] gdb/breakpoint: add flags to 'condition' and 'break' commands to force condition Tankut Baris Aktemur
2020-09-04 11:02 ` [PATCH v2 0/2] Breakpoint conditions at locations with differing contexts Tankut Baris Aktemur
2020-09-11 11:56 ` Tankut Baris Aktemur
2020-09-18 20:36 ` [PING][PATCH " Tankut Baris Aktemur
2020-09-25 15:51 ` [PATCH v3 " Tankut Baris Aktemur
2020-09-25 15:51 ` [PATCH v3 1/2] gdb/breakpoint: disable a bp location if condition is invalid at that location Tankut Baris Aktemur
2020-09-25 15:51 ` [PATCH v3 2/2] gdb/breakpoint: add flags to 'condition' and 'break' commands to force condition Tankut Baris Aktemur
2020-10-13 12:25 ` [PATCH v4 0/2] Breakpoint conditions at locations with differing contexts Tankut Baris Aktemur
2020-10-13 12:25 ` [PATCH v4 1/2] gdb/breakpoint: disable a bp location if condition is invalid at that location Tankut Baris Aktemur
2020-10-13 15:06 ` Eli Zaretskii
2020-10-13 15:17 ` Aktemur, Tankut Baris
2020-10-16 22:20 ` Simon Marchi
2020-10-13 12:25 ` [PATCH v4 2/2] gdb/breakpoint: add flags to 'condition' and 'break' commands to force condition Tankut Baris Aktemur
2020-10-13 15:08 ` Eli Zaretskii
2020-10-13 15:46 ` Aktemur, Tankut Baris
2020-10-13 16:12 ` Eli Zaretskii
2020-10-16 22:45 ` Simon Marchi
2020-10-19 13:58 ` Aktemur, Tankut Baris
2020-10-19 14:07 ` Simon Marchi
2020-10-27 10:13 ` Aktemur, Tankut Baris
2020-10-29 10:10 ` Tom de Vries
2020-10-29 10:30 ` Aktemur, Tankut Baris
2020-10-29 17:30 ` Pedro Alves
2020-11-10 19:33 ` Aktemur, Tankut Baris
2020-12-05 17:30 ` Pedro Alves
2020-12-10 20:30 ` Tom Tromey
2020-12-15 11:20 ` Aktemur, Tankut Baris
2020-11-10 19:51 ` Aktemur, Tankut Baris
2020-10-28 16:57 ` [PATCH v4 0/2] Breakpoint conditions at locations with differing contexts Gary Benson
2020-10-29 7:43 ` Aktemur, Tankut Baris
2021-04-05 17:45 ` [PATCH " Jonah Graham
2021-04-06 14:11 ` Aktemur, Tankut Baris
2021-04-06 14:37 ` Jonah Graham
2021-04-07 7:09 ` Aktemur, Tankut Baris
2021-04-07 11:26 ` Jonah Graham
2021-04-07 14:55 ` [PATCH 0/4] Multi-context invalid breakpoint conditions and MI Tankut Baris Aktemur
2021-04-07 14:55 ` [PATCH 1/4] gdb/doc: update the 'enabled' field's description for BP locations in MI Tankut Baris Aktemur
2021-04-07 15:15 ` Eli Zaretskii
2021-04-07 21:42 ` Simon Marchi
2021-04-07 14:55 ` [PATCH 2/4] testsuite, gdb.mi: fix duplicate test names in mi-break.exp Tankut Baris Aktemur
2021-04-07 21:49 ` Simon Marchi
2021-04-07 14:55 ` [PATCH 3/4] gdb/breakpoint: add a 'force_condition' parameter to 'create_breakpoint' Tankut Baris Aktemur
2021-04-07 22:08 ` Simon Marchi
2021-04-08 7:44 ` Aktemur, Tankut Baris
2021-04-08 13:59 ` Simon Marchi
2021-04-08 14:19 ` Aktemur, Tankut Baris
2021-04-07 14:55 ` [PATCH 4/4] gdb/mi: add a '-b' flag to the '-break-insert' cmd to force the condition Tankut Baris Aktemur
2021-04-07 15:18 ` Eli Zaretskii
2021-04-07 15:27 ` Aktemur, Tankut Baris
2021-04-07 15:53 ` Eli Zaretskii
2021-04-07 16:05 ` Aktemur, Tankut Baris
2021-04-07 16:50 ` Eli Zaretskii
2021-04-07 22:26 ` Simon Marchi
2021-04-08 14:22 ` [PATCH v2 0/4] Multi-context invalid breakpoint conditions and MI Tankut Baris Aktemur
2021-04-08 14:22 ` [PATCH v2 1/4] gdb/breakpoint: display "N" on MI for disabled-by-condition locations Tankut Baris Aktemur
2021-04-08 15:04 ` Eli Zaretskii
2021-04-08 14:22 ` [PATCH v2 2/4] testsuite, gdb.mi: fix duplicate test names in mi-break.exp Tankut Baris Aktemur
2021-04-08 14:22 ` [PATCH v2 3/4] gdb/breakpoint: add a 'force_condition' parameter to 'create_breakpoint' Tankut Baris Aktemur
2021-04-08 14:22 ` [PATCH v2 4/4] gdb/mi: add a '--force-condition' flag to the '-break-insert' cmd Tankut Baris Aktemur
2021-04-08 15:06 ` Eli Zaretskii
2021-04-08 15:12 ` Aktemur, Tankut Baris
2021-04-11 1:06 ` Jonah Graham
2021-04-11 1:12 ` Simon Marchi
2021-04-21 12:06 ` Aktemur, Tankut Baris
2021-04-21 12:36 ` Simon Marchi
2021-04-11 1:13 ` [PATCH v2 0/4] Multi-context invalid breakpoint conditions and MI Jonah Graham
2021-04-21 12:17 ` [PATCH v3 " Tankut Baris Aktemur
2021-04-21 12:17 ` [PATCH v3 1/4] gdb/breakpoint: display "N" on MI for disabled-by-condition locations Tankut Baris Aktemur
2021-04-21 12:48 ` Eli Zaretskii
2021-04-21 12:17 ` [PATCH v3 2/4] testsuite, gdb.mi: fix duplicate test names in mi-break.exp Tankut Baris Aktemur
2021-04-21 12:17 ` [PATCH v3 3/4] gdb/breakpoint: add a 'force_condition' parameter to 'create_breakpoint' Tankut Baris Aktemur
2021-04-21 13:18 ` Simon Marchi
2021-04-21 13:29 ` Aktemur, Tankut Baris
2021-04-21 14:28 ` Simon Marchi
2021-04-21 12:17 ` [PATCH v3 4/4] gdb/mi: add a '--force-condition' flag to the '-break-insert' cmd Tankut Baris Aktemur
2021-04-21 12:50 ` Eli Zaretskii
2021-04-21 13:37 ` Simon Marchi
2021-04-21 13:49 ` Aktemur, Tankut Baris
2021-04-21 14:26 ` Simon Marchi
2021-04-22 14:35 ` [PATCH v4 0/2] Multi-context invalid breakpoint conditions and MI Tankut Baris Aktemur
2021-04-22 14:35 ` [PATCH v4 1/2] gdb/mi: add a '--force-condition' flag to the '-break-insert' cmd Tankut Baris Aktemur
2021-05-06 2:40 ` Simon Marchi
2021-04-22 14:35 ` [PATCH v4 2/2] gdb/mi: add a '--force' flag to the '-break-condition' command Tankut Baris Aktemur
2021-04-22 14:47 ` Aktemur, Tankut Baris
2021-05-06 2:46 ` Simon Marchi
2021-05-06 8:50 ` Aktemur, Tankut Baris
2021-07-11 18:51 ` Jonah Graham
2021-07-12 0:25 ` Jonah Graham [this message]
2021-07-12 8:33 ` Aktemur, Tankut Baris
2021-05-05 15:57 ` [PATCH v4 0/2] Multi-context invalid breakpoint conditions and MI Aktemur, Tankut Baris
2021-04-07 21:24 ` [PATCH 0/2] Breakpoint conditions at locations with differing contexts Simon Marchi
2021-04-07 21:36 ` Jonah Graham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPmGMvh0Rv_epKNpKK+KRYJvZF027v_o4E88Jy__dwtbvz_d7A@mail.gmail.com \
--to=jonah@kichwacoders.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).