* [PATCH] sim: riscv: Fix build fail since INSN_CLASS_A was removed.
@ 2024-05-09 0:54 Nelson Chu
2024-05-09 14:11 ` Tom Tromey
0 siblings, 1 reply; 5+ messages in thread
From: Nelson Chu @ 2024-05-09 0:54 UTC (permalink / raw)
To: gdb-patches, tom, aburgess, vapier; +Cc: binutils, Nelson Chu
Updated INSN_CLASS_A to INSN_CLASS_ZAAMO and INSN_CLASS_ZALRSC since the
former was removed and sepearted into the latter two by the commit,
c144f638337944101131d9fe6de4ab908f6d4c2d
sim/
* riscv/sim-main.c (execute_one): Updated INSN_CLASS_A to
INSN_CLASS_ZAAMO and INSN_CLASS_ZALRSC since the former
was removed and sepearted into the latter two.
---
sim/riscv/sim-main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sim/riscv/sim-main.c b/sim/riscv/sim-main.c
index 41973d9dd06..378e6f1dc69 100644
--- a/sim/riscv/sim-main.c
+++ b/sim/riscv/sim-main.c
@@ -1299,7 +1299,8 @@ execute_one (SIM_CPU *cpu, unsigned_word iw, const struct riscv_opcode *op)
switch (op->insn_class)
{
- case INSN_CLASS_A:
+ case INSN_CLASS_ZAAMO:
+ case INSN_CLASS_ZALRSC:
return execute_a (cpu, iw, op);
case INSN_CLASS_C:
/* Check whether model with C extension is selected. */
--
2.39.3 (Apple Git-146)
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] sim: riscv: Fix build fail since INSN_CLASS_A was removed.
2024-05-09 0:54 [PATCH] sim: riscv: Fix build fail since INSN_CLASS_A was removed Nelson Chu
@ 2024-05-09 14:11 ` Tom Tromey
2024-05-09 14:25 ` Nelson Chu
0 siblings, 1 reply; 5+ messages in thread
From: Tom Tromey @ 2024-05-09 14:11 UTC (permalink / raw)
To: Nelson Chu; +Cc: gdb-patches, tom, aburgess, vapier, binutils
>>>>> "Nelson" == Nelson Chu <nelson@rivosinc.com> writes:
Nelson> Updated INSN_CLASS_A to INSN_CLASS_ZAAMO and INSN_CLASS_ZALRSC since the
Nelson> former was removed and sepearted into the latter two by the commit,
Nelson> c144f638337944101131d9fe6de4ab908f6d4c2d
Considering that Bernd sent the identical patch, I think this is ok.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sim: riscv: Fix build fail since INSN_CLASS_A was removed.
2024-05-09 14:11 ` Tom Tromey
@ 2024-05-09 14:25 ` Nelson Chu
2024-05-09 14:26 ` Tom Tromey
0 siblings, 1 reply; 5+ messages in thread
From: Nelson Chu @ 2024-05-09 14:25 UTC (permalink / raw)
To: Tom Tromey, bernd.edlinger; +Cc: gdb-patches, aburgess, vapier, binutils
[-- Attachment #1: Type: text/plain, Size: 622 bytes --]
Thanks, I think it would be good to apply the fix from Bernd, since I'm not
the expert and regular contributor of gdb ;)
Nelson
On Thu, May 9, 2024 at 10:12 PM Tom Tromey <tom@tromey.com> wrote:
> >>>>> "Nelson" == Nelson Chu <nelson@rivosinc.com> writes:
>
> Nelson> Updated INSN_CLASS_A to INSN_CLASS_ZAAMO and INSN_CLASS_ZALRSC
> since the
> Nelson> former was removed and sepearted into the latter two by the commit,
> Nelson> c144f638337944101131d9fe6de4ab908f6d4c2d
>
> Considering that Bernd sent the identical patch, I think this is ok.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sim: riscv: Fix build fail since INSN_CLASS_A was removed.
2024-05-09 14:25 ` Nelson Chu
@ 2024-05-09 14:26 ` Tom Tromey
2024-05-09 15:06 ` Bernd Edlinger
0 siblings, 1 reply; 5+ messages in thread
From: Tom Tromey @ 2024-05-09 14:26 UTC (permalink / raw)
To: Nelson Chu
Cc: Tom Tromey, bernd.edlinger, gdb-patches, aburgess, vapier, binutils
>>>>> "Nelson" == Nelson Chu <nelson@rivosinc.com> writes:
Nelson> Thanks, I think it would be good to apply the fix from Bernd,
Nelson> since I'm not the expert and regular contributor of gdb ;)
Either way is fine by me. Thanks again.
Tom
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sim: riscv: Fix build fail since INSN_CLASS_A was removed.
2024-05-09 14:26 ` Tom Tromey
@ 2024-05-09 15:06 ` Bernd Edlinger
0 siblings, 0 replies; 5+ messages in thread
From: Bernd Edlinger @ 2024-05-09 15:06 UTC (permalink / raw)
To: Tom Tromey, Nelson Chu; +Cc: gdb-patches, aburgess, vapier, binutils
On 5/9/24 16:26, Tom Tromey wrote:
>>>>>> "Nelson" == Nelson Chu <nelson@rivosinc.com> writes:
>
> Nelson> Thanks, I think it would be good to apply the fix from Bernd,
> Nelson> since I'm not the expert and regular contributor of gdb ;)
>
> Either way is fine by me. Thanks again.
>
Okay, I've pushed it now as b75187cd948
Thanks
Bernd.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-09 15:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-09 0:54 [PATCH] sim: riscv: Fix build fail since INSN_CLASS_A was removed Nelson Chu
2024-05-09 14:11 ` Tom Tromey
2024-05-09 14:25 ` Nelson Chu
2024-05-09 14:26 ` Tom Tromey
2024-05-09 15:06 ` Bernd Edlinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).