Respected community members,

Hi,

Is there any work still going on here or anything pending from this patch?

It caused a build break in AIX.

I have sent a patch to fix the same. One of the includes is still required in AIX. (Did not test in other targets).

Kindly let me know if any information is needed so that we can fix this.

Have a nice day ahead.

Thanks and regards,
Aditya.
From: Tom Tromey <tom@tromey.com>
Date: Monday, 3 June 2024 at 8:27 PM
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Subject: [EXTERNAL] Re: [PATCH 3/3] gdb/tui: cleanup includes
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> Remove includes reported as unused by clangd.  Then, add any includes
Simon> necessary to get rid of errors (includes possibly relying on previous
Simon> includes)..

Simon> I didn't remove the includes of gdb-safe-ctypes.h, because it appears to
Simon> do some some preprocessor magic, redefining standard macros.  I'm afraid
Simon> that removing these includes could change the behavior unintentionally.

It's never been super clear when gdb should use the libiberty stuff and
when it should not.

Approved-By: Tom Tromey <tom@tromey.com>

Tom