[AMD Official Use Only - General] Thanks. I have pushed this patch. Best, Lancelot. ________________________________ From: Simon Marchi Sent: Friday, September 15, 2023 4:41 PM To: Six, Lancelot ; gdb-patches@sourceware.org Cc: lsix@lancelotsix.com ; Morichetti, Laurent Subject: Re: [PATCH] gdb/amdgpu: Silence wave termination messages Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On 9/15/23 06:52, Lancelot Six via Gdb-patches wrote: > From: Laurent Morichetti > > Hi, > > Here is a patch originally written by Laurent Morichetti fixing a > regression in the amd-dbgapi-target I am submitting on his behalf. > > Best, > Lancelot. > > After commit 9d7d58e7262, the amdgpu target started printing > "thread exited" messages when pruning waves that had terminated. > > ... > [AMDGPU Wave ?:?:?:2045 (?,?,?)/? exited] > [AMDGPU Wave ?:?:?:2046 (?,?,?)/? exited] > [AMDGPU Wave ?:?:?:2047 (?,?,?)/? exited] > [AMDGPU Wave ?:?:?:2048 (?,?,?)/? exited] > ... > > The issue was that before commit 9d7d58e7262, delete_thread was silent > by default due to a bug that the commit fixed. > > Replaced the amdgpu target call to delete_thread with a call to > delete_thread_silent. > > Change-Id: Ie5d5a4c5be851f092d2315b2afa6a36a30a05245 > --- > gdb/amd-dbgapi-target.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c > index 22c269b7992..8eafceac569 100644 > --- a/gdb/amd-dbgapi-target.c > +++ b/gdb/amd-dbgapi-target.c > @@ -1634,7 +1634,7 @@ amd_dbgapi_target::update_thread_list () > auto it = threads.find (tp->ptid.tid ()); > > if (it == threads.end ()) > - delete_thread (tp); > + delete_thread_silent (tp); > else > threads.erase (it); > } > > base-commit: 38cc67cc00dc7385991e2658a1b4213d5ba3c4f0 > -- > 2.34.1 > LGTM, thanks. Approved-By: Simon Marchi Simon