From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2051.outbound.protection.outlook.com [40.107.93.51]) by sourceware.org (Postfix) with ESMTPS id C45863858C60 for ; Fri, 15 Sep 2023 16:22:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C45863858C60 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OP07IkREhSyq+cj1Xnh7chf1GNkWTDfknI9rfm3zfj3nds9YO4B/1orrGmOtKH6t/26bYIpbYodd1AWKAYkypowA987OY3qOSTLs1QynsiCo5Q3vYMAZgiHyUovsruJmnmrVTH3Qdh0W6oZ3ux17x90exLJF686EAU1YqwGSKcJK1+aeu+pBb8jTl4jpvfB8rsgiChWWj3TWRN6PLKu1erwuAMuaUHZ1SVhmRGSUvlc2fgKeMZ4djEuI6xRnpxJ8EbisEGeZiu4Jo6cYnftDpCK7hbK4l0Dmt8HTLcuUAvUX4fKEZXCFDkTBuR7hW+7XroxY3Mgm5+4gn6HdoWuqkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y4zLK/sF9iLOU7SIsb8/C91mVqhpfvj2rmY77Vb1D/I=; b=eZJCR/NLW+q5AApU9If69pZDnuM3CDyJwDYvSGjdPFNrzcP//4s1a08zWVcLmja64Rhe5qyvVJeJ4ndNoxx5PZH06hItdI7BHM3tGPKyQWsSWsu1Rgtvke98nltSwTADOlMx0TRkgzz2akDRx20Ngc5bk+YgqLo0En01J4LHAW5IdFpgjjl0rtVMJM5aXdLqRhkBydAiBap1oqacDCmCblBRemnv5x2i0fX2LhKSQn6OL+GMi9ZIfyuA6YrtjCbPSiVtxfMei2p5HbLOcZKhgMu4wU3XMmxSMMAN4OvqVu8NbJamfLRsWja+tSbddvs6JJQXcj0bB/4TmMzxWCh7mQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y4zLK/sF9iLOU7SIsb8/C91mVqhpfvj2rmY77Vb1D/I=; b=fH7e5KNggG77Sb0r/8DUY3+jBE3+7GwsUKN4dJpwRAhWk5a7l0+yotK6BhVxPpkgAUz//dVZeFiliEepzpOuIUdiXpJmInqoda7Y+ccP29UeRjG1XKmuRMndY4WDCFDpJYQabd1RWxozobHzZrvoH03RfINU42XqF8OajnDQJPc= Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by IA1PR12MB6530.namprd12.prod.outlook.com (2603:10b6:208:3a5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.21; Fri, 15 Sep 2023 16:22:44 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::e03f:cc08:43ea:e72f]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::e03f:cc08:43ea:e72f%5]) with mapi id 15.20.6792.021; Fri, 15 Sep 2023 16:22:43 +0000 From: "Six, Lancelot" To: Simon Marchi , "gdb-patches@sourceware.org" CC: "lsix@lancelotsix.com" , "Morichetti, Laurent" Subject: Re: [PATCH] gdb/amdgpu: Silence wave termination messages Thread-Topic: [PATCH] gdb/amdgpu: Silence wave termination messages Thread-Index: AQHZ5+srdLl9yHRj5E6IzswvglMQNbAcEdXp Date: Fri, 15 Sep 2023 16:22:43 +0000 Message-ID: References: <20230915105243.3377965-1-lancelot.six@amd.com> <28ec3678-277d-4327-98e2-e9ab1427b9fa@polymtl.ca> In-Reply-To: <28ec3678-277d-4327-98e2-e9ab1427b9fa@polymtl.ca> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=True;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-09-15T16:22:42.291Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB9079:EE_|IA1PR12MB6530:EE_ x-ms-office365-filtering-correlation-id: 515a1208-b608-4744-20d4-08dbb607fd75 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZfbGcTocBanEtOLRyG/WbKfE5hAVBVc9c82tYVMOBRL+EpAX2oJ7OZcVkxtBk3E9or0LZaedYdY1mse1ue4ydBCwAX/Tb5YC8J6258+Gttm8uz+mX2QQ72dm5+rMMra/zmKXMQ/55nmZ0VnF4T84URKPQq0hZrZ+Enscf7+/ayrhrYoEpCwSW4HPl1GZzuG6dRxLX1+sUEmNU9vUeFVZq2VcaYp84N5BImBJyyfDMs4ehJQTjVm4hOfja5kg2IIEp2DoYRuss62vTSCOWvXXJJSauPWGQs1W3jXS7AXcaTOSzTr5UFvi7hVBaqqqv+bjDdjd8PyyGhyFYfPjOvl9b5sUh5Z4ww8mmJCzZppxDg/pkyDr1sYD0FJANuEwZF7/aVPrfd40p9t6uA5Au5kLPj/Pgks+hhfX7sJfJK3LyPHMNMGKe09/YnqIIWSonUcEHXzndk+6NDW+0SafkV2I/dgK6FboBKrD7WWmzvtvU9+9Q3gp05OOw2R447cAIG0+w1JxFB8XjpCNQlzLjqspMe4xlOwM2xwXFWnT5jUkdlEc+/RZgcOwOcWlYwVEJ/fzqPzJuggh6CDVOpSyhjlQA1qB8PF9iOnMn1Z7Ul3Oq/E0XfJn1zuq+bOHaBc4GcmE x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR12MB9079.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(136003)(396003)(366004)(346002)(39860400002)(1800799009)(451199024)(186009)(7696005)(53546011)(6506007)(71200400001)(9686003)(478600001)(83380400001)(26005)(2906002)(15650500001)(4326008)(66446008)(66556008)(54906003)(64756008)(66476007)(76116006)(66946007)(316002)(110136005)(91956017)(5660300002)(52536014)(41300700001)(8936002)(8676002)(33656002)(86362001)(55016003)(38100700002)(38070700005)(122000001)(19627405001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DRZ4sIb0b13GFamRFj/n3EVYSU4tPHYtbT+I9zoe5WR1qYJC1y7uS/0vKj2w?= =?us-ascii?Q?7mXdQwRbQRxpLkoO0u7NPhfiQSwr/4Ex12BFt5zXi5OjYOW2FPojtj8CZvkG?= =?us-ascii?Q?RjBjK0WSZwuNrSaFDVuL2XxbuHmBrbJhLMq/rrivEEZZ/HftcioqBTH/V2Pt?= =?us-ascii?Q?GAyfohrjBHQiwCrks/o0ifXytAHEs74z0O7ffwWuPaeG6ZeaCIpVAG5mRqSo?= =?us-ascii?Q?QhynjvuE+lEQNEwIY+aCXNPOMhvxr4jd9mhZ6ujhPwlZAmzEv41Y/3RouV9L?= =?us-ascii?Q?RLS/4sXyV4qavSDvofckHzFpHeNh+P5+70S6PFU1nOm2ymJ7/xvx3pZyzPRF?= =?us-ascii?Q?/u44KMPIhQRyLJgtBErTk3jTDnakbju/Li34dXzfxUWh0RyXlGTb6xGMYSRB?= =?us-ascii?Q?DPEZ504kSQDhLDbiMq2jgEabP3p6IZcoIAbyYHFQz0SreSOq8glT7m4MMXtA?= =?us-ascii?Q?l8WKlSjwzuOCIyK2rauCV2tmnDGhyspdNv2osyUzzUi51H/DBoK7QR+FIDuE?= =?us-ascii?Q?PRdt2o5Z6XcQWog/uQjxRLwE7RLvPfP5h4MVUwFqaMmyfNQL9/VDL9f31N+p?= =?us-ascii?Q?3G90cVBRHBWfiFcwAc0pgHMJMDh3Yn478TCRHoFAugrlhE29FUt/zPjMwhfV?= =?us-ascii?Q?xzPxVLIX4wrkb7GaqbWGB5Ii/3BrgsB1th4JTpHovNfrx8Tag+jWP63h7kdi?= =?us-ascii?Q?p/u+IgsHRUXWqEJ4qFShgnxrAsBH6j5ZSBT3UdAP0RdxbCc6xb592Y3VU8Ib?= =?us-ascii?Q?OE+EgT3FkHYRLFY+sH22G1xiCUApEjBObYqq6hwBMuJongrY7IKizKp7KTIm?= =?us-ascii?Q?LB1MT8g7DOGywltLMcKi2kZCIGBGzbQD4QrjDw7//dMxwLTPsouGbxJMoU8C?= =?us-ascii?Q?fjksSWhlixpPMcWq5drtCtfJBLcCwEXZQlKZHAFsyQwuLtsfIXE8ABq9jobo?= =?us-ascii?Q?NaOLyissHLcKWPsATShLw5BlIYydUp++pomlzAELz5l5nSUo4imZW9GjJ98y?= =?us-ascii?Q?KbQCme26Er3o5A1ZLHn/snMAV9Gamv+0d2NWK2yR121BMbJiAlETZPEdGkBZ?= =?us-ascii?Q?wgi5uSd088QoDJ1ibc1PX+NyGdk+NlHeF8xHIUogbTNotyEQHcL0S3sHuG34?= =?us-ascii?Q?FRYRQC40hclUujmwHddXIeDMF6rYeOzjXvbgMApm1uGf2cbv+pSQMpf+3HPA?= =?us-ascii?Q?q3z41P94TCKrlHMzEBr9Jv3qLeCLxDMdU8cXXSHeLAWsV53zzz08gcnDJPh2?= =?us-ascii?Q?8CnNIkUXCpYxZttP2l2l/qYSXi6Q1YBkKpqR+ioaWFNThbHd5P9HW2RbO6dD?= =?us-ascii?Q?mLXrlB9+z2TN8K6/YSWQcLl2Kn+wnjfH23M78jOwRh5Gy2wZ601NzRX16t0i?= =?us-ascii?Q?2ubF/IZVYMqaBXgtxzTxkV2vPfLpIloBP/5IPKLpmEy6po1ctmGQONjRh0ac?= =?us-ascii?Q?hu5EYOAOOUhcG41Tan8mRoHHcejIK0Eu8mxsEGukeMEGFYTkFvNkmeP6K1m0?= =?us-ascii?Q?qbx0rv0g6d1hi8BHLw8+86eXWQoR1d85hWcLa8l90wwZL8YgFP+Gz0mrW7h+?= =?us-ascii?Q?MuqhZWB85v8nprO/NUk=3D?= Content-Type: multipart/alternative; boundary="_000_CH3PR12MB90792A5DF37453E3BB2BE45883F6ACH3PR12MB9079namp_" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 515a1208-b608-4744-20d4-08dbb607fd75 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2023 16:22:43.6017 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BNM/DyTNByX9KrQ/BNA1BE+cO2vuGupRd0cc4/MRrtgfdgWzKGl/nkV3HBOmfjduviRWOh3s0X3OgcH4R8rWyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6530 X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --_000_CH3PR12MB90792A5DF37453E3BB2BE45883F6ACH3PR12MB9079namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Thanks. I have pushed this patch. Best, Lancelot. ________________________________ From: Simon Marchi Sent: Friday, September 15, 2023 4:41 PM To: Six, Lancelot ; gdb-patches@sourceware.org Cc: lsix@lancelotsix.com ; Morichetti, Laurent Subject: Re: [PATCH] gdb/amdgpu: Silence wave termination messages Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. On 9/15/23 06:52, Lancelot Six via Gdb-patches wrote: > From: Laurent Morichetti > > Hi, > > Here is a patch originally written by Laurent Morichetti fixing a > regression in the amd-dbgapi-target I am submitting on his behalf. > > Best, > Lancelot. > > After commit 9d7d58e7262, the amdgpu target started printing > "thread exited" messages when pruning waves that had terminated. > > ... > [AMDGPU Wave ?:?:?:2045 (?,?,?)/? exited] > [AMDGPU Wave ?:?:?:2046 (?,?,?)/? exited] > [AMDGPU Wave ?:?:?:2047 (?,?,?)/? exited] > [AMDGPU Wave ?:?:?:2048 (?,?,?)/? exited] > ... > > The issue was that before commit 9d7d58e7262, delete_thread was silent > by default due to a bug that the commit fixed. > > Replaced the amdgpu target call to delete_thread with a call to > delete_thread_silent. > > Change-Id: Ie5d5a4c5be851f092d2315b2afa6a36a30a05245 > --- > gdb/amd-dbgapi-target.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c > index 22c269b7992..8eafceac569 100644 > --- a/gdb/amd-dbgapi-target.c > +++ b/gdb/amd-dbgapi-target.c > @@ -1634,7 +1634,7 @@ amd_dbgapi_target::update_thread_list () > auto it =3D threads.find (tp->ptid.tid ()); > > if (it =3D=3D threads.end ()) > - delete_thread (tp); > + delete_thread_silent (tp); > else > threads.erase (it); > } > > base-commit: 38cc67cc00dc7385991e2658a1b4213d5ba3c4f0 > -- > 2.34.1 > LGTM, thanks. Approved-By: Simon Marchi Simon --_000_CH3PR12MB90792A5DF37453E3BB2BE45883F6ACH3PR12MB9079namp_--