From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2058.outbound.protection.outlook.com [40.107.94.58]) by sourceware.org (Postfix) with ESMTPS id CF2903858D32 for ; Mon, 15 Aug 2022 09:45:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CF2903858D32 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YrHvHAznIo69d36NvZpP/42kmM2cOzjkzzK6CrCUm7Sk+HF0l516wJUm4F1va9nk1Px7ozu0SCuXqYj7rvNvmUrMNZQ7CqxMCc4aNpTJG3lCwUO9QRjLM8DGjbyjFsaFL78/BqNWJJ1CA9myFJZYPCGhRjdtZ0SIsABintiIABKCbIZdRqu/J+B+HbKKmBBZGKcEtbUtxUQfNW784hQgU7uFCOXUEncWSg5kMwkyMaJ8/nC2+aLAM5uyCcNyCSwNswomXE520CDMLZduCDgiOGRBVAGrwI1DjGhtrtbRB8WWtycypDQQPt9P0279TBtBxdGWUm2+JTl7wY1+QYztiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vukjd8OzYsRjlejVwoG8yqVt5m4OEn/oF/lDRh5Kpic=; b=muGJsyRIbSvSFjUKy5tfsZcyaFr7hB1krjJpT+YAj3BGJjyzQySZcU+vOFErH5AHF17aliJXmBoIX7dh3j9MJBOpC3f3LwR0ocGu56BLxIXbqnnFCcmr2p1BsRUP54n6+n+//RN68w2VesRcc5qFJVMCqWNmdNtJFAwU+VyWCVDWClyANMBwhUOjpf22EPu0PhTdrQxteGKwOV9UgdYOBw5obuRc5l93Q6YXwVygopPAYHa3tHuNMCcUI1p69fYXHOfL8Nh0urNiGgULjmros2j6WbLfwxYftjXtUInbDUfn0dp/WOHg0r1D+t8K2CWVgc7tCFjl0qK8OJu+PjZtHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from CO6PR12MB5491.namprd12.prod.outlook.com (2603:10b6:303:13b::8) by BN8PR12MB4593.namprd12.prod.outlook.com (2603:10b6:408:aa::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16; Mon, 15 Aug 2022 09:45:38 +0000 Received: from CO6PR12MB5491.namprd12.prod.outlook.com ([fe80::bcbe:f61e:81ab:d188]) by CO6PR12MB5491.namprd12.prod.outlook.com ([fe80::bcbe:f61e:81ab:d188%2]) with mapi id 15.20.5504.028; Mon, 15 Aug 2022 09:45:38 +0000 From: "Sharma, Alok Kumar" To: "gdb-patches@sourceware.org" CC: "George, Jini Susan" Subject: RE: [PATCH] Enable Access to containing scope variables from nested inlined function Thread-Topic: [PATCH] Enable Access to containing scope variables from nested inlined function Thread-Index: AdifiG4v+p6eTZ/3TAWVx+6eDMBxZwF4u3YgAT5N8sABicXIMA== Date: Mon, 15 Aug 2022 09:45:38 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2022-07-24T18:07:24Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=2ab2b2ad-6dda-411b-9c7e-4fcd93ad4840; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=1 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_enabled: true msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_setdate: 2022-08-15T09:45:34Z msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_method: Privileged msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_name: Public-AIP 2.0 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_actionid: 735b010a-e5c0-458a-9c40-94531f0ba9b5 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_contentbits: 0 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ee2bb625-d194-4e36-22fb-08da7ea2e929 x-ms-traffictypediagnostic: BN8PR12MB4593:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VuFARcVlVwr81WwzwaKS5si1yavg7XwQQwEPUWEp8wohR6Gw6krG+xljVPWJJ+pCvaGQwwVqAM9e/4qyaKOZLelwAUpCYqP9xtkgmiBrcD10y8S00uypKO0mjNzSbNTPL3+1ss0NDf2gZpf38JVXjeglv+n+C19kuhuQ1+e99ugcsuyYhKak/Lgdt9OBEkY3huPZ6d0qpthzx3q9MtCJDFh/RxhtUenQQIhn6DXbLvn9/LSD+gPWQ7T9U+prA/n/aUlmfi/Td8c70nTXXwbOZxS2GY9eVKFb4ZC/WXfjD1KmxnX4U7V3TW0mKSItCOghW5i1uIpKSc8zXK3S4q1N6TTH1ti1UKBh6L1+egdmb4h1uXuHV7hwnk1mMHYmUujzqjuLAWqsrRYkZXkeuonY1PiJmwaWkunJaVHkndjRaAeA6swyWWY0M4Hfdu6dbT2Apfx1FJwccK+x62VPw+fSJdWcOfaOoSXpXjySPN975l3eNOn1wnXUjiTaHA3yde85+IHgAmiq2p+xjLQjHkTsf6Pz5F42Xx23Y5wTJfmjLjUVlqHx2svf56Zz0YrujLOoJKCIfW2LRXONVe+aq8ja0x2gp1J47eji0dBgDqYNKj6EmKmIG+IZ8aOib6TeCYqXxgk0dtDrhgu4dDvUciXYlaGRqToyG/1FIqRSAQCvg/bRh6hpYoBijXOynW1kyjlaWQfRT0+k9iLVWcNUVjMR5/CudSStl5dNOcTnSI0l/FJMW/CmymUSdgUIENjNrkzU68S7pcZQwbWtg03qWyXDz64agjj+X2Jro6+dqJo3GqE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5491.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(136003)(366004)(346002)(376002)(396003)(39860400002)(64756008)(66476007)(66946007)(76116006)(66446008)(2906002)(8676002)(4326008)(41300700001)(316002)(6916009)(86362001)(478600001)(33656002)(38070700005)(71200400001)(66556008)(52536014)(5660300002)(83380400001)(122000001)(8936002)(55016003)(38100700002)(26005)(6506007)(7696005)(9686003)(53546011)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gj56X5ejt4YKf+uMRDDy2PL5nwf5mQKJv0LQa5PRTXdVEFB191p35VEjXT+/?= =?us-ascii?Q?ny5RlK4WtbaNUKOMZfEDAWpf0+tSupX3XbW9Jvjwm6j9IaQQP0GmT1NLJ/4T?= =?us-ascii?Q?26sn2f+WQOTTNS4WhTg/vdyUerrTkrW/xPKnD3CQd2KJ7xqOJxKYdBl6Tfs7?= =?us-ascii?Q?XOmCtvsxSSF/IhN9aLcdRjvk0tC/E6tXzKQGkT+uAf4n7Cy+pCkUE2e9Pir6?= =?us-ascii?Q?VDg144n80V/uf0ut2ATZff6fwnUYG0t25rMhcpugQLj24+9G7/al6RsYfLJM?= =?us-ascii?Q?V6q/uVYj3Zw85a0WOiCLNFVpj2RH9ksHszCsQsbtHc9dU5Xr1Q2J0ynR4lQr?= =?us-ascii?Q?EJBTHRFmbIIsQrhlkcWj+HRDoMaNODt/UyvNt2uRl5duyY44groIhkUZPXAe?= =?us-ascii?Q?Q0YIbOKYdEUeNYqG29+YHMINtTEdeXPJn8RFwfU1c9oN2W7ThiS9WsLWB8rl?= =?us-ascii?Q?/SFY9b5WllWd+ZpwA2Bln2N8mdN6gw71g6mheKDEzBkywIlOf4nhU3ehbJCv?= =?us-ascii?Q?dUwvPX5u4sT89VE7yNdvtkyY6bVp7bj/fkDZVLX6Jkb1yuI7BLp2V7pguFvb?= =?us-ascii?Q?BQDwQgeWWDXjmHxz4uM9sMflcb/zykrLRS8IUq+uAgAtt+XUEF2V6HI+eZ0k?= =?us-ascii?Q?7tiiAetsArhWByCCuQd0qfumWv0CvLa6YHiXAKuzx5ANLaLJnzGk3hMStcH9?= =?us-ascii?Q?ftpplYe3RR2KzWDXHxlq4ddrGY4yLdhz7s5rk3etQBCbIHXQPnSoIUjwwKEO?= =?us-ascii?Q?L8F8+/k/SzyxfbyU10Asa4BisARSQX7BzexBAJuUl2Y/HW2NrA8iA0M2RAsM?= =?us-ascii?Q?tE4iOrHCPC2u++9vils1IVhO6Df21L1J39BBi1+JQji2a+5qo30V5aK8fnqJ?= =?us-ascii?Q?Md7Ul0SduW1ZnaABKsaWVrR9V+EYaLX0JDryBiexTGuoeAshOZPziA3UH+WQ?= =?us-ascii?Q?+UaooDvNVRAy4d5aOCDLX90fOu1IVqHdxsPk8A7sEuWi4U/sVji3L/OnMzDK?= =?us-ascii?Q?uGj8f9sLGr0DhBZaRxCvYkZuwxKLMxbxklgJOUQqJkydliLlt0P6D6M/t/pN?= =?us-ascii?Q?XyHv5fg5CLL7+iCypWJWHixP0nP9ByujhQOHkTJXpACD5BGA3Q7UaFDtOwGi?= =?us-ascii?Q?gz1Rvkf27cnrqPbgKlr6RBTPKU8h8+t4VG97DeyMwG6inGkiQ1YFluMElsb4?= =?us-ascii?Q?E/IV4w7LCqMu4UIocsNcsHHESv8KSHhap1GV1bzpZ3/GZbt+2GmINLGYJ+cd?= =?us-ascii?Q?PfZo+8CCmQUL28zHEw2/Zbb6yOExO2qd+c7WzBnyZZYWha4NxeXtfWXV8vQr?= =?us-ascii?Q?Jp6yO6YVqShjLPAj3asolMZV+PElrObtVgCUWveEOG+c0sviz2CKRE2awnae?= =?us-ascii?Q?6idq+ymw/bZJFAzICvjz6oorUh9WnT0FJtX2ZI4LfWZQzBnI37qEP7Bahv5G?= =?us-ascii?Q?zCDSsVfA8ac7hRiCFm/OYe4LSjAn/LRSFKv/3megHepla2jtISNm5sEc1U4t?= =?us-ascii?Q?gStkooOtQhw5z63TWQIWdQFqvTu1L5RGcsj8OUNpPMUfJ0Hh4vDHOdEQtwj6?= =?us-ascii?Q?+WQOM74V6JNuC3XNa5I=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5491.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee2bb625-d194-4e36-22fb-08da7ea2e929 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2022 09:45:38.7310 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: D1/e3cfKk/Qt+nneLh3vJX6HDVS6NM1NebCOr0k7panJNx8OvMB09K6XM6YJ/HqAI2rqTBAm9E3DvqcVp0djYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB4593 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2022 09:45:43 -0000 [Public] Gentle Reminder - 3 !!! Regards, Alok -----Original Message----- From: Sharma, Alok Kumar=20 Sent: Sunday, August 7, 2022 8:35 PM To: 'gdb-patches@sourceware.org' Cc: George, Jini Susan Subject: RE: [PATCH] Enable Access to containing scope variables from neste= d inlined function [Public] Gentle Reminder - 2 !!! Regards, Alok -----Original Message----- From: Sharma, Alok Kumar=20 Sent: Monday, August 1, 2022 11:27 AM To: 'gdb-patches@sourceware.org' Cc: George, Jini Susan Subject: RE: [PATCH] Enable Access to containing scope variables from neste= d inlined function [Public] Gentle Reminder -1 !!! Regards, Alok -----Original Message----- From: Sharma, Alok Kumar=20 Sent: Sunday, July 24, 2022 11:46 PM To: gdb-patches@sourceware.org Cc: George, Jini Susan Subject: [PATCH] Enable Access to containing scope variables from nested in= lined function [Public] Hi all, Currently inlined functions are barred from accessing any containing local = scope variable, which makes sense for global scoped functions. The gcc compiler supports nested (local scoped) function for end user, the = Clang compiler does not allow nested function for end user but compiler its= elf generates such artificial functions internally ( in case of Openmp). Ge= neral barrier by gdb reduces debug experience, current patch enhances debug= ging in such cases. Please consider below program --------------------- 1 #include 2 3 __attribute__((always_inline)) inline int outer_fun (int arg) { 4 // Inlined at (A) or not, this function should not have access to 5 // variables caller_fun_var, caller_fun_other_var in non containi= ng 6 // scoped function caller_fun. 7 int outer_local =3D 5; 8 outer_local =3D arg; 9 printf("Value of outer_local =3D %d\n", outer_local); 10 } 11 12 void caller_fun() { 13 static int caller_fun_var =3D 9; 14 volatile int caller_fun_other_var =3D 7; 15 __attribute__((always_inline)) inline void called_fun (int arg) { 16 // Inlined at (B) or not, this function should have access to 17 // containing scope variables caller_fun_var, caller_fun_other_va= r 18 int local =3D 0; 19 local =3D arg; 20 printf("Value of local =3D %d\n", local); 21 } 22 23 outer_fun(caller_fun_other_var); // <--- (A) 24 called_fun(caller_fun_other_var); // <--- (B) 25 return; 26 } 27 28 int main() { 29 caller_fun(); 30 return 0; 31 } ----------------------- Which produces DWARF as below ----------------------- 0x00000094: DW_TAG_subprogram DW_AT_name ("main") 0x000000b2: DW_TAG_subprogram DW_AT_name ("caller_fun") 0x000000d0: DW_TAG_variable DW_AT_name ("caller_fun_var") 0x000000dd: DW_TAG_variable DW_AT_name ("caller_fun_other_var") 0x000000ec: DW_TAG_subprogram DW_AT_name ("called_fun") 0x00000112: DW_TAG_inlined_subroutine DW_AT_abstract_origin (0x00000169 "outer_fun") 0x0000013f: DW_TAG_inlined_subroutine DW_AT_abstract_origin (0x000000ec "called_fun") 0x00000169: DW_TAG_subprogram DW_AT_external (true) DW_AT_name ("outer_fun") ----------------------- Please note concrete instances of abstract functions "called_fun" (0x000000= ec) and "outer_fun" (0x00000169) are DIE:0x00000112 and DIE:0x0000013f. Bot= h have DWARF tag DW_TAG_inlined_subroutine. To stop "outer_fun" (0x00000112) from accessing scope of "caller_fun", gdb = generalize barrier for DW_TAG_inlined_subroutine. GDB should instead check DW_AT_abstract_origin attribute to check actual sc= ope of corresponding abstract functions and allow "called_fun" to access sc= ope of "caller_fun". Current patch stores this information into data structure DIE_BLOCK and use= s that to compute actual containing scope. Please review the patch and let me know your comments. Regards, Alok