From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2064.outbound.protection.outlook.com [40.107.93.64]) by sourceware.org (Postfix) with ESMTPS id 334C33857C75 for ; Sun, 7 Aug 2022 15:05:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 334C33857C75 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=klDCF4NMz7m6djKDskl9wZxSsWpJjlkW/7j18JZc/+x0l+EPQQeV8ncTsPSvgSUsloU+yqyWEqF07nNslB0oEXiU+NBlvTx2LsS67/6/jiupDbZy1WXzb8R4awa0KOMkKdKL9Zr7Zh33lIp6pT3R4Dkh5e3ZsvMeoeXs5HXrZu1v0wtWllo9frL72DFt/OPHeg4ITdlWsXWfnxDtDmER7ZtyHqA1Yo9OwOhI+8LcHkLvnCLynklqXPSPAbyrO1AvBFbHWne1Odl2LHdcnsqevEceX2xgnVto6rxGGQksHXXCwoAVoCKDjzTFnrPK1eko1F/yj2qdilSR66/YGzl6gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZEH1kLcopKM7LbMFPX2WO5IW1HXHPuBnVTTpmS2VNTs=; b=JycTZT7dZReNqkQLPFxl6o0ZB/+d9MGtc59Oq4luPzNixolQAsh08afzULc3yXMWwURW9c5n3DWZWQd5t+KzRrTqh7+kb7ICNuXdkMVQ/HEo6wQDTZDHN1T39hgV28bi5U3B962Zwq30p1m49z1M9Hkhd3uq0ewamenRlYEIf91AZ+tE/hFiowQ3wKPlcOxttnK69ID6Ao1r1tC5KKdUWkPlCKrfMTrhOrVFAeNTbsW6WjwF3mTOXHUhuMMvBlpNNNPSNo/rJQJLRzR7S5Y1DFoFzBaMM+0khyGaRwZalvCYr0K/8g4kMS/782NaZXnrPOr2T19GUpQYLj/+wITT6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from CO6PR12MB5491.namprd12.prod.outlook.com (2603:10b6:303:13b::8) by DM6PR12MB4315.namprd12.prod.outlook.com (2603:10b6:5:223::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16; Sun, 7 Aug 2022 15:05:10 +0000 Received: from CO6PR12MB5491.namprd12.prod.outlook.com ([fe80::bcbe:f61e:81ab:d188]) by CO6PR12MB5491.namprd12.prod.outlook.com ([fe80::bcbe:f61e:81ab:d188%2]) with mapi id 15.20.5504.019; Sun, 7 Aug 2022 15:05:09 +0000 From: "Sharma, Alok Kumar" To: "gdb-patches@sourceware.org" CC: "George, Jini Susan" Subject: RE: [PATCH] Enable Access to containing scope variables from nested inlined function Thread-Topic: [PATCH] Enable Access to containing scope variables from nested inlined function Thread-Index: AdifiG4v+p6eTZ/3TAWVx+6eDMBxZwF4u3YgAT5N8sA= Date: Sun, 7 Aug 2022 15:05:09 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2022-07-24T18:07:24Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=2ab2b2ad-6dda-411b-9c7e-4fcd93ad4840; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=1 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_enabled: true msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_setdate: 2022-08-07T15:05:04Z msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_method: Privileged msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_name: Public-AIP 2.0 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_actionid: fb2f2741-5a4b-40e1-b0f5-a619b793f04b msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_contentbits: 0 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5f1c5277-a542-4d3e-305a-08da78863895 x-ms-traffictypediagnostic: DM6PR12MB4315:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ydn7xtTzSr8TsBaQuCFYSD82rp0UrCSjd7JiFHVibryQKrPhfmFh0ixyYv2va+0FwtCesCjsAy0nzV8ZchrmhVZnaRMUVXs9qXZRnA+O08GOE4b/sCu5Bu8mzQtVMZb6MJMWQAmCYRWS90dUvuzv/yucX4jLrwEcog/znMttu4RP0JBWPVlmFIPnlGx3yJLj8m+/qA/wbmGTjf8WLrmTQ7/J/hmDTs5C/laELoMqwhmj5hjROpdPNzm2uLh/ACMMJR+CsoMKLHAe6HFQ9i1ZTDHszyM7IOQG8hXVhfnp8WeHHzzIMFjw9cQBVA7DseyQcORfy10ZHR30n7QnZ1phFgi2y3wrGwpA1aAvZ6hZeMAH33W/D2JUi1Yleyt48hc2Y8AGJcoBbbY8so5aM1lZ5VQxzw7GEBug4nUG7pOv6XDQ5EIMWZZxTdE9SeMqW3RS244EtBgq3fIlX84d6p6fb9fLSr/s50jfrDurxgCAteMI+LiJ0sQKmBi5JZJ+qj1Tb+YtxlqOPDH75/1OikbnxGuyIE/cth/nGBp0oguDQ3hxtxtWX1GwBHkQNUDhp7Fha+Jap5rgIpUrgkdWIlWYeGe4YOv0DLZzhiiZRi0Bzc/9x4vhzt54FWJf3wG2B0ryh9JkggtzhN4JcfpewdtXpN3Qaf/4OKSxgM3DI3C6vBCIi++SGLuQj+PRlF3xzxpYgv/TbD1bUhADvxSgSflVTZmzVChlezntYTHqVgsxzGOegh31XqqaD2aMMEIOGBK6n9pnDlIhIi3+MrirJGtXkEh57yAGJ96yVjbGvUYx00Y= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5491.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(346002)(376002)(136003)(366004)(396003)(39860400002)(33656002)(55016003)(66946007)(38100700002)(76116006)(86362001)(71200400001)(7696005)(6506007)(316002)(2906002)(53546011)(41300700001)(478600001)(26005)(9686003)(8936002)(38070700005)(6916009)(5660300002)(186003)(122000001)(8676002)(66446008)(66476007)(66556008)(4326008)(52536014)(64756008)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iROIytlLtvFDI5hghlFlTCGvwjo8jN1MXBfy1Kw9KImEoTULA3huKt4Cq94T?= =?us-ascii?Q?soeAJ/FfhMqFW2JYhpEuNeyBmXH/7i/Fr/CI7SqZLVUaoydbPv6/hgAgjFtI?= =?us-ascii?Q?608DV+2pJV8Ki3vTzZL6mSE0nG55QU3PwKwO/tunkZt8dyqMtVc6dZQsrW+b?= =?us-ascii?Q?v/mETe05irWnL1zFCFQepFE22qzyaWaqgvrc36kOhdmT9ed39EDNDUSNetHU?= =?us-ascii?Q?UO+lao0/UYPPwxbZmB26b14ZNIDGyZMD2eJ/bQ71BEWQhCIJCt7aitXJb129?= =?us-ascii?Q?0LjAnXeX0ykgF6oDCTgrQHhma89/ft/KHNcjQDadnnAK38mOLlIRa1qR71pn?= =?us-ascii?Q?Bz1c3RoZqdU/arGsRuQYxJZOEAFdR0ahpDHcnj3U5lnCcj0AeYzf7fbfGOU3?= =?us-ascii?Q?WyM6ukZMJxrq5kNenHOeMlQDWVkqDbkhKz1iv+A/K9U2WIfvCebwAOsYRt/V?= =?us-ascii?Q?f66NLAitedwHUWUd/jhd5QrJWYC3oXDjdnu9Rifb30bgvBTlWoqX3uygvJzp?= =?us-ascii?Q?aP1L4kkXy1D8of8AAhWNKuEHOo2WbiXY9UgjKvBG5k61at1zv8TEzlwPAQzG?= =?us-ascii?Q?eBoNzlpqvD2lp4bZUp1X1tYgkVM02UrRpncG2piK4cmtkLy+ULXpOGS3S9+Z?= =?us-ascii?Q?7GY07RT7UGilfQ/zpL6ZS9jkm0wJ14orjbiWWgCjHqycLTgZHswQ1ww6mUhF?= =?us-ascii?Q?6cnhm4tWo10o0LhGiGpwruXjK+Q7DFAsUXi7fdfQnWWs4X6j4EfXxQlz0hwH?= =?us-ascii?Q?iwURXnkbxz1gs/Q2etq1t56gc0Ymuia/FJ+Tq0hFSgglnu1xGWTGzwcCPnqQ?= =?us-ascii?Q?7idfxFyB8JGE4cGGSQNDzw7mXad+aqFsJ2k+svBg3NbyIL+YgThDFs+4oD9q?= =?us-ascii?Q?3GmHpUbYTQMEIbeyY9ZMfC1+rHgmIlxXkTAJh2/ZoY181yZEqcliK9g6H/e6?= =?us-ascii?Q?a3Ga+G6F+ncjypdAfMxh3nAbvOMIZGLrOvo8Tcuzj3EPpIb4ZaxxN8sutQGm?= =?us-ascii?Q?DcC9OKrPPEsLrb9E6wMDuWHAEZ6d4L32Z8afAS9/quj91EbsE0E0nVP53o2H?= =?us-ascii?Q?wZYpiSpoIE9yHH2QI9GyB6Dj+EnJOW4gdt9sxdB7uyPNP6LaB7sbTgrB1LFq?= =?us-ascii?Q?bGBbBgASg0w2uaY0u8wAQ40hBQ9m2BQumbf9QZKX7Nb2XZdc7lunfJMv6k0z?= =?us-ascii?Q?SQ+aeu6MVf8tlGLdfBe0apYSE+ai5AEwQov8Su9wJlMLZX+a7UeoLQdAL41U?= =?us-ascii?Q?HRrTK6z/wKEk9mEGV8RmHIC8hLm1IbOCuEbVTwMZzFppznhPcS0AZUeEy97m?= =?us-ascii?Q?ySyX0gIfhN8Wkrly8EmeVq135/s1gAmuf1HRQKS5GhiD9CgCOS5Aj353/YuZ?= =?us-ascii?Q?8itUYFyz4QFjb3/8hTfb63wcI+fmHpmfCBB+2iDNa1/uI96Gl2HUSgybS8le?= =?us-ascii?Q?r/2CxNEoArFBeDeVI9Yb4sKHs7u+I2BAsvP/f3I4DbEEP/G9eE+iuubaUqSG?= =?us-ascii?Q?wnpqfvhXhZCRcMD9lyVXnCOIysqef/5iZS8yqbxsU3fNPwQQ5hI2ehpFfkLr?= =?us-ascii?Q?0cZYLodDE0nL5j78jxM=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5491.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f1c5277-a542-4d3e-305a-08da78863895 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2022 15:05:09.5973 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PsiEb9941p6CJLHrrTfvZQRrt+Cgk2WqkKoCBmyqBLbmZ+gbvL/pgNfwX+AzdiKZusiy33rgPjA7tWYysTFUvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4315 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Aug 2022 15:05:14 -0000 [Public] Gentle Reminder - 2 !!! Regards, Alok -----Original Message----- From: Sharma, Alok Kumar=20 Sent: Monday, August 1, 2022 11:27 AM To: 'gdb-patches@sourceware.org' Cc: George, Jini Susan Subject: RE: [PATCH] Enable Access to containing scope variables from neste= d inlined function [Public] Gentle Reminder -1 !!! Regards, Alok -----Original Message----- From: Sharma, Alok Kumar=20 Sent: Sunday, July 24, 2022 11:46 PM To: gdb-patches@sourceware.org Cc: George, Jini Susan Subject: [PATCH] Enable Access to containing scope variables from nested in= lined function [Public] Hi all, Currently inlined functions are barred from accessing any containing local = scope variable, which makes sense for global scoped functions. The gcc compiler supports nested (local scoped) function for end user, the = Clang compiler does not allow nested function for end user but compiler its= elf generates such artificial functions internally ( in case of Openmp). Ge= neral barrier by gdb reduces debug experience, current patch enhances debug= ging in such cases. Please consider below program --------------------- 1 #include 2 3 __attribute__((always_inline)) inline int outer_fun (int arg) { 4 // Inlined at (A) or not, this function should not have access to 5 // variables caller_fun_var, caller_fun_other_var in non containi= ng 6 // scoped function caller_fun. 7 int outer_local =3D 5; 8 outer_local =3D arg; 9 printf("Value of outer_local =3D %d\n", outer_local); 10 } 11 12 void caller_fun() { 13 static int caller_fun_var =3D 9; 14 volatile int caller_fun_other_var =3D 7; 15 __attribute__((always_inline)) inline void called_fun (int arg) { 16 // Inlined at (B) or not, this function should have access to 17 // containing scope variables caller_fun_var, caller_fun_other_va= r 18 int local =3D 0; 19 local =3D arg; 20 printf("Value of local =3D %d\n", local); 21 } 22 23 outer_fun(caller_fun_other_var); // <--- (A) 24 called_fun(caller_fun_other_var); // <--- (B) 25 return; 26 } 27 28 int main() { 29 caller_fun(); 30 return 0; 31 } ----------------------- Which produces DWARF as below ----------------------- 0x00000094: DW_TAG_subprogram DW_AT_name ("main") 0x000000b2: DW_TAG_subprogram DW_AT_name ("caller_fun") 0x000000d0: DW_TAG_variable DW_AT_name ("caller_fun_var") 0x000000dd: DW_TAG_variable DW_AT_name ("caller_fun_other_var") 0x000000ec: DW_TAG_subprogram DW_AT_name ("called_fun") 0x00000112: DW_TAG_inlined_subroutine DW_AT_abstract_origin (0x00000169 "outer_fun") 0x0000013f: DW_TAG_inlined_subroutine DW_AT_abstract_origin (0x000000ec "called_fun") 0x00000169: DW_TAG_subprogram DW_AT_external (true) DW_AT_name ("outer_fun") ----------------------- Please note concrete instances of abstract functions "called_fun" (0x000000= ec) and "outer_fun" (0x00000169) are DIE:0x00000112 and DIE:0x0000013f. Bot= h have DWARF tag DW_TAG_inlined_subroutine. To stop "outer_fun" (0x00000112) from accessing scope of "caller_fun", gdb = generalize barrier for DW_TAG_inlined_subroutine. GDB should instead check DW_AT_abstract_origin attribute to check actual sc= ope of corresponding abstract functions and allow "called_fun" to access sc= ope of "caller_fun". Current patch stores this information into data structure DIE_BLOCK and use= s that to compute actual containing scope. Please review the patch and let me know your comments. Regards, Alok