From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2058.outbound.protection.outlook.com [40.107.243.58]) by sourceware.org (Postfix) with ESMTPS id DDFEF385414A for ; Tue, 11 Oct 2022 14:24:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DDFEF385414A ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YPt+RT3zTnVYV5C5PrOC3mrWW3VRh8NX5FZ0X+VMmjYUXoyjaKNBUeWQ0+zTwPWCrFiRpubGhNm6/WqM83P+ZjmfP4HjZNpukeBQorng+mgpBQbv1shB60e9bhloNBMQEhWxtXc2DfDJAR3MBT/qlchAaI/a8hJNk6MrBh293VqEtJbVqeW0bj4kDPuKZvAmn4uHvViBouY+3VFJH/4phG2450AJG0i+tIdrOfqUhWRRfHG3Kv6J/6Qh09YY1fr186LIlC9NPUkc+PN2JJ5Z2k5iLuA6MIQXgeSdo/Zwm4IPlT4D6Krq4Rk7iwSuKVueHjZXDPXPJKCXtLaLvjoXUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ug0oWgRP1C9+3ynIxncC6Rf4GSHCtBd/9BOMlgUV3z0=; b=RpHz6gLaEA8rXVMD7DgV0QI8p80bTmPMdx2aJunWQ+Iaf3m+WOKOQJWUrL7uaZ/fSI9s379aK/eVJ6+6LHq+h34ZERFKkb4Zp0PINUpb4X/jRHnklEuv1vzsgDXGQ9NbCjGPWBGdw61Cr+IFj+K4fHPP4DJkknWAg0DNnCyGIKTtX8NDRVT2VOEmg6+JlR7Gd3leVAeAjjMO+pElbNcRB2GCZIHhZTc62cQuDTsbBocSx8oiewoeVVcdSd4gknKbQXune3HhTSWrnZy0K69MTB3QRiKWevWqLGso2ptcIjjms+l9TR82KpmxLjO8JonxVqk4mAbJqc45H54PiTkpeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from CO6PR12MB5491.namprd12.prod.outlook.com (2603:10b6:303:13b::8) by BY5PR12MB4275.namprd12.prod.outlook.com (2603:10b6:a03:20a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Tue, 11 Oct 2022 14:24:33 +0000 Received: from CO6PR12MB5491.namprd12.prod.outlook.com ([fe80::d92f:6201:b9dd:91c5]) by CO6PR12MB5491.namprd12.prod.outlook.com ([fe80::d92f:6201:b9dd:91c5%5]) with mapi id 15.20.5709.021; Tue, 11 Oct 2022 14:24:33 +0000 From: "Sharma, Alok Kumar" To: "gdb-patches@sourceware.org" CC: "George, Jini Susan" Subject: RE: [PATCH] Enable Access to containing scope variables from nested inlined function Thread-Topic: [PATCH] Enable Access to containing scope variables from nested inlined function Thread-Index: AdifiG4v+p6eTZ/3TAWVx+6eDMBxZwF4u3YgAT5N8sABicXIMALDby1AArN7JQAByGTp0AP9CqXg Date: Tue, 11 Oct 2022 14:24:33 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2022-07-24T18:07:24Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=2ab2b2ad-6dda-411b-9c7e-4fcd93ad4840; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=1 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_enabled: true msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_setdate: 2022-10-11T14:24:28Z msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_method: Privileged msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_name: Public-AIP 2.0 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_actionid: 03ab19af-f909-45cf-8f28-9b795722052c msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_contentbits: 0 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR12MB5491:EE_|BY5PR12MB4275:EE_ x-ms-office365-filtering-correlation-id: 529ce955-f6bb-4e9a-b772-08daab945145 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: G4u/57/oEFhbPuUwzTAK2NQlElCGQTPuXufKRBd55T/uqNjT/+7SdGoBgXGlONBp5NuXNUX2nWDIybR16z+WC7yz0KhJB29vaxgHzQbHNZ7/f7BJPP8qyVz3tYHQrfJVz0drnaGbpHReLxJvLolWHzDtnc5oB4tYqdj3OFYDHXr40bhhH+7RHVFTnzdotzJsMiaaK7eHv/4NT/gZrFzNSyKYeGfUmmXDD3cF7cJOGZSd2QBEgq82500CZ8cwWiM7Jg/GEM2bPoS9DDFKXh/1/AMHxIOd1Wcad9u12FRc//t/CVhtYWsXyGs6aDI4lvDcuUqxCTA9+IpZyMWN2IYCg/42TC2Kyl/ALWIZmVl8O2QDW1kdRA7iiDzRugjwVvLIXBxGI5SxFpq8i7SJNu3PANdpdq5U+RpsWHYD9B7djLMqX5FRLQMNxn2R1Hoo5ftYPs88MyjOraojVVK/vJOYIWhfzgI2O3pUZMcmUWdIq94GvthhWuBFfiw1MDy4izA6+2FxrgK0feJbkQfoik3h+FgAQZrtegLeYVNuA554kcBU7BTkWEB0gf1kHNoqXH/DaOF/bb9IH71Udac5N3uRgw3rGFlGPmXHbMuKpEqDP1JsE9PvLND3LDEwuialSwIABvWhYrvgPBPuGQ5igfTyOetcpFxHcgtK756jjPcHGXghnAIA2cEG/u1tQSD6SP9W36wueiZW6FWiv7FksZ6vOPxNZjeCvuCQq+qEgmkPHAkYlF2oafqgoarUqLilRfPx x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5491.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(39860400002)(396003)(346002)(376002)(136003)(451199015)(186003)(38070700005)(83380400001)(122000001)(38100700002)(5660300002)(2906002)(41300700001)(4326008)(8936002)(52536014)(55016003)(478600001)(26005)(9686003)(53546011)(6506007)(7696005)(8676002)(316002)(64756008)(66446008)(66476007)(66556008)(66946007)(76116006)(71200400001)(6916009)(33656002)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ei7jzJv4QV/jEPye/0Qn9Rrnpz1UNPeVDo/yT0UzMY8ymzbKucBUvs+nUlGV?= =?us-ascii?Q?p5r6N0eLq9kIUG4TzbVueE0caLTesVfsB6xVWpdooTa68Zik1epBCAH9HvUW?= =?us-ascii?Q?FKBbteFYmPoBB5wKQ8kJnUBbco5Jmzz7F/h4Jd33Vx0waq86C/GH7q/vwvpN?= =?us-ascii?Q?vdpKtOiaaB3C00drk1nETKDASSmWchH78Nh6L3mqYT+d0bw8YIK99qg+M/Qb?= =?us-ascii?Q?HN2UWaulOekt5h6IwZ7gbLaoPb51znHiGsR+vhz0BUa50LO4ao3XHDCn7CN2?= =?us-ascii?Q?fI5t+NhGAhiTgek75FX+EcvpGbmHu1Ahq/8UjpcPeFF7rpmGk1tfMoCZhisd?= =?us-ascii?Q?JMUhKgGCa76OLp+1BFR21Gi59Ij0Lkok+2DuNGIIJAqB5gh/t737ueDvQDqT?= =?us-ascii?Q?frhSgwnKQ6Y2ZMz04nqSSLSzMqp9V0L0Mdv4WmrhgT7xbquxy3jtkOQhBYrZ?= =?us-ascii?Q?HQyHWkDwO6esVK12Yr4tY2n44owBwMwai3qwY0giYCoIf4iYmR7c8WU1bRD7?= =?us-ascii?Q?wJlwTEIiloEA8jOX1hAIipzjmsXNyGnvPxXgzuQyFdsRab70xGk2aYjGEe92?= =?us-ascii?Q?cb3Pet4yF5+mmISUmJjM9aeogc+2a/z9c/fSiQowgtaH0jDBeEt+vfNN9jqD?= =?us-ascii?Q?uJnNtFtO+DfIHkO1oQie+KoDYjtdaeMPaNEJqr5nFYPeYxz+fK2UEUsym1Sj?= =?us-ascii?Q?Sve+AsvgDYUZYdOSMZSK0b4hNL1x75llFS6HZcJ+vk+g8n+jO5TF59SR9kMU?= =?us-ascii?Q?KuEmoO6Q82/qH43h30JL6hga1uC7OdtpwHkbd2EsijfGgPFv7hVLd3xW5aH7?= =?us-ascii?Q?kJ9jWZTvGSeqOX/ydVxGlSzMdPJJy9O4veOXYZhnerbVmQsWlq28L/IUKsbm?= =?us-ascii?Q?YnS9OGiOcz7rpyV4mXVcxFxBr5lkw+Ki1ils7CmO8+DHCuWInDwlYP8i4XpS?= =?us-ascii?Q?xm1iZxEghViWHvZcBlvFwaAaRRkwg8Zds66uK5Sg0nJ3GYbE2DWHDeTL9PXV?= =?us-ascii?Q?3WgiWcwaTh1DsiN8NKA2b3bi755SvnTRPncy6QYH1QDeTxlRN11UZJ9Rsigm?= =?us-ascii?Q?zA6/YTuXj4Y1BdxUVqgBZ2m5Oor9FqIpC1PB6h2zJKBhTktUL5rdBrzrZSW8?= =?us-ascii?Q?9YkYc1A4dER0FFuLcPSzC8db0JqLOZ3mjFmhaDxKgzWE8Uj3f98an8rBTgIs?= =?us-ascii?Q?xzyeo9pN92l4+NzkLjmfmg4znrLlWyGcLSWLM+hIM6aA2lfa2eSrSpNUJ9aC?= =?us-ascii?Q?mZFl70SeDnLewUXqMDGnEcEs/OsMHUarPrYc4EQPtTr2GiONdf8BsrEeNFQi?= =?us-ascii?Q?M5aOLuejV+w4Z3Y5zotOOlmhbvr8lGAc15rJtMNPZX4Tx6lxKd6UcjyOWcw0?= =?us-ascii?Q?15GFiPmIp0be3Q8EcgAuVixr4FXkl/83k1O3u38JvBa4f9lI+uISalhf//O5?= =?us-ascii?Q?yscfmI+vHsBVo5cLJRAoTBVnScSrMQslFojizFxLF8xFSy2J4xhmBjFokSAY?= =?us-ascii?Q?mcLGCX1Q0T8ceJUcz8qZEHn9ZstUh2cJWhKr6+nWfnuF5MMAh6Im1HmDZy9b?= =?us-ascii?Q?UQ7xJXJOZaiQQZzGxnA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5491.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 529ce955-f6bb-4e9a-b772-08daab945145 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2022 14:24:33.3066 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ijajjbCeMvi/XV107upm7IRuhuv5N6JvUty/tc9DdutGtl+Mc3OfllxRv7svk58OYV5OcnJNjRxfs+uhDDrxZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4275 X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2022 14:24:39 -0000 [Public] Gentle reminder - 7 !!! Regards, Alok -----Original Message----- From: Sharma, Alok Kumar=20 Sent: Wednesday, September 21, 2022 12:39 PM To: 'gdb-patches@sourceware.org' Cc: George, Jini Susan Subject: RE: [PATCH] Enable Access to containing scope variables from neste= d inlined function [Public] Gentle reminder - 6 !!! Regards, Alok -----Original Message----- From: Sharma, Alok Kumar=20 Sent: Monday, September 12, 2022 10:51 AM To: gdb-patches@sourceware.org Cc: George, Jini Susan Subject: RE: [PATCH] Enable Access to containing scope variables from neste= d inlined function [Public] Gentle reminder - 5 !!! Regards, Alok -----Original Message----- From: Sharma, Alok Kumar=20 Sent: Monday, August 29, 2022 4:54 PM To: 'gdb-patches@sourceware.org' ; Andrew Burge= ss ; Tom Tromey Cc: George, Jini Susan Subject: RE: [PATCH] Enable Access to containing scope variables from neste= d inlined function [Public] Gentle Reminder - 4 !!! Hi Andrew, Tom, May I request you to have a look at it ? Regards, Alok -----Original Message----- From: Sharma, Alok Kumar=20 Sent: Monday, August 15, 2022 3:16 PM To: 'gdb-patches@sourceware.org' Cc: George, Jini Susan Subject: RE: [PATCH] Enable Access to containing scope variables from neste= d inlined function [Public] Gentle Reminder - 3 !!! Regards, Alok -----Original Message----- From: Sharma, Alok Kumar=20 Sent: Sunday, August 7, 2022 8:35 PM To: 'gdb-patches@sourceware.org' Cc: George, Jini Susan Subject: RE: [PATCH] Enable Access to containing scope variables from neste= d inlined function [Public] Gentle Reminder - 2 !!! Regards, Alok -----Original Message----- From: Sharma, Alok Kumar=20 Sent: Monday, August 1, 2022 11:27 AM To: 'gdb-patches@sourceware.org' Cc: George, Jini Susan Subject: RE: [PATCH] Enable Access to containing scope variables from neste= d inlined function [Public] Gentle Reminder -1 !!! Regards, Alok -----Original Message----- From: Sharma, Alok Kumar=20 Sent: Sunday, July 24, 2022 11:46 PM To: gdb-patches@sourceware.org Cc: George, Jini Susan Subject: [PATCH] Enable Access to containing scope variables from nested in= lined function [Public] Hi all, Currently inlined functions are barred from accessing any containing local = scope variable, which makes sense for global scoped functions. The gcc compiler supports nested (local scoped) function for end user, the = Clang compiler does not allow nested function for end user but compiler its= elf generates such artificial functions internally ( in case of Openmp). Ge= neral barrier by gdb reduces debug experience, current patch enhances debug= ging in such cases. Please consider below program --------------------- 1 #include 2 3 __attribute__((always_inline)) inline int outer_fun (int arg) { 4 // Inlined at (A) or not, this function should not have access to 5 // variables caller_fun_var, caller_fun_other_var in non containi= ng 6 // scoped function caller_fun. 7 int outer_local =3D 5; 8 outer_local =3D arg; 9 printf("Value of outer_local =3D %d\n", outer_local); 10 } 11 12 void caller_fun() { 13 static int caller_fun_var =3D 9; 14 volatile int caller_fun_other_var =3D 7; 15 __attribute__((always_inline)) inline void called_fun (int arg) { 16 // Inlined at (B) or not, this function should have access to 17 // containing scope variables caller_fun_var, caller_fun_other_va= r 18 int local =3D 0; 19 local =3D arg; 20 printf("Value of local =3D %d\n", local); 21 } 22 23 outer_fun(caller_fun_other_var); // <--- (A) 24 called_fun(caller_fun_other_var); // <--- (B) 25 return; 26 } 27 28 int main() { 29 caller_fun(); 30 return 0; 31 } ----------------------- Which produces DWARF as below ----------------------- 0x00000094: DW_TAG_subprogram DW_AT_name ("main") 0x000000b2: DW_TAG_subprogram DW_AT_name ("caller_fun") 0x000000d0: DW_TAG_variable DW_AT_name ("caller_fun_var") 0x000000dd: DW_TAG_variable DW_AT_name ("caller_fun_other_var") 0x000000ec: DW_TAG_subprogram DW_AT_name ("called_fun") 0x00000112: DW_TAG_inlined_subroutine DW_AT_abstract_origin (0x00000169 "outer_fun") 0x0000013f: DW_TAG_inlined_subroutine DW_AT_abstract_origin (0x000000ec "called_fun") 0x00000169: DW_TAG_subprogram DW_AT_external (true) DW_AT_name ("outer_fun") ----------------------- Please note concrete instances of abstract functions "called_fun" (0x000000= ec) and "outer_fun" (0x00000169) are DIE:0x00000112 and DIE:0x0000013f. Bot= h have DWARF tag DW_TAG_inlined_subroutine. To stop "outer_fun" (0x00000112) from accessing scope of "caller_fun", gdb = generalize barrier for DW_TAG_inlined_subroutine. GDB should instead check DW_AT_abstract_origin attribute to check actual sc= ope of corresponding abstract functions and allow "called_fun" to access sc= ope of "caller_fun". Current patch stores this information into data structure DIE_BLOCK and use= s that to compute actual containing scope. Please review the patch and let me know your comments. Regards, Alok