From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2085.outbound.protection.outlook.com [40.107.243.85]) by sourceware.org (Postfix) with ESMTPS id 132543858D32 for ; Wed, 21 Sep 2022 07:09:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 132543858D32 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WOKLfyVBPcQgd5v0Ir1x4DctixF9q8hIpIDa4mcgMRZpnTTX7MOsTU46EmcZSFxN+M+H82zsCoO4Fv4TxzGtSk4jM6PIZewWGSlChFnRtC+OywW8ou7PFKC7R16wxL9HaMN1H9ooes4Dz4e1kptvd9QiaTZq8QXx1bHquCeZbu1mdaaYoDfr/DbwQeuRUsVhGnF+Gw6HZXKyB3AA1GYuNEV3Vhnly0v7ST0f3rASSfH4kLdwhIlWUMLJ7CW6Mm8vKThWEstGN1DqD20KJI5gcgDKiCZqAnw4ajZafl9uHBEiUZcAqEOTeBf7hGGypkHgT+FmKqzUyHqgOhtIIECQqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wVNHccUOK5jIvqEgzVW1M/Taol/adRNL+UbbhM2oWRA=; b=O8gr+uCTKVVfGH0VCLXJ0l8+2+TUyterTgTmC828PffvMbmJjfoNfjlFfAGPjySmwOpBrzz9XTl9ErPt7kyj16rPT/3mhI76K3mv8YknLCdQpG6OID/0KR7FTy7BCyGBJoKiATFRdLTE62TnZOX0J6T7hHkFdTc5aoujgYaCC9LgGdDa6ZMcyUI8Mw7N5cQkGFXh0NvLWQvNgP9smrldALDFuXlkOfgNNyRfCk9zue2l/e82+0M2sSkKGFAqW5T+nPPHdJnTUd/IfxWWtkotHk2ugGIMo0OkqqzoCmeSE6WC1ITwFp5Rk8uoFqelI2UBEGPu3SbZxsZLXLX5vQVjcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from CO6PR12MB5491.namprd12.prod.outlook.com (2603:10b6:303:13b::8) by MN2PR12MB4536.namprd12.prod.outlook.com (2603:10b6:208:263::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Wed, 21 Sep 2022 07:08:59 +0000 Received: from CO6PR12MB5491.namprd12.prod.outlook.com ([fe80::2c1c:4477:5b2f:4968]) by CO6PR12MB5491.namprd12.prod.outlook.com ([fe80::2c1c:4477:5b2f:4968%7]) with mapi id 15.20.5654.014; Wed, 21 Sep 2022 07:08:59 +0000 From: "Sharma, Alok Kumar" To: "gdb-patches@sourceware.org" CC: "George, Jini Susan" Subject: RE: [PATCH] Enable Access to containing scope variables from nested inlined function Thread-Topic: [PATCH] Enable Access to containing scope variables from nested inlined function Thread-Index: AdifiG4v+p6eTZ/3TAWVx+6eDMBxZwF4u3YgAT5N8sABicXIMALDby1AArN7JQAByGTp0A== Date: Wed, 21 Sep 2022 07:08:58 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2022-07-24T18:07:24Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=2ab2b2ad-6dda-411b-9c7e-4fcd93ad4840; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=1 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_enabled: true msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_setdate: 2022-09-21T07:08:55Z msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_method: Privileged msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_name: Public-AIP 2.0 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_actionid: c65804a3-a370-4de5-85a4-ce1075414c21 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_contentbits: 0 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR12MB5491:EE_|MN2PR12MB4536:EE_ x-ms-office365-filtering-correlation-id: 2a41ef24-ded6-451b-8721-08da9ba027c3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LItw9EdVoUZNpezcpX80EEbq+t02iMOBPh+6h0xKx9PVZBdCH7LXAh6m99e4w9aQXBg6/qVqUCYWUvmhq2Hbh8A2/6i6OpeyUTFkkQb+qNZ/dK/gVcmdisF6tC+e5S96jwIOcKs4bNDbHJWN5RPl4uFwocaGbDuCPi4ZMk7Xz1070AEt7TrtPUew4dHZSsbaRmgJLfI1t7lNWRfuewHEMidn9vzekKPZkdUudKfwWHRwxjtUDH+wWxPgeqOrKCUr2rTONPZWc+9uL3JRe5efwIDwoJ6X0cm37In7xkc+PhyxECgYQT+P5nb+5WwhvK2I4+nuwpn56a4QQy780svTfhyECxidSbF15l4pXMKlSOX4ilXy95Mt1hOQixAN6wI4+e2QOp3u4X07wHhqM5eZnTy5Md/0nNDXeKQ04iZ6l9vxd4fU9KSiDyfdeNyLXcjkiQxzgess4CAn7OaKb2c5Xzv6DmnInoIZ/8QvvnNHyGwyJnYx7nGlwunElffyPqSSYccXC+N1QJ+UIXxWxfIzP7WtrEa+P5NGUvGEZqs8SaPsYKmnu7RKlSe0iWNUWaI0ZLumsv11XiqlsUe7Pn2r0+UuFVUFhoR4zefUlzcun6Ppu5ziSgylue138GrQEqje0by7Aqn88JSuXmvDhWdvNZF3Zowp8SETbdqD27b6+8l8o6db2rNjrYOFglowW+FQYSVEQm+upUC93oFyyq0GZrf6ah1nac1I+rGob+Udlj1h8nR8DUSkjmbifEdz70ne x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5491.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(366004)(396003)(39860400002)(346002)(136003)(451199015)(478600001)(86362001)(8936002)(41300700001)(316002)(5660300002)(66446008)(8676002)(6916009)(33656002)(4326008)(52536014)(66556008)(66476007)(76116006)(64756008)(66946007)(38070700005)(122000001)(55016003)(38100700002)(186003)(53546011)(7696005)(6506007)(71200400001)(26005)(9686003)(83380400001)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?F9K2lR7NsN00xyXAOw2DHiwDRN409T267JMaKqs2WhWbV5teNZzUr5fCMZV1?= =?us-ascii?Q?vfm9/GTJ0BCdrmD8iXu1wnfqQl10ILFw1aT1y7ey65GWPZDv9WqG5/fcmWov?= =?us-ascii?Q?MMoW5op63rkU+UCIUzYANe6GRaN80Qo0rUsukvGZ01gVtL2hSKnzc351U/7O?= =?us-ascii?Q?TeC4fMWbq/4egnsRtK5Y+KCOj0On7NdHtgd1ZuXegMpVU+EdILGBNRlanzKH?= =?us-ascii?Q?Ll81qwiwDVSaML6VdzOCofHszMtrFJwrVUh9dUQmgmF6vT3sIeOSfoyKj1cu?= =?us-ascii?Q?3oNGmB/xvka+q/nraprMrwWJkDDMFhdJlF8F6BDdEmw9LpEICX5MgsTG2ew9?= =?us-ascii?Q?Hey0vwThBFJ4tBsV4DF7hJ0uCLHJgqsMWjLJANYSvHqQmICCwqwOC3pE3zah?= =?us-ascii?Q?e39QoxpCwRaJrKG9xVeVHcv2Y9/l4Ft1B/nnzNC8ElOu+Zmecj+CHelLLuA8?= =?us-ascii?Q?ovk1QPcwYpg5V6YsRWmY1ClAdF2aGivO7pxB2Cc0iB1a4M4VP4JFqacy09x0?= =?us-ascii?Q?jnWmyrzwZ2HHa3Kxrii4lRCRuncMWRMUyFbjHJncwlfybeqTpd9KBmaEjwl2?= =?us-ascii?Q?jtodDnBjLINdn+xNH7Bo4/cYXiDMRaaNHn3nMmvEUMaTvV9ytHpI+F3SNBQH?= =?us-ascii?Q?bxbJ5jF37Cb1TkEVIFgOWjLSoOyxTg/KFZPajqloBynZasTRUpXpwQbgVkSA?= =?us-ascii?Q?I1MJLQYlbeThJA4s6hoqPS1RXUXUnhLpX7Af9wCfdch0YgksEliZEN1DsSnO?= =?us-ascii?Q?QoUuQkd17aWUvk4c9NX1OoC5sET/qdOY+1Nrm0lWWb1BDaxfw9kNPcV++J8H?= =?us-ascii?Q?ILSYNAQry9nBgfXyKAnyh/eSMJawV0KD4SNPLMqRa0HFkxNnu0fcrMluY9h8?= =?us-ascii?Q?8cP5TKgn1PKORp5dZfComhAIC1WhyqoAzUrsr1zeMGrSwHq2YAuRycWWSuTA?= =?us-ascii?Q?XlOZlznGaYeFNvAiDQD7CV6UOQzHr1wu4sRweVfKmheQGMsWqxkSyUwf6KyW?= =?us-ascii?Q?lvdU9Z7Bk3HVODixT1UlHfbyDT+VxF8Pwuw3sd2gzEc09khUZcgmD3k6x2Mr?= =?us-ascii?Q?y32whGU1SCUUtzX8IPw5SYKbzG1KXtf3VxHrY40d5cCjP7+0kRq9MCt7Qerp?= =?us-ascii?Q?LcpdFnA9yxAtHMTabjo/cyM44TtD7cyiNW0KfSs+To7Fq1xZsGU2v85H1g6g?= =?us-ascii?Q?z28Hg5Ckfafy+9JFcR/YDG/98HdAkE247egjsYr9iq6pZYvxh+IJimbNQe31?= =?us-ascii?Q?9VuMOSVIY0FvaNEdYXZ0/YcNf09cUsSGMjOhlxxTvlNx4sD3qJNXoLvrRne1?= =?us-ascii?Q?ZEGO2cDZVs6zfvkyPVvU/+MkPYNaRxOvEw6QHLvBtJWWbWPWIeV6cxi5K21j?= =?us-ascii?Q?442bkbE6yrB/8lAWcX8Y6c2eS555CRCddUwqi4IjLcgffPvRRvNUX5cQTdY3?= =?us-ascii?Q?8DXbg112n0750vgh63wABOXswDAnAO1zdO+QJwOLVU6V6fd1vmoiuN9wf3Ju?= =?us-ascii?Q?eYE9fBP5IeB3UbWUgGQjcMhuXI2sKzO0E6uG8ObBIBjoFNF7wQ25sceNhoeL?= =?us-ascii?Q?Nz0STudIyZAs13pMU8U=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5491.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a41ef24-ded6-451b-8721-08da9ba027c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2022 07:08:59.0076 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KZFTRxThrGwryfaPVwIIumkzQKQ7qvzdeiUF/Wg9AgMZD68ujU79xBIbmHyUypI66pY1fbwPva0qtrsLOw1DDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4536 X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2022 07:09:06 -0000 [Public] Gentle reminder - 6 !!! Regards, Alok -----Original Message----- From: Sharma, Alok Kumar=20 Sent: Monday, September 12, 2022 10:51 AM To: gdb-patches@sourceware.org Cc: George, Jini Susan Subject: RE: [PATCH] Enable Access to containing scope variables from neste= d inlined function [Public] Gentle reminder - 5 !!! Regards, Alok -----Original Message----- From: Sharma, Alok Kumar=20 Sent: Monday, August 29, 2022 4:54 PM To: 'gdb-patches@sourceware.org' ; Andrew Burge= ss ; Tom Tromey Cc: George, Jini Susan Subject: RE: [PATCH] Enable Access to containing scope variables from neste= d inlined function [Public] Gentle Reminder - 4 !!! Hi Andrew, Tom, May I request you to have a look at it ? Regards, Alok -----Original Message----- From: Sharma, Alok Kumar=20 Sent: Monday, August 15, 2022 3:16 PM To: 'gdb-patches@sourceware.org' Cc: George, Jini Susan Subject: RE: [PATCH] Enable Access to containing scope variables from neste= d inlined function [Public] Gentle Reminder - 3 !!! Regards, Alok -----Original Message----- From: Sharma, Alok Kumar=20 Sent: Sunday, August 7, 2022 8:35 PM To: 'gdb-patches@sourceware.org' Cc: George, Jini Susan Subject: RE: [PATCH] Enable Access to containing scope variables from neste= d inlined function [Public] Gentle Reminder - 2 !!! Regards, Alok -----Original Message----- From: Sharma, Alok Kumar=20 Sent: Monday, August 1, 2022 11:27 AM To: 'gdb-patches@sourceware.org' Cc: George, Jini Susan Subject: RE: [PATCH] Enable Access to containing scope variables from neste= d inlined function [Public] Gentle Reminder -1 !!! Regards, Alok -----Original Message----- From: Sharma, Alok Kumar=20 Sent: Sunday, July 24, 2022 11:46 PM To: gdb-patches@sourceware.org Cc: George, Jini Susan Subject: [PATCH] Enable Access to containing scope variables from nested in= lined function [Public] Hi all, Currently inlined functions are barred from accessing any containing local = scope variable, which makes sense for global scoped functions. The gcc compiler supports nested (local scoped) function for end user, the = Clang compiler does not allow nested function for end user but compiler its= elf generates such artificial functions internally ( in case of Openmp). Ge= neral barrier by gdb reduces debug experience, current patch enhances debug= ging in such cases. Please consider below program --------------------- 1 #include 2 3 __attribute__((always_inline)) inline int outer_fun (int arg) { 4 // Inlined at (A) or not, this function should not have access to 5 // variables caller_fun_var, caller_fun_other_var in non containi= ng 6 // scoped function caller_fun. 7 int outer_local =3D 5; 8 outer_local =3D arg; 9 printf("Value of outer_local =3D %d\n", outer_local); 10 } 11 12 void caller_fun() { 13 static int caller_fun_var =3D 9; 14 volatile int caller_fun_other_var =3D 7; 15 __attribute__((always_inline)) inline void called_fun (int arg) { 16 // Inlined at (B) or not, this function should have access to 17 // containing scope variables caller_fun_var, caller_fun_other_va= r 18 int local =3D 0; 19 local =3D arg; 20 printf("Value of local =3D %d\n", local); 21 } 22 23 outer_fun(caller_fun_other_var); // <--- (A) 24 called_fun(caller_fun_other_var); // <--- (B) 25 return; 26 } 27 28 int main() { 29 caller_fun(); 30 return 0; 31 } ----------------------- Which produces DWARF as below ----------------------- 0x00000094: DW_TAG_subprogram DW_AT_name ("main") 0x000000b2: DW_TAG_subprogram DW_AT_name ("caller_fun") 0x000000d0: DW_TAG_variable DW_AT_name ("caller_fun_var") 0x000000dd: DW_TAG_variable DW_AT_name ("caller_fun_other_var") 0x000000ec: DW_TAG_subprogram DW_AT_name ("called_fun") 0x00000112: DW_TAG_inlined_subroutine DW_AT_abstract_origin (0x00000169 "outer_fun") 0x0000013f: DW_TAG_inlined_subroutine DW_AT_abstract_origin (0x000000ec "called_fun") 0x00000169: DW_TAG_subprogram DW_AT_external (true) DW_AT_name ("outer_fun") ----------------------- Please note concrete instances of abstract functions "called_fun" (0x000000= ec) and "outer_fun" (0x00000169) are DIE:0x00000112 and DIE:0x0000013f. Bot= h have DWARF tag DW_TAG_inlined_subroutine. To stop "outer_fun" (0x00000112) from accessing scope of "caller_fun", gdb = generalize barrier for DW_TAG_inlined_subroutine. GDB should instead check DW_AT_abstract_origin attribute to check actual sc= ope of corresponding abstract functions and allow "called_fun" to access sc= ope of "caller_fun". Current patch stores this information into data structure DIE_BLOCK and use= s that to compute actual containing scope. Please review the patch and let me know your comments. Regards, Alok