From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2052.outbound.protection.outlook.com [40.107.220.52]) by sourceware.org (Postfix) with ESMTPS id E7FE93857372 for ; Thu, 12 May 2022 08:06:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E7FE93857372 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bHQqbFoIr3vP5k6/SyLr3cE9WQndmBuf8zETuNWDg0yDYtJ9cwy2XcUDZiQCPR4+i4OFXRpNZwWoXdL362NSwulZLpj4so85XxuMAiWFUycOQXCi6q6zjXzVbJCKdjW9bn/UPCsxGJROKsV7xpPjrl0d6m8kpwwBTs5KnOlZf+lEADSbtnVFoXmvqb6n4SNAW+hLq+FlKStw1lm4iWpPV3KJ4llElvyyzt54j0QtFkVXbgKD0UqjySBJmAqMXDc/2/tXVosSX+9Mxad7IkqeJR7K0wBrkpDKtbMdc0lepRDMbZgMAq6i0in/xlmUTV/YPdi4n1ggZ/i26trKnO5hMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HBlkChJbi6u8EqZ8faJkd84NoZYsHpxWs8N0wrbxUOY=; b=oN6ppfywtLCOOCd7WTLrZn6pcOHpoEY7hV5rLjK790YFo/I+aXDDhc/8UPZ665xLWziqn5qOrzcImwNAXh3WkI+R7F5jQROLM+8WzFfkcXisGVxTXWNLRcupT8c08buUsr5xscFi99GH9VVnM9TkyXbKc0yPPXnFigqMSkHfCsF/25nEcgrAD0U9qKt5DzL473lyFpfWb5i3Sl2eKnVVSCkNAHwfZ9ssJ/fA/GESRM/rUV5OaDJK3XPPkDD9SjnjaY90cPK8lHqo8YPJP6lPCcFI0UOXEGU3NjEHe0IG62WciISePiIQKs9YR/J+CHtqY+H53gT5995unbjdlzsY4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from CO6PR12MB5491.namprd12.prod.outlook.com (2603:10b6:303:13b::8) by MN2PR12MB3613.namprd12.prod.outlook.com (2603:10b6:208:c1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Thu, 12 May 2022 08:06:09 +0000 Received: from CO6PR12MB5491.namprd12.prod.outlook.com ([fe80::402c:d14b:f6af:4ded]) by CO6PR12MB5491.namprd12.prod.outlook.com ([fe80::402c:d14b:f6af:4ded%4]) with mapi id 15.20.5250.013; Thu, 12 May 2022 08:06:09 +0000 From: "Sharma, Alok Kumar" To: Tom Tromey , "Sharma, Alok Kumar via Gdb-patches" CC: "George, Jini Susan" Subject: RE: [PATCH] Accept functions with DW_AT_linkage_name present Thread-Topic: [PATCH] Accept functions with DW_AT_linkage_name present Thread-Index: AdhNbAXRuGgou/3YTOaIgkeDbizeNgDehocAAIUqc/AAC+/WjQAhHPmwAvSTMDABlWyk8A== Date: Thu, 12 May 2022 08:06:09 +0000 Message-ID: References: <875yna1f8c.fsf@tromey.com> <87pmley07s.fsf@tromey.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_Enabled=true; MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_SetDate=2022-04-19T05:33:32Z; MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_Method=Privileged; MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_Name=Non-Business-AIP 2.0; MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_ActionId=702e594d-88de-44f4-ac5e-c472b6ee7010; MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_ContentBits=0 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d6ffc950-79ea-43df-acac-08da33ee4609 x-ms-traffictypediagnostic: MN2PR12MB3613:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: n32PT17I5Y8/8z0WghVRlOcCby6mBEecgHajpJKTodUnmuYcpUhZ00NUtdjd4Q4+SMXpXDRP+hkNIo27BrsZzeWvUq3/CV4mYicAeeTBfcc/Xad7g3LHudCYYz/Qxy1J5W5+7jQTnp8PUL9Qd5Vcv6hm38ooECH8rKJBpCtVwRu1mH2LeQslFXZlj0QXuUC1kP83TTPiRyGcpLHINL3HPuMwK9XF8IZjrJzuGsowOQ3mwdcG+UjGgw2+vP0zblGZLhITlFVAdZgWoq/3BkSNLUB62TmFX4u0NO3p5zDC9+oQJlbZxoFRBY47YUXYzwPktczAwRNkMb/yaZdEplNS26q9T9Qp3IaoqDx6ZaG+bY98HpwGvElOWnV+kcEEQhvxX9D4OM+n9tg5F90ytld//z15KGOmjqfCxawZc5WWd0VSichoSSjYuDAPyhDQeZL2U6iNpDKEbzmVUraZ48aWeYis0kV1BNVzg352nWjlp+kmsN8w2uD8ekSF/0Ww4vfaIQBD1xKST9x8lvCm+7fCoFX/kbVesZj77D4J7SiZFHYM+ivruDSBvLS97PJ4RghjQQ/BGqGS+enwf7gF32e6IMDKo4Rr/dycbYomuWML6qea1tK6Vc9JeSevQN6vo8SJkCQPaQ7Q9Gf+kGLiLFrAN8vQ6b3d0+BAbOnIabbW1/ffXQmGVzCkUpkLzyhSsk+rCIENn2aUkq0CGAQmRUuL3qSq8WA/Y0gphTx1Hg8iwKjUKyilKBhi7eTAq7Eyv1j/DmDvtrufrnL+/CfmXBpLr/j81LolAVHaYoZA4Zlkm/A= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5491.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(186003)(66556008)(66446008)(8676002)(4326008)(66476007)(64756008)(38100700002)(33656002)(76116006)(66946007)(2906002)(86362001)(71200400001)(122000001)(9686003)(26005)(5660300002)(7696005)(38070700005)(110136005)(83380400001)(966005)(6506007)(55016003)(508600001)(52536014)(316002)(8936002)(53546011); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xTgP59/2LmryeYexYcnNpuI0td8i3x5z5Zx2mvtZAIqakkR71gZLPtZl6+F3?= =?us-ascii?Q?I+zJ8Q/kcUmamTR9cB4OKMv8f8Ff320wNic5gFyCv43JVdfGwJrmPuwbU/Zc?= =?us-ascii?Q?HGpg+mM+36POliEryji/aXuwLuRpYImDKqDUaOc117SD9/l4dLvMDvvGeOQz?= =?us-ascii?Q?wWNuwuK3B/RuH+ZTZwxTvMgG3L3ulriTVXK/nkuslBqzzYNDqsfIW9JmSUIU?= =?us-ascii?Q?KE3u7tZZyon/nCRs2R3Cp6kt3IzQSlYF4LXbTcXl1trMd15zkNSCAT78tFcg?= =?us-ascii?Q?XXQEt0+pHF/NvPGCSwFVBlIGjY/9PMOar+iAp7YEUjiaG7LyZk9mKWyejaaw?= =?us-ascii?Q?izN5ELIVKxWFZxM6MIgqq/Go68AXGFubXPxxmre0vzr42VhXDzdS749a4cKQ?= =?us-ascii?Q?frTK2ELqZLpICSE3b61c48AEvOl2wDKREB1+QyDQCVbPavTtr/oGK4amDIxM?= =?us-ascii?Q?/tIRlw21YxZwjhgU43u6Ydfk8gPURh1NKgcmY1CjkWCpwG8wdxD0Ip07IF1x?= =?us-ascii?Q?XGi5fCjT2ANXMmMyDoPnBNxKMu/wwFTxwtXm0lAgtpRz4PzxsIJRpoAHFaIY?= =?us-ascii?Q?t7bl/Wz8AckGmfjZm055hauqwHDPSoEEIcf4JVcSfFvZuEsz2wmK6wn0ifz4?= =?us-ascii?Q?3aZ13vMjf6Q0KuhjpNiWt99+tEGhez/piJQdrRPNW3Khn1KdDcqHDJdl/gMS?= =?us-ascii?Q?H0S/uV7QU2qw5K6FemRGcBQTqzJVjxYcq1AKMcrfiYB1DGTpNu+xUUiFcVAh?= =?us-ascii?Q?T7FtvWeBNOIFxSi8gQsa/YSKH0RAFn1fyTY1X6GGAJf1yJ3BDDMBYI6WetaJ?= =?us-ascii?Q?AmVhz8saPzkyH7i+PqKJY71aWxLl8l2ZrQgbwfh0fzPNGcBwITf4KL/dbSmj?= =?us-ascii?Q?yh8AoeSlREVoBvvthgd7/e2jC5CKDQLF2jvkEoRgSJLtyCF26/hLAOqGXZ/6?= =?us-ascii?Q?4jaej7l/Uq199ZIlFuRzIUvJZyc+nbhK0LLXPg1rFrsWoKeHNWlPGl9/8eQ+?= =?us-ascii?Q?nUHcxbS/OHlSj6dTZKJrYFjjW4LO15FirUoUSvWIvcuqgGiYSNeJWQOzu7PJ?= =?us-ascii?Q?9TO0RkYEepgqIh9ak2KjdJ3EcKQJY3IvPNHi+QV5IQAz8otw+WS/QcfvgkOT?= =?us-ascii?Q?/C/oX0qufXwVg1jZBdO9AfsdxsQiB0GnqzrmnDlgYrWLunx3XjWYi311S736?= =?us-ascii?Q?q8b12KosHOK885naEzjfwJQivtvo/mb6JTOh646aimMHzWgbDOIXfExRE5J/?= =?us-ascii?Q?AdzAcXLDl87X/BstZMizqOBtg9DKctKSyqSQsY52eG5UaPM2XeLMoictiD0P?= =?us-ascii?Q?Mm84kFLH0rw3D498tcGQFj+RUfMdCEmWi0/6YVGlHPMs8Af+ixEYJBbaZDYk?= =?us-ascii?Q?/nkQnaCu7vFMlRV71y/J9rI1q2mPYtRPHv/x6oPIvD07p4W0j0xufJ+l4t2K?= =?us-ascii?Q?sTL5UE9idH4WAgQPWSdIe/nSL3ZmEZwE4xl1WtwewVhBfaTE9Gx5uaJY6t0b?= =?us-ascii?Q?MP+3J7TbtcMyHgWHHxNnzwwdLjmUiHtkwdVe8bUgrqzGicRz3Q18rPp3d9wQ?= =?us-ascii?Q?sIT1veongqJvx5bFQgfYePL3sWQbVU6I/y39C+FLgPMj0JkC5Ig4TBKDQK2Y?= =?us-ascii?Q?csrKnK8Z0b9+vn/yauHaocGjNPjFTJRjimvTvlyGxCb4SkcmbytnzQRtcsM6?= =?us-ascii?Q?YTfPK+MJ8ox7jG35r5ngt5KazWYXXRw9KslS0I3uFNL2NPk1?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5491.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6ffc950-79ea-43df-acac-08da33ee4609 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2022 08:06:09.6149 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5Jx0yvu8ZpZRNuqY74+iCshXs4F47oRoTFRlhNYNYStR31OAL8KdrxWNRoMGCSQGrGmKxhDiI9zv+JfbosvRQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3613 X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2022 08:06:17 -0000 Gentle Reminder. Regards, Alok -----Original Message----- From: Sharma, Alok Kumar=20 Sent: Wednesday, May 4, 2022 2:26 PM To: 'Tom Tromey' ; 'Sharma, Alok Kumar via Gdb-patches' Cc: George, Jini Susan Subject: RE: [PATCH] Accept functions with DW_AT_linkage_name present Hi Tom, Please find the attached updated patch, which includes required changes to = work with your patch https://sourceware.org/pipermail/gdb-patches/2022-Apri= l/188285.html Regards, Alok -----Original Message----- From: Sharma, Alok Kumar=20 Sent: Tuesday, April 19, 2022 11:17 AM To: Tom Tromey ; Sharma, Alok Kumar via Gdb-patches Cc: George, Jini Susan Subject: RE: [PATCH] Accept functions with DW_AT_linkage_name present Thanks Tom for your review comments. Attached is the updated patch to exclu= de DW_TAG_subroutine_type. > Yes, but why? Would there be something bad about using the linkage name = for a variable? Actually initially I tried without this conditions but that failed few gdb = tests. Let me share the short testcase to explain. ----------- #cat test.cxx typedef enum { DD, EE, FF } anon_enum_t; typedef anon_enum_t nested_anon_enum_t; volatile nested_anon_enum_t var_s; int main () { asm ("" ::: "memory"); return 0; } # g++ -g test.cxx -o test --------------- I tried below command with the tag check and output matches what was there = without this complete patch. ---------- # gdb -q test -ex "pt var_s" -ex "info types" Reading symbols from test... type =3D volatile enum : unsigned int {DD, EE, FF} All defined types: File test.cxx: 4: typedef enum {...} anon_enum_t; int 6: typedef enum {...} nested_anon_enum_t; unsigned int ----------- When we remove that tag condition it looks like below ----------- /gdb -q test -ex "pt var_s" -ex "info types" Reading symbols from test... type =3D volatile enum 11anon_enum_t : unsigned int {DD, EE, FF} All define= d types: File test.cxx: 2: 11anon_enum_t; 4: typedef 11anon_enum_t anon_enum_t; int 6: typedef 11anon_enum_t nested_anon_enum_t; unsigned int ----------=20 Please note the name "11anon_enum_t", which is linkage name (internal name)= not exposed to user and showing that probably is not good. This linkage na= me is present only in case for C++ compilation only, in case the same code = is in c and compile with gcc this linkage name is not present. So probably = it is better to keep the output same as we get in C and not expose this lin= kage name for enums and keep it exposed only for functions. Please let me k= now if you differ, I shall change the testcases to suite the new output. Regards, Alok=20 -----Original Message----- From: Tom Tromey Sent: Monday, April 18, 2022 7:15 PM To: Sharma, Alok Kumar via Gdb-patches Cc: Tom Tromey ; Sharma, Alok Kumar ; George, Jini Susan Subject: Re: [PATCH] Accept functions with DW_AT_linkage_name present [CAUTION: External Email] >>>>> Sharma, Alok Kumar via Gdb-patches write= s: >> is this tag check really needed? > I want to keep this limited to functions. Yes, but why? Would there be something bad about using the linkage name fo= r a variable? > name =3D dwarf2_name (die, cu); > if (name =3D=3D nullptr) > name =3D dw2_linkage_name (die, cu); I guess if we avoided the tag check, this could just be done in dwarf2_name= itself. > + if (name =3D=3D nullptr && (die->tag =3D=3D DW_TAG_subprogram > + || die->tag =3D=3D DW_TAG_subroutine_type > + || die->tag =3D=3D DW_TAG_inlined_subroutine > + || die->tag =3D=3D DW_TAG_entry_point)) If there is a reason to only check functions then you should remove DW_TAG_= subroutine_type here, because that is a type, not a function. Tom