RE: [EXTERNAL] Re: [PATCH 0/4] sim: riscv: Compressed instruction simulation and semi-hosting support

[Jaydeep Patil <Jaydeep.Patil@imgtec.com>]

Andrew Burgess <aburgess@redhat.com> writes:

> Thanks for working on this.  Better risc-v sim support has been
> something I've wanted for a while.
> 
> I noticed that your email client has mangled the patches during sending,
> making applying them harder than necessary.  I recently found this site:
> 
>   https://urldefense.com/v3/__https://git-send-email.io/__;!!KCwjcDI!3xH-JYp0hLFW2vfmp5cY5pABSk8Os_bk18e-uc1eHL3KF5KoIrwMzN6qvxyoeT9-EfHWRLF2b7tsEo6iwgXNwQ$ 
> 
> which has some pretty extensive guides for setting up git to send email
> directly, which is by far the best way to send patches.
> 
> Additionally, in order to test patches like this it would be great if
> you could include details of the compiler build you're using (e.g. what
> --target=... flag I should build gcc with to ensure I'm testing the same
> thing you are), and additionally, to run these tests you must have a
> riscv-sim dejagnu board file, it would be great if you could share that
> too.  Then I (or others) can easily reproduce your environment and test
> these patches.
> 
> Thanks,
> Andrew

Hi Andrew,

Thanks for looking into it.

The GDB has been configured with --target=riscv64-img-elf option.
The test suite is run with following options:

RUNTESTFLAGS="--target_board='riscv-sim-picolibc/-march=rv64gc/-mabi=lp64d/-mcmodel=medlow'"
Baseboard is riscv-sim-picolibc.exp which is based on riscv-sim.exp.
Please refer to the attached file.

I will address all your review comments and submit version 2 of the patches.

Thank you,
Jaydeep

-----
# Copyright (C) 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2012, 2016
# Free Software Foundation, Inc.
#
# This file is part of DejaGnu. For RISC-V target simulation.
#
# DejaGnu is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# DejaGnu is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
# General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with DejaGnu; if not, write to the Free Software Foundation,
# Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA.

# Load the generic configuration for this board. This will define a basic
# set of routines used to communicate with the board.
load_generic_config "sim"

# basic-sim.exp is a basic description for the standard Cygnus simulator.
load_base_board_description "basic-sim"

# No multilib flags are set by default.
process_multilib_options ""

# The compiler used to build for this board. This has *nothing* to do
# with what compiler is tested if we're testing gcc.
set_board_info compiler "[find_gcc]"

# The basic set of flags needed to build "hello world" for this
# board. This board uses libgloss and newlib.
set_board_info cflags 	"[libgloss_include_flags] [newlib_include_flags]"

# Set ldflags with:
# 1. --oslib=semihost to include semihosting lib
# 2. -lc -lsemihost -lgcc to link, so the libraries will be grouped by
#    --start-group and --end-group in the linking command line.
# 3. Define __ram_size=0x2000000 to set SP to higher place to avoid some gcc
#    test cases allocate big trunk of local memory and let the SP underflow.
# 4. Define __heap_end=0x1000000 to avoid heap overflow in some gcc test
#    cases.
set_board_info ldflags "--oslib=semihost -e 0 -lc -lgcc -Xlinker --defsym=__ram_size=0x2000000 -Xlinker --defsym=__heap_end=0x1000000"

# This board doesn't use a linker script.
set_board_info ldscript ""

# And, it can't do arguments, and doesn't have real signals.

set_board_info noargs 1
set_board_info gdb,nosignals 1

# skip gdb.reverse
set_board_info gdb,can_reverse 0
set_board_info gdb,use_precord 0

# Setup the timeout
set_board_info gcc,timeout 600