public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: "Kempke, Nils-Christian" <nils-christian.kempke@intel.com>
To: "Kempke, Nils-Christian" <nils-christian.kempke@intel.com>,
	Luis Machado <luis.machado@arm.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH v3 00/11] Improve Fortran intrinsic types and procedures
Date: Mon, 25 Apr 2022 13:21:23 +0000	[thread overview]
Message-ID: <CY4PR1101MB207100FEB278BD9DEB28F3FAB8F89@CY4PR1101MB2071.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CY4PR1101MB20714F29D956D17A121A764BB8F89@CY4PR1101MB2071.namprd11.prod.outlook.com>

> From: Gdb-patches <gdb-patches-bounces+nils-
> christian.kempke=intel.com@sourceware.org> On Behalf Of Kempke, Nils-
> Christian via Gdb-patches
> Sent: Monday, April 25, 2022 3:20 PM
> To: Luis Machado <luis.machado@arm.com>; gdb-patches@sourceware.org
> Subject: RE: [PATCH v3 00/11] Improve Fortran intrinsic types and procedures
> 
> Hi,
> 
> Sorry for that - I think the assert should have been removed anyway.
> 
> I might have missed removing it - but the two lines below are what I wrote
> instead - an
> error and gdb should not crash..
> 
>   if (value_type (arg1)->code () == TYPE_CODE_COMPLEX
>       || value_type (arg2)->code () == TYPE_CODE_COMPLEX)
>     error (_("Types of arguments for CMPLX called with more then one
> argument "
> 	     "must be REAL or INTEGER"));
> 
> Does removing the assert do that? I'd assume the tests then just FAIL.
> 
> Cheers,
> Nils

I have to correct myself - I wanted to say we should instead of having the assert
likely have an error instead, similar to the two lines below (the ones I cited).

Nils

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

  reply	other threads:[~2022-04-25 13:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11  8:18 Nils-Christian Kempke
2022-04-11  8:18 ` [PATCH v3 11/11] gdb/doc: add section about Fortran intrinsic functions and types Nils-Christian Kempke
2022-04-11 11:38   ` Eli Zaretskii
2022-04-11 12:08     ` Kempke, Nils-Christian
2022-04-25 12:52 ` [PATCH v3 00/11] Improve Fortran intrinsic types and procedures Luis Machado
2022-04-25 13:19   ` Kempke, Nils-Christian
2022-04-25 13:21     ` Kempke, Nils-Christian [this message]
2022-04-25 13:41     ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR1101MB207100FEB278BD9DEB28F3FAB8F89@CY4PR1101MB2071.namprd11.prod.outlook.com \
    --to=nils-christian.kempke@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).