From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by sourceware.org (Postfix) with ESMTPS id 01AFE3857809 for ; Tue, 5 Apr 2022 15:53:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 01AFE3857809 X-IronPort-AV: E=McAfee;i="6200,9189,10308"; a="241372154" X-IronPort-AV: E=Sophos;i="5.90,236,1643702400"; d="scan'208";a="241372154" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2022 08:53:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,236,1643702400"; d="scan'208";a="641662127" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by FMSMGA003.fm.intel.com with ESMTP; 05 Apr 2022 08:53:52 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 5 Apr 2022 08:53:52 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 5 Apr 2022 08:53:52 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 5 Apr 2022 08:53:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OIWPn35vQYXwqXvsWPL4lSIDAM4v8hwJ3YtNIcAyvmDXsgHGtRZH4lN6pT/i6uSFTu2skwJsIyHcKYByMQycTTMxrvdi8a+U0SVy4wIyG23Z83T38SGp2iJ5CGJuFYcMiKBKc6rWUg/5KNrhx5Ez65VTyLKQ3w7yBzT2GXB8H5+gMfAeaO9/kpMD5a3pBAj2DLukLfHyICQhQYTn04f9MhPphklFdY4Dt5EUbchTeRJspy5TMhWwHKhZ0WlD6F/X8isL3T7NJjGwv+MT9ChUcET2VUupIJsvOJ+oSKT8SnLMCFjQ2NZY6vERYtCapDq6Z9F5DerH68CGNv8WfiPT3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AlIBUkV9T6Jh/S5JnxfuYty7/+scn1v4jSd3jrBbU5A=; b=bS8QfxmpnwACo392a9BNSWfamnJ1QUrGwxEazS9FqLobl9F7H5kRXJ8LAxXfnNkmp4dyJaDuQGxLQYRynRMYLVRqSz7t4TLuFQlv9yOOwOQ9+JWVpfJQVWSO7G3ixbg/1e6VE6bWgfmpIsAt587IDbwoBQkrEC+xLD++w5JUbXb6IuOb4kwMfFaP9XeGTsXPtbkAyfCbKOX9H7X9byT+IhnQPEdi5kBRe1s+nhorsPvV2gMoKuTRiiY4LVEy7WbyiWhwnGxyfPKfXexaCYszZXfPjp+AWnrj8VQMnJO1s4CofOD9C9VKvlVAZZ7D7sz2zHrLtK1ESH/VtTyW6uWAJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY4PR1101MB2071.namprd11.prod.outlook.com (2603:10b6:910:1a::10) by CY4PR1101MB2326.namprd11.prod.outlook.com (2603:10b6:903:b3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Tue, 5 Apr 2022 15:53:50 +0000 Received: from CY4PR1101MB2071.namprd11.prod.outlook.com ([fe80::99b6:62d4:b384:998]) by CY4PR1101MB2071.namprd11.prod.outlook.com ([fe80::99b6:62d4:b384:998%5]) with mapi id 15.20.5123.031; Tue, 5 Apr 2022 15:53:50 +0000 From: "Kempke, Nils-Christian" To: Tom Tromey , Nils-Christian Kempke via Gdb-patches Subject: RE: [PATCH v2 2/2] gdb/fortran: print fortran extended types with ptype Thread-Topic: [PATCH v2 2/2] gdb/fortran: print fortran extended types with ptype Thread-Index: AQHYMi60xHoA7OGtVUe8nBPskS31lazgB3TbgAGeZfA= Date: Tue, 5 Apr 2022 15:53:50 +0000 Message-ID: References: <20220307142125.873295-1-nils-christian.kempke@intel.com> <20220307142125.873295-3-nils-christian.kempke@intel.com> <87bkxglwcs.fsf@tromey.com> In-Reply-To: <87bkxglwcs.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 897aa4e2-b1f2-430c-de35-08da171c7a7c x-ms-traffictypediagnostic: CY4PR1101MB2326:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ROJhSS8c9YwPAw/lgetPonW+o0Zl1kOnZdqv4xFKUHjTi0OzPOxNSThgeWsETlyEyj1/YK4rsjysRinZzqPUI/E/JvHquOS90IMPIoPPUSOgxhgjT1mYP9C55xU5rPSCmp79/EsSiQbrhDOdZCCYk7/qDp3LGgzHSR/2polSW4mWh9BzFD5+o0jJYw6+uc3NIOURe1qHWU/xaEdBzRWuTUfderC7cI2pTQYffHwJVOopXWx2XWy86mE+CjAWFrBHmHFuAiiTfmkbxjVtPlf5X9oDL8UOyuD+Xr4o0PSUtpQcm1el5SaNYfhMZcj7oHrOeQuqYs/MrgOlbUYRCx3Ksv+WPmZi1bHs/flh3I87US2S3AusdPK303w8qVuuVItwHhumjRWoYfoASkgRvh6XGP6bl7CDT10jGBGAKE1usl9X+9fqhatBhCLvO1VlaJ1OVyTNHqAx4/p9MKgb5jSoxpo0i8pN7bQyKZhKNctgbC9zq1LgXawBQb9CcymYAeB9czRCwF+QvWG8pvlVsUsqDLRAjwIu8H6IjSITJpTTN6CUdO+0AEM6YRQ+WKBFbdNQRu2/l0DZ3EUjxGE18Gi+y8dworQ4ec2+vhZcsKleMj94JVImYFNB/Uhf0Z3tIlPs+qCZM4CyyXsaKAxJxouBt1efc2ILRKm5/tx0H2YbmlCsg4tUsg/shxMFrQIeK86QLKwy25yP2bvhGoABLf7Md+gzLndCNhxkRYzvMwoq64cdNjKDEDhJ88z2sggSv4z7rey188tc5pPyxl3KtxgHWmS0Geo+8CUt/5f+UJunnjU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2071.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66556008)(122000001)(316002)(66446008)(66946007)(76116006)(55016003)(38100700002)(33656002)(110136005)(52536014)(83380400001)(66476007)(2906002)(8676002)(38070700005)(186003)(64756008)(82960400001)(53546011)(966005)(6506007)(71200400001)(7696005)(508600001)(9686003)(5660300002)(86362001)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yO1R6+Gvr5kDxbiZszuGGQOtmTtgA505pt8pZSUfQMcPqJp9DZ1K8mYt8scY?= =?us-ascii?Q?aqSg3Gf6QfBU+tfZTBHdYQLqkv5XnSHgXjGKN/GyRSTeSq+5mpNOe9L50j9L?= =?us-ascii?Q?oDjDaWhz1xjka0z11mrs5McdAPRgnrKDGUxbPhjzvWqEkPy2g3UETm24I8N+?= =?us-ascii?Q?UMPwVNdT2Sa6p7CkZNJZzgfIXICU3pKYbXh2xXS4Qy4Qyb63wfQ9FXL49hz2?= =?us-ascii?Q?6chPe6RGEbhSGXbayMaVutXQ0+Tgnp9hUpVYcHZzygvU3CudsvrzqJqvD3Wy?= =?us-ascii?Q?ngC9XgpPTZs2v9MXfjtdkh4m7qCRX5RHU9/u/cQS/Vh/T0RF8P42HxS9yEDO?= =?us-ascii?Q?OY0O9GHqTIB1IkRcQCRyDwjRAlhDIC41o4wwuTvBqJGndH+5ngoFRDxIHBaF?= =?us-ascii?Q?eCfp+IBt2iWBVrT9nFzlkFTay7wGG+YLNVcJydl6o4RRuhtyPt63YF98M6/Z?= =?us-ascii?Q?tomJ/dEz7OYzyQDnY6U8bfRx24tVsKewKUFQFFaKKrefRehKyGCkeCxFfSsP?= =?us-ascii?Q?SFCKOVYLmzXcropmvhbKkGgsU2WtAbcWdFpIJxQ2dHVvhGq5m0IQh8fnjZSQ?= =?us-ascii?Q?0DwXV3lfhIQjNjVj4vwgV1vzo92kpRn8l/eA9Stay9VOdVQslE8T+hI2tUx0?= =?us-ascii?Q?K/cF+ZedEMxKmIzwQX6fQO94qLLC+3XEEB9uCjDyRINk1x3S9EvvWBlY8ikk?= =?us-ascii?Q?6kUGqLLd31jSFsLoWTThM5NTkdaEmeUKHFzzjJRwRPDPXKA9HZYRmPcm/5wS?= =?us-ascii?Q?b2uGVXU0GIO5MlNL80A80K0A/uZ5SpPtu7xN2ll9lQ74G7Cupsi5qO42+u62?= =?us-ascii?Q?KZbdpni9FTaQ2YaV5xvdCAgH6fVACYi2IUaPCcUfol0ZNKKMp/F8XwiPS9W2?= =?us-ascii?Q?XPrYR+ih7GZ+PvLO1wcgoobE6hmAkq33z2QrfxPfRQf7r7pe5pdO//U1geVj?= =?us-ascii?Q?J6PMt/wf6EHXEIqMpmimX+j5vp8HYG3sQDSEVXptzyPpNdnAJAqXdpUrgcea?= =?us-ascii?Q?2ZGgK7Oo/52Q4fJuU1fTHfjVj2SOdXtHp9YIzdrf8Jw+O+ka1Tq+SZoSjyuh?= =?us-ascii?Q?q+hcrpqBSDG3NwgNI5JyVhlSTgzf5rS5s47dTcPi6SaxX4H+OyCBSL9QfyqY?= =?us-ascii?Q?YwzzTwhXfV3v1FbSHYwDwkCkTUo+4oFCOlN3nriSxlHjiJx0hwaVKXw6aPVA?= =?us-ascii?Q?XVXhSRSLsTXAvZm/pugAUJAezLOhDhr57jaSOU4nP8F3bw8XlCEy2rCuczSF?= =?us-ascii?Q?zkkK7SOsUYTOAsnmkRlKh0fX7l0OUCoHzB96DFKLBzXTRs5oNVeZAhFuGV2p?= =?us-ascii?Q?JcTkGGIJCX7EMF7ZQzKkDl4coXXb04L5dnIE84zggfLQzATxcPVkL+4yPZvi?= =?us-ascii?Q?T/EyJjdLYakDkZ2vDQ0cnWAo6oizC1uMtOj625bpZBY7tbpZFpq7ufnd1fsB?= =?us-ascii?Q?1x6e7tsET+0W3vuYn8c+42JSD0/tx1+d0hXYVvOSf7KpagRUe8AoZzPojE7Y?= =?us-ascii?Q?AmZweN0GuQ5GTMrTBTkzQbukks2IQ7GN1B6TFk3xVrqP2uG6J/WbjVVcd1Lc?= =?us-ascii?Q?Je8DZhIV5PkEa+MAktxLl0m6sAeM9kybOOFp5RVKLG30P72FbykHOJ1XshVl?= =?us-ascii?Q?uH9bzVseLctdJQprMn61WQqdbrc2Sel2DgjUiERi8FitybGFkNyVjfW94Dz6?= =?us-ascii?Q?6tRago2yxYdxHg3F0qZ3rF1dleMSllTAmBjY+Y9KeaEJQg93dHaUd2gbZH5h?= =?us-ascii?Q?WK+nw1q6+02IpcV7sqGVMk7V1wYucOjmB9M6b7bmBHofHl7B6I2BK3hBwbOP?= x-ms-exchange-antispam-messagedata-1: rs412oAMsaHap/cLrahxWxdFJnMTzd2SfpE= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2071.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 897aa4e2-b1f2-430c-de35-08da171c7a7c X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2022 15:53:50.7248 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LNmh8WEwg6pnMiUAujvGq0I6AygyeHpyJhiOuTcGYUJPgPgzaQBpsaAKymxjg4jWvdQ9fDrPwmf/S5Futsi5f3+SlTIc/qn3EEfL6B3oh0k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2326 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2022 15:54:02 -0000 Hi Tom, Thanks for the feedback! I have incorporated the changes (for patch 1 and 2= ) and sent a new v3 here: https://sourceware.org/pipermail/gdb-patches/2022-April/187486.html since I do not have write access to GDB. Cheers, Nils > -----Original Message----- > From: Tom Tromey > Sent: Monday, April 4, 2022 5:09 PM > To: Nils-Christian Kempke via Gdb-patches > Cc: Kempke, Nils-Christian ; > tom@tromey.com > Subject: Re: [PATCH v2 2/2] gdb/fortran: print fortran extended types with > ptype > = > >>>>> Nils-Christian Kempke via Gdb-patches patches@sourceware.org> writes: > = > > Add the print of the base-class of an extended type to the output of > > ptype. This requires the Fortran compiler to emit DW_AT_inheritance > > for the extended type. > = > Thanks for the patch. > = > > +void > > +f_language::f_type_print_derivation_info (struct type *type, > > + struct ui_file *stream) const > > +{ > > + const int i =3D 0; // Fortran doesn't support multiple inheritance. > = > gdb doesn't use "//" comments, and normally also doesn't use end-of-line > comments. > = > > + if (TYPE_N_BASECLASSES (type) > 0) > > + fprintf_filtered (stream, ", extends(%s) ::", > > + TYPE_BASECLASS (type, i)->name ()); > = > One oddity to be aware of is that any type can actually be passed to the > type printer. For example you can make a C++ type using multiple > inheritance and then "set lang fortran" and "ptype" that type. > = > I don't think this code necessarily needs to handle this. It's sort of > a pathological scenario. > = > This patch is ok with the "//" thing fixed. > = > Tom Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928