From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by sourceware.org (Postfix) with ESMTPS id 1F5E13857C6F for ; Tue, 31 May 2022 14:48:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1F5E13857C6F X-IronPort-AV: E=McAfee;i="6400,9594,10364"; a="361648742" X-IronPort-AV: E=Sophos;i="5.91,265,1647327600"; d="scan'208";a="361648742" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2022 07:48:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,265,1647327600"; d="scan'208";a="611859430" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 31 May 2022 07:48:49 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 31 May 2022 07:48:49 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 31 May 2022 07:48:49 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 31 May 2022 07:48:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YOY6lnc/P/TYIxmCucNguxxSDueCsrwHx1o/4H3OpE+4ao2pJh6jqLFS8UY3ntu1JluMbFhrbBMhv3pBoeSdegztAiZFlUjzAPQ+NBHGBLZ/8NY9XBWS9XLotqoRvtZH8N9jGzTI6vC+taDkVEIy8z9yWoi3MDW+hsUq1fAkiUFrPFch02Xs27do0ftUAwnXLonZkcuTC2YyMbbr4dHxmtsxMVxD2ImRhZLL1hzR2wN1NkE7v0LISD/ZvpSusqB7jRSaHz11uvElXBgKO2Up1JLJQMxjp7iHywkkI5t6/GVf6rGS9kjqZ4IP1Fm+XzYJeCRi1mJRQC4PVZjOkuvGew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6haHk8c0PD6e+D09x5gzzWC+mlwogqI8Dj4sF1W6UHs=; b=KQv44ENaR3snoncjNNe6Ts5tYAXUy22V4kqpcFhDPLhTlxr8w2B9GMhSGR2z2pY1GrjDFUCzm3jQsZc9iWxx3K3LaQefg3svAYFx++db28oRi2+ZZxJGYcWPP8A6tSXQq6CVAk5q16JeZy9V7d+mS/+z2Od8vawP0yYoKQJZKbbh7gq/8aAX5uCbw9Jtuod6kRZZpcmA6k4Y32JsHsBZ1ra834y8APbxCn2MLjTWZ0lKTHAX40sa8iff5lpx0TIFqd0WVQ5nOcGr5THmFeBKY8sZcflNhjDOYUu5VVcy8z9p0wuaH+9PbV7K5ybCb6GMvgp7vWUtAp1A2zCcRE6kZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY4PR1101MB2071.namprd11.prod.outlook.com (2603:10b6:910:1a::10) by CY4PR11MB1638.namprd11.prod.outlook.com (2603:10b6:910:e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.18; Tue, 31 May 2022 14:48:47 +0000 Received: from CY4PR1101MB2071.namprd11.prod.outlook.com ([fe80::f19e:c338:452a:2b6c]) by CY4PR1101MB2071.namprd11.prod.outlook.com ([fe80::f19e:c338:452a:2b6c%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 14:48:47 +0000 From: "Kempke, Nils-Christian" To: Andrew Burgess , "gdb-patches@sourceware.org" Subject: RE: [PATCH v2 03/16] gdb/testsuite: Fix fortran types for Intel compilers. Thread-Topic: [PATCH v2 03/16] gdb/testsuite: Fix fortran types for Intel compilers. Thread-Index: AQHYdNBPdoWURIdLw0eWIw5vbudBwa05CEWAgAAIblA= Date: Tue, 31 May 2022 14:48:47 +0000 Message-ID: References: <20220531092423.2361679-1-nils-christian.kempke@intel.com> <20220531092423.2361679-2-nils-christian.kempke@intel.com> <8735gpeqjk.fsf@redhat.com> In-Reply-To: <8735gpeqjk.fsf@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 44d48a6c-e667-4382-4b95-08da4314aaf1 x-ms-traffictypediagnostic: CY4PR11MB1638:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pBxTwQZp9cv0T/i+o1Vimdo2i7lrUytAy3K0aMEr5fP/IALFjSdogs0C5S10gktdSIFi9jVMep4z2anNDuJxy5RJG7htM+Iqk6RgMH4SAqugQM5e+izey6xiywLcQHeMY/Cfn9UoYQQ1pXy8WuPVg85PhR7GI6YEiGCy0V93u0hMApl2nxELTsdB2ox4lKrWkw2MDO29vmFSlaiH23RV/dKaOZ2/36rTiEOrx1l5paYsA+znp5y1jxXZ+D6pl+VsZS989b533OaAtnTVVtGe1uPyyADkWy5301p7s3M0x7FMkEO/57ktgllFZcLvPbBr3ritBsjWX2kwR5rkwtL+leZWTcBgmxzoFkr6J0z1AIJEXNKsfv5PwgpAJEpH4qn8G4J+P3D/i2Xo7rbUn99TviWUncV2UmY9pFyEKJW9iDOS+3sS7/06LSDt0HOGt3HAW9VKLQARWiaKMo4N2CwlQ1hd6SfTUB/YMs30mtySyPU8qdcwsMg3UTCslIJK9n9miN63hye1K5jngLyXux552v3ScIlvIR5roipt7rZLRRzL0G4NSWF1sIa6pS5iF0p5QLt4QTKe2XEqpLFzPhwaAsEaQI5Aed2t0B4Sv0IHvUF/zkYmuXxxTc9obhwqSCyklM572IDE084Ivz7nc38XXrBEERbiYt1+u0UCrh4cS3k65XxvH5p8zt0Qrs/cocn/j13n3729lVB7ipQDB907JKJWd/bSEx2iSpgZy6BLoCCD1/1NHEcRm3QuaLf8kwv2rmREKeblxzfGKY3lU3+0gHCS9mlUFhVz6MenUdTCBng= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2071.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38070700005)(53546011)(6506007)(7696005)(86362001)(26005)(2906002)(15974865002)(38100700002)(110136005)(316002)(8676002)(64756008)(76116006)(66476007)(66556008)(66946007)(66446008)(55016003)(71200400001)(9686003)(83380400001)(186003)(122000001)(8936002)(82960400001)(5660300002)(508600001)(33656002)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qGTo4uBQcuheOtCJ4F/8milUV5JnwPFp/h+XHcDye4ARJRQGMf1L+OlrD8e0?= =?us-ascii?Q?JKxLt9zkITa7JZ/oR6Aq172nh/IL5YTlJpLh39DMW8i/iAunq22etqw99YDK?= =?us-ascii?Q?E9lInUWM9EXbLmGoHI2cJ7KHqLQZ72Kj0ZXMYlRMam8/PDyJkMuRVQ02IWsv?= =?us-ascii?Q?GApZU8j2FbzArl3+Q32TL4jHXfDJ20ikF9wfgOBAIyeyXAXRyuvEKxeApZZX?= =?us-ascii?Q?DoBY+CoDjReO0u3J9vFq8hfSglgY1+hlrDbpJWcniBqAJ8KJKUjP5a6y1DqY?= =?us-ascii?Q?Z+x6tU0qrXrZQersiUJ4B5f2zYYkAMisMbRxu9VEDlmREEvDf9tey2bN9Ap2?= =?us-ascii?Q?fsh4ZkThcardwGmds4GG7IcR8MBFN2Zclp329bTqNOYRMY9Y44pO5Jb/O6Hc?= =?us-ascii?Q?d1AzlkGecTO99HDjnbJU9Pbrpo05LHYtl2oClCgUU6ipIlcfGcdJCY8Dv7Ff?= =?us-ascii?Q?DOpVI4LkYMCa+V54iUwEE0U450s1T8OkB5ZXTfFo0tbr6Qcs9hdU8G+5sNpA?= =?us-ascii?Q?Jw52afgpYTUVlXUAkiLOQ9lM8VItYIsLd9hy87rSk3SoEa9krYQZtIu7zMUy?= =?us-ascii?Q?64GiMaMF00f1TD1qmzWowazh0cgJA6azu18eBCKpg73ABC3mhvdAkyp7t0YO?= =?us-ascii?Q?VSkIq346+65TOI494QrUPyI5R4l+thnB0aLf/O8gZH91P9JojeO9IiXRFLBk?= =?us-ascii?Q?MDL7tF878w40ZlQb4097f/s88Xm5P35gESC7SYZNIxObxy/PxBdpyN6eW1IG?= =?us-ascii?Q?ct5AaqXExa4dsSJCu7abg9OlIn0iuCSHCbnN18Tgc/pdVxYQR+FnpAj0GapT?= =?us-ascii?Q?AECEgDFYPlBQtY4EQ5HsgtYcDtHYO7RvhFnkTaC+0kN8foY0FCbM/YO7+4AP?= =?us-ascii?Q?RKyGdqjJyRY0oa0FtcuymWMmjA9x3k+/wIukcff5gUo6YAAZYVzlSx4y8F34?= =?us-ascii?Q?BY58hPziuXQvPdyUMHAfLrUmgWAP+ebnbNfKM61b5nUW40D5m1L/XWxVr4st?= =?us-ascii?Q?VPv/EcmY3gJ5n9HMSL6d1EhSjQjztX5DLnIv75bi9YKwGXeVryFeCFGb9pRQ?= =?us-ascii?Q?9xcSAbrpW17p6otzWgN5fbrzkU6eIq7skFwhlvRHhDxFLbGavOZEXkGYLbg6?= =?us-ascii?Q?CdD9UbuoQIRGl0j9PkkOATOb1IDWcUNtJfwwx4mG/xAAa66YtezNz8uJ1egC?= =?us-ascii?Q?/r8n5G1bWa7ABQogiQ41SZ3PjJRaJ2i4tzdxKVAubxv+uylnBUJHnrHqeYE7?= =?us-ascii?Q?1/FcDcqSX1S9xW7YBFt7XUeNleQ7xvY+eJQc0Ci/NCfqJPInfhxh1w2RHca7?= =?us-ascii?Q?oQTwj8Icg54r1ZPdff9CgPuRGe6zc4cnTh4tFnl9LUhmBNARA5boODaCINGB?= =?us-ascii?Q?Id2NvZiASqVWRoZOJxtBXbf8P47OQc/v/WLpcbze1dAhRn6XDDMTFKs/2+Up?= =?us-ascii?Q?RtOL12YHjp7O7hINODZbZ9yXN8dL41h14Y6gUErmfscy0EI3k1Y0uIOTWqeD?= =?us-ascii?Q?lJOYZvM4lD56U/CzUHJ2QfopdQ/BHYse6GDz9ei5O939IUEf+ygAnK284JEt?= =?us-ascii?Q?O0aAraWvnXjIZpFlivS0Hcz+bYQV6PCUDDUNqhfJNbG87YtXZ5e/oSLbWHxt?= =?us-ascii?Q?jjvkpAl+zzw67Wa/WsLjPkRKOjDord14I3iLZa1jN6ojLOGUb3qm3uT1+Y0L?= =?us-ascii?Q?6IEvDJ89F/M9VYXfgAemqigZnWdGVdvTa/IU4RM9IsCE/FoUw0szE9ZAPQdl?= =?us-ascii?Q?/nt/AQOyZwplKx9rXxopQF/4loftKGc=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2071.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44d48a6c-e667-4382-4b95-08da4314aaf1 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2022 14:48:47.2537 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QTZUxBgTHq67wNrJPurNDDKZrVryZN98Ix9KgZ2PdtSBvKnRq/ugQB/qvu6QjJ3sZXFpp8Hi6DR42rFqmFREeJhfFWBSu8yMBi6006DYDdw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1638 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2022 14:48:57 -0000 Hi Andrew, thanks for reviewing. I might have pushed this series by mistake - I saw your comment and somehow= read it as a comment for the whole series (v2).. Sorry for that .. We should likely revert it in this case and finish the re= viewing first... Best, Nils > -----Original Message----- > From: Andrew Burgess > Sent: Tuesday, May 31, 2022 4:16 PM > To: Kempke, Nils-Christian ; gdb- > patches@sourceware.org > Cc: JiniSusan.George@amd.com; Ijaz, Abdul B > Subject: Re: [PATCH v2 03/16] gdb/testsuite: Fix fortran types for Intel > compilers. > = > Nils-Christian Kempke via Gdb-patches > writes: > = > > From: Felix Willgerodt > > > > Newer Intel compilers emit their dwarf type name in a slightly different > > format. Therefore, this needs adjustment to make more tests pass in the > > Fortran testsuite. > > > > Co-authored-by: Abdul Basit Ijaz > > Co-authored-by: Nils-Christian Kempke > > --- > > gdb/testsuite/lib/fortran.exp | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > = > LGTM. > = > Thanks, > Andrew > = > > > > diff --git a/gdb/testsuite/lib/fortran.exp b/gdb/testsuite/lib/fortran.= exp > > index a97c6eeb4e..9531d393a1 100644 > > --- a/gdb/testsuite/lib/fortran.exp > > +++ b/gdb/testsuite/lib/fortran.exp > > @@ -38,6 +38,8 @@ proc fortran_int4 {} { > > return "integer" > > } elseif {[test_compiler_info {icc-*}]} { > > return "INTEGER\\(4\\)" > > + } elseif {[test_compiler_info {intel-*}]} { > > + return "INTEGER\\*4" > > } else { > > return "unknown" > > } > > @@ -52,6 +54,8 @@ proc fortran_int8 {} { > > return "integer\\*8" > > } elseif {[test_compiler_info {icc-*}]} { > > return "INTEGER\\(8\\)" > > + } elseif {[test_compiler_info {intel-*}]} { > > + return "INTEGER\\*8" > > } else { > > return "unknown" > > } > > @@ -66,6 +70,8 @@ proc fortran_real4 {} { > > return "real" > > } elseif {[test_compiler_info {icc-*}]} { > > return "REAL\\(4\\)" > > + } elseif {[test_compiler_info {intel-*}]} { > > + return "REAL\\*4" > > } else { > > return "unknown" > > } > > @@ -80,6 +86,8 @@ proc fortran_real8 {} { > > return "double precision" > > } elseif {[test_compiler_info {icc-*}]} { > > return "REAL\\(8\\)" > > + } elseif {[test_compiler_info {intel-*}]} { > > + return "REAL\\*8" > > } else { > > return "unknown" > > } > > @@ -94,6 +102,8 @@ proc fortran_complex4 {} { > > return "complex" > > } elseif {[test_compiler_info {icc-*}]} { > > return "COMPLEX\\(4\\)" > > + } elseif {[test_compiler_info {intel-*}]} { > > + return "COMPLEX\\*8" > > } else { > > return "unknown" > > } > > @@ -108,6 +118,8 @@ proc fortran_complex8 {} { > > return "double complex" > > } elseif {[test_compiler_info {icc-*}]} { > > return "COMPLEX\\(8\\)" > > + } elseif {[test_compiler_info {intel-*}]} { > > + return "COMPLEX\\*16" > > } else { > > return "unknown" > > } > > @@ -122,6 +134,8 @@ proc fortran_complex16 {} { > > return "quad complex" > > } elseif {[test_compiler_info {icc-*}]} { > > return "COMPLEX\\(16\\)" > > + } elseif {[test_compiler_info {intel-*}]} { > > + return "COMPLEX\\*32" > > } else { > > return "unknown" > > } > > @@ -136,6 +150,8 @@ proc fortran_logical4 {} { > > return "logical" > > } elseif {[test_compiler_info {icc-*}]} { > > return "LOGICAL\\(4\\)" > > + } elseif {[test_compiler_info {intel-*}]} { > > + return "LOGICAL\\*4" > > } else { > > return "unknown" > > } > > @@ -150,6 +166,8 @@ proc fortran_character1 {} { > > return "character" > > } elseif {[test_compiler_info {icc-*}]} { > > return "CHARACTER\\(1\\)" > > + } elseif {[test_compiler_info {intel-*}]} { > > + return "CHARACTER\\*1" > > } else { > > return "unknown" > > } > > -- > > 2.25.1 > > > > Intel Deutschland GmbH > > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > > Tel: +49 89 99 8853-0, www.intel.de > > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Sil= va > > Chairperson of the Supervisory Board: Nicole Lau > > Registered Office: Munich > > Commercial Register: Amtsgericht Muenchen HRB 186928 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928