From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by sourceware.org (Postfix) with ESMTPS id 88C28395B41F for ; Tue, 31 May 2022 16:27:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 88C28395B41F X-IronPort-AV: E=McAfee;i="6400,9594,10364"; a="361684321" X-IronPort-AV: E=Sophos;i="5.91,265,1647327600"; d="scan'208";a="361684321" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2022 09:27:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,265,1647327600"; d="scan'208";a="529654133" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 31 May 2022 09:27:53 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 31 May 2022 09:27:52 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 31 May 2022 09:27:52 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 31 May 2022 09:27:51 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.44) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 31 May 2022 09:27:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fbFYY0tOW1gl/R+1n1R3uqcfm7VLNhCxuYFWD3DxGwVBAcK755mvyT5ylTr/emh5dkYHqnbzFo0uY9YVzCstlr/+DrG6QtHJpJJlnJrM1vyX/f+STfNtwxkOAYWMyZyN3D3grX+lYKXJlJ9HsnCJgaRjP9T0VsGz9VLaICrtrSa8H8I6AukZxhB8Hzt3WH+2eJXfScBIBZ9He3Gkz/srwap5CuCQdzpU9ns9MfnbMErJNgeJYm5hWI4qsd0UnctmJV3FNdCPBw84pCJZtN/saFjqBFKnwV9HeZwMpOHtMA7vYO5JrILbwSW9CZyqCw33KLbtW7Oi2ktWM8FiOH8oTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ssZq7JEAkZ87abo+AunzFz0s2nvUx8yVSOPLUTe5g28=; b=mxJzX8Dl0cV0Z0UrqLO6JeG02rnAORV0r5O7xmt3nI4mqd/nvCzHmiG/92D1m7jcmklrucpePhsS3saW6M435sSs6AZ4zq+Mz4sUFsAPThe5lpQxmf7k3RvvNacnvqusRUr0gdhPMs9Nje12I14e3hpaGC4tQvsuGRDc/Xl+98WOGu605Q4raPXds4BxlEzRmVcBbpgB9jpYAKZUa1OX76te5G4Z9efLeaedbsVg8b36gURbNXaAAJ8g38NfkrLHIPejbFsjuBJb5xU6tDhClHOiKvPbXBKrKV9JPRiaohh9Fuo05tH5rkr42jmFWfhkS/4ll1m3ZwwPwHuGL87MtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY4PR1101MB2071.namprd11.prod.outlook.com (2603:10b6:910:1a::10) by DM5PR1101MB2172.namprd11.prod.outlook.com (2603:10b6:4:50::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.15; Tue, 31 May 2022 16:27:49 +0000 Received: from CY4PR1101MB2071.namprd11.prod.outlook.com ([fe80::f19e:c338:452a:2b6c]) by CY4PR1101MB2071.namprd11.prod.outlook.com ([fe80::f19e:c338:452a:2b6c%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 16:27:49 +0000 From: "Kempke, Nils-Christian" To: Andrew Burgess , "gdb-patches@sourceware.org" CC: "JiniSusan.George@amd.com" Subject: RE: [PATCH v2 00/16] Fortran compiler identification and ifx testsuite support Thread-Topic: [PATCH v2 00/16] Fortran compiler identification and ifx testsuite support Thread-Index: AQHYdNBHIecqxAhC4Uu34s84VOQf7605KV+AgAADDwA= Date: Tue, 31 May 2022 16:27:49 +0000 Message-ID: References: <20220531092423.2361679-1-nils-christian.kempke@intel.com> <87ilpld6ho.fsf@redhat.com> In-Reply-To: <87ilpld6ho.fsf@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8739e508-88ef-48a6-034c-08da432280a3 x-ms-traffictypediagnostic: DM5PR1101MB2172:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nrS6ZYgp9Fjit3YVNpI3k8Fk59Wuc5qRo8zU8mLuHZ9wFBK6z22low84uox8QPuOEFY3gAYReJgV0cvNNdcNHjdmxUAvWW4yJRNMVWGBf6RhytL7up/0MGhaauUANhX1ApBGT/Lf/FVa/E4euRf0v9nnIoit75bzSM1O1rAcLGtZl4lk6zN96gyoqiSN4EOV6LqFFOn8TG923L6Tx1UHjNLAdS1/OnfW7LK7xA1tCXeOOnIcIWneVXMQEz+bLLrfDnbkn1bTvtYxtIGugsI7q7ajsq/9b3kPSS1wCrXGyWmtnpHB3HbtKcqzsduD5J6KANzlne9spPXavjSmCk8tqjaYeJyTIoKsiKrxt6a+NFTxk3M9TcRJ3Y3aNfo/cPV3hVjnjU9l9uZDGSkdkQv85HQq63jQMpy8nTgoygUlFbLLwMZPBXyhxHRB/O9fl0HCX8XxvcQJEg0yBrSAeS2Dm9QWbM9QhfKbKThd6xX5MFE2ITlj/A+VK7A1xea5uSTVpZxx89+yplw+exR26kRfez8y9E6dVM6jQpr01hvW7rHLx1IWLCtwozVTXk0Eba+QpF06GYEz9iUqM3B250o6hM96E3IU2NGZ/g5NvbB3YPtwgqV9ymhnikewZZY1hDThHxJVUgVOjOv2h/cPkcR6dXoabHqhlIK8Xq9Uk0faHYW8Jjzild43+CWB5ba5Jl7lnmdcpNJQpiRpdu4Zx34sgHs70j802B2jBWkKUxv9ljp/OsjTSCUysucoguVQREuPyvtzUWHxzGawFU1Q6xShLzGLKA7bBs8SPvu5tfXDzPw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2071.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66446008)(64756008)(66476007)(66946007)(2906002)(71200400001)(508600001)(66556008)(4326008)(8676002)(76116006)(83380400001)(33656002)(5660300002)(53546011)(38070700005)(966005)(7696005)(26005)(9686003)(86362001)(6506007)(122000001)(55016003)(82960400001)(15974865002)(186003)(8936002)(110136005)(52536014)(316002)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BVYt6DOoLngeKf0KkFLlMn8K61n4n2sutfRKf5J9AdmQSS8roEQhAevS7jFe?= =?us-ascii?Q?D3JaHtWqWScI/qAEfrrizIHmZssx9Y65M9fldag5cLoLNd3wF1UHBGmvGutZ?= =?us-ascii?Q?v/U/oKUgS9KQsAYiBjXrH5P5GCyrGOnbrSx5JThFlUhkcDed9xVnNIvJqTAK?= =?us-ascii?Q?OExwTe2oADPr6QVSr7xi0OXpwnY2Dr282uspaII5caM7yp/+xqDuZL1z70Uv?= =?us-ascii?Q?2MBNsJ5vyaxdHLvDISWl55mUmcTaWqskUV1viegSTE7IKvwlUlYgG32fjMoB?= =?us-ascii?Q?zbNygxqbS0ONyQ7vweji+PDjIVYHv5I5FLouWbrZm9CHku3Qbi68TGiKJ6Mn?= =?us-ascii?Q?qij5ppgS/NH/g/1pVD7RuHwoiNeXtJc8IrKaeCV6hsVux+wyUnjlJdBVCYII?= =?us-ascii?Q?VkEgIuk6ALZYqgG/8BHi1AWsgfXik/or+Fh5EmZYQ9PS6Jh+0OeiZIh5APzZ?= =?us-ascii?Q?NoQi47U5V3HJoowzCay2VC3WNkioUmv+QxhrOiP/pp2fDFKF5nN/WiObgOaG?= =?us-ascii?Q?d78rqpnAjtROMDxdj3oMgfgOmeRjpHuLgJs33h15BfFQwbw+tGTVY2aQoH3e?= =?us-ascii?Q?YlGWchYz8y0esx93/H7rCJ1j/CRzmdy4OJiDWyfsQy+WfBu07HBbfN5kz9CH?= =?us-ascii?Q?Cwbo6lxzjgxKUEZlzUkdLvFPMk3lYEyZZTngDkJInT96WUjUEvKzYF/ulcHn?= =?us-ascii?Q?3mu5RfBzqWbmoXsayx7A3n3nGvCXqScDmnNptcqB9US1OBLFk8SIR0ICv5kK?= =?us-ascii?Q?cOm1sf/xobNoFTIgFTTL5LpQrbiwCcwqXh6XsMyCAG6qt0cb6gpxS7x/EIk6?= =?us-ascii?Q?4A2ChJy5Rf+VpmImms4rzcfgDL9b2vi4box3nSBWSffs4aYXJ8OaCbIbfZPM?= =?us-ascii?Q?neMXHQxJR2R7drqd8RS6/QgAopMnewVuMMqVSE8R2UIPbgbr80OWEWnHhML8?= =?us-ascii?Q?PwWFcAiJmJHalJyrZuS0ssEQClmsqFQJYvPjsEvz6pQKxr3VmPuaIKn2j8f6?= =?us-ascii?Q?Kw5ln/jaZv98avUHNQ3L+dVJWUQg0sR0tEnigOGfkI9MVZ/Lz8wxUNDFrZqD?= =?us-ascii?Q?Omrju2DoPkHKzNrFI/Ok7JHN37UZsDbo6XL4NL126q7U5N66ZzB4JnFIiNB+?= =?us-ascii?Q?W50Qne0n6pKWYaEOyXNqdE25aDseloQTXuRSTGG3mdOafpuTWZSfo9FN+reo?= =?us-ascii?Q?xR2+mUoeiqtyckHTa7EiXMVsF5e3fondrjafOeycX/pcKOp4Y7ym6/jVFNvm?= =?us-ascii?Q?iO+X5OyFkHO0dEfSaKvH3nTP03NHLIPUH6wQPe5ObQI2AJvrksgNgksWbJYK?= =?us-ascii?Q?F7LycQ58k6InWUqokf9H4I+GArfojkIFz/TymJwpkofL+PdhzdE5eIZMPTyg?= =?us-ascii?Q?sPbRvBIYEdaGez85x1pYjTTwpLlRaJW3SxWSh6U+hzMUq9pA5dHhEd16oEZs?= =?us-ascii?Q?08VJva5zU3xOxQVVtQT8lzlrYcjr7E/BhxhX3uEv7YEtnMA3QknqUU9Bculc?= =?us-ascii?Q?7YqiMOMENS7F+JFm4nE0x0lvrXOHR0+IbgaLzweshxJKpXA9UqBc+VZ2shkE?= =?us-ascii?Q?4SCA3R2mdAFKyPDSTAAUgL95HpTlbFc948mTSc+AprhZJ3b4d+qAxJhFaon6?= =?us-ascii?Q?dNNv13u4ivTjH4VGyiKFbfq3bLm1djh06rxcAjjrr+vYadyVShyclyF4UXHM?= =?us-ascii?Q?RDp2jfHw9ZbG9+JcLCBwOtphJ59qx7ELXScaCMGS2yqxkLXHWydkFyJyrl0a?= =?us-ascii?Q?YZY4RA7XpoqboQWG8KF3l241+Feto24=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2071.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8739e508-88ef-48a6-034c-08da432280a3 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2022 16:27:49.2149 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: i8xjwCdi9S/6TCUZMn0NaEVPmSNMRmWmP6eZUPyZyrYiA8GVWDlIX+0kedM+ipJ9t9OEdu99B3zUw8fTz9pyZmJVfUU5tHhhW/1U+rEgzuY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2172 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2022 16:27:57 -0000 > -----Original Message----- > From: Andrew Burgess > Sent: Tuesday, May 31, 2022 6:14 PM > To: Kempke, Nils-Christian ; gdb- > patches@sourceware.org > Cc: JiniSusan.George@amd.com > Subject: Re: [PATCH v2 00/16] Fortran compiler identification and ifx tes= tsuite > support > = > Nils-Christian Kempke via Gdb-patches > writes: > = > > Hi, > > > > V1 of this series can be found here: > > > > https://sourceware.org/pipermail/gdb-patches/2022-May/188904.html > > > > Changes since v1: > > > > * Patch 03: There were some leftovers in the commit message from an > > earlier version of the patch - these have been removed. > > > > * Patch 04: The commit message has been renamed and a comment been > > adapted according to Andrew's feedback. The getting_compiler_info > > variable now also uses actual bool values. > > > > * Patch 06: The commit message has been adapted and now says that > > the intel C compiler names have not yet been used in the testsuite (to > > avoid confusion as to why there are no changes done in the testsuite). > > > > * Patch 08: This patch has been dropped, instead an ifx bug was filed. > > So from now on the patch numbers will be off by 1. > > > > * Patch 11 (now 10): The comment has been reworded and > > 'need the -debug-parameters all flag set to emit' > > now reads > > 'need the -debug-parameters flag set to emit' > > Also, not only ifx but also ifort requires the flag so it is now added > > for both compilers. > > > > * Patch 13 (now 12): I added a comment to the patch as well as made > > the commit message a lot more elaborate (after some online > > discussion). > > > > * Patch 14: This patch has been dropped for now as we are claifying > > whether ifx should change its debug output. The patch numbers will > > now be off by 2. > > > > * Patch 18 (now 16): The '-wrap' is now used here instead of adding > > the $gdb_prompt in test_multiple. Also, flang was added to the > > comments. > > > > Patch 01, 02, 05, 07, 09 (now 08), 10 (now 09), 12 (now 11), 15 (now 13= ), > > 16 (now 14), and 17 (now 15) had been approved before and were not > > changed/included here. > = > I've approved all these patches now. > = > For me I would have preferred to see the complete set of patches > included each time the series is reposted, it makes it easier to apply > the patches. Though I do also appreciate you commenting about which > patches have changed, and what the changes were. > = > Thanks, > Andrew Thanks for the review! I see, yes.. - I remember someone telling me that I need not resubmit some = patches, so I thought this was the standard way. I'll submit the whole series again next time. Thanks again, Nils = > = > = > > > > I am happy about any feedback. > > > > Cheers, > > > > Nils > > > > Abdul Basit Ijaz (1): > > gdb/testsuite: Use -module option for Intel Fortran compilers > > > > Cristian Sandu (1): > > gdb/testsuite: add Fortran compiler identification to GDB > > > > Felix Willgerodt (1): > > gdb/testsuite: Fix fortran types for Intel compilers. > > > > Nils-Christian Kempke (13): > > gdb/testsuite: remove F77_FOR_TARGET support > > gdb/testsuite: move getting_compiler_info to front of gdb_compile > > gdb/testsuite: rename intel next gen c/cpp compilers > > gdb/testsuite: disable charset.exp for intel compilers > > testsuite, fortran: add required external keyword > > testsuite, fortran: add compiler dependent types to > > dynamic-ptype-whatis > > testsuite, fortran: Add '-debug-parameters all' when using ifx/ifort > > testsuite/lib: add check_optional_entry for GDBInfoSymbols > > testsuite, fortran: fix info-types for intel compilers > > testsuite, fortran: allow additional completions in module.exp > > gdb, testsuite, fortran: fix double free in mixed-lang-stack.exp > > gdb, testsuite, fortran: fixup mixed-lang-stack for Intel/LLVM > > compilers > > gdb/testsuite: fixup common-block.exp for intel compilers > > > > gdb/testsuite/boards/cc-with-tweaks.exp | 5 - > > gdb/testsuite/boards/debug-types.exp | 1 - > > gdb/testsuite/boards/gold-gdb-index.exp | 1 - > > gdb/testsuite/gdb.fortran/assumedrank.exp | 6 +- > > gdb/testsuite/gdb.fortran/charset.exp | 5 + > > .../gdb.fortran/class-allocatable-array.exp | 4 +- > > gdb/testsuite/gdb.fortran/common-block.exp | 38 ++++++- > > .../gdb.fortran/derived-type-striding.exp | 2 +- > > .../gdb.fortran/dynamic-ptype-whatis.exp | 79 +++++++------- > > gdb/testsuite/gdb.fortran/function-calls.f90 | 1 + > > gdb/testsuite/gdb.fortran/info-types.exp | 20 +++- > > gdb/testsuite/gdb.fortran/library-module.exp | 2 +- > > .../gdb.fortran/mixed-lang-stack.cpp | 12 +-- > > .../gdb.fortran/mixed-lang-stack.exp | 21 ++-- > > gdb/testsuite/gdb.fortran/module.exp | 5 +- > > gdb/testsuite/gdb.fortran/namelist.exp | 2 +- > > gdb/testsuite/gdb.fortran/nested-funcs-2.exp | 3 +- > > .../gdb.fortran/ptype-on-functions.exp | 6 +- > > gdb/testsuite/gdb.fortran/vla-type.exp | 2 +- > > gdb/testsuite/lib/compiler.F90 | 69 ++++++++++++ > > gdb/testsuite/lib/compiler.c | 2 +- > > gdb/testsuite/lib/compiler.cc | 2 +- > > gdb/testsuite/lib/fortran.exp | 100 +++++++++++------- > > gdb/testsuite/lib/future.exp | 21 +--- > > gdb/testsuite/lib/gdb.exp | 62 +++++++---- > > gdb/testsuite/lib/sym-info-cmds.exp | 18 +++- > > 26 files changed, 318 insertions(+), 171 deletions(-) > > create mode 100644 gdb/testsuite/lib/compiler.F90 > > > > -- > > 2.25.1 > > > > Intel Deutschland GmbH > > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > > Tel: +49 89 99 8853-0, www.intel.de > > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Sil= va > > Chairperson of the Supervisory Board: Nicole Lau > > Registered Office: Munich > > Commercial Register: Amtsgericht Muenchen HRB 186928 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928