From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by sourceware.org (Postfix) with ESMTPS id 25AC038515FA for ; Fri, 8 Apr 2022 12:50:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 25AC038515FA X-IronPort-AV: E=McAfee;i="6400,9594,10310"; a="322273155" X-IronPort-AV: E=Sophos;i="5.90,245,1643702400"; d="scan'208";a="322273155" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2022 05:50:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,245,1643702400"; d="scan'208";a="550490821" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga007.jf.intel.com with ESMTP; 08 Apr 2022 05:50:01 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 8 Apr 2022 05:50:00 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 8 Apr 2022 05:50:00 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 8 Apr 2022 05:50:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ps3jY58hhJZumfU+7v8lgxauvKei6heVy7QI4fkHX+0W4aZCjzlXWqXD/gRDwIUwcGBKne4CoqQSweJy/vvgDlLN/b4Wtv9P47QBuKDkXPcgUaLoznujTObmGrbBSq/vhtMQX635GRjaBlOLKfga84U2Hm2jAGQtY+mDXhY2RQAX+16qWzfJtn4kpy6zLvPqbO255mYiDaxbNh4YlrO5/GxsDIeFEWQzkh/iYLPDZKfrim6s0HQj8TiVhYWQ7xGO2H4EvGtGboyuxPJJLd2lokWBbN6/wgLcFfG21VFm+mkNLc0NqYuD5ern01TcsQJZWzYqswdJayGCo7b2pARd+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pZCcjJbbTq8OgwwMcB74oodtNBbTyr1OJ5c3Sy3HecA=; b=EFMxy64kf/T1viLw5440wUiVCNc1/Os3nnkVaRhtYnFt5EueybeJacZpQ+gPyKycYeuOBRr2by6q0LgGUFrjMXK/Hs1ajATG4IiaPduqEkuKflLPO0UrUgdtGzxKVEIWxeuWNQoZ9FP3d+l/lyT4Zmks+zd3Z+16/SQsBM7Lx78k2SlV3qLzZV+v27hZtMvUbL7y+1aw1rZMbzchtoUmviMJa3XJBRw8sLtlo2tFoyJd2cB//stUCf+BqMEyaEFVUs2YOAUmL79kRub0OyPJGzqRz9b2H5eVoYkjVhwhL1mPr8qRvhe9oWjFnASclJpvy5HWnL322LXz51IA9BHDZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY4PR1101MB2071.namprd11.prod.outlook.com (2603:10b6:910:1a::10) by DM6PR11MB3193.namprd11.prod.outlook.com (2603:10b6:5:57::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.26; Fri, 8 Apr 2022 12:49:59 +0000 Received: from CY4PR1101MB2071.namprd11.prod.outlook.com ([fe80::99b6:62d4:b384:998]) by CY4PR1101MB2071.namprd11.prod.outlook.com ([fe80::99b6:62d4:b384:998%5]) with mapi id 15.20.5144.022; Fri, 8 Apr 2022 12:49:59 +0000 From: "Kempke, Nils-Christian" To: Tom Tromey , Nils-Christian Kempke via Gdb-patches Subject: RE: [PATCH 09/11] gdb/fortran: rewrite intrinsic handling and add some missing overloads Thread-Topic: [PATCH 09/11] gdb/fortran: rewrite intrinsic handling and add some missing overloads Thread-Index: AQHYM6IZSyIAStAONEWu1JhRDKVZuazkthxZgAFvs5A= Date: Fri, 8 Apr 2022 12:49:59 +0000 Message-ID: References: <20220309103922.3257803-1-nils-christian.kempke@intel.com> <20220309103922.3257803-10-nils-christian.kempke@intel.com> <87bkxdaqz3.fsf@tromey.com> In-Reply-To: <87bkxdaqz3.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 439ab235-0b95-450f-6423-08da195e4a79 x-ms-traffictypediagnostic: DM6PR11MB3193:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sDQE0ionMCqC3QlnxcGGSwgbviGY6V3Pg0rsGKtaZEO7j2vp3XMHnbJ+1Rb+pFi3nXxrXLR0ad9nJUad/MmB2gfbtR4rip16kskl5mvM+288KEt/0g5tqOaeYGtuc6lViOfg4s2KQLmoFo+LwOooFOxj26IEYmALpt4Qyi4k/iMreDd0/woyCHRtLSzO0FJy31yVM0yy1bK7Hk1Q4nRwWXxWeqysyy3nbYiDmwU9LzYsllW+uKVXfknNng4Vcog64Jakf1bYSxlDm8vQTkf8nt4AbB3BZT8JHXtnVjlztxhZ1ZHxZL7PgJI9qid0ZijmTujqjZ+xWXcZuufxFzAbPRHMCe+vX+4QVVVlkpo5UTA3N3JClmPalYt0gMW/GKPB7eeVSGaV7a7ezSD7hbqfPysNitAYZvQwqNu6r+9/sDHXKGpzVTCTGgGcaop8pjT81GcFwmgYFXLo6I+cGRe0YiYubrekw0qwBYs1Xa97gQH77KaiXWE3lGGn4wUVy/kX/k0Xv4WguAqx+hRCu6s7qjjoJCkNY1d5WYV8sHP5zNBL5Fu9taCp/IcmKo8fg+lwWqpslnhytHny8d+XYILHg3w5/T2pCdIF5HVG4sCk6V3GGCBJsv3Ep3zg42YTJXncX165rSemcw1V4GtsE3B10r7lJfqZ0RjN4M3MYtOgBkCXrRBNfda5bUNzEFyIFRbo6b/U/uxCcHHFrnikL1yrwQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2071.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(33656002)(52536014)(66946007)(66556008)(66446008)(64756008)(8676002)(66476007)(55016003)(8936002)(38070700005)(5660300002)(508600001)(316002)(71200400001)(122000001)(2906002)(76116006)(110136005)(86362001)(83380400001)(9686003)(7696005)(6506007)(186003)(38100700002)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?S8mUHwBhNYgYXyFf/VPuE1Ei1Zlq9yUJkrkaWd4T9TLK4JdYU94PbyhKwEps?= =?us-ascii?Q?iDoYdQGnTj/ncFJ1iRlfzu/nC6aWPfOB5vN68dRJ/2KhFQ3gnGK8T9jBqeNw?= =?us-ascii?Q?5ywnvnDCDBg6N50iJ1y8ORpFgXKJYelC8koQwrusRgv5cCsedZSQjch6hg6q?= =?us-ascii?Q?tkZAtgWYaiL/Qk9HlnSdnl/I7VCdHqWMz8cVT2Bx53cmQlB/uA606D/uci43?= =?us-ascii?Q?sRf7hG1ATKDqg/78rz65t5psmRaFMJWb6Fd97WpRhbyjuE9Yc55hz4qW42Gg?= =?us-ascii?Q?9bwFKqqlClyXTzPuO9WH6tNfrJSNSZL/ZkcOSjqAOo9LShiA0k6ELsZp+RDu?= =?us-ascii?Q?Xy+xQBZJv2FJWRpt7vZi1zq2ieDqzgtBHS92qjeiMXEP9/cDzJEHRKw+2mSy?= =?us-ascii?Q?qDPnlCyLKpi0MHftvrZq2kovhOqatU95iGtRbYFLxQ5MJQweDgcWb4+ktkNE?= =?us-ascii?Q?cT+9Id3kkzJuuCY1y6uMXpEtnF5pdDYkTnnv4bKD+5uTCdwZrTaBkN5nuGvS?= =?us-ascii?Q?Ds2NKyDaFyC3vECiE+bkAYF2M2vUeDtNU0QjyY8wp81k0P0Jcc4Zuuhti8vh?= =?us-ascii?Q?HbNqhSpwwYSJsoH5LPvuTcXVMgjVgybOv347qzY52RCI+O4m2/vY7iJSG+VI?= =?us-ascii?Q?QUlGWe16+jUG7PW0nDHGTehVorQacRpcvSAvTaK4BorGjPhYaWgm2GwdaRdR?= =?us-ascii?Q?aV2b0Xpb3BdIHsG/HJwQXsk/dxCXBBg6ayf/1+UfZL/4yJ9A5wTfqyh6ZKWL?= =?us-ascii?Q?zhWN8WCokMuCTGgmgqkhfPANUsb+31QnSReuifWcNW2W/d3XpbGeJy54trJF?= =?us-ascii?Q?UZkGklD9kyYYQqgqiILZj03F0MF6MWHLykbWsSOSBKVb1te79M1h8si/Ydeq?= =?us-ascii?Q?Cn65OuqvcIyL9zhKJB7JyUJxS8Mno8go1AJuGafPH/RdQRAGDbwJw3OyertJ?= =?us-ascii?Q?jgsjyPNf81HAtIRFp7N37AV5Ew+JYRbBrcJt4RbIQ87x8EG7UJpidszceKrM?= =?us-ascii?Q?zmT5qBrPoO/Sv5Y+LoM8fNlftMnt2J//yyc5shHIBfQWSl0/gHWb2usKPJGp?= =?us-ascii?Q?RqFW1nIkaL8vf0SSkAoFYTUfTdH5gpwQJCd5pqq8UcpNSWbPy99FlOx373mO?= =?us-ascii?Q?tVR/scwteO0Wb0n0C7KDpqj0t9tAC21gp8VH9bF7sR1J31Ei5AUAYEsI3LGh?= =?us-ascii?Q?Pq175/eNANig0TFNdOX2wu7I+iDaUonucP5/yTRAwxYhQ99kYvSkJW2qBpwg?= =?us-ascii?Q?/EcoxU2YJqk2NrcEUVnC8RrNR2SZubZTExEfi5H6ZxJoBiAyBrT4eUzgAACT?= =?us-ascii?Q?nywJtQW8pQ1XI3p1uSVUxwcauXImfDbZ6JctZAHvf9gvQUsNYv8DmFWhxbTB?= =?us-ascii?Q?euJhlY1QmmRwEaXsDDjepASFeN2GPUuUxoTvHgIIziUksZUsnS9CUqx5kpDB?= =?us-ascii?Q?P+kqTpr4az5RW/X72Bx+wgGq60Hs456bw5r0u0qMIT25TnwM4zQ6RsdixjYD?= =?us-ascii?Q?AZiztjyxZghLyX07j1Rt2MjquyHGWcm7ccuCxltpoY8TxLPiwSMyleH6VNOR?= =?us-ascii?Q?53+wlz4bQInR5Oja7w/yiY1AipIRGH0k/9k/viUGilOc8S4snGoEEVt9bZGx?= =?us-ascii?Q?PFXTfO83w9gq2Kz4D3mgsCvulhWPK8MV3+RyS+SOmxiahI4cZ//FnpoFXdwy?= =?us-ascii?Q?Kp2L9Q0SHAw5EopCy7twCAvjZIdkrBVz5QAK2waaMzn6X5cVrP4pX/sD5tDG?= =?us-ascii?Q?6q+hrQMEKxQ+Pbly/4jvHglf/VJgxdqrF7fk+twoab1rsvcNK9yLtMPHfB7H?= x-ms-exchange-antispam-messagedata-1: Xi52IesBLNqNf51fbiQ6/X9fs63knli9Vz4= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2071.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 439ab235-0b95-450f-6423-08da195e4a79 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2022 12:49:59.2811 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MVljYnaSJOZnkwa8fbcbIw9P51fBtNNNmPln/smfFeRWfc/v2IRqkIAJLV9CU/baFiObCpI1b9qrH5SFw1PXp3TLDihmeZl3MUmeJAyFhmo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3193 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2022 12:50:03 -0000 > From: Tom Tromey > Sent: Thursday, April 7, 2022 4:49 PM > Thanks for the patch. > I found one minor problem in this one. You don't have to resubmit after > fixing it, though. > = > > After adding more overloads to the intrinsics handling, some of the > > operation names were no longer accurate. E.g. UNOP_FORTRAN_CEILING > > has been renamed to FORTRAN_CEILING as it is no longer a purely unary > > intrinsic function. > = > Eventually I'd like to get rid of this operator enum entirely, but it's > also fine to make the names more correct in the meantime. Thanks for the review! I also thought about this while doing the changes.. But I did not want the= series to become even more invasive. Should I touch the Fortran intrinsics handli= ng = in the new future again I'll do that, too (probably while checking the intr= insics code test coverage..). > = > > + case FORTRAN_LBOUND: > > + case FORTRAN_UBOUND: > > + pstate->push_new > > + (code, pstate->pop (), pstate->pop ()); > = > I don't think you can rely on the order of evaluation here. (C++ did > change this, but after C++11, I think.) Instead you need to introduce > temporaries to control the ordering. > = Good spot, thanks! I'll resubmit patch [PATCH 11/11] only then. Cheers, Nils Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928