From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by sourceware.org (Postfix) with ESMTPS id CD1293857C4A for ; Tue, 24 May 2022 15:25:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD1293857C4A X-IronPort-AV: E=McAfee;i="6400,9594,10357"; a="272380712" X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="272380712" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 08:25:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="526447451" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 24 May 2022 08:25:03 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 24 May 2022 08:25:02 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 24 May 2022 08:25:02 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.45) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 24 May 2022 08:25:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RFIu2CRUgTOnx+g6+U8BuPgP9Wt+wzrs9J4ZDzl70W6Bf+/eU4CpR6tSnSAgAYJ3LZ6M7dw9ZeVMTbhUtU5WCAdyT7meIhpjqX+DxhMCVNF8uf3TBg0Hgr4pxMYAqT1sMqtwGCflUPJlzcLP6DPBkISyOcQUdabY7+uFhidIlXj/A+DBd6TAWZCSvBrQvT3uEwtZmZE3z6dWqCn2cxCIVasUj5jj5+tjk+reYd0ZXjlegq50jKsZMdmrTEZSHm81u/qP9QoqMHtB5EVJX86z64zh2efxuky3upvwtmYfdNP346Mhd8194pG2GwKJ7riMcHm1IMzh4b6aAKasEZEn4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BtKGwVuZw8UlIRfToaf85EulEbeauO8qOvL2d8DJZ1U=; b=XXO0fU+0zN8HSV8wIfmHLOnqEUMp9hvSiCPremr1vw/FwYds9lUnflQhr1g4q/5P3RBtCgW8csRrlpLH7H0cWoNVbPLyJim4nxuyLojc0q30G0FlOFm4DU5JW0k0TpY3vuR8lzp2UuWBqBHkUyHSOZfQgF89X6oDR0aEwNyyG2XCHiYjV/2H4LcLsa6ReWYApf6ykjeE/yBLlp7jLOYxYl056tEFpqicSgcGUiehpPTPBuv509JiIRVu0pW+4yop/UKbu6y+O7XhAG/7Q+rkjTm17FGies0UzDPWBPFCTWJPnXx89wBelUBUovjHL9yRRYehm2Bq0HjYCpygXttbIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY4PR1101MB2071.namprd11.prod.outlook.com (2603:10b6:910:1a::10) by MW4PR11MB5871.namprd11.prod.outlook.com (2603:10b6:303:188::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.23; Tue, 24 May 2022 15:25:00 +0000 Received: from CY4PR1101MB2071.namprd11.prod.outlook.com ([fe80::a9a4:ba0b:a4e8:b7fb]) by CY4PR1101MB2071.namprd11.prod.outlook.com ([fe80::a9a4:ba0b:a4e8:b7fb%10]) with mapi id 15.20.5273.023; Tue, 24 May 2022 15:25:00 +0000 From: "Kempke, Nils-Christian" To: "Kempke, Nils-Christian" , Tom Tromey , Nils-Christian Kempke via Gdb-patches Subject: RE: [PING][PATCH v2 1/1] dwarf, fortran: add support for DW_TAG_entry_point Thread-Topic: [PING][PATCH v2 1/1] dwarf, fortran: add support for DW_TAG_entry_point Thread-Index: Adhvgmpe6fM6omuPREG44sErUJcz+Q== Date: Tue, 24 May 2022 15:25:00 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b239ad8d-b999-4fa2-4548-08da3d999152 x-ms-traffictypediagnostic: MW4PR11MB5871:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U/rF6G5rDJc4hADefFwvN1pXf8Ebgz/nYZZ+T86FDq1OVRFIzGV6wJOqlMhUqbyZTBeMTB6IYUMo68MwoRPnfnYzJ5mLl+blbteQugrc18DI0Pai4ouqfv0zPQSRFFqe/MvQ6yAB5AZkfHyKeY20MqZElnPDOpPzczLbkv1K4TJb9fG520HCL9Ip3N7TmznSzg3sC89cJKE5utdz179QmR4JnP4f8ekJMrCD8Ca8oPQxrvAOjTb8SBJoypEp7JSC9KVrUeBRvOu0GThxPFYwKjIoHT193cnQxV9cWECdHUt5tSNTWaOgbULgfn9jls1gKFyljdI6orGlF0Ucvy/QXsT92sFV5TgiIKiB7ZOGkzDd5+tTKfGMcKBypIOF1fHJb3A/tO/Yl9XgXF4EVCI4S7NYhm7LsLal7i2qkI6/JKWe5r8PRJE1XJzYJ67yvBGFYtU75lO++/oDDAs1Uc/rgL4YOyTIa+kon5Bbev8SglGRRmw1y+supIuV1XxzmezDR0xozMvC06cBFo4WObqGATn66sWcvEgyOc1wIXdqbPUi+/C9VV0DxHZT9Ai0DBkSvIGd6W35KzUfpMuKDID2eZFSYlPlc3fOqmZFxJzZALFgKXqOShSE5lP1xOu668FHje/eWWFq5V4x3pAqiR5t7t+hk2xRpDPmpsbvjSws09YNdSqwqIC3Ee+DASzCu6eCgyP6bP+arMsa/RTHYDyxOU5dfshkrc8nl26sygsjRKMQE9EcXLmXA0TxzCC9UPr3vYSnO4gDe5WTd/DWc3Z2ronSk1XW8hQ3c3cOjLhCcU4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2071.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(110136005)(8676002)(8936002)(5660300002)(86362001)(76116006)(52536014)(64756008)(26005)(6506007)(7696005)(9686003)(53546011)(508600001)(33656002)(2906002)(66476007)(66556008)(66446008)(66946007)(55016003)(71200400001)(316002)(15974865002)(186003)(38070700005)(82960400001)(38100700002)(122000001)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?q78MCQhw3Z96Iw28V9+ox4qCBL+ULaBGfWI9wBteiiqhJ889b6VvqfTZOR5p?= =?us-ascii?Q?ygVtxjeLffzZ9CGKjaMgarK2/iFcGvlBDp5/hFtfPQplk+G1gZHsM3IqNooV?= =?us-ascii?Q?yGf5fberunJVSNMDmVvIVuCmG2DdGvbJbNXShYiL+7XpQtVOOm2lTUBrx4Dp?= =?us-ascii?Q?zSMUHxRwbcgbAkPSXl4v9ShYaQ2qUf8RlkCynMfDxcLLKkHT0yDJM3VQsXRT?= =?us-ascii?Q?gBpz2TJwuyeq4lCc6SavTtwOxFvoAnastCsRvLuNXehhgjNU85DPgGIKsj2n?= =?us-ascii?Q?OS+plCEutFMV7TF9wZRiDPilbvNkzwvLwEtYBZukDvS8XcCrPQYKRx4NNqPA?= =?us-ascii?Q?OtWIKPcxene7bpq3ByfBVHfB1v0QoKih3Fsll3S9mexbDpFO9K7YIx4Bhq4m?= =?us-ascii?Q?VEwuJNJqz7ncR5zbdeciB7UFx/rd/AD8DWt8rAEJUnqVsMxU1FjsG45D/rjg?= =?us-ascii?Q?TfsF7H+ahrCNA0E19VbjgvyAkiInwdFbfWNC//oNGhPKYewTKh48VcQPMTgd?= =?us-ascii?Q?iS24HHwBZ7rdbHmM8wTxOOapqiCrWMFU2Uhh3CScEwS4b914jqiucGOblNev?= =?us-ascii?Q?SLSS4QKty40T51q0V8RF6Y6XvhWyXpWXWM8sqkRZsmgQekYEenK+Z2unI4B5?= =?us-ascii?Q?uGXvENJO22o7IUwu1qPdKtfLVOUDlpudXn5d+3VY1FkLsxBr3QPMmt/RMo4T?= =?us-ascii?Q?NY3ulWABndKzeRvyGO6EEEowpEC6iKtzKfZrQ6CW6UpC7Q5xBYqRGobMw4nO?= =?us-ascii?Q?u3D7+dFJTDNblm5Zg80wP6T3yISBvz2bw3HdrCnBIEbFXsHbrGCzUgjd1lLI?= =?us-ascii?Q?gI6ZSjwZdJdP0RkJUPSRsNQxUcWRexynstjY/DSVj9zRA1kctqiruS+Ws7Aa?= =?us-ascii?Q?Vhth4wEhVZpsN7fCb3OkGTBy+OKhXszBLRoSnMoHAWCvrIIcFE/W2SAdhl2U?= =?us-ascii?Q?AbkXnAWWbB8GuBY5ZAoQ/GURFFfOhO0ZUKFqq8ALl5mkSYZrBz6pKi84ki0f?= =?us-ascii?Q?DNVFF/eIeFXzRc1I6GXRop/x6e0Pr/veU1vZVLN7sj6sw00dftzhe0SjS2Oz?= =?us-ascii?Q?u+5r3LXgpv069J1xYhfWqn1iRrniRQqmIB0mcBUyU9V+9JIXGf4WhVl4GI0T?= =?us-ascii?Q?BduaLjHc6ifcEb+3WPVw1L/DJuhHJ69vvLFn90F0b6uW8mPyLdScHs/rz9ud?= =?us-ascii?Q?Fm9gQfIVMVJ03k5aT/Fk9l2Y6nwi7uC9ldBLRSS8DArOlSwaUaoZENv91mu+?= =?us-ascii?Q?az9l7CxuRzrHiZ8VhGET3QKICK8vZC1mS+s8dG6pgUNLShE3W1/YHuC6hpCF?= =?us-ascii?Q?hPklgmQFwnQhwz41IKkBq0LOEJQx/ZBiP60i14jLvO1cHo1yrFCiAP3qCuPW?= =?us-ascii?Q?slWfCwPIMohf6tGpz9dXN56Fi/O4pmb4gXGljywJWcUjn9OFe+IAWTRKEYks?= =?us-ascii?Q?v6OXGlx9f0hbRczDZNu44V7FuhTqQxPWaoKgwaO2uEvuKTDQDG32doSGfFO6?= =?us-ascii?Q?uC/tF7WH7EBdETdVWNBMZzosrpo0eBOOYBw+NX5xH7IRMHHFMF8CpWrk33+I?= =?us-ascii?Q?bpfprJEzsXZNOdO96rZlAQzN0gaglF2onOZFF/7i5a278/bimjyOE3tA8n9x?= =?us-ascii?Q?3+ZgxBvsEoPqwrkFdEwPfaYByibAoenrqJ9cY+H54rCpb9LvU90dPlJpEPaB?= =?us-ascii?Q?nmplSfqT39rRkwphgICZdiobboJ0KOgfcDLXuluZgguoQtmWsZq/5HC+ylY9?= =?us-ascii?Q?HPPR9P978M5FV5ZlVSYRZxYNG20TLbg=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2071.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b239ad8d-b999-4fa2-4548-08da3d999152 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 15:25:00.3256 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: di5a6mEEgyIP9+HUl2J4xCwqQwIKqKsF6vwZ0DZoKzyr3H9Rmth7eSJEQ863fHDwbYQXHlkE5rJA5R9C5bqn4n0j+3F66mPbiJCI7xHdcM4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5871 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 May 2022 15:25:13 -0000 Ping > -----Original Message----- > From: Gdb-patches christian.kempke=3Dintel.com@sourceware.org> On Behalf Of Kempke, Nils- > Christian via Gdb-patches > Sent: Thursday, May 12, 2022 12:39 PM > To: Tom Tromey ; Nils-Christian Kempke via Gdb- > patches > Cc: jinisusan.george@amd.com; Bernhard Heckel > ; Tim Wiederhake > > Subject: RE: [PATCH v2 1/1] dwarf, fortran: add support for > DW_TAG_entry_point > = > > -----Original Message----- > > From: Tom Tromey > > Sent: Friday, April 15, 2022 5:28 PM > > To: Nils-Christian Kempke via Gdb-patches patches@sourceware.org> > > Cc: Kempke, Nils-Christian ; > > jinisusan.george@amd.com; Tim Wiederhake > ; > > Bernhard Heckel > > Subject: Re: [PATCH v2 1/1] dwarf, fortran: add support for > > DW_TAG_entry_point > > > > >>>>> Nils-Christian Kempke via Gdb-patches > patches@sourceware.org> writes: > > > > > diff --git a/gdb/dwarf2/abbrev.c b/gdb/dwarf2/abbrev.c > > > index 2db5ea15ac..3b47987a0e 100644 > > > --- a/gdb/dwarf2/abbrev.c > > > +++ b/gdb/dwarf2/abbrev.c > > > @@ -88,6 +88,7 @@ tag_interesting_for_index (dwarf_tag tag) > > > case DW_TAG_base_type: > > > case DW_TAG_class_type: > > > case DW_TAG_constant: > > > + case DW_TAG_entry_point: > > > case DW_TAG_enumeration_type: > > > case DW_TAG_enumerator: > > > case DW_TAG_imported_declaration: > > > > I wonder what happens if this is removed. > > > > If it's needed I suppose I would expect some other changes to the > > indexer. Like maybe cooked_indexer::index_dies has to handle it, or > > cooked_index_entry::matches(search_domain). > > > > Tom > = > Hi Tom, > = > So, I have tried this and without this line we'd loose the possibility to= do > do something like > = > gdb ./outputs/gdb.fortran/entry-point/entry-point > (gdb) b foo > Breakpoint 1 at 0x404202 ..., line 33. > = > Removing it would show > = > (gdb) b foo > Function "foo" not defined. > Make breakpoint pending on future shared library load? (y or [n]) n > = > I am honestly not quite sure about the two parts you pointed out. > What I think I understand it this: > = > In cooked_index_entry::matches(search_domain) we could add the > DW_TAG_entry_point to the FUNCTIONS_DOMAIN (similar to > DW_TAG_subroutine). Not sure if this would be wanted but I think > this is quite reasonable. Entry points are virtually like separate functi= ons > with their own argument lists. > = > I am not sure what this would actually change within GDB though - > commands > like 'info functions' and 'info module functions' > = > (gdb) info functions > All defined functions: > = > File .../entry-point.f90: > 33: void bar(INTEGER(4), INTEGER(4), INTEGER(4), INTEGER(4)); > 44: void foo(INTEGER(4), INTEGER(4), INTEGER(4), INTEGER(4)); > 50: void foobar(INTEGER(4)); > 19: void mod::MOD(void); > 20: void mod::mod_bar(void); > 25: void mod::mod_foo(void); > 59: void testentrypoint(void); > = > (gdb) info module functions > All functions in all modules: > = > Module "mod": > = > File .../entry-point.f90: > 19: void mod::MOD(void); > 20: void mod::mod_bar(void); > 25: void mod::mod_foo(void); > = > Seem to be ok without this as well. But maybe it still makes sense to add= it > here? > = > The other part you mentioned is cooked_indexer::index_dies. I think here > the > change you meant is to recurse the entry if it is a DW_TAG_entry_point? In > my > understanding this would then also index possibly interesting child DIEs, > right? > = > Here, I am not sure whether a DW_TAG_entry_point can even have > interesting > child dies. It will not possess any other > DW_TAG_entry_point/DW_TAG_subprogram > tags I think. So far I only know it can have DW_TAG_formal_parameter, > DW_TAG_unspecified_parameters and DW_TAG_common_inclusion. But I > guess > it would not hurt to also add it here and it might catch child entries th= at I do > not > think of right now. > = > I hope I understood this part correctly. > = > Currently, I am inclined to add the DW_TAG_entry_point to the functions > domain, > about the second change I am not quite sure (currently > DW_TAG_subprogram tags > are only recursed if the language is ada/fortran. > = > Thanks! > Nils > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928