From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by sourceware.org (Postfix) with ESMTPS id 048303858029 for ; Wed, 6 Jul 2022 15:31:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 048303858029 X-IronPort-AV: E=McAfee;i="6400,9594,10400"; a="284513720" X-IronPort-AV: E=Sophos;i="5.92,250,1650956400"; d="scan'208";a="284513720" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2022 08:30:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,250,1650956400"; d="scan'208";a="920207678" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga005.fm.intel.com with ESMTP; 06 Jul 2022 08:30:42 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 6 Jul 2022 08:30:41 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 6 Jul 2022 08:30:41 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 6 Jul 2022 08:30:41 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 6 Jul 2022 08:30:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X0QR4kLZ8D2Ou7OpYzhhMP+daCVb8m67yv0aXRep3SVPDUshJD9qocGJYjU9VaFqUCJG/t5ZqSZ2GPW/FuizHXF3j6X7JC76CqhNJNq75DCbN5PMrw4UGXt6tP5mEcY0BEucXemtzI2bAvpqYbNA2lPnZdPUcK89VcFw5AuPyksUX42WSwlvfvVfaM81CjGYJx6bDTtJNsxd1t3LCjW/AcaMoAqV3WcE7rFOTPtSGQcN+cWRk+QB/1aan2CyzKnCk1uof8sLLZXEwz05oSQLyHwnxW4YN2oJ7nvQBd16EScL+0kH+NQGQc+qTRI+5mNQ9TrZvnSMecVtqWXz37kzPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dxtw/I1gCnAppwFuw5bhkdknMfG1AQ/yAgjCUox1/ws=; b=ekWvadnb1107yW/5fymARAdP6oCYLlZBmpcUKBL070KGBFNm8nGqAnI59biaHvwyK5HiEAMAGv1nRlA5cxF+hVHIRvACDymsA/FgRXWnLo5ujbHX7oWNz+MUKZFlsK+WaJflEPDPRXfSllXJfkXbXd5qC/XcCEeXBP7Yd2Ic57yZrthcN+c3KmuINWYs3kfF8dFH775riJRtwUvyd6Jc+Jq4+dBauJfjAkJ2fYjjlJK4rfhZ/iODpfxBRvyTqtXPnQ+zqcIyOsz0K8xZcX1u0LpmpMGwC4GpjTfs7hjGf2GwAWcyxb3269QiS/ZTD2SGF+HeDZVyQnmvLK2hD7f9hA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY4PR1101MB2071.namprd11.prod.outlook.com (2603:10b6:910:1a::10) by BN9PR11MB5468.namprd11.prod.outlook.com (2603:10b6:408:101::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Wed, 6 Jul 2022 15:30:38 +0000 Received: from CY4PR1101MB2071.namprd11.prod.outlook.com ([fe80::b5b1:e930:177e:adc4]) by CY4PR1101MB2071.namprd11.prod.outlook.com ([fe80::b5b1:e930:177e:adc4%5]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 15:30:37 +0000 From: "Kempke, Nils-Christian" To: Tom Tromey , "Kempke, Nils-Christian via Gdb-patches" CC: "jinisusan.george@amd.com" , Bernhard Heckel , Tim Wiederhake Subject: RE: [PATCH v2 1/1] dwarf, fortran: add support for DW_TAG_entry_point Thread-Topic: [PATCH v2 1/1] dwarf, fortran: add support for DW_TAG_entry_point Thread-Index: AQHYT+PlYwi1BeSeQUyzdPLbJzVXa6zxGw1mgCoRBWCAFoIA5YA/9a0g Date: Wed, 6 Jul 2022 15:30:37 +0000 Message-ID: References: <20220414094108.2758482-1-nils-christian.kempke@intel.com> <20220414094108.2758482-2-nils-christian.kempke@intel.com> <87v8va1i4w.fsf@tromey.com> <87r14g6vus.fsf@tromey.com> In-Reply-To: <87r14g6vus.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 731d4b13-3159-4c8b-11e7-08da5f647a35 x-ms-traffictypediagnostic: BN9PR11MB5468:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BS8jDhClIgf63h0t5mvvH6X4WENVYP1VheEeZX3078v5ha1TGXFGJdhQsgVBkYB3yBTZkYBRL73gW6b/C3SiEQQdh5xPhPLlw7F6NXs+CXCdDrr0uJebtUGMLdEKXyVJA4GRcIky5at2XWMxbaa5s1fUjqdWEvhPvR0c18uEaFoZPIGoqZPyADBffykbF3tw5aiHxTec4q6i7MgkMb4bzUuu2u6aakhdbvSfl33FVgXt5NSdeV3rCeI96x83vJJHxdhp7RpqpHCCCHe3BYevzrQ1QmiShuAmJ/da/caMu7ceYBPOSM0LJUmwUXpCjecWQaoc3+/FvUJexDEGgWOMh2FuKZIhrmNHF2mTJCfmLyKbc32EvVYuE9HbDad6HSn7Q1Ux6VKum8LPTmNBNf0FYiucknfxj8Z6mAvVEmffYdFZqHbQaBPuQPwyjeyNLhFlUGvcDU+NRWQB137nl/Wa/80Pw52U2FAGafiy/CNlf1KZFvOno9P/GnR/AwZ++FmInK9hoOYooepQpKXt1vEHEjza82XGgII2N5QNxurLtF68Mw1e5xU1QOJXmFAGimiUSxh09DU+WPp6aQZrs0pp+u8ikf8RhXY963Zsk9Zz0PWNe4bZ5XaDC/9DzbcMOS0rD/y5cU0PfzmDEgFYzWrgi/bkxoSSFv4WPh6x9eEoHu6L/3zHl9j3lmNQ7Xs6Ma/XBx42kfge5nGeo7/Zhk6VQP5R/yUBcU4+iKPlIn3EjcLTwaybmqro0TMNMgGxLsZSgJ6vE2NYKShJxLt3ZaU0++z0zk16rNpK6d5reRwTjl63IMr4+5k4unKxCUd4S38j x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2071.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(376002)(39860400002)(396003)(346002)(366004)(8676002)(4326008)(66446008)(66556008)(76116006)(64756008)(478600001)(66476007)(38070700005)(186003)(53546011)(7696005)(6506007)(41300700001)(107886003)(66946007)(110136005)(82960400001)(9686003)(316002)(54906003)(83380400001)(86362001)(26005)(71200400001)(2906002)(38100700002)(8936002)(122000001)(5660300002)(55016003)(33656002)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?E43T2+QTiE8tfzffF8atZZ7k2a39FLnMwVnFFeF58XjvJSXXAaqGffPwH7ks?= =?us-ascii?Q?UDPVu/mo18aCXy8NM1HX3tNtPJFu6GbnPXHM/6N+BHzRIfHsMppa9Fv1tLhQ?= =?us-ascii?Q?YCi6PSKon1xjsOyqO6JdfbhfiLhTl8MKjaNVilR7KMH4MlcCEK39Tu48rPfv?= =?us-ascii?Q?A3/u5mIO5vqtk3tvXqn4V1DvMLoBM9bD8/KU1gPdOIb7s3K4YwekW6BalYa0?= =?us-ascii?Q?ebjjpFg4Ne2z11gWfztr2jYrFxWP1MOFfyXGzoqmSw1O9NcPV4ZlvGUT+DgE?= =?us-ascii?Q?txTy2MtvqE3lmqVNFfP/tX4f4sAPP9I2C1SctbiBa1coRBRtLN3zpnpJqJo0?= =?us-ascii?Q?rLffGC/25a+g7+y62ymrvG5+6QRI0abXIfcPNFkwfLtJZFQhnk0z97vnIVZS?= =?us-ascii?Q?xQ0XS7F0q7WE/mHWwZfKcnKvY14/FuWN5Tzz/Tx0R6s3a1i6o3z5OkTzuFeT?= =?us-ascii?Q?EgtVkIbMNcHFvgUd3UNjTb1afH4mc+suXkdVI58La4mBmfkLPaGOsgPofSYP?= =?us-ascii?Q?lK4Ak+rbbWugfyyrs1Wkc/pzJzNj1/cf2hXy9mBi07QNrW5x72yorFnJ2zl9?= =?us-ascii?Q?Dlj+yg7UFAdCYxBN8KCMzMN237rKmAm/IdFHMFVobYdbxq5XhdbMBP7xWZgM?= =?us-ascii?Q?2xbaQSaK/X5YvI1yf7tcakwj2UrzOPFU+9U25Vtn+/k4dt7F0QT4ncjFRcP3?= =?us-ascii?Q?NITldEtF1ezUJEKwf+QdIgglOhElpyTiK7ISn5hFIduhTy+2YfLiuTmBsbs6?= =?us-ascii?Q?X2j4GcX12llR98V2MzMla07QepIaV3tNUjvwhI6EbtOq9dQpxMcNBb+Ncu/i?= =?us-ascii?Q?bQPx7jkdPLUo7LluHQ+8UEaxF3gxALiCIiQ545vGSyhQSsZQHIbL7WhjsLT/?= =?us-ascii?Q?E7vnvem2k4B+vehkzfdhOUMExHDEVYENmwt3bYnIh0zA9XXIHn+3IgMOOpoH?= =?us-ascii?Q?3rpNJriq1nDlLeqofNa8qJlhbzss8gLlM0M/a3ex0O2AgMHQDYit3Ke2fUt7?= =?us-ascii?Q?2nGg0fVXFdG5VHZ/n5EXHBKoZpMP5Pny4FpgUUcw27OeVR5mmnuQ7nvEg1kd?= =?us-ascii?Q?ZeWKnflAlbCVf+/O0J7uhiCbU1KPRnqQDnm4KpK4Fqv4c19LnRRmQ3n7C138?= =?us-ascii?Q?dGWp1Dc+4atmln296xuWnrihPxx68/W9PzQIzkoxMN+a76wCCCYcVU110mwn?= =?us-ascii?Q?3AzFYR4yRspL5y6F0yHDyqxMosueAMhsRLjdnpfR0OKC4nGWyLwN+n3tCNFp?= =?us-ascii?Q?CYxdHEwfvNj1JehuSuVZm1ALVxQEQe2upNkR8sbmY2YhNgL2v7f1kY4wN5nF?= =?us-ascii?Q?TTLRA4GMXfYt2d2kgIc6/IfeWwsD1I85xMTk+TjcVFnoTj4tDY+Ijcq3EBXJ?= =?us-ascii?Q?eJXJejpRb3eDQV7KZKFNFEUteP46Qwr7t/YeCOeEiTuBvZM4R9ZmF1zbH678?= =?us-ascii?Q?5ZKt2hZU0Ndqb1EwBBqWgKn8XV7E04KvZ04APCvBUCbHU2NyZE0ybKX0XD3+?= =?us-ascii?Q?bB9QxCNoWl9bcpNOAvr344ESb8dkSHmLkq0JsOfHZ1+PqHc/V10Hi08zyHGe?= =?us-ascii?Q?OdSY9lpzOD7g/KB8/lSC8Df+DmYGEcpPBfNclHPwCz13hbOJyfaT6GPpFnmK?= =?us-ascii?Q?3w=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2071.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 731d4b13-3159-4c8b-11e7-08da5f647a35 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jul 2022 15:30:37.7544 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ksdMhbA47Sju3+c4ugVXxkyqLcfCZpgD2g8fVk7mt+PzNNGsyX+w1/awj87zlM4mV7JhRrddQhfcmYUhjwR0MV9v5tqhhBlYpwiTYz0mEug= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5468 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_STOCKGEN, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jul 2022 15:31:09 -0000 > -----Original Message----- > From: Tom Tromey > Sent: Thursday, May 26, 2022 7:35 PM > To: Kempke, Nils-Christian via Gdb-patches > Cc: Tom Tromey ; Kempke, Nils-Christian christian.kempke@intel.com>; jinisusan.george@amd.com; Bernhard Heckel > ; Tim Wiederhake > > Subject: Re: [PATCH v2 1/1] dwarf, fortran: add support for > DW_TAG_entry_point > = > >>>>> Kempke, Nils-Christian via Gdb-patches patches@sourceware.org> writes: > = > >> If it's needed I suppose I would expect some other changes to the > >> indexer. Like maybe cooked_indexer::index_dies has to handle it, or > >> cooked_index_entry::matches(search_domain). > = > > I am honestly not quite sure about the two parts you pointed out. > > What I think I understand it this: > = > > In cooked_index_entry::matches(search_domain) we could add the > > DW_TAG_entry_point to the FUNCTIONS_DOMAIN (similar to > > DW_TAG_subroutine). Not sure if this would be wanted but I think > > this is quite reasonable. Entry points are virtually like separate func= tions > > with their own argument lists. > = > > I am not sure what this would actually change within GDB though - > commands > > like 'info functions' and 'info module functions' > = > The test case in this situation is to have an entry point in some other > CU -- not the same one with the program's "main" -- and then try to > "break" on the entry point. > = > I think this should make gdb try to look up the function via the index, > but since the matching will fail, I suspect it won't cause CU expansion, > and so the entry point won't be found. > = > > The other part you mentioned is cooked_indexer::index_dies. I think here > the > > change you meant is to recurse the entry if it is a DW_TAG_entry_point?= In > my > > understanding this would then also index possibly interesting child DIE= s, > right? > = > Yeah, I think I was mistaken about this one. > = > thanks, > Tom Hi Tom, It took me a while but now: yes, you are right - when compiling (with ifort= ) e.g. a static library containing an entry point, linking it and trying to break = on the entry point the symbol lookup fails as the symtab is not created. I added the entry_point to the FUNCTIONS_DOMAIN now and also found another place where I probably had missed to add DW_TAG_entry_point. In write_cooked_index I added it to the GDB_INDEX_SYMBOL_KIND_FUNCTION. I adapted the testcase and added a second cu to the DWARF testing the looku= p of the entry_point. I'll send a v3 soon with these changes. Thanks, Nils Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928