RE: [PATCH 4/4] gdb/fortran: Fix sizeof intrinsic for Fortran

["Kempke, Nils-Christian" <nils-christian.kempke@intel.com>]

> -----Original Message-----
> From: Simon Marchi <simark@simark.ca>
> Sent: Monday, September 26, 2022 7:07 PM
> To: Kempke, Nils-Christian <nils-christian.kempke@intel.com>; gdb-
> patches@sourceware.org
> Cc: tom@tromey.com
> Subject: Re: [PATCH 4/4] gdb/fortran: Fix sizeof intrinsic for Fortran
> 
> 
> 
> On 2022-09-20 03:26, Nils-Christian Kempke via Gdb-patches wrote:
> > The sizeof operator in Fortran behaves differently from e.g. C/Cpp in
> > that it can be applied to pointers.  We thus dereference pointers before
> > evaluating their size.  A test has been added for the Fortran sizeof
> > operator.
> > ---
> >  gdb/eval.c                           |   3 +
> >  gdb/testsuite/gdb.fortran/sizeof.exp | 110
> +++++++++++++++++++++++++++
> >  gdb/testsuite/gdb.fortran/sizeof.f90 | 108
> ++++++++++++++++++++++++++
> >  3 files changed, 221 insertions(+)
> >  create mode 100644 gdb/testsuite/gdb.fortran/sizeof.exp
> >  create mode 100644 gdb/testsuite/gdb.fortran/sizeof.f90
> >
> > diff --git a/gdb/eval.c b/gdb/eval.c
> > index ce1d883aa86..bb6b757d452 100644
> > --- a/gdb/eval.c
> > +++ b/gdb/eval.c
> > @@ -2730,6 +2730,9 @@ evaluate_subexp_for_sizeof_base (struct
> expression *exp, struct type *type)
> >    if (exp->language_defn->la_language == language_cplus
> >        && (TYPE_IS_REFERENCE (type)))
> >      type = check_typedef (TYPE_TARGET_TYPE (type));
> > +  else if (exp->language_defn->la_language == language_fortran
> > +	   && type->code () == TYPE_CODE_PTR)
> > +    type = check_typedef (TYPE_TARGET_TYPE (type));
> 
> Do you need yo handle TYPE_CODE_REF for fortran too?

I believe no - there is not concept for references in Fortran and such
a type having a TYPE_CODE_REF in Fortran would seem quite unexpected.

Nils
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928