From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by sourceware.org (Postfix) with ESMTPS id 0F0233858C74 for ; Wed, 9 Mar 2022 17:08:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0F0233858C74 X-IronPort-AV: E=McAfee;i="6200,9189,10281"; a="341462115" X-IronPort-AV: E=Sophos;i="5.90,167,1643702400"; d="scan'208";a="341462115" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2022 09:01:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,167,1643702400"; d="scan'208";a="510555309" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga002.jf.intel.com with ESMTP; 09 Mar 2022 09:01:11 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 9 Mar 2022 09:01:11 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Wed, 9 Mar 2022 09:01:11 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Wed, 9 Mar 2022 09:01:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E9SNb2PL/8E9db1wfujMv5mUoXigUxPmOF3uQr5zXcBalO8wfVFRqY/SnAjursQpylSpIZ+6yKy7zRlyZuh0lrjB/wHSIYt40nKckVi3q+FAnWsaGev/t8YpvZe3y3evi51JJVqPjLPZmUN6+M5oWN7eEfeHGqR5JE/NyOq5z4GuUOZVkO1ON+8hoqtBQW4sQanBpYEhW4Gi5AA36M88wnwaKRlv6rTYAMU6aNZbVVv3jxsiYQiUvSB5tToRSnMbiMdEWTy82k1FDKej/zaxkEADG91MBLEyhM23dGhgcePtYbpEwUnKBCjNQi+auBsz8qK4gHcebbhwDjWF6v2gvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VUu453T3mx0pnpT3ljhhvSEw0MWea8QaRGg8SHlBLXA=; b=QnKpLqRQk6kjmAoXbzNkeGx+xlxRoq/ZSeYNCj3C4VIS28xuGY90cvkwmHoIRlucbBD9Pxmz/+f+PPV78lwXIjZvq5yL+SVB0CZvQKbg/ReSEcpffIJMImFgQ52KCsqU4swftepLxsB/2YZ2nrZr+EFiuS8CQhfvhEpoMQ357jVlv02D39EP2LlEBGBBldVHFdogP1WSX0oE3XQMnD7klvFYTGxF/U2UQouKmiXQ5IJjE1+2xQ+Zv1U/AcDps2PUaP7e/x4T/Q2QQVdAB8qBqO5bspavTJiDVAJJnuTmjANXnzDpJwUPQ5DtbFsDsCZzeiKSkcPAJmPsbKT6XeuQmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY4PR1101MB2071.namprd11.prod.outlook.com (2603:10b6:910:1a::10) by DM8PR11MB5640.namprd11.prod.outlook.com (2603:10b6:8:3f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.17; Wed, 9 Mar 2022 17:01:08 +0000 Received: from CY4PR1101MB2071.namprd11.prod.outlook.com ([fe80::ecc8:4cf5:3f52:24c6]) by CY4PR1101MB2071.namprd11.prod.outlook.com ([fe80::ecc8:4cf5:3f52:24c6%12]) with mapi id 15.20.5038.027; Wed, 9 Mar 2022 17:01:08 +0000 From: "Kempke, Nils-Christian" To: Eli Zaretskii CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 11/11] gdb/doc: add section about fortran intrinsic functions and types Thread-Topic: [PATCH 11/11] gdb/doc: add section about fortran intrinsic functions and types Thread-Index: AQHYM6IXa7Jv/PvXQU6+2x3R4ekD26y3ASdOgABFufA= Date: Wed, 9 Mar 2022 17:01:08 +0000 Message-ID: References: <20220309103922.3257803-1-nils-christian.kempke@intel.com> <20220309103922.3257803-12-nils-christian.kempke@intel.com> <83y21je1fe.fsf@gnu.org> In-Reply-To: <83y21je1fe.fsf@gnu.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d5ab6d41-cfaf-43d1-4028-08da01ee67d1 x-ms-traffictypediagnostic: DM8PR11MB5640:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Uvts/w3LkbUTqXvlKov3OBbnSZOPuMO/zANS1tbagVERxdtjAAI56luM4lscxs5UMonuIe4pXjkPhL7fGX8hpZJfpYtDiXYVHjBK7bmFzPf2oRiSraKgbUslI1rN7AgZ7xLIxgGRFWxGpjYZ+kvEgOE0ojbJJOztTCqtlzLZB2HEYiBsmByJ/6s8ywH6K3W1Qwhn9fusQbclQdW570xfJfVGufR8rGmGdkpHDluDTno8VraRPwQUY8OaCrSKxBJrjeID7GWbSPiJS+wGF1j12oNWVePPvLxo+pOVNAw4DPIcR9yHy0UcR50exmr5eIEYq50Y4lltwr6WU3lY62hxSMnMeJwZ99TDpIyE1yg2bOJxWiyzOEicwBajXab9STfZsDRMzyxykBy+qhPT6d+MzHB3Kf2v3qdJgjVWC05fZtKQ/mooB49vvxbQ1rcowdN/ze/zgNfrd2T3GyGNtlFdA4/pkyporR6J0pYHhDoo+OPv9+6EmzDho8AvJKOGcimtP8s9Dd1GwTcctHGw4Z+ZnDw5Gz7Gmnd1RP6Ww9TqwZgQma3pdLMAMIbl8uOYHUETzRKHmEyJv+gdjWZi8phNUb/tfQn70Sr+bbZ/5E5YkrOZgI3kE4VXkFP3a3ZaMOkRlEjIII2EARCxjyawtN4gB3sOjKOLQF/UYn02M8Na8u4zVr87vf1jsNOzVcs5r5cr1yNyn0WepQF26suD9APAVg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2071.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(86362001)(508600001)(38070700005)(83380400001)(186003)(71200400001)(55016003)(9686003)(53546011)(6506007)(7696005)(82960400001)(2906002)(4326008)(52536014)(66446008)(5660300002)(76116006)(33656002)(66476007)(8676002)(64756008)(66556008)(66946007)(316002)(38100700002)(122000001)(8936002)(6916009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?d+LcOCf2+5La1fKpOMnwA+pPWT0nVGXodtV7SJTaJcz2zOrbop2RRlBvHRXA?= =?us-ascii?Q?W5qgE+FZeTWjHUEMTW0h3hggmijNpamD0ro65wjyXogwDfxKmgU8x4/rLNhT?= =?us-ascii?Q?ENwdwVWuwzPha8b6fZ64KJxKDlVc4w9HI4FDC2lRRoq6vB0hixBbwU8aCez6?= =?us-ascii?Q?uu3YeNhjbqngt3bmeFRnGx0ZQa8PxbdXNRZ6qr4SfGvM8eUHVbasOM0M8kkM?= =?us-ascii?Q?xqBtwc5wDKMZXNU9xr3dvmKG+2qAVrfEemvuArYv3wNmdSjc3cl6BQY7K/SK?= =?us-ascii?Q?TvIYS1wskY75+j8+JvDKH6ER0ATBQwznExQ59KZm2su8jf/E633DRiluVl4e?= =?us-ascii?Q?AUYnXpIHXIDqzSh9xNG2s4nAeX+isk1OCzZ+dnl74EkMtR923PWyFcVmhRt3?= =?us-ascii?Q?+4tcCbwdtmz//L0vkcUV8pVqytFJXo8R5NtTMCcc+9q+kNlgR1FNYjTDazdl?= =?us-ascii?Q?UJ5M3meUUWovwQND1mGfhbxKzfSxWI9jtmtd3F+uh9mW1we8icSGi5xFZjVi?= =?us-ascii?Q?/GqTR6rrgPc4DiRzuKNzyEsJ5uLdOGKApo52oA0fE54l2ZD8wf8UN1Mz9Uk8?= =?us-ascii?Q?XxqZ77aae6jL+KmhAcHoyqauQg2fb4V59CZZfhptpX1pLj4fkDdGbF8eaRDk?= =?us-ascii?Q?T7E6GlUvfRL9iSRw4cqD/a1ZNlGHIYKbO0rBeo3rwMksPOEznDCzSM/Y1P9I?= =?us-ascii?Q?xin3DHUc7rjKYs3LN35tvNSh/fAwQJcb7JyfDBTgzC6W4xnMF69at3QdYood?= =?us-ascii?Q?fcZbku/LsMMs+tgdIh8RVTRxHb1RgvhogA9edg2gyxd89hZqGiueLss6gV2d?= =?us-ascii?Q?Btp+0/jihi6ElvPgN4HhgKvj4gNb47+H4tKA1V8tfa3qE+sBb1wziNnjp7fy?= =?us-ascii?Q?H3a1I7H62TmSwZT9osL+RCjqdtGmBhMa+NXKN/CigSatgtOD9EtIKI/lIaEd?= =?us-ascii?Q?ij820Ygut48CaSfZIHEQVq369ohc3F/1divrd/QHYOOOBKf8h/3FYC5t+9tw?= =?us-ascii?Q?IbpRr14lm57yfPY6LGVHRUXgdNE4JSY0PJ7rJioGRaNhOyI5MbWUdfkgZd5E?= =?us-ascii?Q?KRRr7zcMJ81nSPb0t90xwcz1VWe86s5QFIvNcgjsZusEvHMTJn3wl1fHffcq?= =?us-ascii?Q?cEkEvb+cRKJcGC1r24hSWxAO4gvfnGHxGc9Vlm9y/K9SuAuXgIiLbnIrT1rz?= =?us-ascii?Q?5quqldmgvUbvTu0jUGcrrnu4gtqcEIdHnt55Ow9INcOL2pI/HhIcplUK648B?= =?us-ascii?Q?r7tp3b4NWiamF0KOCtXlzsS/oKcI/tUq2NmE6IDxK2kX9yp+up7uu+8SkARM?= =?us-ascii?Q?Hvvz+gF9a/eYoxQ99hwz55t1+YS1iVoihloj0AlWi38sVSaA4AA9FmZ6/S6p?= =?us-ascii?Q?arnBg6BY2JEvjTNzB5Y3S04PKcwXzEzkNfaPUGo0VzC+tp2wIoyqIDIe0h8u?= =?us-ascii?Q?D0BCvbb4VhZVbc8+MsUB8vHFKXV7NEr1fVYTG0CJYeIdcRF7CoRjeUfkXaRM?= =?us-ascii?Q?fCr7SEOQjbYMbQIVAv77kBuVrAOAI8puygRIAk0jCJUwTFnPKB6rtPjfDzsO?= =?us-ascii?Q?24axZ7MBXkz5iyXzRKibtJ7j/X2DMU3D9y3OsMDoqHZbx764yfI5Ip+oUOfy?= =?us-ascii?Q?FS+zS8MrcGtkP4GW7jUBk/gIG59yCtRuuHsJcz0b6n9CY0+JGxJssvEp8E9y?= =?us-ascii?Q?/BnunAEeL8DhrJ/OCYd71ijHZJuzCCRsvdjkM1u9hXHIUwVIpUSqQxaFOMH+?= =?us-ascii?Q?8l2iiAmabA=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2071.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5ab6d41-cfaf-43d1-4028-08da01ee67d1 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2022 17:01:08.1019 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OQ2Y4DI+jicHw98kT7eWEA1Gcifl4V7IcbdU6pOmif9dAUsp4iSpw6yd3h+9qy9HEIufshhR2rklZ0PPdFEtGU6LnOV5WVfQ7Bul8hmeiFY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5640 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2022 17:08:19 -0000 Hi Eli, Yes I see, sorry for that, thanks! I'll update this locally and wait for a review on the rest of the patch before sending it as V2. -Nils > -----Original Message----- > From: Eli Zaretskii > Sent: Wednesday, March 9, 2022 1:49 PM > To: Kempke, Nils-Christian > Cc: gdb-patches@sourceware.org > Subject: Re: [PATCH 11/11] gdb/doc: add section about fortran intrinsic > functions and types > = > > Date: Wed, 9 Mar 2022 11:39:22 +0100 > > From: Nils-Christian Kempke via Gdb-patches patches@sourceware.org> > > > > The earlier version of this document had no sections about the > > available Fortran intrinsic functions or the Fortran builtin types. > > > > I added two sections 'Fortran intrinsics' and 'Fortran types' to > > document the available Fortran language features. > = > Thanks, see some comments below, mostly about markup. > = > > +In Fortran the primitive data-types have an associated KIND type > parameter, > > +written as 'TYPE*KINDPARAM', 'TYPE(KIND=3DKINDPARAM)', or in the > > +@value{GDBN}-only dialect 'TYPE_KINDPARAM'. A concrete example > would be > > +'REAL*4', 'REAL(KIND=3D4)', and 'REAL_4'. The kind of a type can be > retrieved by > > +using the intrinsic function KIND(), see @ref{Fortran Intrinsics}. > = > Some of the words you wrote in CAPS are actually meta-syntactic > variables, i.e. they aren't literal symbols, but rather stand for some > symbol. Those should have the @var markup in Texinfo, and should be > spelled in lower-case letter. In this case, I think the correct > markup will be this: > = > In Fortran the primitive data-types have an associated @code{KIND} > type parameter, written as @samp{@var{type}*@var{kindparam}}, > @samp{@var{type}(KIND=3D@var{kindparam})}, or in the @value{GDBN}- > only > dialect @samp{@var{type}_@var{kindparam}}. A concrete example would > be @samp{REAL*4}, @samp{REAL(KIND=3D4)}, and @samp{REAL_4}. The > kind > of a type can be retrieved by using the intrinsic function @code{KIND}, > see @ref{Fortran Intrinsics}. > = > The above also fixes other issues with markup: > = > . use @samp instead of manual quoting 'like this' > . use @code{funcname} instead of funcname() to reference to a > function (the latter looks like a call to the function with no > arguments, which is not what you meant) > = > Please make such fixes elsewhere in the patch, there are other such > places. > = > > +Generally, the actual implementation of the KIND type parameter is > compiler > > +specific. In @value{GDBN} the kind parameter is implemented in > accordance to > > +its use in the @sc{gnu} gfortran compiler. Here, the kind parameter f= or a > > +given TYPE specifies its size in memory - a Fortran Integer*4 or > > +Integer(kind=3D4) would be an integer type occupying 4 bytes of > > memory. > = > Since "Integer*4" and Integer(kind=3D4) are literal pieces of code > (AFAIU), they should be in @code. > = > > An > > +exception to this rule is the COMPLEX type for which the kind of the t= ype > > +does not specify its entire size, but the size of each of the two REAL= 's it is > > +composed of. A COMPLEX*4 would thus consist of two REAL*4s and > occupy 8 bytes > > +of memory. > = > Same here with the other data types. > = > > +note, that the @sc{gnu} default types can actually be changed by compi= ler > flags > > +such as '-fdefault-integer-8' and '-fdefault-real-8'. > = > Instead of quoting command-line options by hand, please use the > @option markup. > = > > +Computes the absolut value of its operand A. Currently not supported = for > ^^^^^^^ > Typo: should be "absolute". Also, I thing "argument" is better than > "operand" here. > = > "A" should be @var{a}, according to the same methodology as explained > above. > = > > +@item ALLOCATE(ARRAY) > > +Returns whether ARRAY is allocated or not. > = > @var{array} > = > > +@item ASSOCIATED(POINTER [, TARGET]) > > +Returns the association status of the pointer POINTER or if TARGET is > present > > +whether POINTER is associated with the target TARGET. > = > POINTER and TARGET should b @var{pointer} and @var{target}. > = > Same in other similar situations in your patch. > = > > +@item CMPLX(X [, Y [, KIND]]) > > +Returns a complex number where X is converted to the real component. > If Y is > > +present it is converted to the imaginary component. If Y is not prese= nt > then > > +the imaginary component is set to 0.0 except if X itself is of COMPLEX > type. > > +The optional parameter KIND specifies the kind of the return type > > +COMPLEX(KIND). > = > "0.0" should be in @code. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928