From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by sourceware.org (Postfix) with ESMTPS id 260823858C54 for ; Wed, 7 Jun 2023 12:20:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 260823858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686140409; x=1717676409; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=S+hXVBf15UCBnNHUY8Og2QpGHWjpfHA9yI2EujMLhZE=; b=gKK3GNl05Aon3hOE3JJMis2CTQR0S+tBq3CHBg3tvk1TkrJLOLpVExO+ Epv4+2E0lW1DPVhvsH9Joy/cHigHPvtLrNivsJqbuaZueqRUcWBeXGxEt e+r8EXiZr6O17ETxMd8nc6PUxfL7K9P7G+2fytwQuGokdd2Njg/A5I2Tj W936B7joAXciCkwWcUtMTHumv+CtUB/EBOco9ij9Y/WrbI4ZcjvuswurD xc1hCNFPQVquVACgMYfSfjY091cKm6AdCKV2CXB0M7j/55JLw4OM5+9ds NVgaQ/fFnyouXAz5fzPLilwgNLet15wwgM/XTgqpOFY3xKbYzyx/Z604g w==; X-IronPort-AV: E=McAfee;i="6600,9927,10733"; a="360297926" X-IronPort-AV: E=Sophos;i="6.00,224,1681196400"; d="scan'208";a="360297926" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2023 05:20:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10733"; a="739231520" X-IronPort-AV: E=Sophos;i="6.00,224,1681196400"; d="scan'208";a="739231520" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 07 Jun 2023 05:20:06 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 7 Jun 2023 05:20:07 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 7 Jun 2023 05:20:07 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 7 Jun 2023 05:20:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OHrkKWooaxergxiwIv3EvMLcE63amVpF8pBRLrau5E2KW82jL80EuGejifNmFt4ZA7+31nitRx6DsUa3i7WCnik6Lvwb0cK/S3ROBkfQo+2tj9v4dtX9xxtI6iu5+OCmj20bxdkhbJOeIkUYKgQf1ly4CyTxH/rugMnI8p3y/AyRJQO2FkI1UF7uns4uUcXy15pSVU80K6wD91Bxs/jD8XGrRHpg8OzlEygy8oma7HWuQeMlQfT4UJgY7B2nMe6ddyaxWtehu+rFdyNfpfT0dIG9g2F4DmU+3j2ZWfEuB+u2rPdKN2CbhkijDGeiHLhC5aKVFJ5JPW1UojDmUdLZxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=40086sPT9nEdLt3LuJuYnnWmtMzG3M8GdmMLMP/arSA=; b=iSO+jq7Z/jM2CErG+/BuWRHRsS0kAMlVFdtds7xDzpWHQnWRpzeqht4dzJorQJJ62Y7ajq6oNNH5RXBDNg5BcLjjTWPSvL1HiCsUKeXTlnIDf50YbOKtiUjLg3VvFSR6xT30MawPFKx37VuLOTjpM3diUgxS6aevOMjpERz/gd0s6G55iuBA0Q5L3cxkbJE86fFuDoTf35NNj0iAcSV7LCsNmQ7jDROvnOOzVrPSS1BnN7qpqEzKya6YBYgC6yGbKKfsmKVMZGM5GJLdOiECUoK48rwGeeDFOib6/tm49xdiQ+joCeOZ1xxV33fUVA+8HG2nh7hbal6vx9CvDdifLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY4PR11MB2005.namprd11.prod.outlook.com (2603:10b6:903:2e::18) by CH3PR11MB8413.namprd11.prod.outlook.com (2603:10b6:610:170::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Wed, 7 Jun 2023 12:20:05 +0000 Received: from CY4PR11MB2005.namprd11.prod.outlook.com ([fe80::b405:9025:f19c:90c1]) by CY4PR11MB2005.namprd11.prod.outlook.com ([fe80::b405:9025:f19c:90c1%5]) with mapi id 15.20.6455.030; Wed, 7 Jun 2023 12:20:05 +0000 From: "Schimpe, Christina" To: Andrew Burgess , "gdb-patches@sourceware.org" CC: "eliz@gnu.org" , "simark@simark.ca" Subject: RE: [PATCH v4 1/1] gdb, breakpoint: add breakpoint location debugging logs Thread-Topic: [PATCH v4 1/1] gdb, breakpoint: add breakpoint location debugging logs Thread-Index: AQHZlKcTnrgEMEf0oUyiCEgZ+6oHKq9/D5QAgAA5HmA= Date: Wed, 7 Jun 2023 12:20:04 +0000 Message-ID: References: <20230601163345.3895525-1-christina.schimpe@intel.com> <20230601163345.3895525-2-christina.schimpe@intel.com> <87a5xb3bk9.fsf@redhat.com> In-Reply-To: <87a5xb3bk9.fsf@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CY4PR11MB2005:EE_|CH3PR11MB8413:EE_ x-ms-office365-filtering-correlation-id: 6fbe9c43-0046-4335-dbd8-08db6751866c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: T5qVx4tP7EHvA+W7SEr+ZAvFi8Ab7ZMht5hKZnVZMXXf8vrpzVVnXAJ5h4EHX/AUUaB21XxFq/3vQGSjqZ9GfdwXx8PhltRmbSLttm/A+9oqCpKijiXDTucVr8zBGLJZpO6JEIcnufGxvXcAV8WJCfB3SjU2BrxzcwHTIq9k3PT2qoVoj22w5TUBzuv91ftHSW8pDuI6sXn7OIb3Wwh75hcsLD74+Y5jj3HqOhUJD3z9XRJ5/ZIcIqkwmyIIGvNy54ssSORAS5kdnQ87nMoNo7JPGsroWsrSYmTy9oBNTCdxRK5zXeUUskKrsBSqMie1Ve5LjB4xTtGN7jvRdyxIzNKDh5cWKyGQCHkjbSW2qMAQTFNar4RCwGzub3esUEdcHULIY+YaK0wSopd6e+MxmAIky+O+E4m1APCDDcdrJMfxuM5uoOwFbcbCllA6uRaCIDQQzNdpLsvvPGcpWX84pl2yNntFz2y3RZooFpHWNQLYoEFKrNJ1HgNwLf1dF42bGU3UsURuIDFoMTfCr1EBAElGSbKOj5mA1g0IgX32Ix9T5dtun/ftjehGlqrjaVjjLZE/5XSXVCue0b0C+VA7ZuIUuJwnkSeg6rz7v4kqGVV2m0H6ortDYUnmms9R4Xaq x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB2005.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(346002)(376002)(136003)(39860400002)(396003)(451199021)(55016003)(7696005)(54906003)(110136005)(478600001)(82960400001)(316002)(8676002)(8936002)(41300700001)(66446008)(76116006)(64756008)(38100700002)(66946007)(4326008)(66476007)(122000001)(66556008)(186003)(71200400001)(26005)(6506007)(9686003)(86362001)(52536014)(5660300002)(38070700005)(2906002)(4744005)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3Ib0SCFlffj8UH9+gj2tJqckWknuqG34GrfbBa1eW7RtpzkwtY0h6ZC9KvQ9?= =?us-ascii?Q?Rc7lBbhE/0Mf/uABREk9gnEYHkU9uPrZLvb0szFiUOuPbca0GdhaEoVQcDXp?= =?us-ascii?Q?oAivtH/Wn9pRWtfp3DgUSeDHUF2FuGmkehCRThK5d22KtWPDxTXdZyuVhZGi?= =?us-ascii?Q?6ul12pIfMOYpFNRwxfwS1qPV6pQ9HAcpNK+DAMIMLtVfgr/OLFjGaIUC43im?= =?us-ascii?Q?gArYOCWZ2bp6vhF+UMnvOlxICY7qHgRKNavXz067Gi3I8U0UqWD6RxkEf2LK?= =?us-ascii?Q?4n2P1YVtZpmdpAQdF+igkoLKeXUu/Y8momGc0l0eJJWsP2iTunasn15DMZKF?= =?us-ascii?Q?3dkIJtS3qapVG9pTOmfMyMrSmCc8IWxyYXT2NdKNnr/dNKIDl7VQU4pkcR11?= =?us-ascii?Q?cPdgApYrU+L0ZZuBaFcZp1jaVGZW709161THC8iIWOZ8W91VEirpfIL6XxBH?= =?us-ascii?Q?ZmwebAZF7ZXr5uwAN7Y6AHlweG6C4/fjJoy+yu96P42UEgg+fa5f0o4N83A7?= =?us-ascii?Q?N3VkIbG1K6X6P2c7MROyaa4vSRiyvPEFuMXWEDo0NFERzEpKMBhAGUuN5ndk?= =?us-ascii?Q?BC8mYnHiKfbY9lOCGOq28VjuXzj1+SQarhMNfU8VBnShxbE4y6x4cje7ANAP?= =?us-ascii?Q?lgQp5/4a0QfFdFsl6QfnpXgAnV52gbJnlgmjJE+a4UY2hgAt5EPqKWrbjv9B?= =?us-ascii?Q?uTWv+sYswBQr9rMJf9xPjo6DKW7Zks8qKflH1AnBEK6bNntBI0pLdf91NhRX?= =?us-ascii?Q?Ar6o4+4cIVLEzKtAubSNJdjOpDy4CEL0x4LwuUxJ+p+1Lw73bi1e+GYm/6Tn?= =?us-ascii?Q?t5kgKYA15V8Al5FO8rR2WlOPUVVErhsayOnnIZnB9uFhZU3f5oThGwbD99mT?= =?us-ascii?Q?5habT75oAc7o3X6ICPb+sRGJRvik2jPg0OeRN/HvQI3aqbWguHGh2tCrmUz0?= =?us-ascii?Q?QLVvT84ctq/oRSgtGdxwFu5ea/9PEX3T0Z5MWbXEQFm+FAp4bVYWhnEkiKGz?= =?us-ascii?Q?C6McUuboGOzlSaa7MGmmRmNOWQAL9oETD5A4Zyx1rtA33gBJ71WTg2CdMjfy?= =?us-ascii?Q?XiX/iziszfkx3+JoO9XySf4PG0f6aQYvqM5n29JnURfCeUQYo+fvNBP1kHqc?= =?us-ascii?Q?0qHvv2uOSfzF3UXMPITDxJihNuQB9WnU0zJuV+wFF0HYYNjC5HBecIhhKS2Y?= =?us-ascii?Q?fr2XiAGFesHx3voH4fREgQ1rHyaSts3q8pJ9ZgdY3rB07DMLcdN1cyyzyAvJ?= =?us-ascii?Q?heoiFrWSL/FvcSAwpMh40oW57wSrLJGLsGHzVv2/psXQJCHcijjl8E+dLc3c?= =?us-ascii?Q?s4y+8IN0Q8eeDF7otR+rpBx1GTNr9u//42CrUsXoUScdVdCE0O2T+fIRVoME?= =?us-ascii?Q?tUL3xYDNTd2sLdpkt0EbFGiYwLLXtCOaPPejd1Ch9JoeFXTeUJsxnmsvmfDd?= =?us-ascii?Q?wCtQ8RxFOqiqZuCvyC7dzp22Ac1VZJstQDcyiz773r6qSQjFnkPfTytAMnJ5?= =?us-ascii?Q?114Mcsb3k3/m+wvHai5w0tYfvv8bKmIKXo9dS8kRRAQBS4sQFH8kjyD2HzdB?= =?us-ascii?Q?nbxzsF/WREZUqfQg2kvK9GR2K5i9uvf92NFEQa9hKYkiLaek5pKPiWSjn78A?= =?us-ascii?Q?mA=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB2005.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6fbe9c43-0046-4335-dbd8-08db6751866c X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2023 12:20:04.8336 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 69w5QdY/zAlYf1ZM92Q9azBl66HNjfnhC4jEL20CAXOeM7fVkzFPtQ+vD1+PPIJZTP4PkMt9f5Tc6syQcQqAK/LJppVAHdvZR/EvJ8MxckA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8413 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Andrew, = Thanks a lot for your review. = I only have one small question, else I agree with all of your feedback. > > + > > +static std::string > > +breakpoint_location_address_str (const bp_location* bl) { > > + std::string str =3D string_printf ("Breakpoint %d, location (%s) at = address %s", > > + bl->owner->number, > > + host_address_to_string (bl), > > + paddress (bl->gdbarch, bl->address)); > = > I can't help but think using 'location' in this string is a bad idea, 'lo= cation' already > has a meaning for GDB breakpoints. How about just dropping the work > 'location'? Just to be sure that I understand correctly - do you suggest dropping the w= ord 'location' in string_printf as follows: static std::string breakpoint_location_address_str (const bp_location* bl) { std::string str =3D string_printf ("Breakpoint %d (%s) at address %s", bl->owner->number, host_address_to_string (bl), paddress (bl->gdbarch, bl->address)); This would be fine for me. Best Regards, Christina Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928