From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by sourceware.org (Postfix) with ESMTPS id B8E203858403 for ; Tue, 1 Mar 2022 07:54:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B8E203858403 X-IronPort-AV: E=McAfee;i="6200,9189,10272"; a="339513386" X-IronPort-AV: E=Sophos;i="5.90,145,1643702400"; d="scan'208";a="339513386" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2022 23:54:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,145,1643702400"; d="scan'208";a="804435220" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 28 Feb 2022 23:54:28 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 28 Feb 2022 23:54:28 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Mon, 28 Feb 2022 23:54:28 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 28 Feb 2022 23:54:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XQO+5l0GRa8sORhgc+XsRH4WL+ns1Fi4iNMfr7t/em8kEfPAOtKIp4WLKX1d+f46wuolXatWA8SvVqO1lz1gtkh0kyrjGf0j8G8pEcLLoy4TTitrgwuAmZY1gdgB9ozj5Knc/NTZxSt+n0zvCSSqAbFl1pCNgSGPBoeY4CdshJWmpBul5x/LzEK+1TFgAc8CESjJDxYrWHQzqJ8TBA5TANlcZerIyOThlcM9Xp2go4IzNp2+vA9if0hCScFrjGgCvtH6sOB5mWn+951cQcbcY07tUR/8K7MdwBkzopWUz+kUjBM2VqZc+/t5MyaMR24FbMGH+dptEcph5y6Sbf52uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZiX98OOB3aGYHuIgSznlRWv7CU/TO3qHj6W3ytkN1Ak=; b=nk+/LVXZ6UgRVI8e72kLqpJ27McqY4LvS+W75cEimHFkKQ02yq+lo+E8pD/0RGXnp+6tu1uVq+54qLXDw80uqxwstAj6QNdqHdtc786EpBRZvyOF8WTq6EMmJW096G2C9s1vUXvxaQHbn85yAwMBxhljRxGho/MRtFkQljEks4Uyu2vdr47C+xRdqYxKNHhFfffDdly5BfM2CevPymSRpoddEwHoYJywV4xH30JkPJhO2KxUg7zBfHcl3GixUG0e/g2T4brKXSW2SGK8eM5uBnSOoECN+NnjFtcCJwOsLXUeasqAFCZcZwZ0KtwFtybTdv1+ag7Cu8twRGWl86G5Yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY4PR11MB2005.namprd11.prod.outlook.com (2603:10b6:903:2e::18) by DM4PR11MB5568.namprd11.prod.outlook.com (2603:10b6:5:388::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Tue, 1 Mar 2022 07:54:21 +0000 Received: from CY4PR11MB2005.namprd11.prod.outlook.com ([fe80::d5b1:69fe:5611:5aae]) by CY4PR11MB2005.namprd11.prod.outlook.com ([fe80::d5b1:69fe:5611:5aae%10]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 07:54:20 +0000 From: "Schimpe, Christina" To: "gdb-patches@sourceware.org" Subject: RE: [PING 5] [PATCH v3 1/1] gdb: Use a typedef's scoped type name to identify local typedefs Thread-Topic: [PING 5] [PATCH v3 1/1] gdb: Use a typedef's scoped type name to identify local typedefs Thread-Index: AdgtQV76Qx+s4B6rRRC+0xgFJlqSaQ== Date: Tue, 1 Mar 2022 07:54:20 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5ca67b5c-e136-4c65-b070-08d9fb58b1d2 x-ms-traffictypediagnostic: DM4PR11MB5568:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8gwsfHms+1OyHQ9V3p9z1hcXHNCBCpOi8FvjI5EYW+3Oz4BI9Yl86/WCAJyyrM2Cd2D/qnLKCqLskKiLEyOORw+ScKKTYB84/VuUckc7fPILfmYT1wfLreAqcZ6zjJ0Lkcge4Xd94S88EY5+M5Qz4z+i0me5/vvDPgILhl06izFb9ZYBgoT68o02VnuuO6ik8bgIELXMHBBUWdJuU3VhtaKP8ZLwHsNxb7wQPdfbhk3J/0K/qeQJ5zr1cbxvxpy8BxttR+21JlnB7blX3wUP/Agid5NG/VwHZxFUs70U2cllPwnT8sokK6Zmz/+pPX8014V0AGIyaU7Gg1YdO5YR7XDY4k+mpNpufBeKCgwLbREuXwpOYQ4BRW6itaqPiXxvPCmUhLDUUdouDa0oHQWv0I2hCFEaaKul0155fm3hmATMZC5NDPpd9ckGGs/bp/e5aQAMaC9tGHAHRkUX/pfOy9SUYR8bBZEM1bDtJQDGiILuxvz2i/UJETbFrfTrnLuOArRcbXTTHE7yGAdho2TbfTKiLA8RPhXkUFUClxy6rDYdr9msUrb20mzqcnubS8J0kbNSqh/rY0LSoKPyxh9keuT3d8YsDN7ygTK6TjjywYOJsPI0sxPy94sjTbN2JatTae417hjn7LqqMvKR2XIs31m01W3NOrEtqagpyM54uF6sPwwFrg8k1s/88KFtbbTRUNtfmF303vsVCGLgdW2VgsDhYzhGEi2g03VL6m3ME/uQ6h3zcR9ka+TW6/vvDW1+XhYCJUX69xu1OvaPz1JVOs47ubdmw8sfTJC3Uo5Y078= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB2005.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6506007)(7696005)(71200400001)(966005)(508600001)(38070700005)(38100700002)(82960400001)(122000001)(86362001)(66556008)(6916009)(66946007)(76116006)(66476007)(66446008)(8676002)(64756008)(316002)(33656002)(55016003)(53546011)(83380400001)(9686003)(186003)(26005)(5660300002)(2906002)(30864003)(52536014)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?t0dn8WFTEF6lW+C5PGfqQ3jnRoXi3+mvryGGyVBGvGJBS1Qgr22jJPLAjYC2?= =?us-ascii?Q?S8Qk4elX3/rvhRnF6pfUgWLjUQ4iufijHNB/JwTtFNOx9w5kn//i90foLhrm?= =?us-ascii?Q?5IuvoKqV6GlQbGZNfzTvL7xvC4a8tRit7XWuf7K2O3wKibI8uYH8mY9RsAK0?= =?us-ascii?Q?Vy8xX8L7pm0e4GETbuWpHzpeGWWmWawgCnwbF169MKkwhoBSAq+OlManGWh0?= =?us-ascii?Q?4olA2E1Rv5WgAg9oThb1mmVZ3j8nnVmJSIUF7GGjpYsScozqiA1UwEyBqJXn?= =?us-ascii?Q?UBTDcHrJRMvW3V5LPxYvOHUSGL3/6/fRhvzwaakDHFNKO9eWE3CdlK2s94FL?= =?us-ascii?Q?bKnwzqwcoCrGIlidiCbf86ab+pOtHdjvnT6+woR+7kgO3roFY4+DuRyKcGo8?= =?us-ascii?Q?9XwFfjulSiWZCnB0JNIgQroealCs8fZIIEONVIo5KPQiMdK03/EUPaVzSBix?= =?us-ascii?Q?0sqqvBO/VJhXR7Cf1iVkcBrA10plig/LGjsN5X51NCF3ygnhk5nhHBHwQABs?= =?us-ascii?Q?ohQAQFkj7HqdAg7beI7jIZcIJVoTT4AVJ7dGJap79YjetXC49Al82a5vrWqa?= =?us-ascii?Q?HjRktkZ56p9u/JFvL44olVElaJJjVm5uamZenElzVWH/qenlBhHSjZ5YEnrH?= =?us-ascii?Q?yImlNbwHPpKJcd9FYq81kBa6KKoONOcJzoRiX9S2D9XdJPm87JduhP2EUCE1?= =?us-ascii?Q?D3F98HxwM3bE3KuB3alkdiVVvai116hE3UfrXyJF+kYneWMeD+I8J191ORWL?= =?us-ascii?Q?1UgYvdYvieyPWrox7jp2rbremhI7inttDjo02d4uOHZTwpDJor5ykm/o87zz?= =?us-ascii?Q?GEwwBRq7w6c5mRVUsMeJ569YDMstnGbYR14gctT5fkOv4WBTy3Dlg3vvhrAo?= =?us-ascii?Q?+8Si63khk9nd+b21oYuZvjk3fdookipdXGWSY2QMJBhbQkIR9DzWYeRr+QXq?= =?us-ascii?Q?34EKFjfr9YGht5i16ay46y+7b9fqdJS6pZfa9sMoocST8Zma1XMfS/eobS5z?= =?us-ascii?Q?52c4zeqkuwllelzFvPfffy4Qw6PFhhoNbjJ5kteh2sLgGc09JAnFZJG2c3Ex?= =?us-ascii?Q?Nh1jQ44J38kRrmpdWGEoA07Aa08DW1Ql91wUHyM0EmKt3ItOvxQNp6iz0XPz?= =?us-ascii?Q?gNt1aFSZm3HoDu3jCf5PuC03QGjLgkKoy+lqS4ygiEPL+ljyYk0Jk1V/VsC0?= =?us-ascii?Q?zG6ptG748RgrrT5dkK2M7qgEDYAh5/zruuITmqq8Z0bhqiHA8n6//wqpRpFI?= =?us-ascii?Q?TpMs9Ketzd2b3/5OM8FhKBd2AwHlmhHHk8u79Ni5t0rV7baqE+lqK1qOxS7w?= =?us-ascii?Q?X8bNo7IwtyJKLZPd0ri5sn49T3ej+peE6QCuGAGtaoFz1ivoTLPu226wE8YK?= =?us-ascii?Q?7sGWkMADY6z9aAnhcpv619AsxO1K5ourUCP0zQfvAy4yJjC6aQDc9CFs8EeD?= =?us-ascii?Q?/PTji0vSSbogzKsJK9zs0ecTdHBO2nSt+nNTETIAiH6GsU9pqKSjK+k3pSu8?= =?us-ascii?Q?w56eEl592FxlA3DUBrBQ7NZjuEVeS500kkWsOGWS2EHRJPp6R+islUWcqgN3?= =?us-ascii?Q?KR9cgqwRW8Dln9Ro08XOZVRQ4b9DahxhmIVucudAVBxVYr2p/X19XqsVHcv/?= =?us-ascii?Q?n3IM2CHXu+jIEbtD/QPkAhih3pdQu5vPNykTuaACGhW5Hi3DbPKemW4T6Gol?= =?us-ascii?Q?OY1lZA=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB2005.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ca67b5c-e136-4c65-b070-08d9fb58b1d2 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 07:54:20.6204 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: p9V75VDVGZgTcEuNTX1td8OEaEnjHfRECDwrC13Y3HwSwCA2qPFBQcrqfoasj1H1TeEC8/1m+JGVdEm8p2Ri09IAaZHXTtd/TQBLnGYTbpI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5568 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2022 07:54:33 -0000 Kindly pinging. Thanks, Christina > -----Original Message----- > From: Schimpe, Christina > Sent: Thursday, February 17, 2022 1:48 PM > To: 'gdb-patches@sourceware.org' > Subject: RE: [PING 4] [PATCH v3 1/1] gdb: Use a typedef's scoped type name > to identify local typedefs > = > Kindly pinging. > = > Thanks, > Christina > = > > -----Original Message----- > > From: Schimpe, Christina > > Sent: Wednesday, February 9, 2022 8:41 AM > > To: 'gdb-patches@sourceware.org' > > Subject: RE: [PING 3] [PATCH v3 1/1] gdb: Use a typedef's scoped type > > name to identify local typedefs > > > > Ping. > > > > > -----Original Message----- > > > From: Schimpe, Christina > > > Sent: Wednesday, February 2, 2022 9:51 AM > > > To: 'gdb-patches@sourceware.org' > > > Subject: RE: [PING 2] [PATCH v3 1/1] gdb: Use a typedef's scoped > > > type name to identify local typedefs > > > > > > Kindly pinging. > > > The changes made for V3 of this patch are described here: > > > https://sourceware.org/pipermail/gdb-patches/2021- > > > December/184601.html > > > > > > Thanks, > > > Christina > > > > > > > -----Original Message----- > > > > From: Schimpe, Christina > > > > Sent: Tuesday, January 18, 2022 8:11 PM > > > > To: gdb-patches@sourceware.org > > > > Subject: [PING] [PATCH v3 1/1] gdb: Use a typedef's scoped type > > > > name to identify local typedefs > > > > > > > > Kindly pinging for this patch. > > > > > > > > Thanks, > > > > Christina > > > > > > > > -----Original Message----- > > > > From: Schimpe, Christina > > > > Sent: Monday, December 20, 2021 2:15 PM > > > > To: gdb-patches@sourceware.org > > > > Cc: Schimpe, Christina > > > > Subject: [PATCH v3 1/1] gdb: Use a typedef's scoped type name to > > > > identify local typedefs > > > > > > > > GDB prints the wrong type for typedefs in case there is another > > > > typedef available for the same raw type (gdb/16040). The reason > > > > is that the current hashmap based substitution mechanism always > > > > compares the target type of a typedef and not its scoped name. > > > > > > > > The original output of GDB for a program like > > > > > > > > ~~~~ > > > > namespace ns > > > > { > > > > typedef double scoped_double; > > > > } > > > > > > > > typedef double global_double; > > > > > > > > class TypedefHolder > > > > { > > > > public: > > > > double a; > > > > ns::scoped_double b; > > > > global_double c; > > > > > > > > private: > > > > typedef double class_double; > > > > class_double d; > > > > > > > > double method1(ns::scoped_double) { return 24.0; } > > > > double method2(global_double) { return 24.0; } }; > > > > > > > > int main() > > > > { > > > > TypedefHolder th; > > > > return 0; > > > > } > > > > ~~~~ > > > > > > > > is > > > > ~~~~ > > > > > > > > (gdb) b 27 > > > > Breakpoint 1 at 0x1131: file TypedefHolder.cc, line 27. > > > > (gdb) r > > > > Starting program: /tmp/typedefholder > > > > > > > > Breakpoint 1, main () at TypedefHolder.cc:27 > > > > 27 return 0; > > > > (gdb) ptype th > > > > type =3D class TypedefHolder { > > > > public: > > > > class_double a; > > > > class_double b; > > > > class_double c; > > > > private: > > > > class_double d; > > > > > > > > class_double method1(class_double); > > > > class_double method2(class_double); > > > > > > > > typedef double class_double; > > > > } > > > > ~~~~ > > > > > > > > Basically all attributes of a class which have the raw type "double" > > > > are substituted by "class_double". > > > > > > > > With the patch the output is the following > > > > > > > > ~~~~ > > > > type =3D class TypedefHolder { > > > > public: > > > > double a; > > > > ns::scoped_double b; > > > > global_double c; > > > > private: > > > > class_double d; > > > > > > > > double method1(ns::scoped_double); > > > > double method2(global_double); > > > > > > > > typedef double class_double; > > > > } > > > > ~~~~ > > > > --- > > > > gdb/testsuite/gdb.cp/ptype-flags.cc | 23 ++++++++ > > > > gdb/testsuite/gdb.cp/ptype-flags.exp | 88 > ++++++++++++++++++++++-- > > -- > > > -- > > > > gdb/typeprint.c | 3 +- > > > > 3 files changed, 95 insertions(+), 19 deletions(-) > > > > > > > > diff --git a/gdb/testsuite/gdb.cp/ptype-flags.cc > > > > b/gdb/testsuite/gdb.cp/ptype-flags.cc > > > > index fc92d3950c..564d272e57 100644 > > > > --- a/gdb/testsuite/gdb.cp/ptype-flags.cc > > > > +++ b/gdb/testsuite/gdb.cp/ptype-flags.cc > > > > @@ -38,7 +38,30 @@ public: > > > > double method(void) { return 23.0; } }; > > > > > > > > +namespace ns > > > > +{ > > > > + typedef double scoped_double; > > > > +} > > > > + > > > > +typedef double global_double; > > > > + > > > > +class TypedefHolder > > > > +{ > > > > +public: > > > > + double a; > > > > + ns::scoped_double b; > > > > + global_double c; > > > > + > > > > +private: > > > > + typedef double class_double; > > > > + class_double d; > > > > + > > > > + double method1(ns::scoped_double) { return 24.0; } double > > > > + method2(global_double) { return 24.0; } }; > > > > + > > > > Holder value; > > > > +TypedefHolder value2; > > > > > > > > int main() > > > > { > > > > diff --git a/gdb/testsuite/gdb.cp/ptype-flags.exp > > > > b/gdb/testsuite/gdb.cp/ptype-flags.exp > > > > index c368415793..9734a70ee2 100644 > > > > --- a/gdb/testsuite/gdb.cp/ptype-flags.exp > > > > +++ b/gdb/testsuite/gdb.cp/ptype-flags.exp > > > > @@ -33,7 +33,9 @@ if ![runto_main] then { gdb_test_no_output "set > > > > language c++" "" > > > > gdb_test_no_output "set width 0" "" > > > > > > > > -proc do_check {name {flags ""} {show_typedefs 1} {show_methods 1} > > > > {raw 0}} { > > > > +proc do_check_holder {name {flags ""} {show_typedefs 1} > > > {show_methods > > > > 1} > > > > + {raw 0}} { > > > > + > > > > set contents { > > > > { base "public Base" } > > > > { field public "Simple t;" } > > > > @@ -62,24 +64,76 @@ proc do_check {name {flags ""} {show_typedefs > > > > 1} {show_methods 1} {raw 0}} { > > > > "" {} $flags > > > > } > > > > > > > > -do_check "basic test" > > > > -do_check "no methods" "/m" 1 0 > > > > -do_check "no typedefs" "/t" 0 1 > > > > -do_check "no methods or typedefs" "/mt" 0 0 > > > > +proc do_check_typedef_holder {name {flags ""} {show_typedefs 1} > > > > {show_methods 1} > > > > + {raw 0}} { > > > > + > > > > + set contents { > > > > + { field public "double a;" } > > > > + { field public "ns::scoped_double b;" } > > > > + { field public "global_double c;" } > > > > + } > > > > + > > > > + if {$show_typedefs} { > > > > + lappend contents { typedef private "typedef double class_double;"= } > > > > + } > > > > + > > > > + if {$show_methods} { > > > > + lappend contents { method private "double > > > > method1(ns::scoped_double);" } > > > > + lappend contents { method private "double > > > > method2(global_double);" } > > > > + } > > > > + > > > > + if {$raw} { > > > > + lappend contents { field private "TypedefHolder::class_double d;"= } > > > > + } else { > > > > + lappend contents { field private "class_double d;" } > > > > + } > > > > + > > > > + cp_test_ptype_class value2 $name "class" "TypedefHolder" > > > > + $contents > > \ > > > > + "" {} $flags > > > > +} > > > > > > > > -do_check "raw" "/r" 1 1 1 > > > > -do_check "raw no methods" "/rm" 1 0 1 -do_check "raw no typedefs" > > > > "/rt" 0 1 1 -do_check "raw no methods or typedefs" "/rmt" 0 0 1 > > > > +do_check_holder "basic test" > > > > +do_check_holder "no methods" "/m" 1 0 do_check_holder "no > > typedefs" > > > > +"/t" 0 1 do_check_holder "no methods or typedefs" "/mt" 0 0 > > > > +do_check_typedef_holder "typdefs class: basic test" > > > > +do_check_typedef_holder "typdefs class: no methods" "/m" 1 0 > > > > +do_check_typedef_holder "typdefs class: no typedefs" "/t" 0 1 0 > > > > +do_check_typedef_holder "typdefs class:no methods or typedefs" > > "/mt" > > > > +0 > > > > +0 > > > > + > > > > +do_check_holder "raw" "/r" 1 1 1 > > > > +do_check_holder "raw no methods" "/rm" 1 0 1 do_check_holder > "raw > > > > +no typedefs" "/rt" 0 1 1 do_check_holder "raw no methods or > typedefs" > > > > +"/rmt" 0 0 1 do_check_typedef_holder "typedef class: raw" "/r" 1 > > > > +1 > > > > +1 do_check_typedef_holder "typedef class: raw no methods" "/rm" 1 > > > > +0 > > > > +1 do_check_typedef_holder "typedef class: raw no typedefs" "/rt" > > > > +0 > > > > +1 1 do_check_typedef_holder "typedef class: raw no methods or > > typedefs" > > > > +"/rmt" 0 0 1 > > > > > > > > gdb_test_no_output "set print type methods off" > > > > -do_check "basic test, default methods off" "" 1 0 -do_check > > > > "methods, default methods off" "/M" 1 1 -do_check "no typedefs, > > > > default methods > > > off" > > > > "/t" 0 0 -do_check "methods, no typedefs, default methods off" "/Mt" > > > > 0 > > > > 1 > > > > +do_check_holder "basic test, default methods off" "" 1 0 > > > > +do_check_holder "methods, default methods off" "/M" 1 1 > > > > do_check_holder > > > > +"no typedefs, default methods off" "/t" 0 0 do_check_holder > > > > +"methods, no typedefs, default methods off" "/Mt" 0 1 > > do_check_typedef_holder \ > > > > + "typedef class: basic test, default methods off" "" 1 0 > > > > +do_check_typedef_holder \ > > > > + "typedef class: methods, default methods off" "/M" 1 1 > > > > +do_check_typedef_holder \ > > > > + "typedef class: no typedefs, default methods off" "/t" 0 0 > > > > +do_check_typedef_holder \ > > > > + "typedef class: methods, no typedefs, default methods off" "/M= t" > > > > +0 > > > > +1 > > > > > > > > gdb_test_no_output "set print type typedefs off" > > > > -do_check "basic test, default methods+typedefs off" "" 0 0 > > > > -do_check "methods, default methods+typedefs off" "/M" 0 1 > > > > -do_check "typedefs, default methods+typedefs off" "/T" 1 0 > > > > -do_check "methods typedefs, default methods+typedefs off" "/MT" 1 > > > > 1 > > > > +do_check_holder "basic test, default methods+typedefs off" "" 0 0 > > > > +do_check_holder "methods, default methods+typedefs off" "/M" 0 1 > > > > +do_check_holder "typedefs, default methods+typedefs off" "/T" 1 0 > > > > +do_check_holder "methods typedefs, default methods+typedefs off" > > > > "/MT" > > > > +1 1 do_check_typedef_holder \ > > > > + "typedef class: basic test, default methods+typedefs off" "" > > > > +0 > > > > +0 do_check_typedef_holder \ > > > > + "typedef class: methods, default methods+typedefs off" "/M" 0 > > > > +1 do_check_typedef_holder \ > > > > + "typedef class: typedefs, default methods+typedefs off" "/T" > > > > +1 > > > > +0 do_check_typedef_holder \ > > > > + "typedef class: methods typedefs, default methods+typedefs off" > > > > +"/MT" 1 1 > > > > diff --git a/gdb/typeprint.c b/gdb/typeprint.c index > > > > 1312111b60..98f6af4104 > > > > 100644 > > > > --- a/gdb/typeprint.c > > > > +++ b/gdb/typeprint.c > > > > @@ -201,9 +201,8 @@ static hashval_t hash_typedef_field (const > > > > void > > > > *p) { > > > > const struct decl_field *tf =3D (const struct decl_field *) p; > > > > - struct type *t =3D check_typedef (tf->type); > > > > > > > > - return htab_hash_string (TYPE_SAFE_NAME (t)); > > > > + return htab_hash_string (TYPE_SAFE_NAME (tf->type)); > > > > } > > > > > > > > /* An equality function for a typedef field. */ > > > > -- > > > > 2.25.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928