public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* PATCH:  fix typo in elfcore_write_lwpstatus()
@ 2014-10-23 22:16 Dennis Brueni
  2014-10-24 16:12 ` Pedro Alves
  0 siblings, 1 reply; 2+ messages in thread
From: Dennis Brueni @ 2014-10-23 22:16 UTC (permalink / raw)
  To: gdb-patches; +Cc: Dennis Brueni

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]


Fix an obvious coding error that led to a crash on AIX or HPUX.  I don’t remember which platform.

bfd/ChangeLog

2014-10-23  Dennis Brueni  <dbrueni@slickedit.com>

* elf.c (elfcore_write_lwpstatus): fix typo in call to memcpy



[-- Attachment #2: gdb-7.8-elf.diff --]
[-- Type: application/octet-stream, Size: 534 bytes --]

diff -urN gdb-7.8-dist/bfd/elf.c gdb-7.8/bfd/elf.c
--- gdb-7.8-dist/bfd/elf.c	2014-07-29 05:37:42.000000000 -0700
+++ gdb-7.8/bfd/elf.c	2014-10-23 14:27:01.000000000 -0700
@@ -9334,7 +9334,7 @@
   lwpstat.pr_lwpid  = pid >> 16;
   lwpstat.pr_cursig = cursig;
 #if defined (HAVE_LWPSTATUS_T_PR_REG)
-  memcpy (lwpstat.pr_reg, gregs, sizeof (lwpstat.pr_reg));
+  memcpy (&lwpstat.pr_reg, gregs, sizeof (lwpstat.pr_reg));
 #elif defined (HAVE_LWPSTATUS_T_PR_CONTEXT)
 #if !defined(gregs)
   memcpy (lwpstat.pr_context.uc_mcontext.gregs,

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: PATCH:  fix typo in elfcore_write_lwpstatus()
  2014-10-23 22:16 PATCH: fix typo in elfcore_write_lwpstatus() Dennis Brueni
@ 2014-10-24 16:12 ` Pedro Alves
  0 siblings, 0 replies; 2+ messages in thread
From: Pedro Alves @ 2014-10-24 16:12 UTC (permalink / raw)
  To: Dennis Brueni, gdb-patches

Hi Dennis,

Thanks for the patch.  bfd patches need to be sent to binutils@
though.  gdb and binutils (which owns bfd) share the git repo,
but maintenance is separate.

On 10/23/2014 11:16 PM, Dennis Brueni wrote:
> 
> Fix an obvious coding error that led to a crash on AIX or HPUX.  I donÂ’t remember which platform.
> 
> bfd/ChangeLog
> 
> 2014-10-23  Dennis Brueni  <dbrueni@slickedit.com>
> 
> * elf.c (elfcore_write_lwpstatus): fix typo in call to memcpy


Thanks,
Pedro Alves

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-10-24 16:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-23 22:16 PATCH: fix typo in elfcore_write_lwpstatus() Dennis Brueni
2014-10-24 16:12 ` Pedro Alves

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).