From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4348 invoked by alias); 11 Jun 2015 19:47:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4299 invoked by uid 89); 11 Jun 2015 19:47:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: smtp-p02.blackberry.com Received: from smtp-p02.blackberry.com (HELO smtp-p02.blackberry.com) (208.65.78.89) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Jun 2015 19:46:56 +0000 Received: from xct108cnc.rim.net ([10.65.161.208]) by mhs215cnc.rim.net with ESMTP/TLS/AES128-SHA; 11 Jun 2015 15:46:51 -0400 Received: from XMB126CNC.rim.net ([fe80::8025:a9ca:ffe7:8a3c]) by XCT108CNC.rim.net ([fe80::8dc1:9551:6ed8:c618%17]) with mapi id 14.03.0210.002; Thu, 11 Jun 2015 15:46:51 -0400 From: Aleksandar Ristovski To: Jan Kratochvil , Gary Benson CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH v6 04/10] Create empty common/linux-maps.[ch] and common/target-utils.[ch] Date: Thu, 11 Jun 2015 19:47:00 -0000 Message-ID: References: <20150607200422.8918.48900.stgit@host1.jankratochvil.net> <20150607200454.8918.52868.stgit@host1.jankratochvil.net> <20150608083733.GA5405@blade.nx> <20150611184842.GA14293@host1.jankratochvil.net> In-Reply-To: <20150611184842.GA14293@host1.jankratochvil.net> user-agent: Microsoft-MacOutlook/14.5.1.150515 Content-Type: text/plain; charset="us-ascii" Content-ID: <57A39CA071A8C046B78605BD2A154C37@rim.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2015-06/txt/msg00232.txt.bz2 On 2015-06-11, 2:48 PM, "Jan Kratochvil" wrote: >On Mon, 08 Jun 2015 10:37:33 +0200, Gary Benson wrote: >> Jan Kratochvil wrote: >> > * common/target-utils.c: New file. >> > * common/target-utils.h: New file. >>=20 >> Nothing to do with the target should be in common. The declarations >> should probably be in target/target.h, and they should have "target_" >> prefixes. You could create target/target.c to put the definitions in. > >gdb/target/target.c would create target.o which would conflict with >gdb/target.c. > >There is already gdb/target/target.h "conflicting" with gdb/target.h but >it >does not really conflict as gdb/target/ does not have default -I include >dir. >Despite for example gdb/common/ has default -I. > >I could propose various ideas what to move there but what is the suggested >solution? Sure one could also for example just generate >gdb/target-target.o >from gdb/target/target.c. As you say, there could be various ideas if needed, but the simplest seems good enough to me: just move the files to target dir common/target-utils.[hc] -> target/target_utils.[hc] Provided Gary is happy with that solution.