From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11465 invoked by alias); 22 Jun 2015 12:55:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11438 invoked by uid 89); 22 Jun 2015 12:55:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: smtp-p02.blackberry.com Received: from smtp-p02.blackberry.com (HELO smtp-p02.blackberry.com) (208.65.78.89) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 Jun 2015 12:55:17 +0000 Received: from xct108cnc.rim.net ([10.65.161.208]) by mhs215cnc.rim.net with ESMTP/TLS/AES128-SHA; 22 Jun 2015 08:55:16 -0400 Received: from XMB126CNC.rim.net ([fe80::8025:a9ca:ffe7:8a3c]) by XCT108CNC.rim.net ([fe80::8dc1:9551:6ed8:c618%17]) with mapi id 14.03.0210.002; Mon, 22 Jun 2015 08:55:15 -0400 From: Aleksandar Ristovski To: Jan Kratochvil , "gdb-patches@sourceware.org" Subject: Re: [PATCH v8 09/10] Validate symbol file using build-id Date: Mon, 22 Jun 2015 12:55:00 -0000 Message-ID: References: <20150614192542.18346.87859.stgit@host1.jankratochvil.net> <20150614192655.18346.17075.stgit@host1.jankratochvil.net> <20150621101644.GA12733@host1.jankratochvil.net> In-Reply-To: <20150621101644.GA12733@host1.jankratochvil.net> user-agent: Microsoft-MacOutlook/14.5.1.150515 Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2015-06/txt/msg00436.txt.bz2 FWIW, looks good to me. Minor thing: it seems you did not put space before the comment block, but in the practice most of such blocks are separated by an empty line from the previous. Example:=20 ... } +/* Boolean for command 'set solib-build-id-force'. */ ... Thanks, Aleksandar Ristovski QNX Software Systems