From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-123712-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2583 invoked by alias); 22 Jun 2015 20:41:03 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 2571 invoked by uid 89); 22 Jun 2015 20:41:02 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: smtp-p01.blackberry.com
Received: from smtp-p01.blackberry.com (HELO smtp-p01.blackberry.com) (208.65.78.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 Jun 2015 20:40:58 +0000
Received: from xct101cnc.rim.net ([10.65.161.201])  by mhs210cnc.rim.net with ESMTP/TLS/AES128-SHA; 22 Jun 2015 16:40:56 -0400
Received: from XCT111CNC.rim.net (10.65.161.211) by XCT101CNC.rim.net (10.65.161.201) with Microsoft SMTP Server (TLS) id 14.3.210.2; Mon, 22 Jun 2015 16:40:56 -0400
Received: from XMB126CNC.rim.net ([fe80::8025:a9ca:ffe7:8a3c]) by XCT111CNC.rim.net ([::1]) with mapi id 14.03.0210.002; Mon, 22 Jun 2015 16:40:56 -0400
From: Aleksandar Ristovski <ARistovski@qnx.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v8 09/10] Validate symbol file using build-id
Date: Mon, 22 Jun 2015 20:41:00 -0000
Message-ID: <D1ADEAD0.D0F3%aristovski@qnx.com>
References: <20150614192542.18346.87859.stgit@host1.jankratochvil.net> <20150614192655.18346.17075.stgit@host1.jankratochvil.net> <20150621101644.GA12733@host1.jankratochvil.net> <D1AD7D6A.D079%aristovski@qnx.com> <20150622203700.GA25292@host1.jankratochvil.net>
In-Reply-To: <20150622203700.GA25292@host1.jankratochvil.net>
user-agent: Microsoft-MacOutlook/14.5.2.150604
Content-Type: text/plain; charset="us-ascii"
Content-ID: <01E0399600063045B5799468FB42D5F2@rim.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-SW-Source: 2015-06/txt/msg00447.txt.bz2

On 2015-06-22, 4:37 PM, "Jan Kratochvil" <jan.kratochvil@redhat.com> wrote:

>On Mon, 22 Jun 2015 14:55:14 +0200, Aleksandar Ristovski wrote:
>> Minor thing: it seems you did not put space before the comment block,
>>but
>> in the practice most of such blocks are separated by an empty line from
>> the previous.
>> Example:=20
>> ...
>> }
>> +/* Boolean for command 'set solib-build-id-force'.  */
>> ...
>
>I guess it is some mail reading problem.  The patch is:
>
>1: }\n
>2: \n

^^^^^^^^
This one appeared to be missing when I viewed the patch, apparently due to
the viewer.

Thanks,

Aleksandar