public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Alan Hayward <Alan.Hayward@arm.com>
To: Yao Qi <qiyaoltc@gmail.com>, Omair Javaid <omair.javaid@linaro.org>
Cc: Philipp Rudo <prudo@linux.vnet.ibm.com>,
	"gdb-patches@sourceware.org"	<gdb-patches@sourceware.org>,
	nd <nd@arm.com>
Subject: Re: [PATCH v2 0/8] Remove XML files from gdbserver
Date: Wed, 31 Jan 2018 11:28:00 -0000	[thread overview]
Message-ID: <DAA8D38F-E59E-490C-AD2E-A7CD8D5B6A15@arm.com> (raw)
In-Reply-To: <C31D5C79-6973-4F5B-9122-92C1CAC669ED@arm.com>



> On 29 Jan 2018, at 17:13, Alan Hayward <Alan.Hayward@arm.com> wrote:
> 
> Only just spotted this thread.
> 
>> On 29 Jan 2018, at 16:28, Yao Qi <qiyaoltc@gmail.com> wrote:
>> 
>> Hi Omair,
>> Thanks for testing these patches...
>> 
>> On Fri, Jan 26, 2018 at 10:31 PM, Omair Javaid <omair.javaid@linaro.org> wrote:
>>> Hi Alan,
>>> 
>>> I just ran gdb testsuite with native-gdbserver configuration on your
>>> patches and found a couple of regressions. At least first three seems to be
>>> coming out of your patch series as they seem persistent over multiple runs
>>> of testsuite.
>>> 
>>> 1c1
>>> < Test Run By omair on Sat Jan 27 02:51:24 2018
>>> ---
>>>> Test Run By omair on Sat Jan 27 01:58:06 2018
>>> 1257,1258c1257,1258
>>> < FAIL: gdb.arch/i386-mpx.exp: bndcfgu formating
>>> < FAIL: gdb.arch/i386-mpx.exp: test if bndstatus is enabled
>>> ---
>>>> PASS: gdb.arch/i386-mpx.exp: bndcfgu formating
>>>> PASS: gdb.arch/i386-mpx.exp: test if bndstatus is enabled
>>> 6706c6706
>>> < FAIL: gdb.base/gcore.exp: corefile restored all registers
>>> ---
>>>> PASS: gdb.base/gcore.exp: corefile restored all registers
>>> 50790c50790
>> 
>> If I read the diff correctly, there are regressions in
>> gdb.arch/i386-mpx.exp and gdb.base/gcore.exp.
> 
> Looking into it, I always get UNTESTED: gdb.arch/i386-mpx.exp: failed to prepare
> 
> MPX was a Skylake addition. I’ve been using a Sandy Bridge processor.
> 
> Is there any emulator setup or suchlike to enable testing?
> 
> I’ll see if I can find a suitable box to use.

Was finally able to run the mpx tests.
(My MacBook is a Skylake, but is running macOS. Using ubuntu in virtualbox disables
mpx, but using ubuntu in vmware fusion is fine! Thankfully didn’t have to resort to a
live usb stick)

On the latest head, with or without my patches I always get the same results:

Mpx tests pass with unix / no target board, but fail with native-gdbserver

"gcore.exp: corefile restored all registers” fails with unix / no target board, and passes
with native-gdbserver.

I can’t see any obvious reason why my patches would break mpx or the gcore tests,
but never say never.

Is it worth me digging more into these tests?

> 
> 
>> 
>>> < PASS: gdb.threads/thread-unwindonsignal.exp: continue until exit
>>> ---
>>>> FAIL: gdb.threads/thread-unwindonsignal.exp: continue until exit (timeout)
>>> 55145,55146c55145,55146
>> 
>> This test case isn't stable for me, I remember I saw the fail several times
>> before.
>> 
>> -- 
>> Yao (齐尧)


  reply	other threads:[~2018-01-31 11:28 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24  9:26 Alan Hayward
2018-01-24  9:26 ` [PATCH v2 1/8] Move tdesc header funcs to c file Alan Hayward
2018-01-24  9:27 ` [PATCH v2 2/8] Use tdesc_reg in gxdbserver tdesc Alan Hayward
2018-01-25 13:12   ` Philipp Rudo
2018-01-24  9:28 ` [PATCH v2 3/8] Use tdesc_feature in gdbserver tdesc Alan Hayward
2018-01-25 13:12   ` Philipp Rudo
2018-01-24  9:28 ` [PATCH v2 4/8] Move make_gdb_type functions within file Alan Hayward
2018-01-24  9:29 ` [PATCH v2 5/8] Use tdesc types in gdbserver tdesc Alan Hayward
2018-01-25 13:13   ` Philipp Rudo
2018-01-29  7:28     ` Omair Javaid
2018-01-29 11:01       ` Alan Hayward
2018-01-29 11:31         ` Philipp Rudo
2018-01-29 15:52           ` Alan Hayward
2018-01-24  9:30 ` [PATCH v2 6/8] Create xml from target descriptions Alan Hayward
2018-01-25 13:14   ` Philipp Rudo
2018-01-25 15:45     ` Yao Qi
2018-01-25 16:13       ` Alan Hayward
2018-01-25 16:56         ` Philipp Rudo
2018-01-24  9:31 ` [PATCH v2 7/8]: Remove xml file references " Alan Hayward
2018-01-24  9:32 ` [PATCH v2 8/8] Remove xml files from gdbserver Alan Hayward
2018-01-24 10:57 ` [PATCH v2 0/8] Remove XML " Omair Javaid
2018-01-24 12:29   ` Alan Hayward
2018-01-24 14:44     ` Omair Javaid
2018-01-24 18:53       ` Alan Hayward
2018-01-25 13:11 ` Philipp Rudo
2018-01-26 22:31   ` Omair Javaid
2018-01-29 16:28     ` Yao Qi
2018-01-29 17:13       ` Alan Hayward
2018-01-31 11:28         ` Alan Hayward [this message]
2018-01-31 11:43           ` Omair Javaid
2018-01-29 18:18 ` Pedro Alves
2018-01-30 12:16   ` Alan Hayward

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DAA8D38F-E59E-490C-AD2E-A7CD8D5B6A15@arm.com \
    --to=alan.hayward@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    --cc=omair.javaid@linaro.org \
    --cc=prudo@linux.vnet.ibm.com \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).