From: Alan Hayward <Alan.Hayward@arm.com>
To: Luis Machado <luis.machado@linaro.org>
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
nd <nd@arm.com>
Subject: Re: -Wtautological-bitwise-compare error in arm-tdep.c
Date: Tue, 26 May 2020 09:45:42 +0000 [thread overview]
Message-ID: <DB9DDA56-2A38-4CAC-9714-4C9B3129E35A@arm.com> (raw)
In-Reply-To: <b020084f-e99b-f5b3-599f-d677d848e468@linaro.org>
> On 25 May 2020, at 14:51, Luis Machado <luis.machado@linaro.org> wrote:
>
> On 5/25/20 10:49 AM, Simon Marchi wrote:
>> On 2020-05-25 9:08 a.m., Luis Machado wrote:
>>> This fixes an instruction mask typo. We should be matching only
>>> ldrd (immediate) and not any other of its variants. As is, it never matches
>>> anything.
>> And moreover, within the `ldrd (immediate)` instruction, it only matches the
>> `Offset variant` variant, right?
>
> That's right. We don't want to handle anything that changes the SP here. And the post-indexed and pre-indexed variants do so.
>
>>>
>>> With the patch, the instruction mask also allows matching of ldrd (literal),
>>> but the check for SP discards this particular instruction pattern, as it has
>>> a hardcoded PC register.
>> I don't feel the most qualified to approve this patch. Alan, could you please
>> take a look?
>> Simon
The maths looks good now.
However, Binutils uses a slightly different mask, 0xff50:
{ARM_FEATURE_CORE_LOW (ARM_EXT_V6T2),
0xe9500000, 0xff500000,
"ldrd%c\t%12-15r, %8-11r, [%16-19r, #%23`-%0-7W]%21'!%L”},
It does use 0xff70 for a different variation of ldrd:
{ARM_FEATURE_CORE_LOW (ARM_EXT_V6T2),
0xe8600000, 0xff700000,
"strd%c\t%12-15r, %8-11r, [%16-19r], #%23`-%0-7W%L"},
{ARM_FEATURE_CORE_LOW (ARM_EXT_V6T2),
0xe8700000, 0xff700000,
"ldrd%c\t%12-15r, %8-11r, [%16-19r], #%23`-%0-7W%L”},
That’s in binutils-gdb/opcodes/arm-dis.c.
All that code was added at the same time in 2015.
0xff50 is going to allow more matches than 0xff70.
And given that the thing we care about is matching the opcode,
then 0xff50 is safer.
Before I go off and start looking at instruction decodings,
Luis - where did you get 0xff70 from?
Alan.
next prev parent reply other threads:[~2020-05-26 9:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 20:32 Simon Marchi
2020-05-15 20:41 ` Luis Machado
2020-05-15 20:57 ` Simon Marchi
2020-05-25 13:08 ` Luis Machado
2020-05-25 13:49 ` Simon Marchi
2020-05-25 13:51 ` Luis Machado
2020-05-26 9:45 ` Alan Hayward [this message]
2020-05-26 12:17 ` Luis Machado
2020-05-26 16:10 ` Alan Hayward
2020-05-27 12:43 ` Luis Machado
2020-05-27 14:00 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB9DDA56-2A38-4CAC-9714-4C9B3129E35A@arm.com \
--to=alan.hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@linaro.org \
--cc=nd@arm.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).