From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2043.outbound.protection.outlook.com [40.107.105.43]) by sourceware.org (Postfix) with ESMTPS id 382373858C52 for ; Thu, 14 Sep 2023 22:34:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 382373858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zx77JkenPDxarREj/QX/uFS5k/ppQC/VVuxfxQK7B2g=; b=Vuv32FOCw6o+EYOnMptJacJOaqTPqllsLJN6O0pPuD3dpYm9InvS6oNlpqepQoV0Li4MI1JQKn0xXu2VCYbJE1CrVmuAh9OSoGQzts/wI0veHHIzWSk3vYpbTqj4AH5hsBkiEqzmO2wexZ02HcdJFSHt7YjpmH17IvtlqTOQNKU= Received: from AS8PR04CA0147.eurprd04.prod.outlook.com (2603:10a6:20b:127::32) by DB9PR08MB9540.eurprd08.prod.outlook.com (2603:10a6:10:451::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.31; Thu, 14 Sep 2023 22:34:28 +0000 Received: from AM7EUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:127:cafe::29) by AS8PR04CA0147.outlook.office365.com (2603:10a6:20b:127::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.21 via Frontend Transport; Thu, 14 Sep 2023 22:34:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT025.mail.protection.outlook.com (100.127.140.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.20 via Frontend Transport; Thu, 14 Sep 2023 22:34:27 +0000 Received: ("Tessian outbound c99fbc01d472:v175"); Thu, 14 Sep 2023 22:34:27 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 26bf8f1048963529 X-CR-MTA-TID: 64aa7808 Received: from 0acd5dd0cc8b.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 83917A1F-E955-4343-A479-C1CEE045788E.1; Thu, 14 Sep 2023 22:34:20 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0acd5dd0cc8b.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 Sep 2023 22:34:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TGvXKvl1+Z7v0WwEI7rgJ9lILhOj5wxa/EdGRUPOzg0hwe8Wb2Lj6aFW3x6YDtdwc31B5EBaexFVf0f7Ub0uKycGU2ssRpgqNBCtnIKrOsGcy9EPcNEirkfLaXV+GH7lSaUp4Hs58aBfsQQ9+HuFOGVDiAz1+8NWdFzsooUHPGuvVq9pwoX0j7ghyH9HZi5nt/lBIenNb69m4WxBIhorskSJ5buqd/Luyv55D6SCnUGLONRKQgod/nfOo6Q9CSJ4hFXLK2Pvhemr1QFoLROBWv1zprGI+ld02PMrUJisCD9EumlRqbRrnWuGaPm2yv65mP9hDUa4WJlU+N6Et5wEuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zx77JkenPDxarREj/QX/uFS5k/ppQC/VVuxfxQK7B2g=; b=VWZf6SUetT3FL638Hl98ttkOwZYoA8nnstqPpQQ+vyqT/PiaInmcWmYjN2XemKoE8cEY66wQUxpKMGwS1+V6V6mZjodPLgOPQneiUm/uBB5uXzHfUMAj6zqU39GRoWsg1eMoDqNfObPisxuTkcieXQ5sFjOdbdpjnW6hVROQg1UtBr31QgsSGWaIgqk/E1+i75f5ymuoLtKx7GfCM/2vmVvpVg6s+XvTkuf5HbgcBSRkt6djlH4LDRy6g9R7CJ3RLIR/x5UcTOtoCZRNdrfaa21jkPi1ClplaxtlO95XL6pEiv8nn9P3x63zJjmW6caXgb7mLCTR777r+sfRF7VJtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zx77JkenPDxarREj/QX/uFS5k/ppQC/VVuxfxQK7B2g=; b=Vuv32FOCw6o+EYOnMptJacJOaqTPqllsLJN6O0pPuD3dpYm9InvS6oNlpqepQoV0Li4MI1JQKn0xXu2VCYbJE1CrVmuAh9OSoGQzts/wI0veHHIzWSk3vYpbTqj4AH5hsBkiEqzmO2wexZ02HcdJFSHt7YjpmH17IvtlqTOQNKU= Received: from DB9PR08MB6474.eurprd08.prod.outlook.com (2603:10a6:10:255::17) by DU0PR08MB9275.eurprd08.prod.outlook.com (2603:10a6:10:41b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.20; Thu, 14 Sep 2023 22:34:18 +0000 Received: from DB9PR08MB6474.eurprd08.prod.outlook.com ([fe80::1e3e:abb0:9157:6fb9]) by DB9PR08MB6474.eurprd08.prod.outlook.com ([fe80::1e3e:abb0:9157:6fb9%3]) with mapi id 15.20.6792.020; Thu, 14 Sep 2023 22:34:18 +0000 From: Vaseeharan Vinayagamoorthy To: Tom Tromey CC: Simon Marchi , "gdb-patches@sourceware.org" , Vaseeharan Vinayagamoorthy Subject: Re: [PATCH] Specialize std::hash for ptid_t Thread-Topic: [PATCH] Specialize std::hash for ptid_t Thread-Index: AQHZ5L7ujinWup2eiEKyFAiskkFixbAVvs6AgAATtKKAAArAgIAE1W1cgAAIirOAADCyjw== Date: Thu, 14 Sep 2023 22:34:18 +0000 Message-ID: References: <20230911144718.3425981-1-tromey@adacore.com> <99e5e4c7-9530-4eaa-8062-c13abb66b7b2@polymtl.ca> <878r9cllbs.fsf@tromey.com> <8d359fca-6e2a-406e-a99a-d9623cbd37be@polymtl.ca> <875y4ch7nc.fsf@tromey.com> In-Reply-To: <875y4ch7nc.fsf@tromey.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: DB9PR08MB6474:EE_|DU0PR08MB9275:EE_|AM7EUR03FT025:EE_|DB9PR08MB9540:EE_ X-MS-Office365-Filtering-Correlation-Id: cf5542ab-9b5a-40a5-9917-08dbb572c168 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ZC/hlqx6v8egmUsCm2D4TI9Ygr0FVCqb55UpGjUjHiIaDWUb2FyLmO5vX+33rmB0Geq79oGPpXGKh/nPvl/FerddldW7Xgct0vhXq4xE+5kO0axM22Kva6J9toI2Djgr22QmwDy8clwVAOsXN5DoreP2p4thj+LDPR/CEQIImvrQJhoVCkc3RdLxXAR4TcOcsCqEizy0E06l+dO3ER24rzqiMe8u0uY3pYpDI919NuWeCEslIYTRDS04FViDgD5+Yanky8N9KVgriftIRAUAwglRvMH1lcV2ueVlquOfCRHYdc5jb/9Citv5Pj1cUeh7j7JQ4fnt/QxprDG1XUQIfAlGk728CkfTaBqzKgfRvsqOpFnKQmTn+L2Qq+Rgir4qn3sXW+6j7h5vC9ZMdOx6y1ZJ7LevFVA25whvS0yC+IIuwVKdJgkTEQaqHrarlMttqxCmHVBqtD594C27m+3JC1cuMOm/qgxdijDjpz47uWd4wj2i/GRKlUhlINQEvsnXq0YNQYfWdXym//CNR7TgEGGLXHz4oGvRUBHmRv6w7EV0GWTScdCYZiKx2brF7fbE5+xaXwHyPF0GSCFpA3Fshm8HK+YnxqMPOakSjz9YhHE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB6474.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(366004)(346002)(376002)(39860400002)(451199024)(1800799009)(186009)(26005)(38070700005)(38100700002)(122000001)(478600001)(966005)(33656002)(9686003)(166002)(71200400001)(6506007)(7696005)(53546011)(66476007)(41300700001)(54906003)(66446008)(316002)(64756008)(76116006)(66946007)(66556008)(6916009)(91956017)(19627405001)(52536014)(8936002)(21615005)(5660300002)(8676002)(2906002)(4326008)(55016003)(86362001);DIR:OUT;SFP:1101; Content-Type: multipart/alternative; boundary="_000_DB9PR08MB647449C7ACB6D5AF425832F681F7ADB9PR08MB6474eurp_" MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9275 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fe85105a-f441-49c1-8458-08dbb572bbd5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a1jPA7zNxhd//0Sf0sdMS3t6oTpata6S0xBwq4K2WwXTjdYnhZoFih6CvCU2CFt/unuZPovOs9GyEXxko1YVOpkOI8kQs56ozaJ0vtyE9QDFi5C8CukRZ8npydLC10cjgIKMD5SaMwL9pJIVMIi98BUAXwN7zHLoaVtURaobkCeax1novOdbJiu/4E1Fm6AlC62IPTdZWvIy2IRouQSDNpfZEoyKL4P4ByjV5S9eASqJUcUccXu6LswiwqEGqRscda6IthCrmP1+XKk+STUEekWsST6Te6CmNWs+Dbr0N5ESrIAq6P1bL74ocR2ZERCWazz/5dE1vg1VwuLwPqEmmXO0ZeARIOlD2kbTf+keOmlM68SKdYxPemKALmL17IJxpCcT+5RV3p1be1jzjsmdDZlwT9uWyel/tEa/5GUisAUkXlnrK2tPE6FYox4Y+2SbYwzibcrVkltKeJzUiyHPwxKlTigrV+DKV76AkDucNhJeO31Dj/zYNMUcZ0/VQB418Jm3v+x3bpIXx0cvjzcOG2td7dJvZQxn664ukib0MbVcfUCKxAxErybFOk0zeTQxg57Pbx29QG0jTEFafp3ApovSrUygF8/6XGHRPwby9lzwF/SCs76Qa4VsrhpMcO2EurpsYqVPNwn2L3jBnwXBM/PFgbzwXRO1bYyB2wqmnq+38D+zeTJf/v6jRbTIC6XbijKAzP3Q/WhO3zkjttoEG2AejagCzY87WyN1hlNHSUk= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(376002)(346002)(39860400002)(396003)(136003)(451199024)(82310400011)(1800799009)(186009)(46966006)(40470700004)(36840700001)(40460700003)(26005)(40480700001)(336012)(55016003)(966005)(2906002)(82740400003)(36860700001)(86362001)(478600001)(70206006)(81166007)(5660300002)(21615005)(52536014)(41300700001)(54906003)(4326008)(356005)(6862004)(316002)(9686003)(47076005)(70586007)(166002)(8936002)(19627405001)(7696005)(33656002)(53546011)(8676002)(6506007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2023 22:34:27.8189 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cf5542ab-9b5a-40a5-9917-08dbb572c168 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9540 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,HTML_MESSAGE,KAM_DMARC_NONE,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --_000_DB9PR08MB647449C7ACB6D5AF425832F681F7ADB9PR08MB6474eurp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Hello Tom, It does build ok with GCC 7.5. Has the minimum required version for building GDB changed? At least for GCC, the minimum requirement seems to be 4.8: https://gcc.gnu.= org/install/prerequisites.html Kind regards, Vasee ________________________________ From: Tom Tromey Sent: 14 September 2023 20:33 To: Vaseeharan Vinayagamoorthy Cc: Tom Tromey ; Simon Marchi = ; gdb-patches@sourceware.org Subject: Re: [PATCH] Specialize std::hash for ptid_t >>>>> Vaseeharan Vinayagamoorthy write= s: > I think that after this patch is when I am seeing these errors when > building cross toolchains, for arm-none-eabi and aarch64-none-elf, > using gcc 4.8. Can you try a newer gcc? > /=85/src/binutils-gdb--gdb/gdbsupport/ptid.h:161:13: error: specializatio= n of =91template struct std::hash=92 in different namespace [-fp= ermissive] Or, alternatively, try the appended? Tom diff --git a/gdbsupport/ptid.h b/gdbsupport/ptid.h index f8644d47633..96c7d9c8bfd 100644 --- a/gdbsupport/ptid.h +++ b/gdbsupport/ptid.h @@ -157,8 +157,10 @@ class ptid_t tid_type m_tid; }; +namespace std +{ template<> -struct std::hash +struct hash { size_t operator() (const ptid_t &ptid) const { @@ -169,6 +171,7 @@ struct std::hash + long_hash (ptid.tid ())); } }; +} /* The null or zero ptid, often used to indicate no process. */ --_000_DB9PR08MB647449C7ACB6D5AF425832F681F7ADB9PR08MB6474eurp_--