From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20127.outbound.protection.outlook.com [40.107.2.127]) by sourceware.org (Postfix) with ESMTPS id 42522385740F for ; Tue, 9 Aug 2022 15:00:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 42522385740F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=xmos.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xmos.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XQI1wBhLz5+p3Xv1TSj3ZxXb5B5zye+efEc5fDnfgi8l4LB0vMo4BunsQn0n9tBZinBa3EBG5TthnXFUWecPAqEY76b0KFfrb2VmfmAcKnX5hyTU+WKqyo/+oPRKlz4xvl0j7sZL0iIWbwYqSFVi8kujHzSkoqaGQqYfNby2KroNiOIqQ+2KekwEm1E4onHarRbYZZPNoKTMJ18lQyKSvtN8bag16SxmduSP6B/z9lBAfPqUfRKz7drn35OAn0n3WS64CqulbnL1BgSwLEqmRFFpGadzMcE2ZXS8txw2ZN52VEB7aQKDZ1l3NZBQ2M1YyUqGeTLyqnH5Itbf2HNtLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wp9J7crqlsA2+mKU4+XanQiVMKvY2tz9Lp+oR2ZvgZ8=; b=HJJeLS+kJX3Xed3pdSxhsqt0XYTCeB07d9mlzR5k17pUUXxMzq2PreC9cUaKxanMSioj49X95lJaCLTxQiMFcf8P4TKo1qQMPRN1fEu5KjFhrraPc4dWCylx4gfAxRQ7e6hrx8yTTqYj9yZ5c9qmGSW1ZVgULJazA8aAzPz0m8iN6BLI6gyPUAWO66DCR8+/nOU1LAfIdN9k6ZCwzyq0WdD/q46/jXtvQh+fT2xLNZd0KU3hXWWeR62r87tnTjyoN/J+YbKM3Ll+K0uf9/XxSDVl5/Phz/YBtHUIpVs2mihaMBXSp/1vbOkuPpVQSAk1IayQ6wiin3SIm+cqxSKd2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xmos.com; dmarc=pass action=none header.from=xmos.com; dkim=pass header.d=xmos.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xmos1.onmicrosoft.com; s=selector2-xmos1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wp9J7crqlsA2+mKU4+XanQiVMKvY2tz9Lp+oR2ZvgZ8=; b=YinyyGbDd0dgO72c7lTvgnc+cdqYQ7kzqDIlFC1Tp0hcl0WOKZs5+D4QE1DbC5lqpTKb8uhtF80u4uzHRQFUhvKipqp0w5H5nxB0sPeh7+sacWshF4LryxFnTiWNuqkJNznlASE0wVbCwUtw/x8ZuSpjTMmN88y5lFIPG7kKE84= Received: from DB9PR09MB4988.eurprd09.prod.outlook.com (2603:10a6:10:26d::11) by DB8PR09MB4454.eurprd09.prod.outlook.com (2603:10a6:10:153::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Tue, 9 Aug 2022 15:00:55 +0000 Received: from DB9PR09MB4988.eurprd09.prod.outlook.com ([fe80::71f7:e3b2:6c17:c209]) by DB9PR09MB4988.eurprd09.prod.outlook.com ([fe80::71f7:e3b2:6c17:c209%6]) with mapi id 15.20.5504.021; Tue, 9 Aug 2022 15:00:55 +0000 From: Ciaran Woodward To: "gdb-patches@sourceware.org" Subject: [PING] [PATCH] gdb: Fix missing first breakpoint in schedule-multiple mode Thread-Topic: [PING] [PATCH] gdb: Fix missing first breakpoint in schedule-multiple mode Thread-Index: AQHYoELE6TsD4VW2AEq8KrJPBohV2K2mwSDA Date: Tue, 9 Aug 2022 15:00:55 +0000 Message-ID: References: <20220725162231.4473-1-ciaranwoodward@xmos.com> In-Reply-To: <20220725162231.4473-1-ciaranwoodward@xmos.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-bromium-msgid: 09e4635d-bc29-47ff-82ca-97e12bf9fb39 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=xmos.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a35205c2-1a88-4291-9f83-08da7a17f60e x-ms-traffictypediagnostic: DB8PR09MB4454:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /WkiGCj2cE4y8PGrhWriOevbC9zhTPWc6a59vcmqNE3KLjHC6D8qoBJxecAwLPAytJ10+I7BwMvfgMMzC1mWLsv1R8nV0bA9JP4+F+fu78pJPi1lJEXm/UdSSRAnGhQgsaU71ng1DyH1qkpcr5PeNWf/NM/rM8QBSh4Un9fuQuisD7fw+9Mhis7pX3GTY4aM34zvh9TjJoeoYoBAFGEikAgQT21PGa5pci5xlY6btzH7WwbwsOwAfkjL5O6N2i+wVJGY6Sn3Mza7uqWlPkFJqcAKoEFZD0e1tCjQUXDnFLh6u5mfhiV6Sdq0LKmhSbqyZdT0Xblz2Vc13BTwuMTiIsDmbiajBqu+sn/eBF2HgtECr7qh6Juhhp0q/ELBZ1Vq00JgOy6mjrVd9/ejpVBjIMBSe1ZfEkMgq5RhEvkXPyI9xXd+Bu3lQUyHKQqmwf43P/aeTMYc1ttcGKJE6QFN5YRb5bHwzhGC1QkODSgGqNWrlVW2LAMEGe3VMJN0CS0B6y+dbepgMOMvdA1b1LsoqF2a1+jMiDunp5a6G/fOEZvIlAx9wrMti+uJODX9M9oI2jEhKBOtF0K2SJSTO++TQaK5ELRKwhX756F2jcF0FDoToVWoBNTCyrzYdOR2I4Or29F43T1NInEQWs/fp/9/CJInoZ95KUhuzIZZfVOCIiLhi0Y8MmrmVMlOEJMvW1Ihg5OMJF+SxJfqpzWSQaR6O6HqNkQKVmHXA/kFVv9I5wSvH08YZzQmsVSk83vkVBEbkKhS7dN/+3K20lBcOM7A/YIK/UsBDX3lPnx1b9GkFbp4IjP+a+oljg0yWHcr5f10/dPQFl0hGhBvlAQR98AGjg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR09MB4988.eurprd09.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(376002)(39840400004)(366004)(396003)(136003)(38070700005)(38100700002)(122000001)(6506007)(7696005)(186003)(9686003)(53546011)(26005)(86362001)(33656002)(83380400001)(316002)(478600001)(6916009)(41300700001)(71200400001)(966005)(2906002)(66446008)(66556008)(66946007)(5660300002)(76116006)(8676002)(66476007)(8936002)(52536014)(55016003)(64756008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gJlxIqUToU2mUpbmEVpERLiK1Y4o24SYhrMFzJP3hgh2p24Juh2cw1udwaGD?= =?us-ascii?Q?ra3jUzSXH9lDP9DR2bfv/W5Xdh1Kg4sSwu4SD0FieGdKonCgx70lhrvuwcyT?= =?us-ascii?Q?2y9nviludrBX4ez86m6Ih+VBwXEqD6Q6JGRyNhPbjIVRtextfJSWC9YO0ug6?= =?us-ascii?Q?B107pTiGpeT7sHNWPWye1sOUfzjAV1mo9CduPqk6UNkJ3m33JoGBGywINJS9?= =?us-ascii?Q?dhbG5Rt53dDuxNZakj2wPjaGoexgiHHh+iDMUZhc1HOv3tNejDA2QbrDmPcU?= =?us-ascii?Q?ddZneDkk9iCDErGKd5pCp6TjWc3aes1F8J85ec9IIvIvVGMlYP76NbpdZ7zB?= =?us-ascii?Q?kqhjlqltk3ewazNBxBb7sCriEzMgTM4NwaqZbBXH1fuvq9CC9ZVIs2RA22OY?= =?us-ascii?Q?LsXEGMr2e0QQMhzmE/BLEy6/bKuxMm8yudpjuwG/XEg373UYVkGbYDbJLOZI?= =?us-ascii?Q?nME/Id8u66zDB3JpPB9FLjaDCsoKYhkIlmu8GGOf/f+N1aqFBtm5DMM55cCI?= =?us-ascii?Q?wlsEFaSKrs/TR2MXqU4PZTGFAWc5GT2a3724B5IoX8s3XXTZeupYmQJbcRxG?= =?us-ascii?Q?cmx8S3wjqzfaWNlczLP+SjMUJ30TuByjSzUwOH0CuOExvTtG/MZne1y5R/sh?= =?us-ascii?Q?fGJq3E/H8RKzOiWme/e4OKYU9Z1mv/MBRE9rAU18zGJS5BEP8WBk72a7LAjp?= =?us-ascii?Q?T32GT4/DCjg94PF6sJ3P2zqkwuPP1OJCDV9lS664X9GRIRju66IABtYwLyEo?= =?us-ascii?Q?mvMiuCT3vJBQf2jepZHgFXhADhB3IKqaT3E/z0TDGrQxcyek1U7ERKkSYL8S?= =?us-ascii?Q?xI6Fd0bq10hZtBV737SHuf+qLpq17eQvTngk/VyD8moL8CjcYHB/zEUVoiMa?= =?us-ascii?Q?NKpXuSbOBPyNLgzvLO4Ui+5QOsitlffSl9t9AERTmUmglQtxvc3c+CtQXe4y?= =?us-ascii?Q?k78prVGm7n5Ufv7T8bQHiCYLSH9HYAeibnBy9Oq1qfKnKQt1RgvxixjnTHcq?= =?us-ascii?Q?dFX3mtnVR5j+ANpxtHjnLb/Fs2DmP7jUoaMawoveGIn0jRY7CKnOCHTI9Biq?= =?us-ascii?Q?ZTTE/2LpvviRB7B4/1Oj8l2zTFQgRurE5vX8jnVm0w9btQQYMdRXKZXJhG6j?= =?us-ascii?Q?rjVfFeI2Rq08+IstsCKrWguk8enewPhcIUIQiu8SFCfhc+8/zDA+Gh3Byf0k?= =?us-ascii?Q?2Rs1Ky7LvTmdAJ9aByL5vxSILsu1eQODUslWIyoIVO1Pqfq08nZXM63SrYEe?= =?us-ascii?Q?y4PKoNI6sbFbluBSETmuQv5kuOMV/S16d2B3eaN9PP9AkbuiGQEqZYwMsMZj?= =?us-ascii?Q?VVf5NA3sft9mUwuXNFfgJabTPNRutVysDkzFoqkMo0jXvcLCAv0ukmWvHjHI?= =?us-ascii?Q?k8cCshj1bi4QX/M2yMV0AQn9vIw5UC8MCG76pVtsZ3jtgnhdZ8mkdpGPGuSN?= =?us-ascii?Q?YBDM28aMMcBncnTsZ80YnBhPK7yB6ARS7gBYVBtALOYkmAi8ovqBr3vMn0Zu?= =?us-ascii?Q?pOvcvNlyCWyL0adAVyU4K7WS3FXs4mrJgX8vTLhrlD24h28Gw8wv+YoDCHRf?= =?us-ascii?Q?APwrzwo3BlGl0IC/hj5icWsD+6Cy7anaYSmUGLmC?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: xmos.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB9PR09MB4988.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a35205c2-1a88-4291-9f83-08da7a17f60e X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2022 15:00:55.6867 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 975ecfb1-4080-42d2-a01d-4a4d0707a539 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 20ihtixE8Vz3zR52j2bKCA1CbSQCQ9+43PfFfO9aXRULX4oxNX+dARJIqI+eGJGHyAhJ/4KYh9PowybdOrxgJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR09MB4454 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Aug 2022 15:01:00 -0000 Hi, Quick ping - this (or something similar) is required for working with multi= ple inferiors on a remote if you connect to the remote while the inferiors = are already running. There is a reproduction description here: https://sour= ceware.org/pipermail/gdb-patches/2022-July/191092.html Cheers, Ciaran > -----Original Message----- > From: Ciaran Woodward > Sent: 25 July 2022 17:23 > To: gdb-patches@sourceware.org > Subject: [PATCH] gdb: Fix missing first breakpoint in schedule-multiple > mode >=20 > Rationale/background: > When using schedule-multiple (sched_multi) in gdb, all inferiors > are set to continue when the c command is used. However, before > this patch, only the 'current' inferior would have its > control->stop_soon field cleared. This field causes certain stops > to be ignored, and is only intended for initial attach. >=20 > By not clearing this field before continue, continuing with inferior 2 > in focus and with inferior 1 hitting the next breakpoint, would cause > gdb to ignore the breakpoint and any attempt to stop the target with > Ctrl-C following that - even though the target was already stopped. > The only fix was to quit GDB and restart. >=20 > Solution: > With this patch, all inferiors being resumed have their > control->stop_soon fields cleared, so gdb does not ignore the > breakpoints of any inferior inadvertently. > --- > gdb/infrun.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/gdb/infrun.c b/gdb/infrun.c > index 543cccc5311..894157ed1d1 100644 > --- a/gdb/infrun.c > +++ b/gdb/infrun.c > @@ -2808,18 +2808,18 @@ clear_proceed_status (int step) > we're about to resume, implicitly and explicitly. */ > for (thread_info *tp : all_non_exited_threads (resume_target, > resume_ptid)) > clear_proceed_status_thread (tp); > + > + for(struct inferior* inferior : > all_non_exited_inferiors(resume_target)) > + inferior->control.stop_soon =3D NO_STOP_QUIETLY; > } >=20 > - if (inferior_ptid !=3D null_ptid) > + if (non_stop && inferior_ptid !=3D null_ptid) > { > struct inferior *inferior; >=20 > - if (non_stop) > - { > - /* If in non-stop mode, only delete the per-thread status of > - the current thread. */ > - clear_proceed_status_thread (inferior_thread ()); > - } > + /* If in non-stop mode, only delete the per-thread status of > + the current thread. */ > + clear_proceed_status_thread (inferior_thread ()); >=20 > inferior =3D current_inferior (); > inferior->control.stop_soon =3D NO_STOP_QUIETLY; > -- > 2.25.1