From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by sourceware.org (Postfix) with ESMTPS id 970453858C31 for ; Thu, 14 Mar 2024 15:20:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 970453858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 970453858C31 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=198.175.65.20 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1710429604; cv=fail; b=tuKy2HvSDhhdkubmBJOVncNq/VqdB/QRgo8Ic/Gje2E0OHpQq9Q0dWyrYd6evNuX7vUqCh+qHlWLjz2QW06pskq//OHOOoEQejJ38zbPFFTjzuE3NyTD0BjXyhghz8bhALYNXHS04z45ctjpus2oc17MYGll2v9KrvOWZn5McsI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1710429604; c=relaxed/simple; bh=hXNpl4BrPEro7K2swU+hQ7ojZQvBkuhSP09XNbLFE8g=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ovebZHmGmcQ53DwciAWZZu943LylkkNrg31mCJTnKvl9ujAX/cQg7CAnUn1/DXqQuCPzgYpgnzZrGuGWdl9TqHnXX2E8OaId7S7gLjhRkwMF8djj6Gbr1z3t2/unDqk6Y+kst95CMAGa+jlg/Kh2nIkthO3p6yO/5X4YjvUJNLI= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710429601; x=1741965601; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=hXNpl4BrPEro7K2swU+hQ7ojZQvBkuhSP09XNbLFE8g=; b=TAIsrystEQSgj2TNAoPbNkB86lRcHCBQR3zNCZ3u6vrKBm7c1qiNZDcL QV8zm/b2XGOOGjcVVM5i0BRhUQ+v6NF8waG9zz7ivplHwADknP80PmLH5 SXx4+0K/Tk1bvjRSWB3jguqekxFoBFJYVTCCST3NfoD0k4Dqy32ex4Kkb Z31iMoBJN5GQFXtple5RsroRy5z81HaXxoSrwsXgH4a4Rvk26shbACqhm DXXsdZ40/OGbjlJo2Q7TZdiTetIMfABY9MfXxZM+UH/LUsrefe/Km3ExD 2zrLS335jfE30xbrBzjiCNwejUylEd7MwlXUD40LWt69LpqESxGxr+ybF Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11013"; a="5123115" X-IronPort-AV: E=Sophos;i="6.07,125,1708416000"; d="scan'208";a="5123115" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2024 08:19:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,125,1708416000"; d="scan'208";a="16920436" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Mar 2024 08:19:59 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 14 Mar 2024 08:19:58 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 14 Mar 2024 08:19:57 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 14 Mar 2024 08:19:57 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 14 Mar 2024 08:19:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E+6+grFcmUCa+wWNIeGGwm+SSKzz+ihfbT2VeAiqChcy46WB6K/Z2zpVs86XyRzQOgJbODKRWVoy9YwpbSLy7AuYyLEXHyadq0WU5S+gUs5m/WhwiKklBwtY6ofsdBqdQnLlS8QeVx9Jbv4Ky4+2H4jEbwNFVnbeRXMdqUPNnMxNoQwHIrU0glTUHRie/mOuNJNw1yMWzaxJlNagbl9INKEEcsicnVaix6ZlOzNEETlqu5TF/V4Utlb96BV0ns60Qf5oxFwFEZE4IK1UqmLYRDlhL2eR24MhUiCEshEzay23DwwxgoOO7HIyIa4N8Mhf9WcSgsdc/8lGY/D0ZsnVBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NIDChEXTmq8yFN9bV9NHX2AV29HxyfK8HMZYceOE0dc=; b=BR+iehiFGkjnZE3BPphATcclBcSC+Y+Fp1Vz9irHX4ygRcaAFmJeoi3LmksW+3UVfqYhJpSSX2Mxw5nJfkRTwxhIthpGfU7KVChcFsf+e+m2pWNGkr1JdU6mG73lJ9Le3GzO2q+K0mGLbgFMHDLNRWfwBsntuB1XOIIaA6WI6AhM+Wbd96Ay/tnjnLxHWhFWkFTzjp9zbfJUwXYP1rwapPjNDB/UObyLfLRNqCwDSOBzSG23gfTmmDEC0yCv3ng98V8QAqU9p6lX7S+D659nfUMwNLtllHWHF+L3rUyRXJQh1Nt790TCuWxd6fpDHCl4lExZ6gm+saEwgUt656SvHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB7303.namprd11.prod.outlook.com (2603:10b6:8:108::21) by PH7PR11MB6005.namprd11.prod.outlook.com (2603:10b6:510:1e0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.20; Thu, 14 Mar 2024 15:19:53 +0000 Received: from DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::d151:d3b0:297c:ec32]) by DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::d151:d3b0:297c:ec32%7]) with mapi id 15.20.7386.017; Thu, 14 Mar 2024 15:19:53 +0000 From: "Aktemur, Tankut Baris" To: Ciaran Woodward , "gdb-patches@sourceware.org" CC: "tom@tromey.com" Subject: RE: [PATCH v2 3/4] rsp: add 'E' to escaped characters Thread-Topic: [PATCH v2 3/4] rsp: add 'E' to escaped characters Thread-Index: AQHadhCwG87rkCjoa02jtibRsFbMTbE3P/KAgAAZFnA= Date: Thu, 14 Mar 2024 15:19:53 +0000 Message-ID: References: <2df4539dd59feb3b70f15ed679563a85bb286075.1710420898.git.tankut.baris.aktemur@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB7303:EE_|PH7PR11MB6005:EE_ x-ms-office365-filtering-correlation-id: ad1bd920-8173-4eea-d4be-08dc443a32d6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cv+B/0C3JTIECv3TllFrPTi77PoB8JgRnBL3fRdXqfj28QP4f5muku0rqLIpoautolbqB3Cg9gbbmYvTCzwZextMMFt6U/N8tkW/s80gh23tUNLtpKQZ44+H6CrqcBUGIKCtS5hSvRC5R6A81HiXvgP6LLwZX7Dnc+qDqEAp//KupGzUfIdi8x3lBr9CQdwsyzNdDmhDQnlpBa4K900QOfPRNm3hDtXns7g4DOVPmV1HnOVaxQ2tM47zLINJ+udjR/MbCtB2FFQnhYQPUtO3itY024MC4NGTmVgrB9tTR/FLGqRIbBqYQXRYbZMIttoQHt1zO0g6d2iUZyvgVPMtrrtRXe+h+5oUtDxagpSpUtFPh2+4EOTssl2kzix3AsUEe7toWRr4FFznPLu1I4NTLOnPORWRoG0bfKckFlDFAZbUHQhmAuJA2BcY9FC48fKPL2IRURMr2Z79aHeK7gZKzrI0jUinyuEYc4WWFpQiOKjQE0PkxwpvikqG+9TULKnbW8NHbd8qMFOAYDbhOUBRZrLhSQ0q5uinhdk8wy9ZfdknkfxHRRytLZq9FKkTfqbEsXaGdBfZ26/MiMHMDfU+SukzeduM9+M2CKfdcuFkNWhiu+Uq65/zoExko39S80mxSvAEpYI9GI8ctfBrt7+hgNPBiXU9ALMEs9Ao/lhMcZvLKA6nLd1jJcP8U5M1C3bT2w1M4Dro4vTp75/X0tP+p/YTtrcKKeRFmPbVhm7qsN8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB7303.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(38070700009);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/yboGxSnhov7vYVAqI19/z09GIpt2JBjZmC0BloHMXB0yPEYZes9rl7Ves0Q?= =?us-ascii?Q?0rgoA7wvVSZlBopoNQXIHiZLd4apBs4WSE03yx5OD+YTT179LkigDQcA2xNY?= =?us-ascii?Q?k5e8SibcVIaR5+YMDftgBVhlNSDa/PnjWby5w7t2PhOCEG2ATzVH/05yZjXN?= =?us-ascii?Q?Uze2AeCiPDEIhvzVnzWSwfy83qowKqtYMZHpPWB/fefb+e3uwEnZqiBxBdp8?= =?us-ascii?Q?WjFoZPB77LmScp9wIaqo9//TvtcCis/ZTRpduBzaS2gZUWRA9JKljSrWi2Dk?= =?us-ascii?Q?u0dQhllQhMPlGQcNBh9SnZ2pffLvF5fpsKDXNjiIWBDSe4CMyFWdodAbJltE?= =?us-ascii?Q?XkVkDOeETI/1S5Q6FlZlm7793StuV6xhsqeVbiu8RjuJd5rGhxzLBC+zrv3y?= =?us-ascii?Q?YWcWkFzyyjfDBDSC9uMkHl2SVPecujr06oDoOjqvnfvFkBpRadHjEljaZ57A?= =?us-ascii?Q?6cq6BIbjK3+NcfMXBaQNpBbn775Dy//z+XGq3nhQaavKkLzwRZEy5FepLBxK?= =?us-ascii?Q?Z9crTuySim203WdTozPKGnoFAsgbJfMYeR0qmDrs/0TeknVfqKKUI4f0Njb1?= =?us-ascii?Q?c3R9pEATrGiHVROeA5ECCWvR4ejcgw4ECRwHasu/rEGQeIEWqxcPiuFAPOzW?= =?us-ascii?Q?NyliAOd7Se21NB7bkjTxu5ISKR/lwhcFslueYRlWO72ZlFk2Dew4RxED5dYb?= =?us-ascii?Q?z/a++Gok5tZEYo+dSTxVR5Gg4bCr3ORLMnI91Q2Gqou57LFrnL0SLcoCHBDQ?= =?us-ascii?Q?9Sk57ucDP88UzkM46Tl2Z2ECv8hYgNiGPhRnUpEuietZxH8Jw4pinGGQHul2?= =?us-ascii?Q?EbPuW4P+wmZmJ2XEKpLA29rgB2Xobk5RX0Gv68Tdvt6xw0Eyh+D05rfvJYFj?= =?us-ascii?Q?INPUWJWJKalGx2AQjmz5q/OYD0/myzyFIEpbkMFMdKNq0ofvJrC1hXl3/DNj?= =?us-ascii?Q?OuSxIl0d4TkRZdV2B9mf0B2oB8+deq7nuW5NLxk3jPAIJGIMtGvQCJ558Lib?= =?us-ascii?Q?L3LSgYRHj9zzoBY4IKhoPuz68FMAgXcj1ecU3SFnmHONbMwxg8rxoeYgjRjd?= =?us-ascii?Q?ShcJ0HpmPdGGq8rO8RAe8pvtSCkx7U8/m99djtMVxrzTyLDnLiepFbU+XGpT?= =?us-ascii?Q?65JRVw7+qS42JDaFiSKxHIO6ehvSGYFOQwxfah3NP+CAEy/6DQ40fyFY3dih?= =?us-ascii?Q?X5O3bo1x5i94DGgB3fBXAPur8fEugCONTmqv6AKJMJUbIrqhRYBwy1VrQj30?= =?us-ascii?Q?XsfgllTQhvVatqHq9UZBmKA6v9/vuG8VRAYr72sybA3HrytVsLDwtAcoY+LO?= =?us-ascii?Q?gvO07BazIZ+T+BgBsHW9O7hM2+fxKA8eOsNgh6pBMj7dwZW+hB6tX4zo1OiR?= =?us-ascii?Q?XysOKaXlbZCYB6/sgIXAS8d9FEi7xNsUMjpGb2WqLIh4v5CZxT3Tn63DlOFe?= =?us-ascii?Q?QLOGo1g1l7T8iTcLLq1r+1LF1fmkQ89MnaVG7y3eGHfV9FJDRKHmGZdq+WtO?= =?us-ascii?Q?JXsW5kGS4koTHUI8LX8lhKopxg855m6mpZ6yBzQgRkEFBniMM+w+4oyhRZmn?= =?us-ascii?Q?NNffK1ie9K+9rSAkXyetDssvoC3kaNxDlRUt466NmE7yrgK1S5ZOHpIjf/3I?= =?us-ascii?Q?cg=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB7303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad1bd920-8173-4eea-d4be-08dc443a32d6 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2024 15:19:53.1371 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rS9Zdy/tntU2piPQIypoH/wnVs3JTy/6Oh4otUb9fjT0IiLanYwfn1Sr175MT2LBwaVMNrId6GVPRwZ5XyJRQBxB5CAmLEinKxfYnlpGReQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6005 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Ciaran, On Thursday, March 14, 2024 2:47 PM, Ciaran Woodward wrote: > Hi Tankut, > = > > Add 'E' to the list of escaped characters when sending/receiving > > binary data. This is a preparation for the next patch, to be able to > > distinguish an error response from binary data that starts with 'E'. > = > I wonder if there is a better way to do this, given that this is for a to= tally > new packet. My concerns are twofold: > = > 1. The other 'escaped' characters are part of the RSP packetization layer, > which is conceptually below the message processing. This new packet is > looking at both escaped and non-escaped message in order to figure out > which type of response it is looking at, which is (in my opinion) > unnecessary layer crossing. > = > 2. The idea of allowing this list to grow when there are other possible > solutions is just less scalable if other new binary packets are added > in the future. > = > Instead, I would propose a similar approach to other packets which would > have the potential for 'ambiguous' replies, such as 'qCRC', 'qMemTags' et= c. > = > That is: Always have a leading byte (not just in the error case) in order > to disambiguate what type of reply the message contains. > = > So (for example) the message is something more like: > = > 'E NN' for an error > = > 'd XX...' for binary data > = > Does that sound reasonable? > (Note that I am not a maintainer, so would appreciate other opinions!) > = > Thanks, > Ciaran My goal was to keep similarity to packets like 'm', 'g', 'p'. Starting the= reply with a marker is certainly doable. Let's see what the maintainers will say. If= that's the direction, I can work on the change. Thanks -Baris Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928