From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by sourceware.org (Postfix) with ESMTPS id 55DAB3858C83 for ; Tue, 16 May 2023 15:08:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 55DAB3858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684249735; x=1715785735; h=from:to:subject:date:message-id:references:in-reply-to: mime-version:content-transfer-encoding; bh=O7VGTld59yuiEtaLsmyPFdL1fmLb6UmMsgxp+e0x7CA=; b=NuzVTXVM2vIC0axgAMU0NOwVcy14QYfpQZnt/OfLJbZgRoVIyF2QpX6M uXuIRF8ciurI6bFn1V7nzkjIYwzOkeXtyHy/dxjAIA6yZziD0CQOjtfDO 57FcbBjQTItVpyXsPUzovEJsw1Tu13fy5+YEd8mYjfSBaktk5klufsQrq founJ9iyAEtX32IBH//BZNbeh2SmEQsRm2x+ZrqTazRKI7+NdNLDpdc50 UF+P5CcyAqHrjVP4TMg8rOOaPdZwToP+dADK9OKPARwJ1Ri4JJehz+dEf aZLGbkrc/5jG2QhCTuhy0KgybC6f3ctj3DR/0njcwU1Z39INuBZ/Z/Esv g==; X-IronPort-AV: E=McAfee;i="6600,9927,10711"; a="414909451" X-IronPort-AV: E=Sophos;i="5.99,278,1677571200"; d="scan'208";a="414909451" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2023 08:08:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10711"; a="732023832" X-IronPort-AV: E=Sophos;i="5.99,278,1677571200"; d="scan'208";a="732023832" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 16 May 2023 08:08:36 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 16 May 2023 08:08:35 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 16 May 2023 08:08:35 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 16 May 2023 08:08:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wc3u6BbXyozueYq+8ndEOtnjeWIApT40hXzoclvI3Xf0CSfxKtq2mF2x6oBxUtfUiEslWQM31TChKec3jks+ZxUL0wgDrb93nCUERad8JJyFnaBywo/XMfSDs3po2Cf+rnpCj+pnpRVnzcB3hEfCSV05WfV7/m2ML5+hpEI0pyJosXiKROwlttpR49sxTae3iwi0XKdEcTJXhVAbjOC7XOfYb1zJProMMGyOTpRf35wMX02yvcS0DLQH4DSDmHHyQtv/lRU/D9Qt9NvZzJ0lPt0XsI/iBnShFOu6I/Yqzt5ouLWDkH0MChe8lHuyZdw2jwPT9F0n+aoIso5W4qgE/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9kFESMfHt2yGtXHG94I6HglOYjN3Y+nkPxiz8xYB3bY=; b=Kuuwz0phLDm4ErSi3KGQ7Dt63IpXGQ0wiqOVDUGtIokBW0njoynjGpuSdTmF6rSXzjRIG8Bb/vk8aGmeaO/tFy31JNf7/T5Cf5ktV+7tGXgLcQVHPt1j9SKwLN74+Cpdv8JLJXItd9C5xlVxmB1+5GYhhCG/g7ajaMLm15QVIb/9m2ulKA2ahGZfsaWlm8WvaeTGZZJGmU0DeILp8bnc/nNd2hFS4rjAOtTHAbwLb6QuYZ3OIqDDQePFiRdywebmiACUBGkw5izXidWfDAYCalFwT5zTPz3IaAulD6Hrll2ru2UF/d1sANlglZx9Priu72Ar00L57erXZvaNBmM9zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB7303.namprd11.prod.outlook.com (2603:10b6:8:108::21) by DM8PR11MB5623.namprd11.prod.outlook.com (2603:10b6:8:25::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33; Tue, 16 May 2023 15:08:33 +0000 Received: from DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::830b:dc92:e628:ab8c]) by DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::830b:dc92:e628:ab8c%2]) with mapi id 15.20.6387.030; Tue, 16 May 2023 15:08:33 +0000 From: "Aktemur, Tankut Baris" To: Andrew Burgess , "gdb-patches@sourceware.org" Subject: RE: [PATCHv7 1/6] Revert "gdb: remove unnecessary parameter wait_ptid from do_target_wait" Thread-Topic: [PATCHv7 1/6] Revert "gdb: remove unnecessary parameter wait_ptid from do_target_wait" Thread-Index: AQHZh2Kk3XgqBfopWEanc3oUDutwM69c432Q Date: Tue, 16 May 2023 15:08:33 +0000 Message-ID: References: <60689fdeeceadfe1824f99f47f88f4172838f45f.1684178293.git.aburgess@redhat.com> In-Reply-To: <60689fdeeceadfe1824f99f47f88f4172838f45f.1684178293.git.aburgess@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB7303:EE_|DM8PR11MB5623:EE_ x-ms-office365-filtering-correlation-id: 6fa7cd7f-e741-45f6-453c-08db561f6a8b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jbuy3V62+wsX0vJX09M3eukreHRt6DWvrMJcnEY+J6ZUgZZgYsa579BqvqGJOHiqOXz2lp/gmhZlNYqm4n5YLB0W4cR96keRzv+fsH80T4mLRumMM5i1d7j3vD0eoSOxBGvGLN2d9r4O0wxrSfELXhs7D4gORheiYyzC3YtT3vmd/E40jdDDv9hzSFopOuhWcNFvYEB+ED7K6JkjZPCAJIQaFeypD56cqt15Gsff1Wo1y8NK3kUy6G2d3BpqXkWQuUGs6QYQ3fT+eY3sDDVTM1HXmyXqHm/19UlQranXoFyAEMSqDNtLrXlkmLmklxod5t6U9qEgmzCnPtf1Cif4DnC7Nl02wdufwQK3hTJqIgTxhfxl/SIwBKwVX9tz+1G5T3yB40J5WB96JtF3okCK0YTsZ6JRIQkshRJJ0ce+l0pZzIWmeoJfQOt4WtwMa1n5nDVamlrey9JqDabjAoLnmcI/vNt4U1MLpkqMihPpt3hW2zPnMTqOWkRoeHL9mwLTY/4Za/PVjP0DDtN6Kz6UFUB72LajsRW/sPn8ArfvWGKwBryHyid5Mkx4ht243nyZNPcsXARqp8XZURUBiym19yU558ClgaDGpdprWgP1HOU= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB7303.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(376002)(346002)(39860400002)(396003)(366004)(451199021)(38070700005)(33656002)(86362001)(7696005)(110136005)(316002)(76116006)(66556008)(66476007)(66446008)(66946007)(64756008)(478600001)(55016003)(71200400001)(8936002)(8676002)(5660300002)(52536014)(41300700001)(2906002)(4744005)(38100700002)(122000001)(82960400001)(6506007)(186003)(53546011)(9686003)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Hrz5oUaEi9YANrFmhsfhmuXetvOwZobn+7eO2fekt5wajWZ3S/CI35aUpqEl?= =?us-ascii?Q?YZ8wvWG57SLJ8eIRhfIHUmOB6sGi+Jmzq2EkZvv/fVDdE+ZPVrUHcbouliRB?= =?us-ascii?Q?uALx2BwrNS1cQmLw+fPNKZFjTBfthda6/9LEc2oCP0Zh0BEuALacx09H/fJT?= =?us-ascii?Q?cP4wPVqc05/xZlnhPle2RMpONvkaZeinfp09ySCjFri6+RfwcOb59rhqBZ3l?= =?us-ascii?Q?txd44Grlcd+jAN5K5PVEhMMkzFNp5GP+a8vmpcqBEIJEte8teQ0FPjyBaoYk?= =?us-ascii?Q?Ns06xmd/505PYwGfr+gL0lsVodIh/OKv+VmHoky++4ZLMkFrgFVPcoSHeVQn?= =?us-ascii?Q?kD8kSzrgyBGLjwISF07UyPmFZIv2NP/huyOZW7PpUZ1Xsk7W7JvWhVpJKpUe?= =?us-ascii?Q?T0NFKeXOPqEYyfyxM4fHX9S/tlvsfwXJXaqou8RzGzzFNpOwXt/4DJ91WGaU?= =?us-ascii?Q?r3p5yvCZeEbKMSeconrDqo1KsGBzMbERlNFZGx3MwALdUafQGJreFOxgOLMZ?= =?us-ascii?Q?ra9XXQvwO6w/TtnfUcoPrF0wRfqDY/Wylq+Zk35AfljmH6JnOKgOZmkpG7gd?= =?us-ascii?Q?M3wC7mi0qLQb0/BN6o3qJgifHssOI2du4sLxL9GAMD/QV+cMk4mWLqxfOOrV?= =?us-ascii?Q?25hRReIzTIU5AXXYhw0ItuM3orbiz8Xc2tEIVx05IpNNTIYFgkWuvu0r3mdj?= =?us-ascii?Q?qPA1O/U845eTxcHDMtFTggmQfPKUDDERd9V7kvVupX/CgyaTcOtsLmH4mWp9?= =?us-ascii?Q?vH6fPQoWONYfww1/xitv5FFT0HtGz+/4UtwO3NBFtQRJoh90qEHqyixtRh6O?= =?us-ascii?Q?w994KH14MA8shvT1j01s2iO+MK97IA+Nd2Jjmh5aard5SH3tgkIZ8S+xaQdH?= =?us-ascii?Q?fOMGJzIDA4K91Rpwpsl+Z2Ol1F/Hq7LgvjoGJuBEa3vKeZ38BhrFmBpw1HPd?= =?us-ascii?Q?mqdjZzx1iFebkLwomurb7N4XUtd+y1+TkeOnoyYukb4IdNQGf0idwOyEx9wZ?= =?us-ascii?Q?IzHGgAZ/XRn7e93HvoWhyQApCLOedEsxfAna//jmiQtVolrVMomW0iAV8itX?= =?us-ascii?Q?6ndP1mAgXJvsybp0VYGYSGIviVY2lQ36F05wVdyp4N317x9BzqRWw9sxoANo?= =?us-ascii?Q?yYWyYhlKO47bcGO9M4TG6CBsBb3EteVfc86Zeyq08e6fLle+fN95jYVWBMBz?= =?us-ascii?Q?p+v8aIJjyqrzhLlKwGWPzXqcjOx5DwCvJWNgLpYK++yV2JNcqBI6Pn+3byA7?= =?us-ascii?Q?yD8fh6crh0kWSYhjcleKQIoxNdyF2G5T81/PlLxuMzOJpVtDpepFlli7LNWe?= =?us-ascii?Q?X0/DhbFagoM8YNVI4aYi41397dlg2waTfBKy1zF5h9XKBq20RH+DGLr6WHK6?= =?us-ascii?Q?F9GVBBXJLuhWJKCOfs/JQ0rE088DUx6SXLWPWd4ID0wiTJS+kHfMSxqIJclw?= =?us-ascii?Q?qDavUzUYv7zuNwcHilIfDQcY4cSrT0djsCsOJENwKgr0TCFyuLQsBd8VFUYR?= =?us-ascii?Q?F2pLuL0DKGIt4ZvOhVthWTIza2iiIbi/D0L0Xhik7W5INFGdU5lUdg856oFC?= =?us-ascii?Q?zKVoXMTpkLW/8oObyTaRxSbUIiEqgNtGY8ZKENkkbitZ5UD4YoxNo/NrY6Vq?= =?us-ascii?Q?0w=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB7303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6fa7cd7f-e741-45f6-453c-08db561f6a8b X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2023 15:08:33.4024 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: K7sk7UZMFxexQMxXJ+u0xK28V4pozpupqg8TA/up6b2DuGZjYQy+9a5DbjmC3ClQJdIDMggwnf5S3ZCxnUroy6OY68Bm99NxWb6vJUQqACo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5623 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Monday, May 15, 2023 9:22 PM, Andrew Burgess wrote: > This reverts commit ac0d67ed1dcf470bad6a3bc4800c2ddc9bedecca. > = > There was nothing wrong with the commit which I'm reverting here, but > it removed some functionality that will be needed for a later commit; > that is, the ability for GDB to ask for events from a specific ptid_t > via the do_target_wait function. > = > In a follow up commit, this functionality will be used to implement > inferior function calls in multi-threaded inferiors. > = > This is not a straight revert of the above commit. Reverting the > above commit replaces a 'nullptr' with 'NULL', I've gone in and > changed that, preserving the 'nullptr'. FWIW, this looks good to me. Reviewed-By: Tankut Baris Aktemur Thanks -Baris Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928