From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by sourceware.org (Postfix) with ESMTPS id E9BDD3858CDA for ; Tue, 2 Apr 2024 08:52:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E9BDD3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E9BDD3858CDA Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=192.198.163.9 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712047941; cv=fail; b=aQd00ODo/YLwP4xNcMmwrrCepvIrDv6U1GyOiF0uXfgtmshCRK/rWgUssKDs1B2Lva3t1/4MhBxUv2WOjnnuE/tR5ttSrTjO0+A8BNrAT92y9nYdaRGkfU0ota1Ryqkny4ENnIdMMafJ7YTqFnq7llKXf20//X8W6GrPGAI8at0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712047941; c=relaxed/simple; bh=7Y0WcjbEnD2VYT8Ug6y4p9VtuXRtQE2SWEVLQGQYFFU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Rd/jReErCQi8lSJJcNvJ1mcJx1RJ+agtrHsM7xfcgYpPWjlN8udxW5rz/lHk8GafiTbobft2gFEAEPld4MV43+/liHcSFEK91LZZQ1YYOoyOFw39cqZaDFQqvS0sPmFRACsZlbkNAMEWydS/v5QkXWUiTOXPkB2Ml5O7t48WctE= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712047939; x=1743583939; h=from:to:subject:date:message-id:references:in-reply-to: mime-version:content-transfer-encoding; bh=7Y0WcjbEnD2VYT8Ug6y4p9VtuXRtQE2SWEVLQGQYFFU=; b=f11sCHVEoG3hJmZ/yNY9eKLL71wMNmB9oIBd3QHfyzlF+3VfbCVfSOpu TOmQSUoRxKIxnMOvjI7Fr7JQpFuCd7GXEMq5K5LQzzZ4BKdX6T+tC9Cxd 7kDRF0qd3EtbLcDJRzsZtvpqoZHOuwJzZQijHQvaJYDOeIcktG/2YglKy a6jzCS23QeaowXLgKnGIrLMlegtWirhnJO+FdiTYFPj6nLKlSlp72GK+d NtX6M2Kt91U18wjAMe5MFkPtFD5WfyJNJ1FiRp/SzbEzLV+Vn42txbS5C Kmwxu76JmpgU3RK6WRaP+/lTtXtk9ZPfkASlktfr4rvJLP3/Ig/ZraLlt A==; X-CSE-ConnectionGUID: 8W4XuWKXQHe2s1Pwf4B22w== X-CSE-MsgGUID: MkneCqu5T+uoglXNTB0oKA== X-IronPort-AV: E=McAfee;i="6600,9927,11031"; a="17930638" X-IronPort-AV: E=Sophos;i="6.07,174,1708416000"; d="scan'208";a="17930638" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2024 01:52:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,174,1708416000"; d="scan'208";a="22474500" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Apr 2024 01:52:09 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 2 Apr 2024 01:52:08 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 2 Apr 2024 01:52:08 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 2 Apr 2024 01:52:08 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 2 Apr 2024 01:52:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D2WBKU3IP4vfqZF7hcc7SMzRJQzdBm+a7AxnYd2JjN3hhaoryymbPeaGUrNnaHapPdguW6Y+kswkvF2AYS78BFJuyNtSHsx5jQeBETpPpdCWB0RZ1rJoIu+KUpJVtcWcXrYPP/SyePtaSOoIQYsxA9bZgtnXkuAtL0w6AnKYaYN2aDf1GvUQKxH9vW+GyFQ4Y5UbakmhCgDtOWTVwpDh0tce79BWw6btUWEI3olSlm6/TErrvdwPEfWzKyhbj3S2S05mBMftpnUz3eqsj+1oq8aKhQdfjUHBqcfcWOetP9LAyGqCvzqMV/xJHIYPfXUzVQTBhr50EooL5rVjxJI1Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1AsVSz1YFQEPn5gdRvjynTs0rW4EYIIYB8w+YnPQWsY=; b=HRymGhS56X9MJU+XeOZS4YHl3YRceJcdVLi705NBc7AX7obVDZtcQfrRZKhfPP3pQ3Z1deS9wmGQQiZVtXcSKKxgDzOP87AREVu7vfmGALe5Our09EbHegnP7o0kLza49QJ1YAz+pWSCEJle5FiuZgABmXtR4I+QGSyVF7B0w2JYh3wK5NwuoqcHWvx6xkkIFs5bg4ysHhKonJfJqy4WoKukVhQSLY0xwY4xz/b8ikT0lqNA0/AvfE1Fc4nxyu3ajb3JqmgtIjzmvPaSgAbtHl5DVIV5VMVxOY5OTwCEaHnfluNNT64fpeAXooVIeXp+3MYmuK4fgJdZozzzJzlyig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB7303.namprd11.prod.outlook.com (2603:10b6:8:108::21) by SA2PR11MB4891.namprd11.prod.outlook.com (2603:10b6:806:11e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.25; Tue, 2 Apr 2024 08:52:06 +0000 Received: from DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::9c92:b02a:3add:529e]) by DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::9c92:b02a:3add:529e%5]) with mapi id 15.20.7452.019; Tue, 2 Apr 2024 08:52:06 +0000 From: "Aktemur, Tankut Baris" To: "gdb-patches@sourceware.org" Subject: RE: [PATCH] gdbserver: require_running_or_break for the 'z' packet Thread-Topic: [PATCH] gdbserver: require_running_or_break for the 'z' packet Thread-Index: AQHaayUBDcI7i00SFE27qGrbes//e7FU34ow Date: Tue, 2 Apr 2024 08:52:05 +0000 Message-ID: References: <20240229153541.3057573-1-tankut.baris.aktemur@intel.com> In-Reply-To: <20240229153541.3057573-1-tankut.baris.aktemur@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB7303:EE_|SA2PR11MB4891:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U4vogjrrZEgXP1pswhxt6wrYN95rIr+5dOo3pLDkwJxetesdT0F2tq6H5xW4vIwJTosYGkaI7YpIEH8aV9xHpZB1Knd3Tn1Egmpxzi/d12gXg6Yid+fZRswA7WVgDMfSn5kSqDs3b5+g0ctw4QnqTzTe07v2ygRtHll8+wvkpOvlGTQdqYmCbYMqzJvl/gqVt5vzNzRVGOjrDX5D28kbKcMD8hCTjUeNjMQpyO4CbRZrglyaqBnV9Z1WrH+0EHCPyVxvCBgqgs2a+JMeF+q99h0kcwMjNpz94cMBZLlNUL13vp8A5DKvdWO0xRR6Jlj5leba08hz0Z1WcGefCN+Rl85E9BqkMb9o4Z9xKcIU+7PWQwmtYfj0uuLXppRcc997HtAZu9qFFkh8keVWcvyL6FC+n/qAnyJpmC98Ha94baLMLgsafSDP90r24siqdfdcJeTIexX6P29PA/yiRbZy2999KR5T/UQgNaqnSiCM/XlJ/WIvDE3uCUvH06T1CpwdxBOqXtjmMdtMs4Xi05OfE2SJ+YpmsxCyIGmwTxXJ5qvLCBnTmX8ox6jDQASXU5NPdnl+FtHs4SqVIv17fqnpfArN/s/K+gfW0Mxz7tWBismNdY51xbBQT/LcwWclKZsowPlu88NRr4IQ8jkGaoBHlwy1Ew2QgicxpI7anHVWFSY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB7303.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(366007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?z9c8nFDeQgw5h5QhjitKqXpTMGQZaICkhXy6ztVXqb/5uIJjTKqt22D6Dqhy?= =?us-ascii?Q?qGvribx0V5XisIQfpRjL3JLcSrv1pNAYqU4pYZ2IY3PRY9QsvHoFPnyiTeUx?= =?us-ascii?Q?PfFyDvf/3YXur7CyQ7eXVPitMLL5iTgj6H6yvVl7VQv7m0PtkM448KW/rWuS?= =?us-ascii?Q?l5Kc6NyFQHaC5I9j+24A7dtEoTwt8Vsxf9Mge0eNzIVrV3AD621lgknQHqiw?= =?us-ascii?Q?VrjVY5UhzTDw2NHlLvMrQJ+C8xXMTKMyefBUa2SZZnvvDFUWJc58EiqJco1H?= =?us-ascii?Q?3/V09vJbOdIwCxl3ztXcEgJqw9zUoMnn0OZrTiGRmDJhzMnhsRqcLg2kgOs4?= =?us-ascii?Q?+IWdwbh6+JsXE2JIuo2qqfn4lgmpELh+8pjNv1UhnSaFCm89PoZbBT8tLPeI?= =?us-ascii?Q?nZwWb/z5Nva2Jswml/pvs9Acyiy2HHnxFWXZzpxtus64CxnldH8rwi5cd8HE?= =?us-ascii?Q?tWpPcZ7CRp1pPITn/ltnQSgy7pNVrkyEAbxaWme635GQEBflBtM99dI5SSNP?= =?us-ascii?Q?SHc1amcaIvfn58h1XQsCRc7B10u6MqTuE2BEdMdCl2APUlRsmcMRjfXwJwOb?= =?us-ascii?Q?skrZ6rOCv5qGVysfz0IQnVRae3uF27503B8hACf0obfCSOfgooaIKh4Fdr48?= =?us-ascii?Q?J/oRZTIKoB7MqRVav46fTTcdKtrKstker6xi7Qf+FIEldjiiAS8vjTE2zKT4?= =?us-ascii?Q?ns3ofSDcKUWiq+p5fxPC5CVIp2Iq2kxmk3gXWIpiBda4+ve/+3AHWxZaVrWH?= =?us-ascii?Q?hFgbiZ+zlehm3G1amQ0rmMJhZkNAbMx7/pR19JP04vGeyUnnakeVI/FiyXL5?= =?us-ascii?Q?vR9ZGucJPD0lm6YFnm6CI16eZYv0A6Kp2N5ik4HfS0ltB9ucbzGNuz2yRfOd?= =?us-ascii?Q?RLJfl6RV0kyjSsvd78qI7NqawZF9AKVbu1WjtHdWkYPCIuOFOu7ZmpuoIPtB?= =?us-ascii?Q?JFJWwZCjbMiaf0qeO3IJKTf3T+aPf2rn0dJUCGvTsKUbel9nfH2WAW31L+jt?= =?us-ascii?Q?kiWbPLdE5KN+HsXd9YzsZMwtR4223WPMppS+/nVlm9FMmMswtaAPccnbRV49?= =?us-ascii?Q?tCZ5yZYQUX9pwYReqHdzRoJq4iI2eTl53Ae+O6YBzSsPiBWI6s4zlYhpueGL?= =?us-ascii?Q?rdpzQtvMKOAquMw+Mxel40rrbfJw91O4SRVUOdh90DQMci4bGmc+QRM5NPdQ?= =?us-ascii?Q?H4KnR+xPRhtiUAp6+xDjICLMija6w1yB7QLTxeqFnTyIxdIsRUGlo0WeUc00?= =?us-ascii?Q?wKS9Waw9FjdrYvCPQ4lCKsDpmmdtNtc1SIYQZB+MG9mG/uCdkd2FPfh9kSGR?= =?us-ascii?Q?4Vx2l2rpwi+5/0nwBUwffkevjAvcctVw87wdno74RrSh93bJBOsPlgdVWmVi?= =?us-ascii?Q?9PU0Ql285Tt9racKUwttY2/Aqn4ysxti4dzzwZMQMkSD3Cjv9Aw8RhuWzwoM?= =?us-ascii?Q?f4IBHP74a2w4Zb2Gfcn47cFoC9xJ0sTrd23bg+6Ay+Yj+iGjUOPcTgi1OzTa?= =?us-ascii?Q?RQXU76YG5VYOqg31ndMpP7b71W0/FMiWoKhskmaocNals8LbmacMItROKtIu?= =?us-ascii?Q?k3Lm5FnPuQhk/LysHnt6zwq23UqelityprHHa57tKxi9rgJfF3t6XMLdn1Mp?= =?us-ascii?Q?kA=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB7303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78e9eb46-e0a3-4509-2f07-08dc52f22c6c X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2024 08:52:06.0124 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c/U5QvgSpO+Nnvhm71INr76iqQg6f52jG1JUa6mg22T47vrTXxgRrD9mzpwivZa/JgWNh9KOLhWpfji1Dg7+Hslf1JelZ+SKX5Gn6RcolWo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4891 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Kindly pinging. Thanks. -Baris On Thursday, February 29, 2024 4:36 PM, Aktemur, Tankut Baris wrote: > Similar to several other packages that access/modify process state, > the 'z' and 'Z' packets need to access the process. Hence, add a > `require_running_or_break` as a pre-check. > --- > gdbserver/server.cc | 1 + > 1 file changed, 1 insertion(+) > = > diff --git a/gdbserver/server.cc b/gdbserver/server.cc > index 74c7763d777..8b9c4df50ae 100644 > --- a/gdbserver/server.cc > +++ b/gdbserver/server.cc > @@ -4731,6 +4731,7 @@ process_serial_event (void) > /* Fallthrough. */ > case 'z': /* remove_ ... */ > { > + require_running_or_break (cs.own_buf); > char *dataptr; > ULONGEST addr; > int kind; > -- > 2.34.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928