From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by sourceware.org (Postfix) with ESMTPS id CDD763858D20 for ; Mon, 27 Feb 2023 09:34:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CDD763858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677490456; x=1709026456; h=from:to:subject:date:message-id:references:in-reply-to: mime-version:content-transfer-encoding; bh=s+G/UbOB9RhEiup9RtyoBRtKZg3eRfQ1hlQdODeKdas=; b=koMU5kBGH4hf76XmnsKNkbeSzCfhYZ0yEr4HAyo3x78Fb5WbjdR1Jdvn eAefesCcNoz/XQxOnpYGAQMIH6XP3k+n1IER7sTU9GdYqYFJETzOdhDgz uqpaR1kC+N9v73qr7pY9kc99nuy+zd+THH87dxPYIF95BGNQVNWgOY9yt hZS/JrP2TlhnImVyZbZ25LXG8yLz5iURiuYLTXVMhjd/bQ70PRcqFQD6u Yz3C22M8zobDdb1jcjCMmHe5nc9Pa/EgTB9Gz6kFewJUelZt8XruV3arX i+T6IsX2vBuUznPoEYn3BN6Xcw4HBj0rziWJeF77/vjx1VsEmReF4Wz6G A==; X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="317620037" X-IronPort-AV: E=Sophos;i="5.97,331,1669104000"; d="scan'208";a="317620037" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 01:34:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="797546753" X-IronPort-AV: E=Sophos;i="5.97,331,1669104000"; d="scan'208";a="797546753" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 27 Feb 2023 01:34:15 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 27 Feb 2023 01:34:15 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 27 Feb 2023 01:34:15 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 27 Feb 2023 01:34:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VRhEhwT/Eq1+RVaPAb4+4AW0UyQk+oLWyAs2M90QucNZRQt+FewexYBeXbBnMeuVuvhbR80Af9kl9+9IKC62WXsQzzK4U7JpeFw9waDA057w59Dl0+4/Ic3D5fIFw3SWqrW81ogi53Qk+V0hFZHJtmqPRb9ILEo22VkH3h8x6eS1F5oU8dRH2nOjDKsJhxeXzXb0vgvOv/pJcnxfpBqX2uwwvBJ8iOwTJtzZ9CFkRhFvHMXDiTFR92iEx12dJLExoyIfPlMx6M4tJ6PnX0WTrS5mUYIrOZQ+6LdgrQDaxjl9IKsdFMnJx/Zbr/MTqYfMlLoDA4zC33ypUlwNb+aiRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZPd2pPdaiwaPjg/pDh6sOJqpRoW+F5nUkMQv1ySLLwo=; b=oRv5JKPBUCDDSRr6EzLPCRnA6kWZA+nH63OeA1B8UjpIHiiGKNsmhO6mQ1ALIYukcycu+wIFMm7bSU5WCL6XuSjYr3pSXXTCDPeRM0JphCFW6mRbjj68lkM80I4GaRiuQBYcNc4b3dlqrqqZ7Uz/ac/54YnfoWtJOqez6LDDbU1u59UD0GC06ify/rub3I9D8YlXzgLBaFWnvrYA50p3GIte7WwRtwQx0gKyb56sGbhav1Mg0c3ce6xLFGEeaFLQGxgXKpXAkBOP75LwtsRD5k3AXebzQISC8ADwFHb+6bIVMg5vIrUOWCBM0fklcRds7ptNdugl/UvaUYz6eWfToQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB7303.namprd11.prod.outlook.com (2603:10b6:8:108::21) by SA2PR11MB5050.namprd11.prod.outlook.com (2603:10b6:806:fb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 09:34:12 +0000 Received: from DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::dec6:d57d:f767:c5f2]) by DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::dec6:d57d:f767:c5f2%6]) with mapi id 15.20.6134.029; Mon, 27 Feb 2023 09:34:12 +0000 From: "Aktemur, Tankut Baris" To: Andrew Burgess , Tom Tromey , "gdb-patches@sourceware.org" Subject: RE: [PATCH 1/2] gdb, python: do minor modernization in execute_gdb_command Thread-Topic: [PATCH 1/2] gdb, python: do minor modernization in execute_gdb_command Thread-Index: AQHZSFjsvKSI9MATRUO5iAEki+Uaza7efkOegAED4wCAAwn6sA== Date: Mon, 27 Feb 2023 09:34:11 +0000 Message-ID: References: <20230224140410.2647437-1-tankut.baris.aktemur@intel.com> <87mt52hn22.fsf@tromey.com> <875ybqj94f.fsf@redhat.com> In-Reply-To: <875ybqj94f.fsf@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB7303:EE_|SA2PR11MB5050:EE_ x-ms-office365-filtering-correlation-id: d5f0f560-5103-46b0-f341-08db18a5c895 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9NsVbtXwl+xDEsfBEO6GcOx3s76KdL8AT2uGjWleKh0hbPi1V14Qg7NiN8QCyNpQEp+r1cc1LiGgqW1U4DvIT80Gj9rAu8UVC3gkcgHpCEpf3miARBafk7fHm0dUpHEP46t0hmm+74Hs8NfwONFX3nhXb34QtqBZhvVL82w+kFvRT8fCb5Ck0+22k8jWKkQIwhk3JilGfdq5Fm13b3XFw2Msoy2w14c0WQ/nPYcXcilaH5OozmemCzZ/cMcev2gJXOfAV+B/fBQoTrb0vP12KU2m5hTCZpo//3M5n+T8uACPXX4OwPBS5Lor3HS5ZkEKH+j75SmsmH/E/es6o95XOKVzUyugfQtaPBbZbNtIdCoS2q8eekwrh6cXadDR5WZGVgCmeFDIXCgh4XCv6b/aREf+wARMx0Hq/Gcj4p4hKvThEMY1B0fU4l2sWuEq6NfCtZtr7EJWLJL3MskCUicgUURGkUQ9ngvs3RhTozO5to36evcHSLukHGQEJfg2NoQATzKGNqPS7tee60w6ymbIc2TYLbLhkeFobVC9HdLmBS5p3pyixiEapU3HRoOAjyl7gmzZR0ZTBAjkSYRjlk2dNz/Kdpg253pyCZ+9jWRXrNowY8RyH/5wAVKG364Fk8rgEe/0fiz3p0Uana05If2Q6OC39hJVWyQ/QiPb8673vbzFlxk8XfrW6U8XcVc7VKm4nrJVY3hRl2N/3QtT/6xKEw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB7303.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(39860400002)(346002)(396003)(366004)(136003)(451199018)(33656002)(316002)(110136005)(71200400001)(7696005)(478600001)(53546011)(6506007)(9686003)(26005)(186003)(8936002)(52536014)(38070700005)(41300700001)(86362001)(2906002)(5660300002)(4744005)(66946007)(66476007)(66556008)(76116006)(64756008)(55016003)(66446008)(8676002)(38100700002)(82960400001)(122000001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xq2nUq8wQXuQM0+bygeUlmfoBECY9vcy1e7Q7ZfD/lYLb++iGIWbEO8bbss8?= =?us-ascii?Q?Oy+8EIzPseQXhUwIoQCKn2ZOMhrLbLt1BlAQsW59GUDNovmEryXf0IBWhzra?= =?us-ascii?Q?U5FzVhc9aYHx8BVFGSPdg3++io6BgQ5u0qGp2wcp8rwoZFluRoam5/byD66s?= =?us-ascii?Q?1ktePBO8Xhb1jsn3DZmw21cNQxhVtKcFZgpSmftFlJL+go1WAbsfVzHWYPqM?= =?us-ascii?Q?VLVRiVD+jkOZI/haY0GBahfQqw6ETC+o0YUAa9Y1KTyPrPL4bR4v6c3tT9cr?= =?us-ascii?Q?CKyQsQVw9h5QAGNw3wWwfZhTInZ+6LOUlnWxs9Eb1corv2P1poFmplWEsqPU?= =?us-ascii?Q?sgQuvBHDDFZdn/mCWolo9v4jFrjnm5OLJW68IOkPEfrFLM/ucrkQXOpXSuQ8?= =?us-ascii?Q?xd+NixMcxCxpg4f9Ps6kTFhc3dyiwV7Oahu6QtJ7aM/kzt5jmjlpxJlAvGs8?= =?us-ascii?Q?8nJGL4mGQHwQWc+8cPF4FRHrYHeDbq71Yu3kbf/1iNIKMFhbSz8LqGF0pQuc?= =?us-ascii?Q?D69mtAalC4yE9hHljRFN5oOqlG8CqQ/ZDmKPboAbz3bB4KBBOoaEHa3P8F71?= =?us-ascii?Q?FLrzNroC7QPZdr6nf8dbld9SZb8wWTOtyj26gq4NAycRsnF5N8Ip+mSFrGXs?= =?us-ascii?Q?fUpBHpodR5ouzMAoXNY9Abx4oJBM48P0b2gYAayUFQT0h0QDvQoYGmDtlGxg?= =?us-ascii?Q?rijgJgvU10OQ72bjQAN9u57BajPHNWIBlE+FZgot8gV1HJnEgwrr178zOQcZ?= =?us-ascii?Q?xRE/Qmpb+kJj0wvriG1jRR1W4nhXGCDFku7qBzAfV2MpEOtpbFA2toeUMaw0?= =?us-ascii?Q?oYpjKswrx8Bmy1BXE6IRf1JWlhj6NoB+J6zcjlSu394QY3qMWwOMKribSyFF?= =?us-ascii?Q?C4XwXA1PRBMS4VnJU5FbGGTE+oYJfJS/3jtlbVGy8iRQyrBjQqN1WLlDx5Sv?= =?us-ascii?Q?MPcSwsZiguwgNPJoocibT8dQjLx1mUlCmjkbN0YGfxpsMfOKss70pRkfdFx/?= =?us-ascii?Q?jQ7hZYKBIWbaVOUup5icwsRf2Ot+cPu0HONYIoodYD5+nXrkMKpBnyyoInjJ?= =?us-ascii?Q?tKq8wMY4HboIyP+GoQT5UkGsaoi9y5J6yTxYTIyvigwU5d/DRMryI1LbcQUq?= =?us-ascii?Q?OGyooKIhQJSjlTwsEXf1ZWSQdYg8k9/2fP1Yl9imzi6H+6g9kxbwDj01Z97g?= =?us-ascii?Q?dpDKXJ21xBZlqNT8wJYU54TZLgJK005FbwwZDmY1Jol++hHbqjok4O+B6j2J?= =?us-ascii?Q?ynGoKJLYo6NKNa7zcOA+xzeiKJkC304gVBqxfqvzG90WK6BXRd1zOosvCrmR?= =?us-ascii?Q?yyzpJH7dQPUCSoZia9Kp9rFqS71caK+uzdquqU+G2f0txlYqDXdtLEnzcSI4?= =?us-ascii?Q?tEYHZTFGuPtjqd9FQfzXM+5PkdUneKbv88m5cG3TcV6LqINqc5zVB78uzc1z?= =?us-ascii?Q?t2sckqzwiwuoSUa3b5ZpXipM3D6cWmGAW+lA9hsdN7A68N2ROFmCFjvtPu6c?= =?us-ascii?Q?2mlStOuMOpktGypw4QBBYqRzwR9rvJ2vReK2q2AasTacaYBHX/5g8RDjnz+Q?= =?us-ascii?Q?WBkUELPUN0wNqia/foYsCUjzbIRVt1jDqKhax9fitz369rlhGozhtxJ4EJI0?= =?us-ascii?Q?eg=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB7303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5f0f560-5103-46b0-f341-08db18a5c895 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2023 09:34:11.6529 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YfEuriyFnE59O6oVdbVe7iXUpJbHVeNpnBuXzELzXd3GB6Af+u+LnWcxyxhz95bZQEWaA1Y2Bkrw3GdTsCzNyM2opkuEVB337uXT69bKI4s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5050 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Saturday, February 25, 2023 12:08 PM, Andrew Burgess wrote: > Tom Tromey writes: > = > >>>>>> "Tankut" =3D=3D Tankut Baris Aktemur via Gdb-patches writes: > > > > Tankut> Use nullptr instead of NULL and boolify two local variables in > > Tankut> execute_gdb_command. > > > > Seems fine. > > Approved-By: Tom Tromey > > > > Tankut> + from_tty =3D ((cmp =3D=3D 0) ? false : true); > > > > I'd probably write '=3D cmp !=3D 0' but this is alright. > = > +1 from me. Please don't use: 'COND ? false : true'. I made this change (in two places) and pushed the patch. Thank you. -Baris Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928