RE: [PATCHv2 5/6] gdb: add inferior-specific breakpoints and watchpoints

["Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>]

On Friday, January 20, 2023 10:46 AM, Andrew Burgess wrote:
> This commit extends the breakpoint mechanism to allow for inferior
> specific breakpoints (and watchpoints).
> 
> As GDB gains better support for multiple connections, and so for
> running multiple (possibly unrelated) inferiors, then it is not hard
> to imagine that a user might wish to create breakpoints that apply to
> any thread in a single inferior.  To achieve this currently, the user
> would need to create a condition possibly making use of the $_inferior
> convenience variable, which, though functional, isn't the most user
> friendly.
> 
> This commit adds a new 'inferior' keyword that allows for the creation
> of inferior specific breakpoints.
> 
> Like thread specific breakpoints, the inferior specific breakpoints
> are automatically deleted once the inferior in question exits.
...
> diff --git a/gdb/guile/scm-breakpoint.c b/gdb/guile/scm-breakpoint.c
> index a7e043d847b..4c6fff070cf 100644
> --- a/gdb/guile/scm-breakpoint.c
> +++ b/gdb/guile/scm-breakpoint.c
> @@ -779,6 +779,11 @@ gdbscm_set_breakpoint_thread_x (SCM self, SCM newvalue)
>    else
>      SCM_ASSERT_TYPE (0, newvalue, SCM_ARG2, FUNC_NAME, _("integer or #f"));
> 
> +  if (bp_smob->bp->inferior != -1)
> +    scm_misc_error (FUNC_NAME,
> +		    _("Cannot have both thread and inferior conditions "
> +		      "on a breakpoint"), SCM_EOL);

The CLI error message used single quotes around "thread" and "inferior".
I think it was better to read.  It'd be nice to do the same here, too.
There are two more such messages below, in the Python code.

Regards,
-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928