From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by sourceware.org (Postfix) with ESMTPS id 4CC683858D33 for ; Thu, 16 Feb 2023 12:56:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4CC683858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676552167; x=1708088167; h=from:to:subject:date:message-id:references:in-reply-to: mime-version:content-transfer-encoding; bh=Wu1sAN8ys0pZ9s36x9KdkPxibwgvFXYUBg/8qUgGGH8=; b=K/cIJBQVqxSTBJavfdX+mgPlbzNAGFEY3ub8Q7lquDLGxZB+8Z/GGknG QZ2+9aQaXfEKq57DCRTEwc5iWI2OczwaWcYz8vfeso4HkJ9WugL/VkzGH So3MYhQnNE6el7sc8LbyKuWiWXe7L2QlaxXwPz2EuBEHB4+TgswEwmlN/ PPnuHhdbzUgDZWm7KSgAoC9HpayWR3ndhY/o1QEQsj+mNCpgUqTf9wAq9 yLumplTmDqcBDi3rflhWgS+s75HcamfIRM24NgW1OrJNEKmkSQzLH3gSJ uOr4p8MP/xbO0Zqt67jtyGSAeGXKoEbKlTiOichPTRQN9tBLuF/e5X0zT w==; X-IronPort-AV: E=McAfee;i="6500,9779,10622"; a="359138025" X-IronPort-AV: E=Sophos;i="5.97,302,1669104000"; d="scan'208";a="359138025" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2023 04:56:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10622"; a="700489819" X-IronPort-AV: E=Sophos;i="5.97,302,1669104000"; d="scan'208";a="700489819" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP; 16 Feb 2023 04:56:05 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 16 Feb 2023 04:56:05 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 16 Feb 2023 04:56:05 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 16 Feb 2023 04:56:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d3J/sKVjcFz3HMKxmS4SfLUOkhAMoEKaFhsV0EdhLUIjdHaqKBwh1TO+KmhCo6BJXwuX46pvLM8TUT2Eo85w2li3Xb00xFz9gvKBs93F+4YnV3tca0UXPjANMsvd0DjwjKI75gFK8q0KuB9jK2kimCKGqCACxWiS0q9EmTeZGvdSYQZ3nw3e9FGxP3OY7+8MlG0J8HqeG2eNPxKufR1cYtrE4wxIydBF5ePIQ8LZYgyCSGz0eqMtP3J5QaZRv165uuGJrtwpV3jQ8iX55Cf3Hepl2IPmwAZcj+ag8O4M7jz5hqyha8x4Zg2gxcsiZPfMBDumMbRXoY85wiR8PrEjlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HBshKxZdeHObTd7Q+XWSJg+2VJzpQTFlDl/het+5BdQ=; b=gfR7PIUGmpuiwwFOP9IMUlTRmjpp7SSwvfIY9ww8EdCj5KT0ImYEjfJnmyXg0E0VFCS02s2dwqQqvK3ET7tg0do6Y7G4Rm1jc2Ac6+z3bMQlXBYB9hgQgBf2icrTR+S49yod29NK4qhD071vc6VbrNUNGC38pW18jtgw/CsgPjApka3otVlBE6QrGXdy2UK8Sv2//dn7gF1mTFhNPIfJ2RnBEJTBIWprgwg/Rg1GnbCmnkoxjNIrErQMHuvyh/ivADMOEjGKP86fadr0jiuAbeZkfohVBzAL0QpBKc5efrFZbXrRlYeeUXcY2KHZ8VNBbgx0Yc93fpgSsHkOo0QscQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB7303.namprd11.prod.outlook.com (2603:10b6:8:108::21) by BL3PR11MB6433.namprd11.prod.outlook.com (2603:10b6:208:3b9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Thu, 16 Feb 2023 12:56:02 +0000 Received: from DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::dec6:d57d:f767:c5f2]) by DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::dec6:d57d:f767:c5f2%4]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 12:56:02 +0000 From: "Aktemur, Tankut Baris" To: Andrew Burgess , "gdb-patches@sourceware.org" Subject: RE: [PATCHv2 5/6] gdb: add inferior-specific breakpoints and watchpoints Thread-Topic: [PATCHv2 5/6] gdb: add inferior-specific breakpoints and watchpoints Thread-Index: AQHZLLRNW8cEjQ5oK0mggnsidM/AU67RsJVw Date: Thu, 16 Feb 2023 12:56:02 +0000 Message-ID: References: <050da90b0b8c886983ec472a957b1075d4ecf7d6.1674207665.git.aburgess@redhat.com> In-Reply-To: <050da90b0b8c886983ec472a957b1075d4ecf7d6.1674207665.git.aburgess@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB7303:EE_|BL3PR11MB6433:EE_ x-ms-office365-filtering-correlation-id: 92441101-3a22-4878-3af8-08db101d2897 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9mz6kUdtcjHbSxmImcEYW2HqGFUcDKk6mXdNvS+rsJaEX+XOYA95HC2E3bcjybicTSXN9zHI/88ze55hUl+GVU2WfTXVqAiMxjDTd1dT33zbV4Z4lnoOZWTwEp5rOAxHQf3OttU1uWyEwOYXIfy9S4YLnPEs/CxnNr37ZA35fAd0lyH4o9jF6kRqWJ6q9XsBl7qRSLiS1qXJ73JXHA14DHEDPI2SWBVs9SHAj+moLQQBKMgsc8Dz+2RWUmVrIvngHYq/B/Aa20hnFoSAa9X3+nLesl3SI+egRZmsgnzbepsQ7jDqoJ7BhhCo8H5TZr+yb2OC6ueyWZli2Fo6NBsC8Avr3t1pjK3W30FkeYCStmkA8p/QC3FE7PPut1ROVA8DNZKo9Vf78NZop39+39hE2xc4zdC0x7j94Szs85ceCK0TKbXvdGirTEzZswpcpnB95DSYuKJIdnDxFn1xZRBWFYJ2/6wVJY7832bKtcy3cWasoc3lvO9IEFsOI61vs/dq76h3TEwSk+3PpAJs2OVGu/HqJ6jIlszNfXzDgKpv2uNc3I8YT9zV3Xeqs4bYP7GOGBXZySSCqBLlncusBhoekyyMzGY/4dgGyr7G6PqFqtZXg0DJX2Ege0ATANHMwBr3C2R+mRWFTq2im2C6BBa2YbpuKi+f4HdXMxRRuWZglIUJSeweKUIb6nm55bbRF+ajlUlA9Lmnuvz6WHjQDp7X7w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB7303.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(396003)(376002)(366004)(346002)(39860400002)(451199018)(71200400001)(33656002)(86362001)(38070700005)(38100700002)(122000001)(82960400001)(83380400001)(53546011)(9686003)(6506007)(478600001)(186003)(7696005)(26005)(66556008)(66446008)(64756008)(76116006)(316002)(5660300002)(110136005)(8676002)(66946007)(2906002)(55016003)(66476007)(41300700001)(52536014)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MFyjnFQImipbyf9hG0iT29Ly8so43md/ldzFXWY99W2a1FDgHrWhF5mlJ8OU?= =?us-ascii?Q?0+DjmL8EJxLBp//dC6Vkn9EeWlqxbuwFxYRi3DSmxIo4BzbILvgHKu9GnVWP?= =?us-ascii?Q?xt7bYOo7Gs/D0C0gffnAw5IChih7yfvq7zy57KuBI32d/lrGLP+RTqqLMV3G?= =?us-ascii?Q?RZ3m4nGBEHTNEEmG8Q3e+d5IoKiMaUn1ELtA4W9ManZ2vhMUNFpX7rNtY4uP?= =?us-ascii?Q?iReEzH4lC4KQKQSWHBa2P1POgcBU42oDVrvFaGNer5lroLGIK+DlinYl9Nla?= =?us-ascii?Q?GZeT5RAebJcJGALXKpwBWPZc7o/pG90RIeidYDTmxRC4T4+HgyzEIzMKHViT?= =?us-ascii?Q?pwKiVIdAVNylt4iFIzuLSHrCRE8ZfYFU0OftL2Db7O0iG64AvsJNUo6YZkn0?= =?us-ascii?Q?kIUeQF18OqbZR8oeEka7J3MAj2OG7iDdvueCZdXq8L+3xDN+iNp7ijPbFIRx?= =?us-ascii?Q?i3Vd43jVUORH1RQAYsAKOtvAafxh8LD6kj41hC0uFSCTwzEx+RPQg2N3mB8L?= =?us-ascii?Q?Cp9XjSkuvGhCesHJtlIK3npW0C8CQ/mNYLS7yhonsBQTyFDNyVafjdzNM3xv?= =?us-ascii?Q?x9L7EGRefFoqtoUEXDH9ddZUhGcfw2JHk3Aavih2S+fu2NB3akjBFdDGToP+?= =?us-ascii?Q?ubvk9M8ZT4GyMDF2YxAlLnYxcaPtyXMobfTFuHEnHDGjxQIG8Yaj48olY3Wx?= =?us-ascii?Q?ddWOOpFVY0okU+m6ScAff6pWdXyrOkskkOd8pOcCzr29bbnU4ExA+wRPkPLB?= =?us-ascii?Q?/cdeW3Qzs/1t9JPCcs44B+UXSVZj/nqz25GDAR5Ev8GXxrqujYN3AJhbQwVJ?= =?us-ascii?Q?36ToH6gaTOh65gzC+cIE17uwsO0R8vhCAmh8etd0SZ75E1YpdQ2Kbn+lhlTP?= =?us-ascii?Q?uMM+Rx5VHHH3g+WaKj3Yzi+NtEkCkJTm2T4EGAECtjmxribY9aqvPTdoLH9k?= =?us-ascii?Q?GuUCrIKsooVzbC6lAO4T7NOtiO5ZEzFU6SBOfEna9sQ1QiZpbG7Eopymw8Ij?= =?us-ascii?Q?lZQbiNd2YHk80d/40uGSWthTk3w914Wy+sQRxLRyJg5uipgTExX6we2DAAcU?= =?us-ascii?Q?bvZEKyq0fu0fSx30sCmArwTpjwZx/35wtvcusTf7iZAfqZYuJV+2bZ0lT2dY?= =?us-ascii?Q?6dt7IcO/a/Bj+Ydiu1bxpqn6+DmuIh/qu2CAEjCxnTItQ0C2AHyObEyWRse0?= =?us-ascii?Q?PxTMzeTk40bnFo3lS27Gqnq0W0wVgywcw8QGSSWWHWmi9qt7g4OU+8Ubtuhq?= =?us-ascii?Q?zrrt1AGZsGu+T36E8JQHBT2GDZ3W1cgGCiBAsX+8qgV2s6SOrG2//Rp4dhZb?= =?us-ascii?Q?/4yAvElBrOBQHBdb+5H/dKyBIGCnDEFS4OHrSmCJvPK3BhieJJhAIenDr0Zt?= =?us-ascii?Q?THW9AZRcu6XDGGYDf+kh4AyTPImmNkIb2WPYXozqfYLPADCitL274cohDayg?= =?us-ascii?Q?MzL19H8Rpd/M+MDdsYYamEYIGJRUHmitgAstESaHT0cnjHgXeVYsEmJYXAJ9?= =?us-ascii?Q?S0lnL9UJkvFnjg+8+xyf148moJYor0M368Ckv3f+KYMh6M1w73iMA8rx0KnQ?= =?us-ascii?Q?Z2Y9oe94fjWHhxly/ARaesmIZYyWp0UWv/10VdJLTp0PyoDeKKOmQB9nlQJQ?= =?us-ascii?Q?gA=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB7303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92441101-3a22-4878-3af8-08db101d2897 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2023 12:56:02.3996 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GmGrB8ZDgBandqyCAovWCYtdeX0I5pSQrby8yKJckn5crCzinVELTTkqP3CnQS1/9XYTdDKdRGnqX/MqFT0TT/k0NqsY5tBXTizmM3woA0I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6433 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Friday, January 20, 2023 10:46 AM, Andrew Burgess wrote: > This commit extends the breakpoint mechanism to allow for inferior > specific breakpoints (and watchpoints). > = > As GDB gains better support for multiple connections, and so for > running multiple (possibly unrelated) inferiors, then it is not hard > to imagine that a user might wish to create breakpoints that apply to > any thread in a single inferior. To achieve this currently, the user > would need to create a condition possibly making use of the $_inferior > convenience variable, which, though functional, isn't the most user > friendly. > = > This commit adds a new 'inferior' keyword that allows for the creation > of inferior specific breakpoints. > = > Like thread specific breakpoints, the inferior specific breakpoints > are automatically deleted once the inferior in question exits. ... > diff --git a/gdb/guile/scm-breakpoint.c b/gdb/guile/scm-breakpoint.c > index a7e043d847b..4c6fff070cf 100644 > --- a/gdb/guile/scm-breakpoint.c > +++ b/gdb/guile/scm-breakpoint.c > @@ -779,6 +779,11 @@ gdbscm_set_breakpoint_thread_x (SCM self, SCM newval= ue) > else > SCM_ASSERT_TYPE (0, newvalue, SCM_ARG2, FUNC_NAME, _("integer or #f"= )); > = > + if (bp_smob->bp->inferior !=3D -1) > + scm_misc_error (FUNC_NAME, > + _("Cannot have both thread and inferior conditions " > + "on a breakpoint"), SCM_EOL); The CLI error message used single quotes around "thread" and "inferior". I think it was better to read. It'd be nice to do the same here, too. There are two more such messages below, in the Python code. Regards, -Baris Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928