From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by sourceware.org (Postfix) with ESMTPS id 0AEA83858C39 for ; Thu, 14 Mar 2024 10:36:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0AEA83858C39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0AEA83858C39 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=198.175.65.18 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1710412595; cv=fail; b=DDyMHoj3G0uAuwI/qeguqC6u9BIuOWTrnn3jBYabATHNhx+EnTAr6UwkYmDDcwUn0Il8CqrKmAfaHcfjmaTm1eRFXUq57A3mCckYuWbOQJ09MoFXjkmi80ygz1MYtl8eTEBVAmNEtKBBbdTAgyJdeWpUVYXB0EzgbdltFTAOSMQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1710412595; c=relaxed/simple; bh=gUB5LeC5/BxAC2aTAIT838S1EtHiAkzuRdLTcuQw7FU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=P1k9m8zuuJ1HG9L52NktzayIR/gaMb+sE0qxaKes6jFQ9ECRRyZelA6zxH6HdvatoCj2OGZogpIK19XJ7YkwfJQjIm2wkpkEjT6iIeDkwvKtajWuEKU3yMIfoaL1vbjBVpJ0YBHloO/VjJtLVOA+SCn+V1z5e2ySZ+pESygYhyI= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710412587; x=1741948587; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=gUB5LeC5/BxAC2aTAIT838S1EtHiAkzuRdLTcuQw7FU=; b=inWk+EcVkNDem+1kMnjMX5cgYoaQP1sQ07AlAjDIk4OhdIxYYkPMV4vy jXboor7iwdr0veUluPXYO2hv+FNFPmDqES4j6Wdj2AoxGGtHcBNhlgZE2 SRjakBpRuF53KhSlLEAS0Na0tifLeetcW0ogPGhAx0XB4f319vG+aWk/K tpNh7aQO1nNWuXTSDeA0BkQtDDIdcZwCsKJvwbbsTsaWpHvz0QFDwG1Fb 6CGgNqgQ+ck0j1U45ii3JYAI6+Vefd9G6EXpXMHDvzx8wWBbbbCPaB19F JNyPMVv+EZavjI1Xah7dHAqU/Qfe/Ne9rhdMudG8gz2sW+AhG4jC6GDS8 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11012"; a="5345991" X-IronPort-AV: E=Sophos;i="6.07,125,1708416000"; d="scan'208";a="5345991" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2024 03:36:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,125,1708416000"; d="scan'208";a="43172391" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Mar 2024 03:36:25 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 14 Mar 2024 03:36:24 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 14 Mar 2024 03:36:24 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 14 Mar 2024 03:36:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jCuOHyIBUXOpovOZI3AMosi+4i09ggY/2NpOJTqMYggWDzX3tyYjEQeMILmm+FFaAoNnFhHZxQQxmrjaO3K3orwiemAexsgEJ2FaRtAFOm5DnnmvuTsT67Kk6b+LeSHgwUAqvhTcoIvWuE1S4x8TgDesoCP3NI61av+u6WDYGhxJX7s9sa7x53E/KttZqEx39iAhERJXYtwQUyqd3RIBjNW03NrUMT4Iw3O1Xw0J/r8iYSiG3b8v68osnGaNmOjJetRzRNIBssMeZjzWwjy6DFB75BXVtZv3r0P7YL6tjMJEoaq3hhrw68xnVQzk6EDE0v6ArHq6ARxzZyL/AXPlOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7dtpeaJ9ScYe1tHj8JLOIuI2LpTlEXJq3xEY0djT3a4=; b=oN9Yajn+aExm34WsrCb6O3JKz6F+2cF5vs2VWYWbRJVVlZfJCJgH7gpY9i/PfGw6VI2r6SXR5k3b43xyGdTjo8/TnE8Z036Vn2SvD2oM+EnSYV+LL7HLnJV+ezzFwl3DMPinPU+cp4L8zUDRybju0ljVEn17SPB1oQ9NLIPJpG9MW9yt4QYsjVA7wartSwGNrM2qBccjIYdc5ahkBD9wuGGiBK2OVg+KBNiCqBF3jm0xJUyzzdggIATkFjF/JQxA5a/If7MkwK8lDCsqXSguPPT1y+7axAdvV8J6/YrXCrMVn66tWkoZ/Xm2x+tgY3kUH0EXe8TkHM47TbDJth0+Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB7303.namprd11.prod.outlook.com (2603:10b6:8:108::21) by CH3PR11MB8591.namprd11.prod.outlook.com (2603:10b6:610:1af::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.16; Thu, 14 Mar 2024 10:36:22 +0000 Received: from DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::d151:d3b0:297c:ec32]) by DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::d151:d3b0:297c:ec32%7]) with mapi id 15.20.7386.017; Thu, 14 Mar 2024 10:36:21 +0000 From: "Aktemur, Tankut Baris" To: Tom Tromey CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 3/3] gdb, gdbserver: introduce the 'x' RSP packet for binary memory read Thread-Topic: [PATCH 3/3] gdb, gdbserver: introduce the 'x' RSP packet for binary memory read Thread-Index: AQHadVxMOgQ6F2ReO0SWhqKqj4NBLLE2DkikgAD1EDA= Date: Thu, 14 Mar 2024 10:36:21 +0000 Message-ID: References: <990be8b42f1f6ca33ffed7a8ae7ead327009d847.1710343840.git.tankut.baris.aktemur@intel.com> <87h6halypk.fsf@tromey.com> In-Reply-To: <87h6halypk.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB7303:EE_|CH3PR11MB8591:EE_ x-ms-office365-filtering-correlation-id: 2e66271e-3741-43a1-4b07-08dc44129753 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zzYCtwLlDENmzTCNkTVwPP8zi3XxWQBTqWOAwEC03EXPadU7NsoE2AULQra2WxMniWwjBz1yNt83Fphj2ktMIqfUuGfv+IXrOLm1iArbeZAESIdUnK9AmVKjinUJt46xZ8UpccMnup+2pDgw/kkhQiAoRMzv1984eYW/VzDI+ljmqRzPIBhfWqR+FUgx0ZD08oxW6vMoTP+SVX6j8NdVUaNJQZS4Bf8tgxkgbzb8+NEfIn+XyUhtcYaxxWdIhoCL5kcdttBpFa3bkpiazwsNyLOaLAZJeSAe+Q6txf8+7XW5JH8Lxf+/45Ajp7znxhQ8Mt3CFcoMAJTPKjIx/xYB2QldF8Y7cTEYDXQEqTwgAldeagMUhSduUrKsRkqv9nsXkXVGOJskmpykLwOGeG4Gg7/jh2eL3KmqhAVT1UCZ9ZWn2dlRgtsTmrH0NfM8T2E7sWk6vGkd4c/2eGAUJGUBIUP81lsQxtoD1LiUVhT8WhthvaRxRwISIIO+mmpxg0PbWIxEk5wwf6RN/1ApYbbSjJ2d0jucOl3UfnXCBhJaDO7NlCBYW8Cr4eIdfMbyi+2svitHZoa7aNmumX9UUPzAYX09b2+2k+KKEXvBiqUoXx8mOQGGUuL21U1RDImTTcr5SIqnp+wjqP9ihgcgYhioa3wCJbCSzrqtN+LpUejkDG7FT+U/17AzSWr39vtJd57KaHFfhtGS3fW4ji/Q0pAPd2FFOtVxv771HD1tcYRN7+k= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB7303.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(38070700009);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JD3S3vc7nwjYOgs66OydGsP3nvR80LMaxJONojQgGG7fCyhHuOHaj5zIOhCh?= =?us-ascii?Q?aFsGqQPnrf9b035hAtCeg+OcSMiQW3SrXsjiYJHgllcZpwmyH7dGks6YHiOB?= =?us-ascii?Q?xgllHfM7g0tYRx2NZxBOwtOddKreeXfeQ/VkJY3Rr8saNBNsTjB5QuKVF8B6?= =?us-ascii?Q?N8GRQoY2Q3NT31R8PXxfiSUsujtMiEnuadJJy40KiE1juGRd5vTkbgNTqji7?= =?us-ascii?Q?w4/jU5g4kJOVSy+ulZZnEoNX2M1hflhivkzPjhshq2ZJkLgs4pfS4YF5FjCH?= =?us-ascii?Q?ZHQZF66FvPAcQoiCRvxpWwTs6LS3YwS3dF4M/dZfsMyljKUh/XDOjg1yTOeS?= =?us-ascii?Q?N4F0UEY0J0Kw9qsNXMaYBx64vgL/ybaIglR3lXQ0wB0URcuuIREcLsk8p/KK?= =?us-ascii?Q?Y+Ml4K+pVw3Eo0aoHS8gtX1cYoHkzfo8et14SpPXGSm52ZTsSXniRtXhfhqy?= =?us-ascii?Q?rVpTuTijztkc/ryxX9nIAV7B4TlMZ8oYOM3AJ9FdYhbfhjK3TcmHzzCv9dSA?= =?us-ascii?Q?9RPWUv864bR/Pie7Vpjxchvibk7J7mSU/ZvcyRCuKsvCage40/UAfVwcyjKy?= =?us-ascii?Q?3CGuYDiO1s2YmfjRIsDL/hci4dDEqVmjVAOHgys6R4YYkIscG9rqvLLw53Ou?= =?us-ascii?Q?PsTaskj6oFJSfGtrYUhPKBARwJOAvxMXRT470HgZZA96qHnPM7ICNzyVwSti?= =?us-ascii?Q?+QpbAFroyPrQKj10fJL7xx2uygTg/nFIA8Z1PhSFO94xIZSbN7NLS6wqTGat?= =?us-ascii?Q?BL84k7nnGIbpem9nA++K/6C/iG772mWEL8sbXsIwD2uSyn4zJSGFRa7E8HCx?= =?us-ascii?Q?VBZ2LMqRwu7sRiHRakxEPDderbDwUF3uAbyc4w4QgvF0c4nh0TZBU3iFjZa8?= =?us-ascii?Q?WCZcGE6XToEt1Qgvd8wyMGGU3AbgXMjI82bE2MU9a+Xsfznl4dOBkNrahRVb?= =?us-ascii?Q?eH89SqlEXUez3EAnG+KCJYp74H2FQ/IQHJqATtmFMbKsYoP3J3uJXg+vFNgP?= =?us-ascii?Q?iC0Ad9QRXW9Nc9Uv9bbradnPR4uANc+k6uKZhR1yCSXZvvSbesqw7JpyeCrS?= =?us-ascii?Q?/mXi+C8wPibpQjlsFRoC8Yom3dtGz5A/Y6RvODvd/8oem9qh04dKwoIX+LwO?= =?us-ascii?Q?qVMkW/MLFAlc+5/V7jvtMy4xBn9/+cCR/CLmZM2KP+MPKMxn6LOdkHU9LHRN?= =?us-ascii?Q?xthXQf1WH4DrNzVXfkYCeL/iUnVkbhFrQthZs3xj8DffxsjsFCrHsXT1JyQg?= =?us-ascii?Q?Yuy+OIlrcb9OSnU3apvkBOdBgPv1H2bqGW3aM5TtjuZmjxJZOufGKfCPABvc?= =?us-ascii?Q?Ch07tFa8Cvr2ZrNAlvJnm1Xa+IIOyHKD02cXL8EwXgwxiExGRStPkTTxI38D?= =?us-ascii?Q?TY6uSHJOr6ZAOOXwE4Z0hhjUa0JhlgtDNAK5EkLO8+7lZ8oJ6tYZcjCCQ3CD?= =?us-ascii?Q?VFlDGfs4hRfGBl8ruAWMEOUOkX1Oo6mxPQCapmBiOuxwEUpoSmGaua+2G0SE?= =?us-ascii?Q?oI/M+DdXmW/qxRyk8W0+pcuC/TcZANtVT7nLCRiftIRF4l7VU/ht8tePvMxa?= =?us-ascii?Q?Fa3QmMG4KHj8yuDg+sPBiiNwFLCpz2VSc9H58tu12R6vg1wRIUNRn08wv1Nk?= =?us-ascii?Q?wg=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB7303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e66271e-3741-43a1-4b07-08dc44129753 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2024 10:36:21.8616 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ldLLoqe4J4nOGgDHQBP90vTIeKrOlWu22LYFX+4ETXQJyhcuad8dRNVVnZAIwdCmkfYGjiLEbCo4IGMSj6qSp0agz1M5jnJUDKJBTCcajgk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8591 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thank you for your review. I'll submit the next revision soon. On Wednesday, March 13, 2024 8:27 PM, Tom Tromey wrote: > >>>>> Tankut Baris Aktemur writes: > = > > Introduce an RSP packet, 'x', for reading from the remote server > > memory in binary format. The binary write packet, 'X' already exists. > > The 'x' packet is essentially the same as 'm', except that the > > returned data is in binary format. For transferring relatively large > > data (e.g. shared library files), the 'x' packet can reduce the > > transfer costs. ... > > + /* Binary memory read support. */ > > + strcat (own_buf, ";x+"); > = > One thing I don't really know about the remote protocol is whether we > prefer to add advertised features (like this) or just have gdb probe. For the 'X' packet, GDB does probing in `check_binary_download`. (It is, at least to me, unintuitive that the function is named "download" while it's checking for 'X', which is for writing; maybe "download" is meant from the = target's perspective.) I also don't know exactly which approach should be taken, but I opted for a= nnouncing the support at the beginning because it's easier and cleaner, in my opinion. Probing needs to sends an address: Which address shall we use? The same add= ress we are given in the first encounter? And the length is 0. Then, what if the = address is bad, e.g. in an inaccessible region? But because the length is 0, shou= ld the target send a success result or an error? From GDB's PoV, for probing, it doesn't= matter, but = from target's perspective, I think it creates an odd situation. If it's su= ccess for a request of length 0, the target would trivially send an empty response as= the binary data. But if the packet is not recognized, the target responds with an emp= ty reply packet, as well. How do we distinguish then success from unsupported? Sha= ll we have a delimiter at the beginning of the sent binary data? For these reasons, a= nnouncing the support upfront had sounded better to me. Regards -Baris Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928